GNU bug report logs - #63205
quodlibet fails to build after python 3.10 update

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63205 in the body.
You can then email your comments to 63205 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Zack Weinberg" <zack <at> owlfolio.org>
To: bug-guix <at> gnu.org
Subject: quodlibet fails to build after python 3.10 update
Date: Mon, 01 May 2023 09:48:05 -0400

[Message part 1 (text/plain, inline)]

After the core-updates merge (specifically after the bump to python 3.10, I would guess) quodlibet's testsuite has one failing test and therefore the package fails to build:

=================================== FAILURES ===================================
_______________________ TCoverManager.test_invalid_glob ________________________
tests/test_util_cover.py:111: in test_invalid_glob
    os.path.abspath(self._find_cover(self.song).name), f)
E   AttributeError: 'NoneType' object has no attribute 'name'
=========================== short test summary info ============================
FAILED tests/test_util_cover.py::TCoverManager::test_invalid_glob - Attribute...
===== 1 failed, 3257 passed, 53 skipped, 139 warnings in 90.85s (0:01:30) ======

Full build log is attached.

$ guix describe
Generation 19	May 01 2023 08:59:02	(current)
  guix 0c6a7e1
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 0c6a7e1045cbd06336ef3699734a803a2e4038e5

[gj1mb1y5bchcq9pm4rsh7x8pyq0fs3-quodlibet-4.5.0.drv.gz (application/gzip, attachment)]

Message #8 received at 63205 <at> debbugs.gnu.org (full text, mbox):

From: Alice BRENON <alice.brenon <at> ens-lyon.fr>
To: 63205 <at> debbugs.gnu.org
Subject: quodlibet fails to build after python 3.10 update
Date: Fri, 5 May 2023 15:31:42 +0200

[Message part 1 (text/plain, inline)]

This problem seems to have been reported and fixed upstream:

https://github.com/quodlibet/quodlibet/commit/5f55431a28509fd4f4f7b40dc246f3d34fa8549e

Since no newer release has been out, I guess we can backport the commit itself.
I've tried with the attached patch. The operon tests still fail due to some
weird utime magic, a problem also known and discussed at:

https://github.com/quodlibet/quodlibet/pull/4053/commits/06a32b319f065550efe0d2a9ff10ca6bdc32b893

So I guess we could backport that as well. Does anyone have a better fix ?

[0001-gnu-quodlibet-Fix-glob-failure-in-quodlibet-tests.patch (text/x-patch, attachment)]

Message #11 received at 63205 <at> debbugs.gnu.org (full text, mbox):

From: Alice BRENON <alice.brenon <at> ens-lyon.fr>
To: 63205 <at> debbugs.gnu.org
Subject: Re: quodlibet fails to build after python 3.10 update
Date: Fri, 5 May 2023 15:58:31 +0200

[Message part 1 (text/plain, inline)]

The second patch needs an edit because part of it doesn't apply to the
actual source (4.5.0 doesn't contain 427793aa88fb57 which applied the
@flaky markers to the test). But quodlibet builds again on my machine
with this second patch.

Le Fri, 5 May 2023 15:31:42 +0200,
Alice BRENON <alice.brenon <at> ens-lyon.fr> a écrit :

> This problem seems to have been reported and fixed upstream:
> 
> https://github.com/quodlibet/quodlibet/commit/5f55431a28509fd4f4f7b40dc246f3d34fa8549e
> 
> Since no newer release has been out, I guess we can backport the
> commit itself. I've tried with the attached patch. The operon tests
> still fail due to some weird utime magic, a problem also known and
> discussed at:
> 
> https://github.com/quodlibet/quodlibet/pull/4053/commits/06a32b319f065550efe0d2a9ff10ca6bdc32b893
> 
> So I guess we could backport that as well. Does anyone have a better
> fix ?

[0001-gnu-quodlibet-Fix-failures-in-tests.patch (text/x-patch, attachment)]

Message #14 received at 63205 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: guix-devel <at> gnu.org
Cc: 63205 <at> debbugs.gnu.org, alice.brenon <at> ens-lyon.fr
Subject: quodlibet fails to build after python 3.10 update
Date: Mon, 12 Jun 2023 10:47:44 +0200

Hi,

Forgotten patch:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63205#11

The supplied patch by Alice works and looks good to me.  Can somebody
please have a look and consider committing it?

Thanks!

Cheers,
Remco

Message #19 received at 63205-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Remco van 't Veer <remco <at> remworks.net>
Cc: alice.brenon <at> ens-lyon.fr, 63205-done <at> debbugs.gnu.org
Subject: Re: bug#63205: quodlibet fails to build after python 3.10 update
Date: Tue, 13 Jun 2023 09:48:03 +0300

[Message part 1 (text/plain, inline)]

Looks good to me. Patch pushed!

On Mon, Jun 12, 2023 at 10:47:44AM +0200, Remco van 't Veer wrote:
> Hi,
> 
> Forgotten patch:
> 
>   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63205#11
> 
> The supplied patch by Alice works and looks good to me.  Can somebody
> please have a look and consider committing it?
> 
> Thanks!
> 
> Cheers,
> Remco
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.