GNU bug report logs - #63274
dia: Fails to build (Meson: Function does not take positional arguments)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63274 in the body.
You can then email your comments to 63274 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: bug-guix <at> gnu.org
Subject: dia: Fails to build (Meson: Function does not take positional
 arguments)
Date: Thu, 4 May 2023 17:26:48 +0200

[Message part 1 (text/plain, inline)]

Hi!  It looks like the Meson build of `dia` fails to complete in the version
of Guix shown below:

```
$ LANG=C guix describe
Generation 56   May 02 2023 11:25:26    (current)
  guix 3f8c489
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 3f8c4899a9a67bb509a603bd21dcfcfab88c0e8e
```

This is the final part of the build log:

```
starting phase `configure'
The Meson build system
Version: 1.1.0
Source dir: /tmp/guix-build-dia-0.97.3-3.0997887.drv-0/source
Build dir: /tmp/guix-build-dia-0.97.3-3.0997887.drv-0/build
Build type: native build
Project name: dia
Project version: 0.97.3
C compiler for the host machine: gcc (gcc 11.3.0 "gcc (GCC) 11.3.0")
C linker for the host machine: gcc ld.bfd 2.38
C++ compiler for the host machine: c++ (gcc 11.3.0 "c++ (GCC) 11.3.0")
C++ linker for the host machine: c++ ld.bfd 2.38
[…]
Message: wpg_filter
Message: xfig_filter

../source/sheets/meson.build:47:32: ERROR: Function does not take positional arguments.

A full log can be found at /tmp/guix-build-dia-0.97.3-3.0997887.drv-0/build/meson-logs/meson-log.txt
error: in phase 'configure': uncaught exception:
%exception #<&invoke-error program: "meson" arguments: ("setup" "--prefix=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887" "--buildtype=debugoptimized" "-Dc_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "-Dcpp_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "/tmp/guix-build-dia-0.97.3-3.0997887.drv-0/source") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `configure' failed after 3.0 seconds
command "meson" "setup" "--prefix=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887" "--buildtype=debugoptimized" "-Dc_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "-Dcpp_link_args=-Wl,-rpath=/gnu/store/v5syv2awp33lvq0fl1pavvpxv53i0w93-dia-0.97.3-3.0997887/lib" "/tmp/guix-build-dia-0.97.3-3.0997887.drv-0/source" failed with status 1
```

I know nothing about Meson, but the error reminds me of
<https://issues.guix.gnu.org/53182>, and I see that its fix 3969dc45 added
`(arguments `(#:meson ,meson-0.59))`, which was removed later in f38d8e05.

Thanks and have a nice day!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 63274 <at> debbugs.gnu.org (full text, mbox):

From: Giovanni Biscuolo <g <at> xelera.eu>
To: 63274 <at> debbugs.gnu.org
Cc: Giovanni Biscuolo <g <at> xelera.eu>
Subject: [PATCH] gnu: dia: Update to 0.97.3-4.b903dd8
Date: Fri,  5 May 2023 15:39:01 +0200

* gnu/packages/gnome.scm (dia): Update to 0.97.3-4.b903dd8
---
 gnu/packages/gnome.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3d49ec3de5..d58b578a04 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1939,8 +1939,8 @@ (define-public dia
   ;; recent versions of the build tools.  The latest activity on the
   ;; pre-GNOME version has been in 2014, while GNOME has continued applying
   ;; fixes since.
-  (let ((commit "0997887d97f01be28bf3886dfd3e2002de437930")
-        (revision "3"))
+  (let ((commit "b903dd83aa5aab1b41c7864dd5027d1b6a0a190c")
+        (revision "4"))
     (package
       (name "dia")
       (version (git-version "0.97.3" revision commit))
@@ -1952,7 +1952,7 @@ (define-public dia
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "199b4n1jydg1g9lnz0r8xx67h7s2ac2lfj89zp015lbs0qqfkmsh"))))
+                  "0j5q7whwpzzfsinjryp3g0xh3cyy88drwyr0w8x0666mj6h70h6a"))))
       (build-system meson-build-system)
       ;; XXX: Parallel builds may cause: [74/566] [...]
       ;; fatal error: dia-lib-enums.h: No such file or directory

base-commit: f0a51a2bda26f9cc1e0b54b48712bd7cc54408e9
-- 
2.39.2

Message #11 received at 63274 <at> debbugs.gnu.org (full text, mbox):

From: Giovanni Biscuolo <g <at> xelera.eu>
To: 63274 <at> debbugs.gnu.org
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [PATCH] gnu: dia: Update to 0.97.3-4.b903dd8
Date: Mon, 15 May 2023 16:52:19 +0200

[Message part 1 (text/plain, inline)]

Hello,

gentle ping (and I forgot to Cc: the gnome team)

Thanks! Gio'

Giovanni Biscuolo <g <at> xelera.eu> writes:

[...]

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 63274 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: 63274 <at> debbugs.gnu.org
Subject: Re: dia: Fails to build (Meson: Function does not take positional
 arguments)
Date: Fri, 19 May 2023 18:06:14 +0200

[Message part 1 (text/plain, inline)]

Ivan Vilata i Balaguer (2023-05-04 17:26:48 +0200) wrote:

> Hi!  It looks like the Meson build of `dia` fails to complete in the version
> of Guix shown below:
> 
> ```
> […]
>     commit: 3f8c4899a9a67bb509a603bd21dcfcfab88c0e8e
> ```
> 
> This is the final part of the build log:
> 
> ```
> starting phase `configure'
> The Meson build system
> […]
> ../source/sheets/meson.build:47:32: ERROR: Function does not take positional arguments.
> […]
> ```

The latest commit in Dia's Git repo (just 3 after the one use by Guix) states
"build: Fix deprecated positional argument for i18n.merge_file":
<https://gitlab.gnome.org/GNOME/dia/-/commit/6ef461d8a04ffcd23df26fc4749cebc6322a5322>

Building `--with-commit=dia=6ef461d8a04ffcd23df26fc4749cebc6322a5322` is successful.

I'll send a patch to fix this.

Cheers!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 63274 <at> debbugs.gnu.org (full text, mbox):

From: Giovanni Biscuolo <g <at> xelera.eu>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>, 63274 <at> debbugs.gnu.org
Subject: Re: bug#63274: dia: Fails to build (Meson: Function does not take
 positional arguments)
Date: Sat, 20 May 2023 10:15:58 +0200

[Message part 1 (text/plain, inline)]

Hello Ivan,

Ivan Vilata i Balaguer <ivan <at> selidor.net> writes:

> The latest commit in Dia's Git repo (just 3 after the one use by Guix) states
> "build: Fix deprecated positional argument for i18n.merge_file":
> <https://gitlab.gnome.org/GNOME/dia/-/commit/6ef461d8a04ffcd23df26fc4749cebc6322a5322>
>
> Building `--with-commit=dia=6ef461d8a04ffcd23df26fc4749cebc6322a5322` is successful.
>
> I'll send a patch to fix this.

I sent a patch on May 5th as #63274 [1] using commit
b903dd83aa5aab1b41c7864dd5027d1b6a0a190c, please send a V2 patch if you
think is better

Thanks! Gio'

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63274

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 63274 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: 63274 <at> debbugs.gnu.org
Cc: Giovanni Biscuolo <g <at> xelera.eu>
Subject: [PATCH v2] gnu: dia: Update to 0.97.3-4.b903dd8 to fix Meson build.
Date: Sat, 20 May 2023 11:57:08 +0200

[Message part 1 (text/plain, inline)]

Fixes <https://issues.guix.gnu.org/63274>.

* gnu/packages/gnome.scm (dia): Update to 0.97.3-4.b903dd8
---
 gnu/packages/gnome.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 754bb668ba..ae891d6cc3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -74,6 +74,7 @@
 ;;; Copyright © 2022 Alexandros Theodotou <alex <at> zrythm.org>
 ;;; Copyright © 2022 Arjan Adriaanse <arjan <at> adriaan.se>
 ;;; Copyright © 2023 Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
+;;; Copyright © 2023 Giovanni Biscuolo <g <at> xelera.eu>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1951,8 +1952,8 @@ (define-public dia
   ;; recent versions of the build tools.  The latest activity on the
   ;; pre-GNOME version has been in 2014, while GNOME has continued applying
   ;; fixes since.
-  (let ((commit "0997887d97f01be28bf3886dfd3e2002de437930")
-        (revision "3"))
+  (let ((commit "b903dd83aa5aab1b41c7864dd5027d1b6a0a190c")
+        (revision "4"))
     (package
       (name "dia")
       (version (git-version "0.97.3" revision commit))
@@ -1964,7 +1965,7 @@ (define-public dia
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "199b4n1jydg1g9lnz0r8xx67h7s2ac2lfj89zp015lbs0qqfkmsh"))))
+                  "0j5q7whwpzzfsinjryp3g0xh3cyy88drwyr0w8x0666mj6h70h6a"))))
       (build-system meson-build-system)
       ;; XXX: Parallel builds may cause: [74/566] [...]
       ;; fatal error: dia-lib-enums.h: No such file or directory

base-commit: 0aab24855238cc7c7a31066ab39cd94e534b857f
-- 
2.39.2


-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 63274 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Giovanni Biscuolo <g <at> xelera.eu>
Cc: 63274 <at> debbugs.gnu.org, Ivan Vilata i Balaguer <ivan <at> selidor.net>
Subject: Re: bug#63274: dia: Fails to build (Meson: Function does not take
 positional arguments)
Date: Sat, 20 May 2023 11:58:43 +0200

[Message part 1 (text/plain, inline)]

Giovanni Biscuolo (2023-05-20 10:15:58 +0200) wrote:

> Hello Ivan,
> 
> Ivan Vilata i Balaguer <ivan <at> selidor.net> writes:
> 
> > The latest commit in Dia's Git repo (just 3 after the one use by Guix) states
> > "build: Fix deprecated positional argument for i18n.merge_file":
> > <https://gitlab.gnome.org/GNOME/dia/-/commit/6ef461d8a04ffcd23df26fc4749cebc6322a5322>
> >
> > Building `--with-commit=dia=6ef461d8a04ffcd23df26fc4749cebc6322a5322` is successful.
> >
> > I'll send a patch to fix this.
> 
> I sent a patch on May 5th as #63274 [1] using commit
> b903dd83aa5aab1b41c7864dd5027d1b6a0a190c, please send a V2 patch if you
> think is better
> 
> Thanks! Gio'
> 
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63274

Thanks Giovanni!  Sorry that I didn't know about your patch, it looks like
Guix debbugs doesn't send copies of messages in the bug thread to involved
addresses (not even to the original poster 🙁)…  I kinda assumed it behaved
like Debian's.  I'll remember to check the issue page and use "reply to all"
next time, just in case.

Yesterday I sent patch <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63592>
(v2), not knowing about yours.  I just checked your patch and it points to a
more recent commit than my patch, so I guess it fixes even more stuff, and I
see that Guix' version has anyway been quite ahead 1.9.5 for a while.  So I
guess that your patch makes more sense.  However, I see that you forgot to add
your copyright entry at the beginning of the file, and you may want to specify
that the patch fixes this issue too (you may want to adapt the commit message
from my v2 patch).

I sent a new version of your patch which just fixes that.  I'll ask to close
my other patch issue.

Thanks again!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 63274-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Giovanni Biscuolo <g <at> xelera.eu>, 63274-done <at> debbugs.gnu.org, 
 63592-done <at> debbugs.gnu.org
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [PATCH] gnu: dia: Update to 0.97.3-4.b903dd8
Date: Sun, 21 May 2023 22:40:06 +0200

Am Montag, dem 15.05.2023 um 16:52 +0200 schrieb Giovanni Biscuolo:
> Hello,
> 
> gentle ping (and I forgot to Cc: the gnome team)
Pushed now.

Cheers

Message #31 received at 63274-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: Giovanni Biscuolo <g <at> xelera.eu>, 63592-done <at> debbugs.gnu.org,
 Raghav Gururajan <rg <at> raghavgururajan.name>, 63274-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: dia: Update to 0.97.3-4.b903dd8
Date: Mon, 22 May 2023 10:25:53 -0400

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Montag, dem 15.05.2023 um 16:52 +0200 schrieb Giovanni Biscuolo:
>> Hello,
>> 
>> gentle ping (and I forgot to Cc: the gnome team)
> Pushed now.

Thanks, Liliana!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.