GNU bug report logs - #63295
[PATCH] Update csvkit to 1.1.1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63295 in the body.
You can then email your comments to 63295 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alice BRENON <alice.brenon <at> ens-lyon.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update csvkit to 1.1.1
Date: Fri, 5 May 2023 12:26:36 +0200

[Message part 1 (text/plain, inline)]

Hello guix,

I use csvkit and noticed it broke after the upgrade to python 3.10

http://ci.guix.gnu.org/build/1263118/details

Updating it and a couple dependencies fixed it so here's a patch. I also
converted the `*-inputs` fields to new style while I was at it.

The addition of `(gnu package base)` among dependencies is because of
`python-agate` now wanting `glibc-locales` for one of its tests. I hate to have
had to write the previous sentence because a `((gnu package base) #:select
(glibc-locales))` would have carried exactly as much information and remained in
the code where it could be useful in the future while this email will be
long-forgotten when someone needs it. But the rest of the imports are implicit
(don't want to break the convention) and someone recently argued again against
explicit imports on the chan. I therefore merely point out another situation
where implicit would have saved the day to be sure not to waste evidence, should
the community want to weigh the benefits and drawbacks of each approach some
day.

Nice day to you all,

Alice

[0001-gnu-csvkit-Update-to-1.1.1.patch (text/x-patch, attachment)]

Message #8 received at 63295 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Alice BRENON <alice.brenon <at> ens-lyon.fr>
Cc: 63295 <at> debbugs.gnu.org
Subject: Re: [bug#63295] [PATCH] Update csvkit to 1.1.1
Date: Fri, 5 May 2023 08:41:31 -0400

On Fri, May 5, 2023 at 6:27 AM Alice BRENON <alice.brenon <at> ens-lyon.fr> wrote:
>
> Hello guix,
>
> I use csvkit and noticed it broke after the upgrade to python 3.10

#62418 from March 24 also fixes csvkit with updated dependencies.

Message #11 received at 63295 <at> debbugs.gnu.org (full text, mbox):

From: Alice BRENON <alice.brenon <at> ens-lyon.fr>
To: Greg Hogan <code <at> greghogan.com>
Cc: 63295 <at> debbugs.gnu.org
Subject: Re: [bug#63295] [PATCH] Update csvkit to 1.1.1
Date: Sat, 6 May 2023 17:27:04 +0200

[Message part 1 (text/plain, inline)]

Thanks for your vigilance and sorry for the duplicate. Following our
discussion I'll leave it open for now, hoping one of them will be
reviewed and accepted.

I'll also follow the advice of the linter (actually I had first gone for a
substitute* to fix the errors in the tests it was the linter which suggested I
updated the packages, making me completely rewrite my patch and taking some time
to check whether the dependencies where still needed and then I forgot to put a pair of
parenthesis back to the line where they belonged — that, and to re-run the
linter after having reworked on the patch that much, that is) and here is a
hopefully cleaner version of my patch.

Le Fri, 5 May 2023 08:41:31 -0400,
Greg Hogan <code <at> greghogan.com> a écrit :

> On Fri, May 5, 2023 at 6:27 AM Alice BRENON
> <alice.brenon <at> ens-lyon.fr> wrote:
> >
> > Hello guix,
> >
> > I use csvkit and noticed it broke after the upgrade to python 3.10  
> 
> #62418 from March 24 also fixes csvkit with updated dependencies.

[0001-gnu-csvkit-Update-to-1.1.1.patch (text/x-patch, attachment)]

Message #14 received at 63295 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Alice BRENON <alice.brenon <at> ens-lyon.fr>
Cc: 63295 <at> debbugs.gnu.org
Subject: Re: [bug#63295] [PATCH] Update csvkit to 1.1.1
Date: Thu, 11 May 2023 18:08:47 -0400

On Sat, May 6, 2023 at 11:27 AM Alice BRENON <alice.brenon <at> ens-lyon.fr> wrote:
>
> Thanks for your vigilance and sorry for the duplicate. Following our
> discussion I'll leave it open for now, hoping one of them will be
> reviewed and accepted.
>
> I'll also follow the advice of the linter (actually I had first gone for a
> substitute* to fix the errors in the tests it was the linter which suggested I
> updated the packages, making me completely rewrite my patch and taking some time
> to check whether the dependencies where still needed and then I forgot to put a pair of
> parenthesis back to the line where they belonged — that, and to re-run the
> linter after having reworked on the patch that much, that is) and here is a
> hopefully cleaner version of my patch.

The patch should be divided with each package update in a separate
patch (a large number of small, similar updates can be made in a
single patch).

Your update to python-agate includes glibc-locales (a 932 MiB package)
whereas mine added python-agate-locales as a new package. Yours has
(as noted) additional changes to the inputs.

My patchset updates python-agate-sql. I don't recall why, but it must
have fixed a breaking build. The only dependent package is csvkit.

Message #19 received at 63295-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 62418-done <at> debbugs.gnu.org, Alice BRENON <alice.brenon <at> ens-lyon.fr>,
 63295-done <at> debbugs.gnu.org
Subject: Re: bug#62418: [PATCH 0/6] Update csvkit.
Date: Sun, 14 May 2023 23:00:35 +0200

Hi Greg and Alice,

Greg Hogan <code <at> greghogan.com> skribis:

> python-leather, python-agate, and csvkit were failing to build for me on
> the core-updates branch.
>
> Greg Hogan (6):
>   gnu: python-leather: Update to 0.3.4.
>   gnu: python-agate-dbf: Update to 0.2.2.
>   gnu: python-agate-sql: Update to 0.5.9.
>   gnu: Add python-agate-locales.
>   gnu: python-agate: Update to 1.7.1
>   gnu: csvkit: Update to 1.1.1.

It’s been two months but I’ve finally applies this patch series.
Apologies for the delay!

Alice, if you see any further changes that should be made, please send
them as a separate patch on top of this.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.