GNU bug report logs - #63310
29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63310 in the body.
You can then email your comments to 63310 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes
 from byte-compile-warnings do not prevent all docstring warnings
Date: Fri, 05 May 2023 16:07:20 +0100

Reproduction:

1. `(custom-set-variables '(byte-compile-warnings '(not docstrings
docstrings-non-ascii-quotes)))`
2. M-x package-install RET move-dup
3. M-x package-install RET monky
4. Observe in the *Compile-Log* buffer the `custom-declare-variable
... docstring has wrong usage of unescaped single quotes (use \= or different quoting)` and `docstring wider than ... characters` mesages

Expectation:

Blacklisting docstrings and docstrings-non-ascii-quotes should not result
in any docstring warnings being emitted during byte compilation.

Message #8 received at 63310 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
Cc: 63310 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#63310: 29.0.90;
 Blacklisting docstrings and docstrings-non-ascii-quotes from
 byte-compile-warnings do not prevent all docstring warnings
Date: Sat, 06 May 2023 12:36:19 +0300

> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> Date: Fri, 05 May 2023 16:07:20 +0100
> 
> 
> Reproduction:
> 
> 1. `(custom-set-variables '(byte-compile-warnings '(not docstrings
> docstrings-non-ascii-quotes)))`
> 2. M-x package-install RET move-dup
> 3. M-x package-install RET monky
> 4. Observe in the *Compile-Log* buffer the `custom-declare-variable
> ... docstring has wrong usage of unescaped single quotes (use \= or different quoting)` and `docstring wider than ... characters` mesages
> 
> Expectation:
> 
> Blacklisting docstrings and docstrings-non-ascii-quotes should not result
> in any docstring warnings being emitted during byte compilation.

I don't see any warnings when compiling the latest version of
move-dup.

As for monkey: it explicitly sets the value of byte-compile-warnings
in file-local variables:

  ;; Local Variables:
  ;; byte-compile-warnings: (not cl-functions)
  ;; End:

So this overrides your customization when byte-compiling this file.

I see no bug here.

Message #11 received at 63310 <at> debbugs.gnu.org (full text, mbox):

From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63310 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#63310: 29.0.90; Blacklisting docstrings and
 docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all
 docstring warnings
Date: Sat, 6 May 2023 17:39:56 +0100

[Message part 1 (text/plain, inline)]

Sorry both message came from monky. I didn't notice the file local
variables set at the bottom. There is indeed no bug here, sorry about this,
you can close this.
Jimmy


On Sat, May 6, 2023 at 10:35 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> > Date: Fri, 05 May 2023 16:07:20 +0100
> >
> >
> > Reproduction:
> >
> > 1. `(custom-set-variables '(byte-compile-warnings '(not docstrings
> > docstrings-non-ascii-quotes)))`
> > 2. M-x package-install RET move-dup
> > 3. M-x package-install RET monky
> > 4. Observe in the *Compile-Log* buffer the `custom-declare-variable
> > ... docstring has wrong usage of unescaped single quotes (use \= or
> different quoting)` and `docstring wider than ... characters` mesages
> >
> > Expectation:
> >
> > Blacklisting docstrings and docstrings-non-ascii-quotes should not result
> > in any docstring warnings being emitted during byte compilation.
>
> I don't see any warnings when compiling the latest version of
> move-dup.
>
> As for monkey: it explicitly sets the value of byte-compile-warnings
> in file-local variables:
>
>   ;; Local Variables:
>   ;; byte-compile-warnings: (not cl-functions)
>   ;; End:
>
> So this overrides your customization when byte-compiling this file.
>
> I see no bug here.
>

[Message part 2 (text/html, inline)]

Message #14 received at 63310 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
Cc: 63310 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#63310: 29.0.90; Blacklisting docstrings and
 docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all
 docstring warnings
Date: Sat, 06 May 2023 19:55:41 +0300

> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> Date: Sat, 6 May 2023 17:39:56 +0100
> Cc: 63310 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
> 
> Sorry both message came from monky. I didn't notice the file local variables set at the bottom. There is
> indeed no bug here, sorry about this, you can close this.

Thanks.

Stefan, any thoughts or comments before I close this?

Message #17 received at 63310 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 63310 <at> debbugs.gnu.org
Subject: Re: bug#63310: 29.0.90; Blacklisting docstrings and
 docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all
 docstring warnings
Date: Sat, 06 May 2023 14:41:23 -0400

> Sorry both message came from monky. I didn't notice the file local
> variables set at the bottom.
[...]
>>   ;; Local Variables:
>>   ;; byte-compile-warnings: (not cl-functions)
>>   ;; End:

BTW, this setting is either obsolete (if the package uses `cl-lib`) or
should be made obsolete (by moving to `cl-lib`).


        Stefan

Message #22 received at 63310-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 63310-done <at> debbugs.gnu.org
Subject: Re: bug#63310: 29.0.90;
 Blacklisting docstrings and docstrings-non-ascii-quotes from
 byte-compile-warnings do not prevent all docstring warnings
Date: Sat, 13 May 2023 17:03:59 +0300

> Cc: 63310 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
> Date: Sat, 06 May 2023 19:55:41 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> > Date: Sat, 6 May 2023 17:39:56 +0100
> > Cc: 63310 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
> > 
> > Sorry both message came from monky. I didn't notice the file local variables set at the bottom. There is
> > indeed no bug here, sorry about this, you can close this.
> 
> Thanks.
> 
> Stefan, any thoughts or comments before I close this?

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.