GNU bug report logs - #63317
29.0.90; ediff-auto-refine is set at require-time rather than runtime

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63317 in the body.
You can then email your comments to 63317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.90; ediff-auto-refine is set at require-time rather than runtime
Date: Fri, 5 May 2023 21:15:11 +0100 (BST)

If ediff is loaded from a GUI, ediff-auto-refine defaults to "on", which is the desired behaviour.

However, if your ~/.emacs contains "(require 'ediff)", and you start emacs with the --daemon option, variable ediff-auto-refine will instead default to "nix", even if you later try to use ediff from a GUI started with "emacsclient --create-frame".

-- 
Peter Oliver

Message #8 received at 63317 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Peter Oliver <p.d.oliver <at> mavit.org.uk>
Cc: 63317 <at> debbugs.gnu.org
Subject: Re: bug#63317: 29.0.90;
 ediff-auto-refine is set at require-time rather than runtime
Date: Sat, 06 May 2023 09:11:23 +0300

> Date: Fri, 5 May 2023 21:15:11 +0100 (BST)
> From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
> 
> If ediff is loaded from a GUI, ediff-auto-refine defaults to "on", which is the desired behaviour.
> 
> However, if your ~/.emacs contains "(require 'ediff)", and you start emacs with the --daemon option, variable ediff-auto-refine will instead default to "nix", even if you later try to use ediff from a GUI started with "emacsclient --create-frame".

If you want the daemon session to do something that requires a GUI
frame, you need to have the relevant customizations in
server-after-make-frame-hook, so that the customizations run when such
a frame is already created.  In this case, I suggest to have that hook
change the value of ediff-auto-refine depending on whether the created
frame is a GUI frame or a TTY frame.  (Or, if you personally never
create TTY client frames, you can set ediff-auto-refine to "on"
unconditionally in that hook.)

Or maybe do that in some appropriate Ediff hook.

We cannot do this automatically, not via the default value of the
option, because a daemon session can be used for both GUI and TTY
frames (and can have frames of both types active at the same time in
the same session).

So I don't see a bug here, just a need for more elaborate
customizations in daemon sessions.

Message #13 received at 63317-done <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: 63317-done <at> debbugs.gnu.org
Subject: Re: bug#63317: 29.0.90; ediff-auto-refine is set at require-time
 rather than runtime
Date: Mon, 8 May 2023 11:30:15 +0100 (BST)

Closing in favour of #63318.

-- 
Peter Oliver

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.