GNU bug report logs - #63318
Variable ediff-auto-refine doesn't always default to "on"

Previous Next

Package: emacs;

Reported by: Peter Oliver <p.d.oliver <at> mavit.org.uk>

Date: Fri, 5 May 2023 20:23:01 UTC

Severity: minor

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63318 in the body.
You can then email your comments to 63318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#63318; Package emacs. (Fri, 05 May 2023 20:23:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Peter Oliver <p.d.oliver <at> mavit.org.uk>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 05 May 2023 20:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: bug-gnu-emacs <at> gnu.org
Subject: Variable ediff-auto-refine doesn't always default to "on"
Date: Fri, 5 May 2023 21:21:50 +0100 (BST)
[Message part 1 (text/plain, inline)]
Severity: minor
Tags: patch

Document that variable ediff-auto-refine doesn't always default to "on".

-- 
Peter Oliver
[0001-Variable-ediff-auto-refine-doesn-t-always-default-to.patch (text/plain, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63318; Package emacs. (Sat, 06 May 2023 06:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 63318 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Peter Oliver <p.d.oliver <at> mavit.org.uk>
Cc: 63318 <at> debbugs.gnu.org
Subject: Re: bug#63318: Variable ediff-auto-refine doesn't always default to
 "on"
Date: Sat, 06 May 2023 09:17:27 +0300
> Date: Fri, 5 May 2023 21:21:50 +0100 (BST)
> From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
> 
> Document that variable ediff-auto-refine doesn't always default to "on".

Wouldn't it be better to instead fix this, so that the default is
always "on"?

Why doesn't Ediff turn on ediff-auto-refine for all terminals?
AFAICT, it only needs faces (basically, colors), and we support that
on all terminals nowadays?  So I think we should simply change the
default value (which will also solve bug#63317).  Or what am I
missing?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63318; Package emacs. (Mon, 08 May 2023 10:27:01 GMT) Full text and rfc822 format available.

Message #11 received at 63318 <at> debbugs.gnu.org (full text, mbox):

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63318 <at> debbugs.gnu.org
Subject: Re: bug#63318: Variable ediff-auto-refine doesn't always default to
 "on"
Date: Mon, 8 May 2023 11:26:47 +0100 (BST)
[Message part 1 (text/plain, inline)]
On Sat, 6 May 2023, Eli Zaretskii wrote:

>> Date: Fri, 5 May 2023 21:21:50 +0100 (BST)
>> From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
>>
>> Document that variable ediff-auto-refine doesn't always default to "on".
>
> Wouldn't it be better to instead fix this, so that the default is
> always "on"?
>
> Why doesn't Ediff turn on ediff-auto-refine for all terminals?
> AFAICT, it only needs faces (basically, colors), and we support that
> on all terminals nowadays?  So I think we should simply change the
> default value (which will also solve bug#63317).  Or what am I
> missing?

I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable.

If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me.  Attached is a patch to do that instead.

-- 
Peter Oliver
[0001-Always-default-ediff-auto-refine-to-on.patch (text/plain, attachment)]

Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sat, 13 May 2023 14:03:02 GMT) Full text and rfc822 format available.

Notification sent to Peter Oliver <p.d.oliver <at> mavit.org.uk>:
bug acknowledged by developer. (Sat, 13 May 2023 14:03:02 GMT) Full text and rfc822 format available.

Message #16 received at 63318-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Peter Oliver <p.d.oliver <at> mavit.org.uk>
Cc: 63318-done <at> debbugs.gnu.org
Subject: Re: bug#63318: Variable ediff-auto-refine doesn't always default to
 "on"
Date: Sat, 13 May 2023 17:02:14 +0300
> Date: Mon, 8 May 2023 11:26:47 +0100 (BST)
> From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
> cc: 63318 <at> debbugs.gnu.org
> 
> > Why doesn't Ediff turn on ediff-auto-refine for all terminals?
> > AFAICT, it only needs faces (basically, colors), and we support that
> > on all terminals nowadays?  So I think we should simply change the
> > default value (which will also solve bug#63317).  Or what am I
> > missing?
> 
> I assumed that this complication was present because there exist displays on which auto-refinement isn’t desirable.
> 
> If that’s no-longer the case, then great, simplifying the default to always be “on” certainly sounds like the best way to go to me.  Attached is a patch to do that instead.

Thanks, installed on the master branch (after applying the necessary
fix).

Closing the bug.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 11 Jun 2023 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 290 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.