GNU bug report logs - #63327
[PATCH] gnu: openjdk9: Fix build on aarch64.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63327 in the body.
You can then email your comments to 63327 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: openjdk9: Fix build on aarch64.
Date: Sat,  6 May 2023 11:50:47 +0100

* gnu/packages/java.scm (openjdk9)[arguments]: Add 'patch-for-aarch64 phase to
remove duplicate line in interp_masm_aarch64.hpp.
---
 gnu/packages/java.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 067284017c..166417a73d 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -884,6 +884,18 @@ (define-public openjdk9
 
        #:phases
        (modify-phases %standard-phases
+         ,@(if (target-aarch64?)
+               `((add-after 'unpack 'patch-for-aarch64
+                   (lambda _
+                     (substitute* "hotspot/src/cpu/aarch64/vm/interp_masm_aarch64.hpp"
+                       ;; This line is duplicated, so remove both occurrences,
+                       ;; then add back one occurrence by substituting a
+                       ;; comment that occurs once.
+                       (("using MacroAssembler::call_VM_leaf_base;") "")
+                       (("Interpreter specific version of call_VM_base")
+                        "Interpreter specific version of call_VM_base
+  using MacroAssembler::call_VM_leaf_base;")))))
+               '())
          (add-after 'patch-source-shebangs 'fix-java-shebangs
            (lambda _
              ;; This file was "fixed" by patch-source-shebangs, but it requires

base-commit: 64086a4fa449a9f6d2f835fcdf5498222b309e3a
-- 
2.39.1

Message #8 received at 63327 <at> debbugs.gnu.org (full text, mbox):

From: burning2007 <at> ya.ru
To: "63327 <at> debbugs.gnu.org" <63327 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: openjdk9: Fix build on aarch64.
Date: Tue, 09 May 2023 05:45:01 +0300

[Message part 1 (text/html, inline)]

Message #11 received at 63327 <at> debbugs.gnu.org (full text, mbox):

From: Anthony <burning2007 <at> ya.ru>
To: 63327 <at> debbugs.gnu.org
Cc: burning2007 <at> ya.ru
Subject: [PATCH] gnu: openjdk9: Fix build on aarch64.
Date: Tue,  9 May 2023 07:10:40 +0400

From: burning2007 <at> ya.ru

Hello!

I've encountered this issue and tested similar solution (patch). It builds successfully. It even allows openjdk <at> 10 to build as well - mine has same build errors as for openjdk <at> 9.

But, on the other hand, it is not sufficient for building jdk <at> 9 itself - please, take a look at https://issues.guix.gnu.org/issue/63069.

P. S. Sorry for attachment in previous message - my email provider does not even have a plain text option in UI.

--
Best regards,

Anthony

Message #14 received at 63327 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 63327 <at> debbugs.gnu.org
Subject: Re: bug#63327: [PATCH] gnu: openjdk9: Fix build on aarch64.
Date: Mon, 22 May 2023 16:50:04 +0200

Christopher Baines <mail <at> cbaines.net> skribis:

> * gnu/packages/java.scm (openjdk9)[arguments]: Add 'patch-for-aarch64 phase to
> remove duplicate line in interp_masm_aarch64.hpp.

I’d say go for it if it fixes the problem.

Thanks,
Ludo’.

Message #19 received at 63327-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 63327-done <at> debbugs.gnu.org
Subject: Close
Date: Wed, 26 Jul 2023 16:00:40 +0200

I just ran the patch, and can confirm that it enables the build of openjdk <at> 9
on aarch64. So I have pushed it and am closing this bug.

More discussion at https://issues.guix.gnu.org/issue/63069 .

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.