GNU bug report logs - #63346
[PATCH] Makefile.am: Use --add flag to "git config".

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63346 in the body.
You can then email your comments to 63346 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] Makefile.am: Use --add flag to "git config".
Date: Sun,  7 May 2023 10:43:41 +0000

Without the "--add" flag to "git config include.path ...", the command fails
if the user already has a configuration entry of "include.path".
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 8af69f88ac..13718e4353 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1121,7 +1121,7 @@ cuirass-jobs: $(GOBJECTS)
 
 .git/config: etc/git/gitconfig
 	$(AM_V_at)if command -v git >/dev/null && test -d .git; then \
-	git config include.path ../etc/git/gitconfig; \
+	git config --add include.path ../etc/git/gitconfig; \
 	fi
 
 nodist_noinst_DATA = .git/hooks/pre-push .git/config

base-commit: fccb48d2cec6bcf47647c82914f31e2dff617f9c
-- 
2.39.2

Message #10 received at 63346-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Mekeor Melire <mekeor <at> posteo.de>
Cc: 63346-done <at> debbugs.gnu.org
Subject: Re: bug#63346: [PATCH] Makefile.am: Use --add flag to "git config".
Date: Sun, 07 May 2023 09:20:22 -0400

Hi,

Mekeor Melire <mekeor <at> posteo.de> writes:

> Without the "--add" flag to "git config include.path ...", the command fails
> if the user already has a configuration entry of "include.path".
> ---
>  Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 8af69f88ac..13718e4353 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1121,7 +1121,7 @@ cuirass-jobs: $(GOBJECTS)
>  
>  .git/config: etc/git/gitconfig
>  	$(AM_V_at)if command -v git >/dev/null && test -d .git; then \
> -	git config include.path ../etc/git/gitconfig; \
> +	git config --add include.path ../etc/git/gitconfig; \
>  	fi

Installed, thank you!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.