GNU bug report logs - #63370
[PATCH] gnu: Add emacs-framemove.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63370 in the body.
You can then email your comments to 63370 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: guix-patches <at> gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: Add emacs-framemove.
Date: Mon,  8 May 2023 14:05:20 +0100

Hi, this tiny patch is to add FrameMove, an Emacs package that allows to move
focus across windows and frames. IIUC, it can be particularly useful to EXWM
users. The package is currently hosted on EmacsWiki at
https://www.emacswiki.org/emacs/FrameMove. Hope this helps.

* gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.

Signed-off-by: Fabio Natali <me <at> fabionatali.com>
---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 050e6377a3..720cefae18 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -128,6 +128,7 @@
 ;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
 ;;; Copyright © 2023 Evgeny Pisemsky <evgeny <at> pisemsky.com>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel <at> erlikon.ch>
+;;; Copyright © 2023 Fabio Natali <me <at> fabionatali.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32435,6 +32436,25 @@ (define-public emacs-windower
 @end itemize")
     (license license:gpl3+)))
 
+(define-public emacs-framemove
+  (package
+    (name "emacs-framemove")
+    (version "0.10")
+    (source
+     (origin
+       (method url-fetch)
+       (uri "https://www.emacswiki.org/emacs/download/framemove.el")
+       (sha256
+        (base32
+         "15fhhywr0y2bd10rp60qkdq521l8ag1is4ahjnd84hl2w0qn7gnw"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/framemove.el")
+    (synopsis "Directional frame selection routines")
+    (description "@code{emacs-framemove} is similar to the @code{windmove.el}
+library, but for frames. It provides a simple set of keystrokes to move the
+input/focus between windows.")
+    (license license:gpl3)))
+
 (define-public emacs-flycheck-cpplint
   (package
     (name "emacs-flycheck-cpplint")

base-commit: 0e09e8ab1554a7dffd60101cb4e631b348e43c9c
-- 
2.39.2

Message #8 received at 63370 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fabio Natali <me <at> fabionatali.com>
Cc: 63370 <at> debbugs.gnu.org
Subject: Re: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Mon, 08 May 2023 18:15:38 +0200

Hello,

Fabio Natali <me <at> fabionatali.com> writes:
>
> * gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.

Thank you.

> Signed-off-by: Fabio Natali <me <at> fabionatali.com>

In Guix, you don't sign your own commits.

> +       (uri "https://www.emacswiki.org/emacs/download/framemove.el")

This is an issue, because the URI is not stable. Please use GitHub
repository instead: <https://github.com/emacsmirror/framemove>.

> +    (description "@code{emacs-framemove} is similar to the
> @code{windmove.el}

Nicpicks: @code{emacs-framemove} -> Framemove and @code{windmove.el} -> Windmove.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 63370 <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: 63370 <at> debbugs.gnu.org
Cc: Fabio Natali <me <at> fabionatali.com>
Subject: [PATCH] gnu: Add emacs-framemove.
Date: Mon,  8 May 2023 20:07:45 +0100

Updated patch, as per Nicolas' suggestions (hopefully I got everything right).

* gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 050e6377a3..45c47fc5f5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -128,6 +128,7 @@
 ;;; Copyright © 2023 Juliana Sims <juli <at> incana.org>
 ;;; Copyright © 2023 Evgeny Pisemsky <evgeny <at> pisemsky.com>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel <at> erlikon.ch>
+;;; Copyright © 2023 Fabio Natali <me <at> fabionatali.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32435,6 +32436,30 @@ (define-public emacs-windower
 @end itemize")
     (license license:gpl3+)))
 
+(define-public emacs-framemove
+  ;; Use the latest commit, as there are no tagged releases.
+  (let ((commit "0faa8a4937f398e4971fc877b1c294100506b645")
+        (revision "0"))
+    (package
+      (name "emacs-framemove")
+      (version (git-version "0.10" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/emacsmirror/framemove")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1z4xqx1cvllil03pdwsybsj5v9w7ggdrak1kxa856ki5mj1ja3gl"))))
+      (build-system emacs-build-system)
+      (home-page "https://www.emacswiki.org/emacs/framemove.el")
+      (synopsis "Directional frame selection routines")
+      (description "Framemove is similar to the Windmove library, but for
+frames. It provides a simple set of keystrokes to move the input/focus between
+windows.")
+      (license license:gpl3))))
+
 (define-public emacs-flycheck-cpplint
   (package
     (name "emacs-flycheck-cpplint")

base-commit: 0e09e8ab1554a7dffd60101cb4e631b348e43c9c
-- 
2.39.2

Message #14 received at 63370 <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 63370 <at> debbugs.gnu.org
Subject: Re: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Mon, 08 May 2023 20:15:04 +0100

Hey Nicolas, thanks for getting back to me so quickly. An updated
version of the patch should be arriving in a minute.

On 2023-05-08, 18:15 +0200, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
> In Guix, you don't sign your own commits.

Ooops, sorry. Fixed in the new patch.

>> +       (uri "https://www.emacswiki.org/emacs/download/framemove.el")
>
> This is an issue, because the URI is not stable. Please use GitHub
> repository instead: <https://github.com/emacsmirror/framemove>.

Fixed.

>> +    (description "@code{emacs-framemove} is similar to the
>> @code{windmove.el}
>
> Nicpicks: @code{emacs-framemove} -> Framemove and @code{windmove.el} -> Windmove.

This is also fixed.

Thanks Nicolas, should you spot anything else, I'm very glad to keep
working on it.

Cheers, Fabio.

Message #17 received at 63370 <at> debbugs.gnu.org (full text, mbox):

From: Fabio Natali <me <at> fabionatali.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 63370 <at> debbugs.gnu.org
Subject: Re: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Wed, 10 May 2023 09:00:46 +0100

On 2023-05-08, 20:15 +0100, Fabio Natali <me <at> fabionatali.com> wrote:
> Hey Nicolas, thanks for getting back to me so quickly. An updated
> version of the patch should be arriving in a minute.

(Just to clarify, the patch ended up arriving a bit earlier than my
above comment, it's here: https://issues.guix.gnu.org/63370#2.)

Message #22 received at 63370-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fabio Natali <me <at> fabionatali.com>
Cc: 63370-done <at> debbugs.gnu.org
Subject: Re: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Thu, 11 May 2023 23:59:15 +0200

Hello,

Fabio Natali <me <at> fabionatali.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.