GNU bug report logs - #63396
\foreignlanguage in babel style file

Previous Next

Package: auctex;

Reported by: Gustavo Barros <gusbrs.2016 <at> gmail.com>

Date: Tue, 9 May 2023 18:55:02 UTC

Severity: normal

Done: Arash Esbati <arash <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63396 in the body.
You can then email your comments to 63396 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-auctex <at> gnu.org:
bug#63396; Package auctex. (Tue, 09 May 2023 18:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gustavo Barros <gusbrs.2016 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-auctex <at> gnu.org. (Tue, 09 May 2023 18:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: \foreignlanguage in babel style file
Date: Tue, 9 May 2023 15:54:29 -0300
Hi All,

just a quick and simple one.

`\foreignlanguage' specs in `babel.el' are missing the optional
argument it takes, both in `TeX-add-symbol` and in
`font-latex-add-keywords`.

Also, `\foreignlanguage' is included in the `function' font-lock
class. Arguably `textual' would be a much better fit for it.

Best,
Gustavo.




Information forwarded to bug-auctex <at> gnu.org:
bug#63396; Package auctex. (Wed, 10 May 2023 07:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 63396 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: 63396 <at> debbugs.gnu.org
Subject: Re: bug#63396: \foreignlanguage in babel style file
Date: Wed, 10 May 2023 09:45:43 +0200
Hi Gustavo,

Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

> just a quick and simple one.
>
> `\foreignlanguage' specs in `babel.el' are missing the optional
> argument it takes, both in `TeX-add-symbol` and in
> `font-latex-add-keywords`.
>
> Also, `\foreignlanguage' is included in the `function' font-lock
> class. Arguably `textual' would be a much better fit for it.

Thanks for the report.  You were thinking about a change like this?

--8<---------------cut here---------------start------------->8---
diff --git a/style/babel.el b/style/babel.el
index 2483b73b..2110289b 100644
--- a/style/babel.el
+++ b/style/babel.el
@@ -256,6 +256,7 @@
       (TeX-arg-completing-read (LaTeX-babel-active-languages)
                                "Language"))
     '("foreignlanguage"
+      [TeX-arg-completing-read-multiple ("date" "captions")]
       (TeX-arg-completing-read (LaTeX-babel-active-languages)
                                "Language")
       t)
@@ -374,7 +375,6 @@
    (when (and (featurep 'font-latex)
               (eq TeX-install-font-lock 'font-latex-setup))
      (font-latex-add-keywords '(("selectlanguage"     "{")
-                                ("foreignlanguage"    "{{")
                                 ("babeltags"          "{")
                                 ("babelensure"        "{{")
                                 ("shorthandon"        "{")
@@ -394,7 +394,9 @@
      (font-latex-add-keywords '(("defineshorthand"    "[{{")
                                 ("aliasshorthand"     "{{")
                                 ("languageattribute"  "{{"))
-                              'variable)))
+                              'variable)
+     (font-latex-add-keywords '(("foreignlanguage"    "[{{"))
+                              'textual)))
  TeX-dialect)

 (defvar LaTeX-babel-package-options-list
--8<---------------cut here---------------end--------------->8---

Best, Arash




Information forwarded to bug-auctex <at> gnu.org:
bug#63396; Package auctex. (Wed, 10 May 2023 09:25:02 GMT) Full text and rfc822 format available.

Message #11 received at 63396 <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 63396 <at> debbugs.gnu.org
Subject: Re: bug#63396: \foreignlanguage in babel style file
Date: Wed, 10 May 2023 06:23:57 -0300
Hi Arash,

On Wed, 10 May 2023 at 04:46, Arash Esbati <arash <at> gnu.org> wrote:

> Thanks for the report.  You were thinking about a change like this?
>
> --8<---------------cut here---------------start------------->8---
> diff --git a/style/babel.el b/style/babel.el
> index 2483b73b..2110289b 100644
> --- a/style/babel.el
> +++ b/style/babel.el
> @@ -256,6 +256,7 @@
>        (TeX-arg-completing-read (LaTeX-babel-active-languages)
>                                 "Language"))
>      '("foreignlanguage"
> +      [TeX-arg-completing-read-multiple ("date" "captions")]
>        (TeX-arg-completing-read (LaTeX-babel-active-languages)
>                                 "Language")
>        t)
> @@ -374,7 +375,6 @@
>     (when (and (featurep 'font-latex)
>                (eq TeX-install-font-lock 'font-latex-setup))
>       (font-latex-add-keywords '(("selectlanguage"     "{")
> -                                ("foreignlanguage"    "{{")
>                                  ("babeltags"          "{")
>                                  ("babelensure"        "{{")
>                                  ("shorthandon"        "{")
> @@ -394,7 +394,9 @@
>       (font-latex-add-keywords '(("defineshorthand"    "[{{")
>                                  ("aliasshorthand"     "{{")
>                                  ("languageattribute"  "{{"))
> -                              'variable)))
> +                              'variable)
> +     (font-latex-add-keywords '(("foreignlanguage"    "[{{"))
> +                              'textual)))
>   TeX-dialect)
>
>  (defvar LaTeX-babel-package-options-list
> --8<---------------cut here---------------end--------------->8---

Yes, very much so. Thank you!

Best,
Gustavo.




Reply sent to Arash Esbati <arash <at> gnu.org>:
You have taken responsibility. (Wed, 10 May 2023 09:48:03 GMT) Full text and rfc822 format available.

Notification sent to Gustavo Barros <gusbrs.2016 <at> gmail.com>:
bug acknowledged by developer. (Wed, 10 May 2023 09:48:03 GMT) Full text and rfc822 format available.

Message #16 received at 63396-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: 63396-done <at> debbugs.gnu.org
Subject: Re: bug#63396: \foreignlanguage in babel style file
Date: Wed, 10 May 2023 11:46:57 +0200
Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

> Yes, very much so. Thank you!

Thanks for your response.  I installed that change (commit c9ab5d58)
incl. some other minor issues I found.  Closing this report.

Best, Arash




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 07 Jun 2023 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 295 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.