GNU bug report logs - #63415
30.0.50; More Build Warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63415 in the body.
You can then email your comments to 63415 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; More Build Warnings
Date: Wed, 10 May 2023 07:25:34 -0400

[Message part 1 (text/plain, inline)]

Hello,

dispnew.c:3650:12: warning: variable 'changed_p' set but not used [-Wunused-but-set-variable]
      bool changed_p = 0, mouse_face_overwritten_p = 0;
           ^
1 warning generated.

In native--compile-async:
comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused

In end of data:
dynamic-setting.el:58:12: Warning: the function ‘reconsider-frame-fonts’ is not known to be defined.

In end of data:
prog-mode.el:164:38: Warning: the function ‘treesit-node-at’ might not be defined at runtime.

In haiku-dnd-wheel-modifier-type:
haiku-win.el:520:25: Warning: reference to free variable ‘mouse-wheel-scroll-amount’

In haiku-handle-drag-wheel:
haiku-win.el:543:21: Warning: reference to free variable ‘mwheel-scroll-up-function’
haiku-win.el:545:21: Warning: reference to free variable ‘mwheel-scroll-down-function’
haiku-win.el:546:34: Warning: reference to free variable ‘mouse-wheel-flip-direction’
haiku-win.el:547:34: Warning: reference to free variable ‘mwheel-scroll-right-function’
haiku-win.el:548:32: Warning: reference to free variable ‘mwheel-scroll-left-function’
haiku-win.el:571:39: Warning: reference to free variable ‘mouse-wheel-progressive-speed’

In x-dnd-wheel-modifier-type:
x-dnd.el:757:25: Warning: reference to free variable ‘mouse-wheel-scroll-amount’

In x-dnd-mwheel-scroll:
x-dnd.el:794:29: Warning: reference to free variable ‘mouse-wheel-progressive-speed’
x-dnd.el:796:23: Warning: reference to free variable ‘mouse-wheel-tilt-scroll’
x-dnd.el:804:34: Warning: reference to free variable ‘mwheel-scroll-right-function’
x-dnd.el:805:32: Warning: reference to free variable ‘mwheel-scroll-down-function’
x-dnd.el:808:34: Warning: reference to free variable ‘mwheel-scroll-left-function’
x-dnd.el:809:32: Warning: reference to free variable ‘mwheel-scroll-up-function’
x-dnd.el:811:34: Warning: reference to free variable ‘mouse-wheel-flip-direction’

Best regards,

Jacob Faibussowitsch
(Jacob Fai - booss - oh - vitch)

[config.log (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Message #8 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jacob Faibussowitsch <jacob.fai <at> gmail.com>, Andrea Corallo <akrl <at> sdf.org>
Cc: 63415 <at> debbugs.gnu.org
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Thu, 11 May 2023 16:25:39 +0300

> From: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
> Date: Wed, 10 May 2023 07:25:34 -0400
> 
> dispnew.c:3650:12: warning: variable 'changed_p' set but not used [-Wunused-but-set-variable]
>       bool changed_p = 0, mouse_face_overwritten_p = 0;
>            ^
> 1 warning generated.

This is expected in a build --without-x.  Avoiding it is too much
trouble (will make the code harder to read), and this configuration is
rare enough to not justify that.  So I've left that alone.

> In native--compile-async:
> comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused

Andrea, would you please take care of this warning?

I hope I've now fixed the rest, thanks.

Message #11 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63415 <at> debbugs.gnu.org, Andrea Corallo <akrl <at> sdf.org>
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Thu, 11 May 2023 09:39:59 -0400

> Avoiding it is too much
> trouble (will make the code harder to read), and this configuration is
> rare enough to not justify that.  So I've left that alone.

FWIW the following silences the warning. But up to you

diff --git a/src/dispnew.c b/src/dispnew.c
index fe661579daf..f456a60246b 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -3808,6 +3808,8 @@ update_window (struct window *w, bool force_p)
              redraw_overlapped_rows (w, yb);
              redraw_overlapping_rows (w, yb);
            }
+#else
+          (void)changed_p;
 #endif

          /* Make cursor visible at cursor position of W.  */

Best regards,

Jacob Faibussowitsch
(Jacob Fai - booss - oh - vitch)

> On May 11, 2023, at 09:25, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
>> Date: Wed, 10 May 2023 07:25:34 -0400
>> 
>> dispnew.c:3650:12: warning: variable 'changed_p' set but not used [-Wunused-but-set-variable]
>>      bool changed_p = 0, mouse_face_overwritten_p = 0;
>>           ^
>> 1 warning generated.
> 
> This is expected in a build --without-x.  Avoiding it is too much
> trouble (will make the code harder to read), and this configuration is
> rare enough to not justify that.  So I've left that alone.
> 
>> In native--compile-async:
>> comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused
> 
> Andrea, would you please take care of this warning?
> 
> I hope I've now fixed the rest, thanks.

Message #14 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
Cc: 63415 <at> debbugs.gnu.org, akrl <at> sdf.org
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Thu, 11 May 2023 17:01:54 +0300

> From: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
> Date: Thu, 11 May 2023 09:39:59 -0400
> Cc: Andrea Corallo <akrl <at> sdf.org>,
>  63415 <at> debbugs.gnu.org
> 
> > Avoiding it is too much
> > trouble (will make the code harder to read), and this configuration is
> > rare enough to not justify that.  So I've left that alone.
> 
> FWIW the following silences the warning. But up to you

Thanks, I'd rather not do that, especially since some recent versions
of GCC are beginning to ignore such "usage", AFAIR.

We could perhaps use some variable attributes, but that'd make the
code less portable to various compilers, and will again require cpp
conditionals, which make the code uglier and harder to read.

Message #17 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63415 <at> debbugs.gnu.org, Jacob Faibussowitsch <jacob.fai <at> gmail.com>
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Wed, 17 May 2023 07:55:06 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Jacob Faibussowitsch <jacob.fai <at> gmail.com>
>> Date: Wed, 10 May 2023 07:25:34 -0400
>> 
>> dispnew.c:3650:12: warning: variable 'changed_p' set but not used [-Wunused-but-set-variable]
>>       bool changed_p = 0, mouse_face_overwritten_p = 0;
>>            ^
>> 1 warning generated.
>
> This is expected in a build --without-x.  Avoiding it is too much
> trouble (will make the code harder to read), and this configuration is
> rare enough to not justify that.  So I've left that alone.
>
>> In native--compile-async:
>> comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused
>
> Andrea, would you please take care of this warning?
>
> I hope I've now fixed the rest, thanks.

Ok I've a fix for this, same as for #63302 do we want the fixes in
master or 29?

Thanks

  Andrea

Message #20 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 63415 <at> debbugs.gnu.org, jacob.fai <at> gmail.com
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Wed, 17 May 2023 14:06:38 +0300

> From: Andrea Corallo <akrl <at> sdf.org>
> Cc: Jacob Faibussowitsch <jacob.fai <at> gmail.com>,  63415 <at> debbugs.gnu.org
> Date: Wed, 17 May 2023 07:55:06 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> In native--compile-async:
> >> comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused
> >
> > Andrea, would you please take care of this warning?
> >
> > I hope I've now fixed the rest, thanks.
> 
> Ok I've a fix for this, same as for #63302 do we want the fixes in
> master or 29?

This is just a cleanup, and for a warning that is new on master.  So
please install on master.

Thanks.

Message #23 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63415 <at> debbugs.gnu.org, jacob.fai <at> gmail.com
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Wed, 17 May 2023 14:11:44 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Andrea Corallo <akrl <at> sdf.org>
>> Cc: Jacob Faibussowitsch <jacob.fai <at> gmail.com>,  63415 <at> debbugs.gnu.org
>> Date: Wed, 17 May 2023 07:55:06 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> In native--compile-async:
>> >> comp.el:4240:14: Warning: value from call to ‘cl-substitute’ is unused
>> >
>> > Andrea, would you please take care of this warning?
>> >
>> > I hope I've now fixed the rest, thanks.
>> 
>> Ok I've a fix for this, same as for #63302 do we want the fixes in
>> master or 29?
>
> This is just a cleanup, and for a warning that is new on master.  So
> please install on master.

Unfortunatelly this is a bugfix.

The case is when a manual async compilation has been asked for a file,
and before it's initiated the jit machinery ask as well for a
compilation.  I think with the current code at worst we'll miss to load
automatically the .eln for the jit case and everything will keep on
working with the bytecoded version.

I don't think the whole mechanism is trivial to be verified, so given
the unlikeliness of the condition and the non severity of the bug I
prefered to push the fix only to master for now with 8a92d00470b.  Happy
to change my mind if we feel is important.

Best Regards

Andrea

Message #26 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 63415 <at> debbugs.gnu.org, jacob.fai <at> gmail.com
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Wed, 17 May 2023 17:30:58 +0300

> From: Andrea Corallo <akrl <at> sdf.org>
> Cc: jacob.fai <at> gmail.com,  63415 <at> debbugs.gnu.org
> Date: Wed, 17 May 2023 14:11:44 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > This is just a cleanup, and for a warning that is new on master.  So
> > please install on master.
> 
> Unfortunatelly this is a bugfix.
> 
> The case is when a manual async compilation has been asked for a file,
> and before it's initiated the jit machinery ask as well for a
> compilation.  I think with the current code at worst we'll miss to load
> automatically the .eln for the jit case and everything will keep on
> working with the bytecoded version.
> 
> I don't think the whole mechanism is trivial to be verified, so given
> the unlikeliness of the condition and the non severity of the bug I
> prefered to push the fix only to master for now with 8a92d00470b.  Happy
> to change my mind if we feel is important.

Thanks.  Let's try to remember revisiting this when Emacs 29.2 will
come close to release.  By that time I hope we will know whether this
fix is safe or not, and will be able to backport it if it is.

Message #29 received at 63415 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63415 <at> debbugs.gnu.org, jacob.fai <at> gmail.com
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Wed, 17 May 2023 14:37:41 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Andrea Corallo <akrl <at> sdf.org>
>> Cc: jacob.fai <at> gmail.com,  63415 <at> debbugs.gnu.org
>> Date: Wed, 17 May 2023 14:11:44 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > This is just a cleanup, and for a warning that is new on master.  So
>> > please install on master.
>> 
>> Unfortunatelly this is a bugfix.
>> 
>> The case is when a manual async compilation has been asked for a file,
>> and before it's initiated the jit machinery ask as well for a
>> compilation.  I think with the current code at worst we'll miss to load
>> automatically the .eln for the jit case and everything will keep on
>> working with the bytecoded version.
>> 
>> I don't think the whole mechanism is trivial to be verified, so given
>> the unlikeliness of the condition and the non severity of the bug I
>> prefered to push the fix only to master for now with 8a92d00470b.  Happy
>> to change my mind if we feel is important.
>
> Thanks.  Let's try to remember revisiting this when Emacs 29.2 will
> come close to release.  By that time I hope we will know whether this
> fix is safe or not, and will be able to backport it if it is.

SGTM

Thanks

  Andrea

Message #36 received at 63415-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 63415-done <at> debbugs.gnu.org,
 jacob.fai <at> gmail.com
Subject: Re: bug#63415: 30.0.50; More Build Warnings
Date: Thu, 21 Mar 2024 07:08:31 -0400

Andrea Corallo <akrl <at> sdf.org> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: Andrea Corallo <akrl <at> sdf.org>
>>> Cc: jacob.fai <at> gmail.com,  63415 <at> debbugs.gnu.org
>>> Date: Wed, 17 May 2023 14:11:44 +0000
>>> 
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>> 
>>> > This is just a cleanup, and for a warning that is new on master.  So
>>> > please install on master.
>>> 
>>> Unfortunatelly this is a bugfix.
>>> 
>>> The case is when a manual async compilation has been asked for a file,
>>> and before it's initiated the jit machinery ask as well for a
>>> compilation.  I think with the current code at worst we'll miss to load
>>> automatically the .eln for the jit case and everything will keep on
>>> working with the bytecoded version.
>>> 
>>> I don't think the whole mechanism is trivial to be verified, so given
>>> the unlikeliness of the condition and the non severity of the bug I
>>> prefered to push the fix only to master for now with 8a92d00470b.  Happy
>>> to change my mind if we feel is important.
>>
>> Thanks.  Let's try to remember revisiting this when Emacs 29.2 will
>> come close to release.  By that time I hope we will know whether this
>> fix is safe or not, and will be able to backport it if it is.
>
> SGTM

My bad I think we missed the 29.2 train, anyway I installed this into
emacs-29 with 51848e4731f.

Closing this.

Thanks

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.