GNU bug report logs - #63452
[PATCH 0/5] gnu: ruby-terraform: Update to 1.7.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63452 in the body.
You can then email your comments to 63452 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yovan Naumovski <yovan <at> gorski.stream>
To: guix-patches <at> gnu.org
Cc: Yovan Naumovski <yovan <at> gorski.stream>
Subject: [PATCH 0/5] gnu: ruby-terraform: Update to 1.7.0.
Date: Thu, 11 May 2023 23:14:29 +0300

Hi,

Here's a patch series that updates ruby-terraform to 1.7.0 and enables
tests for the package. To enable the tests some gem dependencies need
to be packaged and updated.

Yovan Naumovski (5):
  gnu: ruby-i18n: Update to 1.13.0.
  gnu: ruby-lino: Update to 3.1.0.
  gnu: Add ruby-immutable-struct.
  gnu: Add ruby-faker.
  gnu: ruby-terraform: Update to 1.7.0.

 gnu/packages/ruby.scm | 97 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 87 insertions(+), 10 deletions(-)

-- 
2.39.2

Message #8 received at 63452 <at> debbugs.gnu.org (full text, mbox):

From: Yovan Naumovski <yovan <at> gorski.stream>
To: 63452 <at> debbugs.gnu.org
Cc: Yovan Naumovski <yovan <at> gorski.stream>
Subject: [PATCH 1/5] gnu: ruby-i18n: Update to 1.13.0.
Date: Thu, 11 May 2023 23:15:37 +0300

* gnu/packages/ruby.scm (ruby-i18n): Update to 1.13.0.
---
 gnu/packages/ruby.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 1dcd5f76a5..833756704c 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -491,13 +491,13 @@ (define-public ruby-rsync
 (define-public ruby-i18n
   (package
     (name "ruby-i18n")
-    (version "1.7.0")
+    (version "1.13.0")
     (source (origin
               (method url-fetch)
               (uri (rubygems-uri "i18n" version))
               (sha256
                (base32
-                "0hmypvx9iyc0b4hski7aic2xzm09cg1c7q1qlpnk3k8s5acxzyhl"))))
+                "1yk33slipi3i1kydzrrchbi7cgisaxym6pgwlzx7ir8vjk6wl90x"))))
     (build-system ruby-build-system)
     (arguments
      '(#:tests? #f)) ; no tests
-- 
2.39.2

Message #11 received at 63452 <at> debbugs.gnu.org (full text, mbox):

From: Yovan Naumovski <yovan <at> gorski.stream>
To: 63452 <at> debbugs.gnu.org
Cc: Yovan Naumovski <yovan <at> gorski.stream>
Subject: [PATCH 2/5] gnu: ruby-lino: Update to 3.1.0.
Date: Thu, 11 May 2023 23:16:11 +0300

* gnu/packages/ruby.scm (ruby-lino): Update to 3.1.0.
---
 gnu/packages/ruby.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 833756704c..9eb3970a44 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -2997,14 +2997,14 @@ (define-public ruby-libxml
 (define-public ruby-lino
   (package
     (name "ruby-lino")
-    (version "1.1.0")
+    (version "3.1.0")
     (source
      (origin
        (method url-fetch)
        (uri (rubygems-uri "lino" version))
        (sha256
         (base32
-         "11d29g0fk372b9fcpyr0k6hxm2b4j4igpysmi542hgbbgqgp9cd3"))))
+         "1zq9dza040fgjvr9imh7z2lgxrcyc5ac100rqimsnsf9bpfz3fsm"))))
     (build-system ruby-build-system)
     (arguments
      '(#:tests? #f)) ; No included tests
-- 
2.39.2

Message #14 received at 63452 <at> debbugs.gnu.org (full text, mbox):

From: Yovan Naumovski <yovan <at> gorski.stream>
To: 63452 <at> debbugs.gnu.org
Cc: Yovan Naumovski <yovan <at> gorski.stream>
Subject: [PATCH 4/5] gnu: Add ruby-faker.
Date: Thu, 11 May 2023 23:17:31 +0300

* gnu/packages/ruby.scm (ruby-faker): New variable.
---
 gnu/packages/ruby.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 7b16d632ad..26a4fea0d7 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -7342,6 +7342,38 @@ (define-public ruby-immutable-struct
     (home-page "https://stitchfix.github.io/immutable-struct/")
     (license license:expat)))
 
+(define-public ruby-faker
+  (package
+    (name "ruby-faker")
+    (version "3.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/faker-ruby/faker")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1wwdwh5qwaxnd9dl6732mj6b953l5r32r4936pj5680963iagq59"))))
+    (build-system ruby-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'remove-rubocop-from-rakefile
+            (lambda _
+              (substitute* "Rakefile"
+                (("require 'rubocop/rake_task'") "")
+                (("RuboCop::RakeTask\\.new") "")))))))
+    (native-inputs (list ruby-yard ruby-simplecov ruby-timecop))
+    (propagated-inputs (list ruby-i18n))
+    (synopsis "Library for generating fake data")
+    (description "Faker is a port of Data::Faker from Perl. It is used to
+easily generate fake data: names, addresses, phone numbers, etc.")
+    (home-page "https://github.com/faker-ruby/faker")
+    (license license:expat)))
+
 (define-public ruby-terraform
   (package
   (name "ruby-terraform")
-- 
2.39.2

Message #17 received at 63452 <at> debbugs.gnu.org (full text, mbox):

From: Yovan Naumovski <yovan <at> gorski.stream>
To: 63452 <at> debbugs.gnu.org
Cc: Yovan Naumovski <yovan <at> gorski.stream>
Subject: [PATCH 5/5] gnu: ruby-terraform: Update to 1.7.0.
Date: Thu, 11 May 2023 23:17:49 +0300

* gnu/packages/ruby.scm (ruby-terraform): Update to 1.7.0.
  [source]: Use git-fetch.
  [arguments]: Enable tests.
  [native-inputs]: Add ruby-rspec, ruby-faker, ruby-simplecov.
  [propagated-inputs]: Add ruby-immutable-struct.
---
 gnu/packages/ruby.scm | 37 +++++++++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 26a4fea0d7..e0bc6e874b 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -7377,19 +7377,44 @@ (define-public ruby-faker
 (define-public ruby-terraform
   (package
   (name "ruby-terraform")
-  (version "0.22.0")
+  (version "1.7.0")
   (source
    (origin
-     (method url-fetch)
-     (uri (rubygems-uri "ruby-terraform" version))
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/infrablocks/ruby_terraform")
+           (commit (string-append "v" version))))
+     (file-name (git-file-name name version))
      (sha256
       (base32
-       "13zjkp71cd19j2ds2h9rqwcfr1zdg5nsh63p89l6qcsc9z39z324"))))
+       "18d1qkf2rbbvc2f0dxni85i2l2g8zn5kzh0v8zr1b86r1wjy6rvd"))))
   (build-system ruby-build-system)
   (arguments
-   '(#:tests? #f)) ; No included tests
+   (list
+    #:test-target "spec"
+    #:phases
+    #~(modify-phases %standard-phases
+        (add-after 'unpack 'disable-bundler
+          (lambda _
+            (substitute* "spec/spec_helper.rb"
+              (("require 'bundler/setup'") ""))))
+        (add-before 'check 'disable-falinig-tests
+          (lambda _
+            (substitute* "spec/ruby_terraform/commands/plan_spec.rb"
+              (("it 'logs an error raised when running the command'")
+               "xit 'logs an error raised when running the command'")
+              (("it 'raises execution error when an error occurs running the command'")
+               "xit 'raises execution error when an error occurs running the command'"))))
+        (replace 'check
+          (lambda* (#:key tests? #:allow-other-keys)
+            (when tests?
+              (invoke "rspec")))))))
+  (native-inputs
+   (list ruby-rspec
+         ruby-faker
+         ruby-simplecov))
   (propagated-inputs
-   (list ruby-lino))
+   (list ruby-lino ruby-immutable-struct))
   (synopsis "Ruby wrapper around the Terraform command line interface")
   (description
    "This package provides a Ruby wrapper around the Terraform command line
-- 
2.39.2

Message #20 received at 63452 <at> debbugs.gnu.org (full text, mbox):

From: Yovan Naumovski <yovan <at> gorski.stream>
To: 63452 <at> debbugs.gnu.org
Subject: [PATCH 3/5] gnu: Add ruby-immutable-struct.
Date: Thu, 11 May 2023 23:29:53 +0300

* gnu/packages/ruby.scm (ruby-immutable-struct): New variable.
---
 gnu/packages/ruby.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 9eb3970a44..7b16d632ad 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -7322,6 +7322,26 @@ (define-public ruby-term-ansicolor
     ;; There is no mention of the "or later" clause.
     (license license:gpl2)))
 
+(define-public ruby-immutable-struct
+  (package
+    (name "ruby-immutable-struct")
+    (version "2.4.1")
+    (source (origin
+              (method url-fetch)
+              (uri (rubygems-uri "immutable-struct" version))
+              (sha256
+               (base32
+                "1fsx4s9yaga0p4q7arcirhc5vrifh619k6gzr6z8a0xd935zprsi"))))
+    (build-system ruby-build-system)
+    (arguments
+     (list
+      #:tests? #f))
+    (synopsis "Ruby library for creating immutable struct classes")
+    (description
+     "Easily create value objects without the pain of Ruby's Struct (or its setters)")
+    (home-page "https://stitchfix.github.io/immutable-struct/")
+    (license license:expat)))
+
 (define-public ruby-terraform
   (package
   (name "ruby-terraform")
-- 
2.39.2

Message #25 received at 63452-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Yovan Naumovski <yovan <at> gorski.stream>
Cc: 63452-done <at> debbugs.gnu.org
Subject: Re: [bug#63452] [PATCH 0/5] gnu: ruby-terraform: Update to 1.7.0.
Date: Mon, 10 Jul 2023 14:02:39 +0100

[Message part 1 (text/plain, inline)]

Yovan Naumovski via Guix-patches via <guix-patches <at> gnu.org> writes:

> Hi,
>
> Here's a patch series that updates ruby-terraform to 1.7.0 and enables
> tests for the package. To enable the tests some gem dependencies need
> to be packaged and updated.
>
> Yovan Naumovski (5):
>   gnu: ruby-i18n: Update to 1.13.0.
>   gnu: ruby-lino: Update to 3.1.0.
>   gnu: Add ruby-immutable-struct.
>   gnu: Add ruby-faker.
>   gnu: ruby-terraform: Update to 1.7.0.
>
>  gnu/packages/ruby.scm | 97 ++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 87 insertions(+), 10 deletions(-)

Hi Yovan,

Thanks for the patches. I've tweaked ruby-immutable-struct to run the
tests, and pushed these to master as
fd2a01d564ee2909f88aeaad6341eadfa1a75964.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.