GNU bug report logs - #63500
[PATCH] gnu: xfce: Use "Greybird" and "elementary-xfce-dark" as default theme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63500 in the body.
You can then email your comments to 63500 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: xfce: Use "Greybird" and "elementary-xfce-dark" as
 default theme.
Date: Sun, 14 May 2023 19:52:51 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

* gnu/packages/patches/xfce4-settings-defaults.patch: Set "ThemeName"
to "Greybird", "IconThemeName" to "elementary-xfce-dark".
* gnu/packages/xfce.scm (xfce)[inputs]: Add elementary-xfce-icon-theme.
---
 .../patches/xfce4-settings-defaults.patch       | 17 +++++++++--------
 gnu/packages/xfce.scm                           |  4 +---
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/patches/xfce4-settings-defaults.patch b/gnu/packages/patches/xfce4-settings-defaults.patch
index fe91ae5f70..ce5865c481 100644
--- a/gnu/packages/patches/xfce4-settings-defaults.patch
+++ b/gnu/packages/patches/xfce4-settings-defaults.patch
@@ -1,17 +1,18 @@
-This patch make Xfce use "gnome" as the default icon theme and enable font antialias.
+This patch make Xfce use "elementary-xfce-dark" as the default icon theme, "Greybird" as
+the default GTK theme and enable font antialias.
 
-Taken from ArchLinux.
 
-diff -upr xfce4-settings-4.12.0.orig/xfsettingsd/xsettings.xml xfce4-settings-4.12.0/xfsettingsd/xsettings.xml
---- xfce4-settings-4.12.0.orig/xfsettingsd/xsettings.xml	2015-02-24 03:33:11.000000000 +0200
-+++ xfce4-settings-4.12.0/xfsettingsd/xsettings.xml	2015-03-01 09:52:24.376869688 +0200
+diff -upr xfce4-settings-4.18.2.orig/xfsettingsd/xsettings.xml xfce4-settings-4.18.2/xfsettingsd/xsettings.xml
+--- xfce4-settings-4.18.2.orig/xfsettingsd/xsettings.xml	2023-02-11 16:55:53.000000000 +0800
++++ xfce4-settings-4.18.2/xfsettingsd/xsettings.xml	2023-05-14 19:20:43.919701586 +0800
 @@ -6,8 +6,8 @@
- <?xml version="1.0" encoding="UTF-8"?>
+ 
  <channel name="xsettings" version="1.0">
    <property name="Net" type="empty">
-     <property name="ThemeName" type="empty"/>
+-    <property name="ThemeName" type="empty"/>
 -    <property name="IconThemeName" type="empty"/>
-+    <property name="IconThemeName" type="string" value="gnome"/>
++    <property name="ThemeName" type="string" value="Greybird"/>
++    <property name="IconThemeName" type="string" value="elementary-xfce-dark"/>
      <property name="DoubleClickTime" type="int" value="400"/>
      <property name="DoubleClickDistance" type="int" value="5"/>
      <property name="DndDragThreshold" type="int" value="8"/>
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 38d77cace2..2eb90ed4b2 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -1176,9 +1176,7 @@ (define-public xfce
      (list exo
            garcon
            adwaita-icon-theme
-           ;; Greybird is the recommend theme since Xfce 4.14, see:
-           ;; <https://mail.xfce.org/pipermail/xfce4-dev/2018-August/032151.html>
-           ;; TODO: Make it default via "xfconf/xfce/perchannel-xml/xsettinsg.xml"
+           elementary-xfce-icon-theme
            greybird-gtk-theme
            hicolor-icon-theme
            mate-polkit-for-xfce

base-commit: 3c8d0f9e71bbddfb5b1f098c713ff37553f0efcc
-- 
2.40.1

Message #8 received at 63500 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: 63500 <at> debbugs.gnu.org
Subject: [PATCH] gnu: xfce: Use "Greybird" and "elementary-xfce-dark" as
 default theme.
Date: Mon, 15 May 2023 05:41:10 +0000

Fantastic. I was just looking at making this patch yesterday.
It should be noted this is important because adwaita-icon-theme 42 has 
removed
icons useful to xfce, causing missing icons in the settings menu.

Message #13 received at 63500-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 63500-done <at> debbugs.gnu.org
Subject: Re: bug#63500: [PATCH] gnu: xfce: Use "Greybird" and
 "elementary-xfce-dark" as default theme.
Date: Wed, 17 May 2023 18:18:32 +0800

Brendan Tildesley <mail <at> brendan.scot> writes:

> Fantastic. I was just looking at making this patch yesterday.
> It should be noted this is important because adwaita-icon-theme 42 has
> removed
> icons useful to xfce, causing missing icons in the settings menu.

Pushed to master now :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.