GNU bug report logs - #63501
[PATCH] hurd-boot: Symlink /hurd before setting up translators.

Previous Next

Package: guix-patches;

Reported by: Josselin Poiret <dev <at> jpoiret.xyz>

Date: Sun, 14 May 2023 13:37:02 UTC

Severity: normal

Tags: patch

Done: Josselin Poiret <dev <at> jpoiret.xyz>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63501 in the body.
You can then email your comments to 63501 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#63501; Package guix-patches. (Sun, 14 May 2023 13:37:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Josselin Poiret <dev <at> jpoiret.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 14 May 2023 13:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH] hurd-boot: Symlink /hurd before setting up translators.
Date: Sun, 14 May 2023 15:36:32 +0200
From: Josselin Poiret <dev <at> jpoiret.xyz>

* gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
translators.
---

Hi everyone,

This should fix the Hurd not booting.

Enjoy! (and now we also need to fix the native Hurd compilation problems, but
that's for another patch)

 gnu/build/hurd-boot.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
index abcf0304c2..95c15907dd 100644
--- a/gnu/build/hurd-boot.scm
+++ b/gnu/build/hurd-boot.scm
@@ -280,14 +280,14 @@ (define* (boot-hurd-system #:key (on-error 'debug))
             (system  (find-long-option "gnu.system" args))
             (to-load (find-long-option "gnu.load" args)))
 
-       (format #t "Setting-up essential translators...\n")
-       (setenv "PATH" (string-append system "/profile/bin"))
-       (set-hurd-device-translators)
-
        (false-if-exception (delete-file "/hurd"))
        (let ((hurd/hurd (readlink* (string-append system "/profile/hurd"))))
          (symlink hurd/hurd "/hurd"))
 
+       (format #t "Setting-up essential translators...\n")
+       (setenv "PATH" (string-append system "/profile/bin"))
+       (set-hurd-device-translators)
+
        (format #t "Starting pager...\n")
        (unless (zero? (system* "/hurd/mach-defpager"))
          (format #t "FAILED...Good luck!\n"))

base-commit: eb7312401ea89e634f8d686db71bacda58b2755f
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63501; Package guix-patches. (Sun, 14 May 2023 14:17:01 GMT) Full text and rfc822 format available.

Message #8 received at 63501 <at> debbugs.gnu.org (full text, mbox):

From: Janneke Nieuwenhuizen <janneke <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 63501 <at> debbugs.gnu.org
Subject: Re: [bug#63501] [PATCH] hurd-boot: Symlink /hurd before setting up
 translators.
Date: Sun, 14 May 2023 16:16:29 +0200
Josselin Poiret via Guix-patches via writes:

Hi Josselin!

> * gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
> translators.
> ---
> This should fix the Hurd not booting.
>
> Enjoy! (and now we also need to fix the native Hurd compilation problems, but
> that's for another patch)

Haven't reconfigured using this, but it works for me using

    ./pre-inst-env guix system image -t hurd-qcow2 gnu/system/examples/bare-hurd.tmpl

and

--8<---------------cut here---------------start------------->8---
$(guix build qemu | grep -Ev '(doc|static)$')/bin/qemu-system-i386      \
-m 4096                                                                 \
--device rtl8139,netdev=net0                                            \
--netdev user,id=net0,hostfwd=tcp:0.0.0.0:11022-:2222                   \
--snapshot                                                              \
--no-reboot                                                             \
--hda /gnu/store/nap53abhcsjqc2xg8dvbyy1vplb8kkzf-disk-image
--8<---------------cut here---------------end--------------->8---

after some waiting, I get:

--8<---------------cut here---------------start------------->8---
16:07:15 janneke <at> drakenpad:~/src/guix/master [env]
$ ssh childhurd1
Last login: Sun May 14 16:07:03 2023 from 10.0.2.2


  This is the GNU Hurd.  Welcome.

root <at> guixygnu ~# 
--8<---------------cut here---------------end--------------->8---

Well done, phew that was quite a puzzle!

> diff --git a/gnu/build/hurd-boot.scm b/gnu/build/hurd-boot.scm
> index abcf0304c2..95c15907dd 100644
> --- a/gnu/build/hurd-boot.scm
> +++ b/gnu/build/hurd-boot.scm
> @@ -280,14 +280,14 @@ (define* (boot-hurd-system #:key (on-error 'debug))
>              (system  (find-long-option "gnu.system" args))
>              (to-load (find-long-option "gnu.load" args)))
>  
> -       (format #t "Setting-up essential translators...\n")
> -       (setenv "PATH" (string-append system "/profile/bin"))
> -       (set-hurd-device-translators)
> -
>         (false-if-exception (delete-file "/hurd"))
>         (let ((hurd/hurd (readlink* (string-append system "/profile/hurd"))))
>           (symlink hurd/hurd "/hurd"))
>  
> +       (format #t "Setting-up essential translators...\n")
> +       (setenv "PATH" (string-append system "/profile/bin"))
> +       (set-hurd-device-translators)
> +

So, LGTM!

Interesting how this seemed to work with earlier versions of the Hurd...

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com




Information forwarded to guix-patches <at> gnu.org:
bug#63501; Package guix-patches. (Tue, 16 May 2023 12:54:02 GMT) Full text and rfc822 format available.

Message #11 received at 63501 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 63501 <at> debbugs.gnu.org
Subject: Re: bug#63501: [PATCH] hurd-boot: Symlink /hurd before setting up
 translators.
Date: Tue, 16 May 2023 14:53:23 +0200
Hello!

Josselin Poiret <dev <at> jpoiret.xyz> skribis:

> From: Josselin Poiret <dev <at> jpoiret.xyz>
>
> * gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
> translators.

Good catch!

Any idea when the regression was introduced?

Anyhow, LGTM.

Thanks for investigating!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#63501; Package guix-patches. (Tue, 16 May 2023 17:09:02 GMT) Full text and rfc822 format available.

Message #14 received at 63501 <at> debbugs.gnu.org (full text, mbox):

From: Brian Cully <bjc <at> spork.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 63501 <at> debbugs.gnu.org
Subject: Re: bug#63501: [PATCH] hurd-boot: Symlink /hurd before setting up
 translators.
Date: Tue, 16 May 2023 13:08:07 -0400
This patch is working for me to get ‘hurd-vm-service-type’ working on master.




Reply sent to Josselin Poiret <dev <at> jpoiret.xyz>:
You have taken responsibility. (Wed, 17 May 2023 21:31:02 GMT) Full text and rfc822 format available.

Notification sent to Josselin Poiret <dev <at> jpoiret.xyz>:
bug acknowledged by developer. (Wed, 17 May 2023 21:31:02 GMT) Full text and rfc822 format available.

Message #19 received at 63501-done <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: 63501-done <at> debbugs.gnu.org
Subject: Re: [PATCH] hurd-boot: Symlink /hurd before setting up translators.
Date: Wed, 17 May 2023 23:29:58 +0200
[Message part 1 (text/plain, inline)]
Hi,

Josselin Poiret <dev <at> jpoiret.xyz> writes:
> * gnu/build/hurd-boot.scm (boot-hurd-system): Symlink /hurd before setting up
> translators.

Pushed as e041801e615d9194505d30093a7fdc8ac1d4a929.

Best,
-- 
Josselin Poiret
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 15 Jun 2023 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 313 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.