X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH 0/3] Use MAC-based names for network interfaces Resent-From: Felix Lechner <felix.lechner@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Sun, 14 May 2023 21:42:02 +0000 Resent-Message-ID: <handler.63508.B.16841004869676 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63508 <at> debbugs.gnu.org Cc: Felix Lechner <felix.lechner@HIDDEN> X-Debbugs-Original-To: guix-patches@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.16841004869676 (code B ref -1); Sun, 14 May 2023 21:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 May 2023 21:41:26 +0000 Received: from localhost ([127.0.0.1]:41726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyJT3-0002W0-Ne for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:41:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:42580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyJT1-0002Vs-OP for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:41:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>) id 1pyJT1-0001WN-9n for guix-patches@HIDDEN; Sun, 14 May 2023 17:41:23 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>) id 1pyJSz-0003j1-Ju for guix-patches@HIDDEN; Sun, 14 May 2023 17:41:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Au9qeyvClO9fqur HqS7bI5JwpmNc4n0sHSg4B112z74=; h=date:subject:cc:to:from; d=lease-up.com; b=KzxhE4OwHQ4xh1V1PLwJwVKmSnbaFwP7xMTTsCCI11HtgZiEvnMC R/TLZ+7sqb+G/MRjNbl0buYsAYtmfu5rmS0XsF4ENEVAae4UIITkNMI2uzqr+GZdEm98RZ msaOSzwYrZPu44Q2Rq1poX9eUsMNe+f6KtrNB09PA0+SKO5gE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 95121349 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 14 May 2023 21:41:15 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id f65f633a; Sun, 14 May 2023 21:41:15 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 14 May 2023 14:41:07 -0700 Message-Id: <cover.1684100044.git.felix.lechner@HIDDEN> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) Hi, This patch set proposes the use of ID_NET_NAME_MAC for standard network interfaces. In the author's opinion, predictable names for interfaces work better with the declarative configuration style used in Guix. Kind regards Felix Felix Lechner (3): gnu: eudev: Convert native-inputs to new style. gnu: eudev: Convert build arguments to gexps. gnu: eudev: Always use MAC-based names for network interfaces. gnu/packages/linux.scm | 100 +++++++++++++++++++++-------------------- 1 file changed, 51 insertions(+), 49 deletions(-) base-commit: 263f235cd0a2955e865fe38036f84c2bf34375ff -- 2.40.1
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Felix Lechner <felix.lechner@HIDDEN> Subject: bug#63508: Acknowledgement ([PATCH 0/3] Use MAC-based names for network interfaces) Message-ID: <handler.63508.B.16841004869676.ack <at> debbugs.gnu.org> References: <cover.1684100044.git.felix.lechner@HIDDEN> X-Gnu-PR-Message: ack 63508 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63508 <at> debbugs.gnu.org Date: Sun, 14 May 2023 21:42:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 63508 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 63508: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63508 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH 1/3] gnu: eudev: Convert native-inputs to new style. Resent-From: Felix Lechner <felix.lechner@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Sun, 14 May 2023 21:43:02 +0000 Resent-Message-ID: <handler.63508.B63508.16841005629831 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63508 <at> debbugs.gnu.org Cc: Felix Lechner <felix.lechner@HIDDEN> Received: via spool by 63508-submit <at> debbugs.gnu.org id=B63508.16841005629831 (code B ref 63508); Sun, 14 May 2023 21:43:02 +0000 Received: (at 63508) by debbugs.gnu.org; 14 May 2023 21:42:42 +0000 Received: from localhost ([127.0.0.1]:41731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyJUI-0002YT-4t for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:42 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:39696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyJUG-0002YI-Pe for 63508 <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=mpp6MnNmVmkOKyI 1MJNfzCCwsceYki24Tq1JXp/0CdM=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=qszSSu/HfCz03MZCaXepP6O0e5O22fMlPgUg67qq ykvU4hbh8Mm1ElU3NzrzRaFzIbMUzDOKyQOpK8BgwRXMSn/lvwVFN51+r2zCERUNDx0s97 ivVMraEcKhAQyLDSgWPvnMaFdfTwgJBsf7rwihDRazabWoP/UnvwxXUGxPYPg= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id beac318e (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 14 May 2023 21:42:39 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c22bc855; Sun, 14 May 2023 21:42:39 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 14 May 2023 14:42:29 -0700 Message-Id: <efe9ecb3d2c22fe20c82dd92dceaf992ef954b04.1684100044.git.felix.lechner@HIDDEN> X-Mailer: git-send-email 2.40.1 In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) * gnu/packages/linux.scm (eudev): Convert native-inputs to new style. --- gnu/packages/linux.scm | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index ea64e9d241..7ae34d1d4a 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -4190,19 +4190,19 @@ (define-public eudev "hwdb" "--update"))))))) #:configure-flags (list "--enable-manpages"))) (native-inputs - `(("autoconf" ,autoconf) - ("automake" ,automake) - ("gperf" ,gperf) - ("libtool" ,libtool) - ("pkg-config" ,pkg-config) - ;; For tests. - ("perl" ,perl) - ("python" ,python-wrapper) - ;; For documentation. - ("docbook-xml" ,docbook-xml-4.2) - ("docbook-xsl" ,docbook-xsl) - ("libxml2" ,libxml2) ;for $XML_CATALOG_FILES - ("xsltproc" ,libxslt))) + (list autoconf + automake + gperf + libtool + pkg-config + ;; For tests. + perl + python-wrapper + ;; For documentation. + docbook-xml-4.2 + docbook-xsl + libxml2 ;for $XML_CATALOG_FILES + libxslt)) (inputs ;; When linked against libblkid, eudev can populate /dev/disk/by-label ;; and similar; it also installs the '60-persistent-storage.rules' file, -- 2.40.1
X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH 2/3] gnu: eudev: Convert build arguments to gexps. Resent-From: Felix Lechner <felix.lechner@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Sun, 14 May 2023 21:43:02 +0000 Resent-Message-ID: <handler.63508.B63508.16841005669850 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63508 <at> debbugs.gnu.org Cc: Felix Lechner <felix.lechner@HIDDEN> Received: via spool by 63508-submit <at> debbugs.gnu.org id=B63508.16841005669850 (code B ref 63508); Sun, 14 May 2023 21:43:02 +0000 Received: (at 63508) by debbugs.gnu.org; 14 May 2023 21:42:46 +0000 Received: from localhost ([127.0.0.1]:41734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyJUL-0002Ym-D7 for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:45 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:39696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyJUJ-0002YI-GM for 63508 <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=bglLQLbZ+wT7DhV TX6m8DFjNzcNQ01DSOtqRaqcTcD0=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=XW1klxHvLwtijsKX9DRf3G1t81QbALAzSA5U6S1r lDrA5zXLLS1u/RogfoPkZ0opgzxaj1NF4cKI1VObOrWjtaQKu+OwL47ZUqlA/VLDwSrZ8T GZF7DnyI5yQgky0mlZvKL4mqd0cIm7ipEa8Mb1C11bkvFpdM7kbErqmk+EhZA= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id e61cb43a (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 14 May 2023 21:42:42 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id c38e0e3f; Sun, 14 May 2023 21:42:41 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 14 May 2023 14:42:30 -0700 Message-Id: <85af3647b4729638ce33464c835095edc6e208bd.1684100044.git.felix.lechner@HIDDEN> X-Mailer: git-send-email 2.40.1 In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) * gnu/packages/linux.scm (eudev): Convert build arguments to gexps. --- gnu/packages/linux.scm | 68 ++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 36 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 7ae34d1d4a..98e683bdb0 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -4153,42 +4153,38 @@ (define-public eudev (patches (search-patches "eudev-rules-directory.patch")))) (build-system gnu-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (add-before 'bootstrap 'patch-file-names - (lambda* (#:key inputs native-inputs #:allow-other-keys) - (substitute* "man/make.sh" - (("/usr/bin/xsltproc") - (string-append (assoc-ref - (or native-inputs inputs) "xsltproc") - "/bin/xsltproc"))))) - (add-after 'install 'move-static-library - (lambda* (#:key outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (static (assoc-ref outputs "static")) - (source (string-append out "/lib/libudev.a")) - (target (string-append static "/lib/libudev.a"))) - (mkdir-p (dirname target)) - (link source target) - (delete-file source) - ;; Remove reference to the static library from the .la file - ;; such that Libtool looks for it in the usual places. - (substitute* (string-append out "/lib/libudev.la") - (("old_library=.*") - "old_library=''\n"))))) - (add-after 'install 'build-hwdb - (lambda* (#:key outputs #:allow-other-keys) - ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and - ;; similar tools to display product names. - ;; - ;; XXX: This can't be done when cross-compiling. Find another way - ;; to generate hwdb.bin for cross-built systems. - (let ((out (assoc-ref outputs "out"))) - ,@(if (%current-target-system) - '(#t) - '((invoke (string-append out "/bin/udevadm") - "hwdb" "--update"))))))) - #:configure-flags (list "--enable-manpages"))) + (list + #:phases + #~(modify-phases %standard-phases + (add-before 'bootstrap 'patch-file-names + (lambda* (#:key inputs native-inputs #:allow-other-keys) + (substitute* "man/make.sh" + (("/usr/bin/xsltproc") + (search-input-file (or native-inputs inputs) "/bin/xsltproc"))))) + (add-after 'install 'move-static-library + (lambda _ + (let ((source (string-append #$output "/lib/libudev.a")) + (target (string-append #$output:static "/lib/libudev.a"))) + (mkdir-p (dirname target)) + (link source target) + (delete-file source) + ;; Remove reference to the static library from the .la file + ;; such that Libtool looks for it in the usual places. + (substitute* (string-append #$output "/lib/libudev.la") + (("old_library=.*") + "old_library=''\n"))))) + (add-after 'install 'build-hwdb + (lambda _ + ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and + ;; similar tools to display product names. + ;; + ;; XXX: This can't be done when cross-compiling. Find another way + ;; to generate hwdb.bin for cross-built systems. + #$@(if (%current-target-system) + #~(#t) + #~((invoke (string-append #$output "/bin/udevadm") + "hwdb" "--update")))))) + #:configure-flags #~(list "--enable-manpages"))) (native-inputs (list autoconf automake -- 2.40.1
X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. Resent-From: Felix Lechner <felix.lechner@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Sun, 14 May 2023 21:44:02 +0000 Resent-Message-ID: <handler.63508.B63508.16841005959947 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63508 <at> debbugs.gnu.org Cc: Felix Lechner <felix.lechner@HIDDEN> Received: via spool by 63508-submit <at> debbugs.gnu.org id=B63508.16841005959947 (code B ref 63508); Sun, 14 May 2023 21:44:02 +0000 Received: (at 63508) by debbugs.gnu.org; 14 May 2023 21:43:15 +0000 Received: from localhost ([127.0.0.1]:41744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyJUo-0002aM-Uu for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:43:15 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:32996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyJUm-0002aE-Ut for 63508 <at> debbugs.gnu.org; Sun, 14 May 2023 17:43:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=fC2CYLR1lmV1uOU ma/pvUAIDHZcg8CHbRYntjbFUTmE=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=Yh4xiZoSo0L8qrfIKVTpP8OpXPDhg6YudiMxFUx+ rW+IzrVCGsjAeHbEXNg68piV3W/TtZ7pLZMhqAsJUYvQDGwc6Cxq5JGDHnpkPcvlOtFM4V QrDhpMxr9VJlTBhDfA2+4G2CT47SJaHinB3gv8G/fhtBi7aq1fUKTgzFtsaPA= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id e5c0cad7 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 14 May 2023 21:43:12 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id a993efe7; Sun, 14 May 2023 21:43:11 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 14 May 2023 14:42:31 -0700 Message-Id: <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> X-Mailer: git-send-email 2.40.1 In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) Upon personal reflection, a declarative operating system like Guix probably ought to use only predictable interface names. While shorter names like 'eno1' offer an indisputable convenience and beauty when typing on the command line, administrators in Guix are unlikely to do so due to the declarative configuration system. Some system services may explicitly refer to interface names in their configuration. They would also benefit from the predictable and constant nature of MAC-based names. The latter is particularly relevant on multi-homed machines, i.e. those with more than one network connection. A MAC-based interface name as issued by 'eudev' looks like this: enx0123456789af (fictitious) This commit was deployed on two production machines. The migration to MAC-based interface names took place without issues. A second reconfiguration was the used to add the new interface name in services tha needed it. The second step can be skipped, since the name is known with certainty in advance. The current naming scheme is less desirable because some services may silently refuse to start after equipment was added or removed. A removal may take place, for example, when something broke or when equipment was sold. The device enumeration may also change when a CMOS battery fails and system options are lost. In the author's option, Guix should not depend on BIOS enumeration for device names. In the author's case, the name of the sole network interface changed from enp3s0 to enp4s0 when a PCIe disk controller (a SAS host-based adapter) was installed. As a result, OpenSMTPd silently failed to start. This commit switches 'eudev' from the standard naming order ID_NET_NAME_ONBOARD ID_NET_NAME_SLOT ID_NET_NAME_PATH to ID_NET_NAME_MAC, which is always available. [1] The author initially attempted to achieve the same result via (udev-rules-service 'net-name-mac (udev-rule "01-net-name-mac.rules" "SUBSYSTEM==\"net\", ACTION==\"add\", NAME=\"$env{ID_NET_NAME_MAC}\" "))) but that did not work. While the situation was not examined exhaustively, it was not clear that udevadm can currently work because the standard command to test udev setups: [2] $ udevadm --debug test /sys/class/net/* did not find the script installed via the 'udev-service-type'. A review of the 'eudev' sources indicated that the path to find rules [3] is hard-coded to the store location during installation. An attempt to set the path to /etc/udev/rules.d yielded a build error because that target folder outside the store was understandably not writable. The manual page for udevadm did not offer a way to select the runtime location of the udev/rules.d folder via environment variables or a command-line option. Anyone for whom such a setup is working properly should please contact the author. Thank you! This commit may result in some loss of privacy, although it is presently not clear how meaningful that is. With this commit, anyone using privacy-enhanced IPv6 addresses risks having their MAC exposed when they publish their configuration files in Git or post a well-meant sample in a chat rooms, because that configuration may mention the MAC address. Moreover, the compatibilty with schemes to generate fake one-time MAC addresses upon boot should be evaluated. One concern is that the explicit reference to a network interface in a configuration file would likely force the use of a single and constant MAC address for that interface. This commit was tested in production and is currently being used. The change here resulted in the recompilation of several seemingly unrelated packages such as Emacs and GTK. Perhaps those dependency relationships should be examined. [1] https://wiki.debian.org/NetworkInterfaceNames#How_to_migrate_to_this_scheme_on_upgraded_systems [2] https://wiki.archlinux.org/title/Udev#Testing_rules_before_loading [3] https://github.com/eudev-project/eudev/blob/39979ddf46e75d1b75bf381e1c73914c226c4302/configure.ac#L180 [4] https://en.wikipedia.org/wiki/IPv6_address#Temporary_addresses * gnu/packages/linux.scm (eudev): Always use MAC-based names for network interfaces. --- gnu/packages/linux.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 98e683bdb0..724c621fed 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -4173,6 +4173,12 @@ (define-public eudev (substitute* (string-append #$output "/lib/libudev.la") (("old_library=.*") "old_library=''\n"))))) + (add-before 'install 'net-name-mac + (lambda _ + (use-modules (ice-9 regex)) + (substitute* "rules/80-net-name-slot.rules" + (((regexp-quote "ID_NET_NAME_ONBOARD")) + "ID_NET_NAME_MAC")))) (add-after 'install 'build-hwdb (lambda _ ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and -- 2.40.1
X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 15 May 2023 04:33:01 +0000 Resent-Message-ID: <handler.63508.B63508.168412512324105 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org Received: via spool by 63508-submit <at> debbugs.gnu.org id=B63508.168412512324105 (code B ref 63508); Mon, 15 May 2023 04:33:01 +0000 Received: (at 63508) by debbugs.gnu.org; 15 May 2023 04:32:03 +0000 Received: from localhost ([127.0.0.1]:42434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyPsR-0006Gj-Cv for submit <at> debbugs.gnu.org; Mon, 15 May 2023 00:32:03 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:61594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1pyPsO-0006GC-8h for 63508 <at> debbugs.gnu.org; Mon, 15 May 2023 00:32:01 -0400 Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-50db7ec8188so10756428a12.2 for <63508 <at> debbugs.gnu.org>; Sun, 14 May 2023 21:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684125114; x=1686717114; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=pW0wz6uO3B9vFz6znhz9s4GuexRsZuOMIJw9y3qCv7Q=; b=KjlwFQx6imfXIVcEwLB1CedhjzLz5xe0IDOJREXMG9Ozmuc7GOsAo/cDvzA1H+6MDk vryfM7sXgc+XIpBCUjdAETEI8Zowx0UmgLZ7sFJfDNM8iJjw7fR/kb8i0RNh46MCSViF QSgVYvcwGIWgNCjNflmy1GRvuMQzj4Xwe7j/XyPjGjWxPQ0pFuB9XqjrSDDiRr8VvzD/ CTL6v7qAnqEkO2qaBiNHEtcPghE0ITNR9HNVsVDk+fnqGCBaf8yAfXlZMemzqBbY59FQ +4w69JR1muJ32gN9nmEymOeF/I70IEr6LBiOTP5OmvqRPdlnjlX9dQpl9YndF0as6V3J 4IZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684125114; x=1686717114; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pW0wz6uO3B9vFz6znhz9s4GuexRsZuOMIJw9y3qCv7Q=; b=Is4I0kq0YszwXY3Zoij+T3QooJAYgWGlUSUvo+1BwJqmajQa4+ui1jIO3HV4RfPgkp OVDvq0ulyHNostJ4TZNn4U8KoZ/fNA1PRBRAvMTHtontf152NyLcdX+27hQrtjnrRYQJ RugBM3NXGWDCEYF+qJ6BO0FcqPMRvlD3l1gi6M3jz3PrYm77/SRmLISOPkaZv5iUd1bS q3Xiz/tYGdSe3FHbOvLyaiany24tkeEPgwY+sGYn84f6Vk+ThgU+AsU3J5LNi5kyzG2h Crgt44cmLtcCvEojFii7Uv1OcTVJ3nwc8ZJLXQXs1I9hs+7LFGJitLFuwcJCWGnV5HiY XA0A== X-Gm-Message-State: AC+VfDxvxjRFgjfyhzlnSFF7a89jr6v2WB7G4ahGHOR6JY/Xowv93Qfd krzYDsFZlvXyJFPhZSw3gWgm2dOEii+GaQ== X-Google-Smtp-Source: ACHHUZ5vHmI6aLKEH1arIau8i4qjV46/T2J86dKe3k2w86RmV9b0p9ffXiW80UJKTJbnmMCBK+mnIw== X-Received: by 2002:a05:6402:202a:b0:504:8c1a:70db with SMTP id ay10-20020a056402202a00b005048c1a70dbmr28191283edb.32.1684125113942; Sun, 14 May 2023 21:31:53 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n21-20020aa7c695000000b0050bdd7fafd8sm6895816edq.29.2023.05.14.21.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 May 2023 21:31:53 -0700 (PDT) Message-ID: <9f3182a690a147e440cef8dc414365730383172d.camel@HIDDEN> From: Liliana Marie Prikler <liliana.prikler@HIDDEN> Date: Mon, 15 May 2023 06:31:52 +0200 In-Reply-To: <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Sonntag, dem 14.05.2023 um 14:42 -0700 schrieb Felix Lechner: > The change here resulted in the recompilation of several seemingly > unrelated packages such as Emacs and GTK. Perhaps those dependency > relationships should be examined. What? GUI libraries and packages that depend on them need to be rebuilt when we change the way we handle our (input, media) devices?!=20 Can't have that! > =C2=A0gnu/packages/linux.scm | 6 ++++++ > =C2=A01 file changed, 6 insertions(+) >=20 > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 98e683bdb0..724c621fed 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -4173,6 +4173,12 @@ (define-public eudev > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (substitute* (string-append #$output > "/lib/libudev.la") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (("old_library=3D.*") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "old_library=3D''\n"))))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-before 'inst= all 'net-name-mac > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lamb= da _ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (use-modules (ice-9 regex)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (substitute* "rules/80-net-name-slot.rules" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (((regexp-quote "ID_NET_NAME_ONBOARD")) Wherefore the regexp-quote? There is no regexp to be found here, is there? > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 "ID_NET_NAME_MAC")))) I don't see how this change allows users *or upstream package maintainers* to continue using onboard names as they have done for ages and as they would want to continue to do. I think you should a) File a patch upstream to add ID_NET_NAME_MAC into net-name- slot.rules b) Add that patch to our eudev package with a reference to the upstream bug report. Cheers
X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. Resent-From: Felix Lechner <felix.lechner@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 15 May 2023 04:57:01 +0000 Resent-Message-ID: <handler.63508.B63508.168412661926682 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Cc: 63508 <at> debbugs.gnu.org Received: via spool by 63508-submit <at> debbugs.gnu.org id=B63508.168412661926682 (code B ref 63508); Mon, 15 May 2023 04:57:01 +0000 Received: (at 63508) by debbugs.gnu.org; 15 May 2023 04:56:59 +0000 Received: from localhost ([127.0.0.1]:42452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyQGZ-0006wH-8c for submit <at> debbugs.gnu.org; Mon, 15 May 2023 00:56:59 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:45040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyQGW-0006w8-UV for 63508 <at> debbugs.gnu.org; Mon, 15 May 2023 00:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=EeR96zzSaUhRLLp zF0wuGySRv6ta3pAZOW28A3cAENY=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=oQzPFCo6PfjxVfz6TmfFQizK8lygJIS2dysvTSNl kDQc6h9bw+uPNEtkRMgQkjCV3TnKW4ocwRS+2A409U5+cGsbdtqLkAfDPAN2m5XvFbgigz h9bQlEGP5+OREqnlSGA3zX6/Zoe8X4QxbfB2fmyyUbBDCwdY/jROcjrTWGt0Y= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 72a5276e (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <63508 <at> debbugs.gnu.org>; Mon, 15 May 2023 04:56:54 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-4f13c577e36so13884334e87.1 for <63508 <at> debbugs.gnu.org>; Sun, 14 May 2023 21:56:54 -0700 (PDT) X-Gm-Message-State: AC+VfDwGu7/+ew34Ug+b9vnu0J+nPYednK9FpAn1AqLQm2BdKnTCJxFM OlnkxtcjYZUKyVuUQ/YNp6JkuqQMzyoDI2kqSeA= X-Google-Smtp-Source: ACHHUZ4efeiYYKwZdEEawxBbsAGIRIiBhdw0vnEjLBp+IzUQl09+EUJy6w5bqls0gaHaKYU28Iu/NR/TyCHxps7Et8Y= X-Received: by 2002:ac2:558c:0:b0:4f2:56ed:f22f with SMTP id v12-20020ac2558c000000b004f256edf22fmr6568030lfg.22.1684126612522; Sun, 14 May 2023 21:56:52 -0700 (PDT) MIME-Version: 1.0 References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <9f3182a690a147e440cef8dc414365730383172d.camel@HIDDEN> In-Reply-To: <9f3182a690a147e440cef8dc414365730383172d.camel@HIDDEN> From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 14 May 2023 21:56:16 -0700 X-Gmail-Original-Message-ID: <CAFHYt55dZUXX0MkXr32216foTxJvJD-49_aJ0nYdj5Ki2PVb6w@HIDDEN> Message-ID: <CAFHYt55dZUXX0MkXr32216foTxJvJD-49_aJ0nYdj5Ki2PVb6w@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Liliana, Thank you for your review! On Sun, May 14, 2023 at 9:31=E2=80=AFPM Liliana Marie Prikler <liliana.prikler@HIDDEN> wrote: > > Wherefore the regexp-quote? Whoops! That was left over from the attempt to get udevadm to use /etc/udev/rules.d as it should. Thanks for the pointer! > I don't see how this change allows users *or upstream package > maintainers* to continue using onboard names as they have done for ages > and as they would want to continue to do. I have one of those cards. While the interface name did not change when I fiddled with the PCI configuration, I am not sure that prioritizing ID_NET_NAME_ONBOARD over ID_NET_NAME_MAC is a reasonable default for Guix. To rank ID_NET_NAME_ONBOARD below ID_NET_NAME_MAC would not address the shortcoming you perceived because the latter always exists. Instead, I think people wishing to use ID_NET_NAME_ONBOARD should install a custom udev script (and those should be recognized by the udevadm we ship). > a) File a patch upstream to add ID_NET_NAME_MAC into net-name- > slot.rules If upstream accepts such a patch, I believe they would give ID_NET_NAME_MAC the lowest possible priority, but that does nothing for Guix. Common relative priorities are outlined here. [1] For Guix, I think we would like to see ID_NET_NAME_MAC at the top. Kind regards Felix [1] https://wiki.debian.org/NetworkInterfaceNames#How_to_migrate_to_this_sc= heme_on_upgraded_systems
X-Loop: help-debbugs@HIDDEN Subject: [bug#63508] [PATCH] gnu: udev: Allow EUDEV_RULES_DIRECTORY to shadow built-in rules. References: <cover.1684100044.git.felix.lechner@HIDDEN> In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN> Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 15 May 2023 19:26:02 +0000 Resent-Message-ID: <handler.63508.B63508.168417875114931 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63508 <at> debbugs.gnu.org Cc: felix.lechner@HIDDEN Received: via spool by 63508-submit <at> debbugs.gnu.org id=B63508.168417875114931 (code B ref 63508); Mon, 15 May 2023 19:26:02 +0000 Received: (at 63508) by debbugs.gnu.org; 15 May 2023 19:25:51 +0000 Received: from localhost ([127.0.0.1]:44448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pydpP-0003sk-3i for submit <at> debbugs.gnu.org; Mon, 15 May 2023 15:25:51 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:52598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1pydpM-0003sW-Eg for 63508 <at> debbugs.gnu.org; Mon, 15 May 2023 15:25:50 -0400 Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-96a2b6de3cbso1147459766b.1 for <63508 <at> debbugs.gnu.org>; Mon, 15 May 2023 12:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684178743; x=1686770743; h=mime-version:cc:to:subject:date:from:message-id:from:to:cc:subject :date:message-id:reply-to; bh=FeY6+KzMjQmBKIrDRUrCJ1KwhvXb8omWfbyqtvqGnhg=; b=jG47v5gqvR5zKd6IOFDlQ6Jgi3f4KM11PM0XHUxEFHIF8ACcY34k+p5n2Rp+CSMqPV uYkl81ngpDTmRrPaSfzFRZ5K/nRwlyQaiqvSHOjCarKRyOZgGoByx4Ep2V03H+ofQW4v tNgbfN0o9Ds9EOWoaqX7vqu1YE28OWbBAfxmGSIQPUbOtwLaT/cm9tSzarzEr+6V/HuS RNbwSRFc0knNu/fd+Nu7G7rG/sQj7lg1nzIsRoYaoP83B3GB6c5xmrDPH70CKrCaVfDt H3tVrz/t68dRad5i1WXNWLH3ab85w0eAVLWZ0nUR1R3lD5ehfL0UeknBF9a5rAL3TAFm EzVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684178743; x=1686770743; h=mime-version:cc:to:subject:date:from:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FeY6+KzMjQmBKIrDRUrCJ1KwhvXb8omWfbyqtvqGnhg=; b=ghz1MEUa1xbkE6xx0UbJas+Rl+ZQp4bLip4FXAWNmTa3Erq4Fs/vewbFr4No/REieW 0x2giTjTkUU+Q7IZk5Zquyixok9a9RRxU6UUudQWXp4JMkXPaqNqWfy5XqDOjorWD2OH gDxWh6CAnIG9yaOyHjQ5BNw5jgzvVrpRutTybYUHa3bv03DMJUgrdVvTi+ndPk42lZgE I9Y15hxG3rBcmgQTK96XpI4Taj8fTAhA5+Fwxda4WfK1zvTmO3g6rzk08n5zKP7BcrR6 b7vKOuC+7R/mKH+ZiQsJQjU4eluk4yhUV+S+kIKVRDUT9dRFkK4wXPxstq1yBk3qGHz0 dbFw== X-Gm-Message-State: AC+VfDx3pBmHmTlUgz7TNudEhvswSR4l1uWVh2OwREN9EiE7IhOQCn37 QUFqw8eYj7f76rBIhdZrsA03G8dGvUTpKA== X-Google-Smtp-Source: ACHHUZ4aL1LH20S7c4oxB0S/ICW5pCUjs6jpYazCHRG5K2Yrk+iwE9zvmr3EN/tS9qc+nZ8s8XTNIg== X-Received: by 2002:a17:907:3683:b0:966:dd1:bae2 with SMTP id bi3-20020a170907368300b009660dd1bae2mr29721094ejc.73.1684178742346; Mon, 15 May 2023 12:25:42 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id va8-20020a17090711c800b0094f282fc29asm9722291ejb.207.2023.05.15.12.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 12:25:42 -0700 (PDT) Message-Id: <06ea6673ca13ed6bc7fb00336dafc7a3457412ee.1684178049.git.liliana.prikler@HIDDEN> From: Liliana Marie Prikler <liliana.prikler@HIDDEN> Date: Mon, 15 May 2023 21:11:54 +0200 MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/patches/eudev-rules-directory.patch (rules_dirs): Move placeholder to the start of the array. (rules_dirs_real): New procedure. (udev_rules_dirs_new, udev_rules_check_timestamp): Adjust [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [209.85.218.67 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.67 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.67 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.3 (/) * gnu/packages/patches/eudev-rules-directory.patch (rules_dirs): Move placeholder to the start of the array. (rules_dirs_real): New procedure. (udev_rules_dirs_new, udev_rules_check_timestamp): Adjust accordingly. --- Hi Felix, Am Sonntag, dem 14.05.2023 um 21:56 -0700 schrieb Felix Lechner: > > I don't see how this change allows users *or upstream package > > maintainers* to continue using onboard names as they have done for > > ages and as they would want to continue to do. > > I have one of those cards. While the interface name did not change > when I fiddled with the PCI configuration, I am not sure that > prioritizing ID_NET_NAME_ONBOARD over ID_NET_NAME_MAC is a reasonable > default for Guix. > > To rank ID_NET_NAME_ONBOARD below ID_NET_NAME_MAC would not address > the shortcoming you perceived because the latter always exists. > > Instead, I think people wishing to use ID_NET_NAME_ONBOARD should > install a custom udev script (and those should be recognized by the > udevadm we ship). I think the current default is probably fine for more users than the proposed change (ain't no one got the time to type their MAC addresses). I do however see your point in that udev should let you choose to prefer ID_NET_NAME_MAC over the other rules. Now, the shortcoming here actually lies with our incomplete support for EUDEV_RULES_DIRECTORY, see the patch :) > For Guix, I think we would like to see ID_NET_NAME_MAC at the top. Now, I respectully disagree on that proposition, but am here to fix the original bug of udev not honouring your preference. With the following patch your udev-rule-service should be able to override the default behaviour. If not, try matching the file name. There shouldn't be any weird predicates on the name, but if there are, that's how we'll find out. Cheers .../patches/eudev-rules-directory.patch | 44 ++++++++++++++++--- 1 file changed, 37 insertions(+), 7 deletions(-) diff --git a/gnu/packages/patches/eudev-rules-directory.patch b/gnu/packages/patches/eudev-rules-directory.patch index 54fc01c6d5..7cc3f97451 100644 --- a/gnu/packages/patches/eudev-rules-directory.patch +++ b/gnu/packages/patches/eudev-rules-directory.patch @@ -4,14 +4,17 @@ The old udev 182 supported $UDEV_CONFIG_FILE, which in turn allowed the search path to be customized, but eudev no longer has this, hence this hack. ---- eudev-3.1.5/src/udev/udev-rules.c 2015-10-13 06:22:14.000000000 +0800 -+++ eudev-3.1.5/src/udev/udev-rules.c 2015-10-16 20:45:38.491934336 +0800 -@@ -47,15 +47,11 @@ +Index: eudev/src/udev/udev-rules.c +=================================================================== +--- eudev.orig/src/udev/udev-rules.c ++++ eudev/src/udev/udev-rules.c +@@ -48,15 +48,11 @@ struct uid_gid { }; }; -static const char* const rules_dirs[] = { +static const char* rules_dirs[] = { ++ NULL, /* placeholder for $EUDEV_RULES_DIRECTORY */ UDEV_CONF_DIR "/rules.d", UDEV_RULES_DIR, - UDEV_ROOT_RUN "/udev/rules.d", @@ -20,17 +23,44 @@ this hack. - "/lib/udev/rules.d", - "/usr/lib/udev/rules.d", -#endif -+ NULL, /* placeholder for $EUDEV_RULES_DIRECTORY */ NULL}; struct udev_rules { -@@ -1704,6 +1700,9 @@ +@@ -1691,6 +1687,14 @@ static int parse_file(struct udev_rules + return 0; + } + ++static const char** rules_dirs_real() ++{ ++ if (rules_dirs[0]) ++ return rules_dirs; ++ else ++ return rules_dirs + 1; ++} ++ + struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names) { + struct udev_rules *rules; + struct udev_list file_list; +@@ -1717,7 +1721,10 @@ struct udev_rules *udev_rules_new(struct udev_rules_check_timestamp(rules); +- r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs); + /* Allow the user to specify an additional rules directory. */ -+ rules_dirs[3] = getenv("EUDEV_RULES_DIRECTORY"); ++ rules_dirs[0] = getenv("EUDEV_RULES_DIRECTORY"); + - r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs); ++ r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs_real ()); if (r < 0) { log_error_errno(r, "failed to enumerate rules files: %m"); + return udev_rules_unref(rules); +@@ -1776,7 +1783,9 @@ bool udev_rules_check_timestamp(struct u + if (!rules) + return false; + +- return paths_check_timestamp(rules_dirs, &rules->dirs_ts_usec, true); ++ return paths_check_timestamp(rules_dirs_real (), ++ &rules->dirs_ts_usec, ++ true); + } + + static int match_key(struct udev_rules *rules, struct token *token, const char *val) { base-commit: 28bfc5cd081458313fa8601133386209b23deb12 -- 2.40.1
Received: (at control) by debbugs.gnu.org; 18 May 2023 00:27:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 17 20:27:37 2023 Received: from localhost ([127.0.0.1]:51474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pzRUX-00015U-4l for submit <at> debbugs.gnu.org; Wed, 17 May 2023 20:27:37 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:34006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pzRUU-00015L-UZ for control <at> debbugs.gnu.org; Wed, 17 May 2023 20:27:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=4f7+hfzVxgfrj0b g6QNy/CH2g+GjczsiJa/eWuIhlps=; h=to:subject:date:from; d=lease-up.com; b=AkOEIeN0HmtbZsakfYgRbNQJQF4vknuMUn61n7d8mi80rxGBcD0I6OoYUOcCgKT9PMkv 9/QQAoXkdiMwcauJTkrGTIdgz6dllFsihr6k307nf7tvTIvrYREQDpq+Y0MbH2mekIO3Z0 /cclF9mY+Oe55i0FCyRN1yGdcgkmRw+Hs= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 55121f4d (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <control <at> debbugs.gnu.org>; Thu, 18 May 2023 00:27:32 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4effb818c37so1735325e87.3 for <control <at> debbugs.gnu.org>; Wed, 17 May 2023 17:27:32 -0700 (PDT) X-Gm-Message-State: AC+VfDw0KgMgR02hVVe6cqRQJTVAnuws09gS8T90GXk7O7J3QrpFHu3L tw+iwvL0k2lZngkWdqC2CStZgor80/X1uXWbodk= X-Google-Smtp-Source: ACHHUZ7p0FRt6mzedzy5jMT0AgHxGrwFWBwqt8BJaKInqRuUNC1LuCwjA0WsW/A9bWUbvu0cRa7Z9UTodizoKPDclnE= X-Received: by 2002:ac2:5e8e:0:b0:4ef:ec33:9155 with SMTP id b14-20020ac25e8e000000b004efec339155mr693004lfq.28.1684369650525; Wed, 17 May 2023 17:27:30 -0700 (PDT) MIME-Version: 1.0 From: Felix Lechner <felix.lechner@HIDDEN> Date: Wed, 17 May 2023 17:26:54 -0700 X-Gmail-Original-Message-ID: <CAFHYt57FVZuo3ePxXAGqpcFCs23V3BFHnxuGTV77W+QhH+N6fA@HIDDEN> Message-ID: <CAFHYt57FVZuo3ePxXAGqpcFCs23V3BFHnxuGTV77W+QhH+N6fA@HIDDEN> Subject: To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 63508 [PATCH 0/3] Have udevadm look in /etc/udev/rules.d thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.0 (+) retitle 63508 [PATCH 0/3] Have udevadm look in /etc/udev/rules.d thanks
Received: (at control) by debbugs.gnu.org; 18 May 2023 00:39:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 17 20:39:20 2023 Received: from localhost ([127.0.0.1]:51482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pzRfs-0003sp-AU for submit <at> debbugs.gnu.org; Wed, 17 May 2023 20:39:20 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:53908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pzRfp-0003sh-TR for control <at> debbugs.gnu.org; Wed, 17 May 2023 20:39:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=o6tipUVBg25M5/f 9gyfmJ0ZRvgG3Yd5j07CWJvE1VKE=; h=to:subject:date:from:in-reply-to: references; d=lease-up.com; b=nMKvlqMBYjhCTgP82bLyy3MNeSlPD9vLWdm8Ya7q pk7xWpy8VHQFXoU1kl1LqAgAuTniTN8le7AnfELDAF24P6PrzE/Y2dNE2xy14juHAJoi8g C7YK7kR4eLK8uHFb/KIIMEUFqCgujYLAK+QNmuVjWJwAcS5IiaQHXdjXgpmP4= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id ac693de5 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <control <at> debbugs.gnu.org>; Thu, 18 May 2023 00:39:16 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-4efd6e26585so1666956e87.1 for <control <at> debbugs.gnu.org>; Wed, 17 May 2023 17:39:16 -0700 (PDT) X-Gm-Message-State: AC+VfDzT9olUkPbzpRbfs56lPZJU5pFzSc17C6yioeS01s7BFmio9E1l vEO8OxCOhorQJ2AaZHIZeIEwvSzh5gxUjQdwIVc= X-Google-Smtp-Source: ACHHUZ7+F4gyUncyACDHFdjSgdi7n6SItIIfJ0hayKWCdSHunsYL4pLCDiRa4KZKZKNzgLmPyrAKt1UTjtZBhvSag7Q= X-Received: by 2002:ac2:55bc:0:b0:4f1:1e9f:fd72 with SMTP id y28-20020ac255bc000000b004f11e9ffd72mr732092lfg.31.1684370354821; Wed, 17 May 2023 17:39:14 -0700 (PDT) MIME-Version: 1.0 References: <CAFHYt57FVZuo3ePxXAGqpcFCs23V3BFHnxuGTV77W+QhH+N6fA@HIDDEN> In-Reply-To: <CAFHYt57FVZuo3ePxXAGqpcFCs23V3BFHnxuGTV77W+QhH+N6fA@HIDDEN> From: Felix Lechner <felix.lechner@HIDDEN> Date: Wed, 17 May 2023 17:38:38 -0700 X-Gmail-Original-Message-ID: <CAFHYt54zEgJ_-4w8=MmB7p=bq0dinoHVrOgiUVqw4Pcj7eysqA@HIDDEN> Message-ID: <CAFHYt54zEgJ_-4w8=MmB7p=bq0dinoHVrOgiUVqw4Pcj7eysqA@HIDDEN> Subject: To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 63508 [PATCH v2 0/4] Have udevadm look in /etc/udev/rules.d thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 1.0 (+) retitle 63508 [PATCH v2 0/4] Have udevadm look in /etc/udev/rules.d thanks
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.