Received: (at 63508) by debbugs.gnu.org; 11 Feb 2025 20:11:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 15:11:40 2025 Received: from localhost ([127.0.0.1]:58938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thwbb-0006rD-Rq for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 15:11:40 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:61462) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1thwbY-0006qw-Th for 63508 <at> debbugs.gnu.org; Tue, 11 Feb 2025 15:11:37 -0500 Received: by mail-wr1-x441.google.com with SMTP id ffacd0b85a97d-38ddfee3ba9so2120189f8f.2 for <63508 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 12:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739304690; x=1739909490; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=+DQ2dI+catgC3fgY1J2ofDJIE4MSJ5GBMI5jAwQe2bE=; b=kpAvkMq87C90ALix59bp9pcunDrzRqnaj21sPU6kKygtBHvzKd+YoqaiGAu6d4IxQS eA97tYaQJXZfc35bRzFcIr+DZPQTrXtP6mhvjUN1dbmQck0RP/+K2QDO6ob/xjI/YPON /hztp0dgln7wXC0ZptD7ax/iB2rHg/lNTLKNtr60e/w1ik1wIJ/nFHdTUVxsRkcs/Rsn wgby+NM4zAwqQk1W56bEiqJHrPhkQuLa8JeUEzzZgRw7XWpo27RNGby6dlTkOtZZwTh5 Cj18yl5Q9qq7zc/Amws9R1RU3ea88s34WpgdThdtbEJZjgGxO2oyhdVB1VdF0BfWUP9P 0ceg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739304690; x=1739909490; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+DQ2dI+catgC3fgY1J2ofDJIE4MSJ5GBMI5jAwQe2bE=; b=KmgKF9eVpoqI2t7zIFu/XE/bvKFToCDvHk4v+zGQZdMfGMAUFJX0UJrBvtdgdzIMtc qBZmXRLCDURO++xwOec7FaO+vDfyxwdTPBX/YD7XhPMSQ540YIEAqVN5KdqpXo/4n/Fg VPsxSNhCN4sqRoof763tr+zeUyfwUBpS8BMZPK5ahMhMYuDzRp/mDeZc5OGZ1c3Wm9Iy RufR2+MMcc7IsDR/MnSDEetMT4uiunk7eKKNVvNSQ/ZwbdA9B8Jf78TOQb7RXt33OZg6 CqbiYeYvvq5oVu+KrBgfAwfOnKeoJDBL3cvmjcOjBhXKz1Wecybj4sMUg6uSp66o56+h rmHw== X-Gm-Message-State: AOJu0YxCT+HiSjIHYhlCbUeJazJCbMEVG85hYeht65IgC7iv+93JVDbC pybolN2p4B4aUj1MfO2A5VPr44u3WDlgrajn4Xb8qzfct7ahWMp2 X-Gm-Gg: ASbGncuAfGDT5Bh2yzcupMplYyLBN15YvMQ6CvYuvWxUKiTVo71sXqjY9fTi9KRzIYF SQYgpf7azx9SXRb2Uzhx1ft5MYJA7TqER4gy5Z6QK75ze6fNAPvl7V0i9/usvqVUQDeCCrBhcYG PdAEdos0RdSDEFQpJpFKOHv3JiCoVN3X7qouJEXVQ5OEPHKbu9qtoCngyLMbZk3vdvKPiEVH689 5cUZjQmx3IVwJi8FW74sX1fL+WGugLGSfMSP5lPW/of/1xT6v90fb89wExMbEx53LpSF6F3rnMj B5xQSKRqXbE7ZHDU+SoNGjx1xEsLNw6BOjAhEXmvzyzzfVe+ut3LMq2Ioh0bMK6zc4M= X-Google-Smtp-Source: AGHT+IFFXi+979seqrB0yLwheH0Nds2f0+S9qAp52Ed3VgXCuVYO1+7D+0quCy9Qa6am3kOyE1474g== X-Received: by 2002:a5d:5f89:0:b0:385:d852:29ed with SMTP id ffacd0b85a97d-38dea2eadbdmr243491f8f.36.1739304690320; Tue, 11 Feb 2025 12:11:30 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394779a96dsm60733215e9.4.2025.02.11.12.11.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 12:11:29 -0800 (PST) Message-ID: <c04e370b74296b6237ea44143531d1a3019ccf49.camel@HIDDEN> Subject: Re: bug#63508: [PATCH] gnu: eudev: Look for rules in /etc/udev/rules.d From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Date: Tue, 11 Feb 2025 21:12:03 +0100 In-Reply-To: <87tt90sg1r.fsf@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> <87jza38mip.fsf_-_@HIDDEN> <8fc89640aaa3849793fb087bd6ea29357b6f4c33.camel@HIDDEN> <874j166xyu.fsf@HIDDEN> <7417feb35e0153c4ada21ceb46dbfdb6b44cf807.camel@HIDDEN> <87tt90sg1r.fsf@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Wilko Meyer <w@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Dienstag, dem 11.02.2025 um 23:37 +0900 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler <liliana.prikler@HIDDEN> writes: >=20 > > Am Freitag, dem 07.02.2025 um 16:00 +0900 schrieb Maxim Cournoyer: > > > I'd like to go with this v5 as-is, unless you have a problem with > > > it, and we can see in time if there's a need for coming up with a > > > UDEV_RULES_PATH environment variable, for the sake of not > > > expending efforts where there is little reward. > > >=20 > > > Do you agree? > > Sorry for the late reply.=C2=A0 Assuming you haven't pushed the change > > yet, feel free to do so. >=20 > Thanks for the heads-up!=C2=A0 I was waiting on your reply.=C2=A0 Bumping= this > package will involve a feature branch (large rebuild), unless you'd > like to include it on the gnome-team branch? We currently have large rebuilds headed for gnome-team courtesy of `git rebase' resulting in subtle code changes, but I recall now why I prefer EUDEV_RULES_DIRECTORY (or EUDEV_RULES_PATH) to exist: Am Donnerstag, dem 18.05.2023 um 06:19 +0200 schrieb Liliana Marie Prikler: > Now, you may object that this doesn't mention /etc/udev/rules.d and > thus could be problematic on foreign distributions, but I argue that > you probably shouldn't mess with foreign udev anyway, and if you do > that setting EUDEV_RULES_DIRECTORY is appropriate. In other words, I do think that a search path is a necessary prerequisite to prevent cases where Guix and a foreign distro want their udev rules in the same place. (It can also be an explicit way of opting into Guix' udev using rules from the foreign distro). I'm not sure we should relinquish our environment variable just like that. Especially on foreign distros there might well be a situation where we would like to load more udev rules from places other than /etc/udev/rules.d Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 11 Feb 2025 14:38:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 09:38:16 2025 Received: from localhost ([127.0.0.1]:55400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thrOx-0000JS-I6 for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:38:15 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:51662) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1thrOv-0000JB-1D for 63508 <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:38:13 -0500 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-21f49837d36so65088095ad.3 for <63508 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 06:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739284686; x=1739889486; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hx4EdIIw5iuHcbHj2/n4YiirlJvpLoAj+zi1jq8N264=; b=fH0wPomuEsHonbxXQD+JC1GN2JbB78S9TtXUZGmvUqcgeqwfwj0VDYOQzr+N2MQGm0 k6vuA3dl0KY1qCwLsVzsWnE3oVuGi8lP+HJOyYHAILj/nZlZI7LUlghvZTwe6zLLuUhw S0+pb1HsLue/Ume3FMdDTmXcyc37VBt7IrnJdO2xJGbEkTtzk2WeQtCKwRuJjcKcpWGX MIbpVpQGzhjIinwBc2TA56ZCziYdsHnlhrZlsABWu/aAHrl8CTfikdvBGeGbMAIp6uIV 0/Y+atCnZpccdpX3eQ+V9qyIrwZdyZkZ8h39u/FUI6ikZFthpvjp05DNVbOYC4hsNSLq K6vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739284686; x=1739889486; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hx4EdIIw5iuHcbHj2/n4YiirlJvpLoAj+zi1jq8N264=; b=QimD3wS0C2peUCGAiYybCT811ddQ3jmc7p63MGfmKYPYX/DXrScSajvZDU/D4uWHRW oL1K1z+H/lHLnNX9cH8roKoLIxOr/ciDDKlR2MIpcC2DkKwgAPkFZ79kxZuKLMdvRyFy 5bwaH9CIXgl9P8s1WE1YHL8NPrc3wzpUBynE6tPgE4kDFIGYoL+uhHXqiDdHlnjy/Z9f 1XIWYQCFMKYr8u9f+VkmqvF6RMml1NmwH+BZsxknvibpTNlOG/W1YGa7YmVqJZer8guE dLa1kWSpUcwQdTC/zWMIjcdedl3CWY+RPbjpLGjz3QWieMGaS6K4Lovxv6piilYYKiVb b6DA== X-Gm-Message-State: AOJu0YzstZSetrxM69VWZxEonQULGOz6Gbvle4uenK2f5m0iFirS2H6M tbAOAJ74EnEdCSNEEX4tduNCmzthZnhYhXgWBrEyGQWv+9qcKQ95 X-Gm-Gg: ASbGncuHloye6V2BhmxZl+She+ewmU1HFGM07oveJq2HLfaUgc+izDxP0GsyRVNSAVL DYJb7DtAg3IDQcPYzEdUWPdqrfokGY7NjsApKj4hEthjSURajE6kM2Jv7mNJa07YXhgx0l74+8h kP2SreJfzFgjO1GksZpTlI0ArpAbvnqtTxCP9cTqKGwGoxhUeyl/L6hBrSPpkAwkTowY+p1TUTf 9sQGW2G6hdfo6SXU3Pv/THoeU9Bp31ounif7yDwtzgUaviXu6fOWFmjY23u9lUYhSR/s8o5iJC6 ZZNF7TLQZj6q X-Google-Smtp-Source: AGHT+IGuQ/8d6Djt/J+lz5IuuUZltYTP8MBtUtZd8l2L7jj0JoPMlVx9uHK6vcanERYaxYhZ0KOkng== X-Received: by 2002:a05:6a00:2e08:b0:732:a24:7351 with SMTP id d2e1a72fcca58-7320a247d22mr6134448b3a.6.1739284686418; Tue, 11 Feb 2025 06:38:06 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048ae7f9asm9475544b3a.72.2025.02.11.06.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 06:38:05 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: bug#63508: [PATCH] gnu: eudev: Look for rules in /etc/udev/rules.d In-Reply-To: <7417feb35e0153c4ada21ceb46dbfdb6b44cf807.camel@HIDDEN> (Liliana Marie Prikler's message of "Mon, 10 Feb 2025 15:26:24 +0100") References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> <87jza38mip.fsf_-_@HIDDEN> <8fc89640aaa3849793fb087bd6ea29357b6f4c33.camel@HIDDEN> <874j166xyu.fsf@HIDDEN> <7417feb35e0153c4ada21ceb46dbfdb6b44cf807.camel@HIDDEN> Date: Tue, 11 Feb 2025 23:37:52 +0900 Message-ID: <87tt90sg1r.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Wilko Meyer <w@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler <liliana.prikler@HIDDEN> writes: > Am Freitag, dem 07.02.2025 um 16:00 +0900 schrieb Maxim Cournoyer: >> I'd like to go with this v5 as-is, unless you have a problem with it, >> and we can see in time if there's a need for coming up with a >> UDEV_RULES_PATH environment variable, for the sake of not expending >> efforts where there is little reward. >> >> Do you agree? > Sorry for the late reply. Assuming you haven't pushed the change yet, > feel free to do so. Thanks for the heads-up! I was waiting on your reply. Bumping this package will involve a feature branch (large rebuild), unless you'd like to include it on the gnome-team branch? -- Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 10 Feb 2025 14:25:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 09:25:57 2025 Received: from localhost ([127.0.0.1]:49782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thUjU-0002eA-QY for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 09:25:57 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:49421) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1thUjR-0002dt-D5 for 63508 <at> debbugs.gnu.org; Mon, 10 Feb 2025 09:25:54 -0500 Received: by mail-wm1-x341.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso30234165e9.3 for <63508 <at> debbugs.gnu.org>; Mon, 10 Feb 2025 06:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739197547; x=1739802347; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=uLLeNEwvQRZIuFiGz+Weny1JnCxm07uF8/E3KnNPz1U=; b=bikiDXstH3nCFP5FLJuUP9UPZtslCDLEGSlVYMoM5mbiGurpmV/i2eTNdrtPWyApYi szobD9B5FaYp5z298Dtz2dHafi6XL99vadCu7U2FdSYZFjmotW9AMQI8rwUBUoK5hqf3 kKGLPATzKhQ6ock6+wBF1EEtT2oCO5+jGYDSe50+yLr4XBNzArg8H2f0Be1yMP6YKjSi gUrhYs+jDjIzvu68awhLfRT7N7GuMFIzWdgUc0NrlVVkHLFdv7FxGK80CsMBYd1nmmcm +WwreoPTG/69EOGrJNlbh73nT22FezqIuDEI5SPiX8kKV0bYSPm3i88Z7eGqbVFkVeIg w74g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739197547; x=1739802347; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uLLeNEwvQRZIuFiGz+Weny1JnCxm07uF8/E3KnNPz1U=; b=tSV7LvGckn9pUk5YWgSTxjXrXNocgR18oYWPhg9Cppc3EfuBDwUYFdwXBXd/5gszHD KHiVQt+x8ge2VQWMA9TGppIUIxXdEEfO15LkCwlEdzoiPJUBxnwEHOUyN0BoQUGvfmxi tK+4O24xEBe5pkgEYLzF0B1vSxQe8qSsEJ161cHLHa0yfXw+cvuxXpNPa/lr/bY4xQQx qNWB0/ZPm0Ej5VdWPQZTEfD+2cKOJGrQ2EGHj683Yx4LtgcbmSE1PaA7jFsDJtLTm2R5 MCoa+qk3OsdRJz1gpwr33lZ2+rwVJs/SySlPknSfJ9rvIUxvf/qT8q1vwPSRHfHBVk9f id+Q== X-Gm-Message-State: AOJu0YyfnWOGBuzSh5RmrFNtPoeIDnPDgfQqtFd39RVIGVIAugD+4W0v ysPOIPnWpYhD7ZeI019BLCrOchH/3k+AZ03WAKF21Sv09S0pMFZd X-Gm-Gg: ASbGncuiwu103u4Bakfm2pNjQeTb4WvQSrGrcoKeH3sXlXwo9MbG/fbGx7YZD3xyuVM FYxEqor0kgYxQcOfxoezcfqPtCu9fFEo0KLWhvO8Kw5hmBktVsMg8irc5MSEfJELN4Fobo//lSA wJszYx1m+j/hcecdUxuyTv3MAe9lCYoEA/YTJrRAUxOAA2nqSE/c7PpmvTgI95m/jXfy3w3G/Q8 eo7VMohsyYXDG1cYSpWj/elymdRn18XCPjnBCDN8tvBzYckilXnAQvhHXXdhQAu2W31Wngbxbjn hDluPUcubTGwGuWvWwOQtZcNYCg5Hp2ojg/h7UxtTrgn2I6dugob8eOA7K4P5rwTQSg= X-Google-Smtp-Source: AGHT+IGiGNrQBFTAjXP1RMvmDN79h373xCXZA201ita2XPB80yOPCPc+vHPyaME92Coys3Dzu5fhIw== X-Received: by 2002:a05:600c:4fd4:b0:434:a29d:6c71 with SMTP id 5b1f17b1804b1-439249b2af8mr106371765e9.27.1739197546834; Mon, 10 Feb 2025 06:25:46 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394679a3a1sm24415845e9.5.2025.02.10.06.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 06:25:46 -0800 (PST) Message-ID: <7417feb35e0153c4ada21ceb46dbfdb6b44cf807.camel@HIDDEN> Subject: Re: bug#63508: [PATCH] gnu: eudev: Look for rules in /etc/udev/rules.d From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Date: Mon, 10 Feb 2025 15:26:24 +0100 In-Reply-To: <874j166xyu.fsf@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> <87jza38mip.fsf_-_@HIDDEN> <8fc89640aaa3849793fb087bd6ea29357b6f4c33.camel@HIDDEN> <874j166xyu.fsf@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Wilko Meyer <w@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Freitag, dem 07.02.2025 um 16:00 +0900 schrieb Maxim Cournoyer: > I'd like to go with this v5 as-is, unless you have a problem with it, > and we can see in time if there's a need for coming up with a > UDEV_RULES_PATH environment variable, for the sake of not expending > efforts where there is little reward. >=20 > Do you agree? Sorry for the late reply. Assuming you haven't pushed the change yet, feel free to do so. Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 7 Feb 2025 07:35:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 07 02:35:35 2025 Received: from localhost ([127.0.0.1]:60692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tgIti-0002bY-J1 for submit <at> debbugs.gnu.org; Fri, 07 Feb 2025 02:35:34 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:51308) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tgItg-0002bH-8k for 63508 <at> debbugs.gnu.org; Fri, 07 Feb 2025 02:35:33 -0500 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-21f5660c2fdso3853535ad.2 for <63508 <at> debbugs.gnu.org>; Thu, 06 Feb 2025 23:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738913726; x=1739518526; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KR7/xDf3UWpVkc5iW+ZaWg9artCpf5Qc3mQk8n5tQCU=; b=M1aTTSH1Y3sTEcHbzlK0yAl/S0ILJoIrxFbI0n/NVrQe4wNNXyQT+QBteYA3A4CVMu gkngo9gOF+Mh+gb0eOl7mwaCSjukFmO96vSCOKRGCPuhbUbhNEpIp05zlWeY9i+i7fvS 3Lo8AYzSXeC5dnhdOdGrkJIygxLA/7sfC2HsRGqAjI1jFHOdwOGsBlFGTmi54aisk/TJ Ym2imsUFKr5htG7aC/MtXRR+uSHC9gN7i471akNlv7qC9OHTUQWaZkFk5FwB5PoqmuY0 SuOYv7yMtcsz7UToHeFQWE0nirbpzReiSDpxtwt46JunBgyJk0viFeNwBJvHyHUgXcwM AeYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738913726; x=1739518526; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KR7/xDf3UWpVkc5iW+ZaWg9artCpf5Qc3mQk8n5tQCU=; b=t8ZW3Muguq00KdVv9+Ns7WkfBaMelCqq5p+Rh1+J1hkqlNqiilPBaHjYwMqoFOGQRb B8m6WLHZeaFGwWxn3svvNz2ko3RytJSPJSJNvG7bzi+6dfakk0JLWIrNIQcBs54iu0rj Iq1dx2uxU//s3mgdezTrtgf/J6Ce+AFykWhIZ9kwoRQKnFSrLefg6ct4C2lN/VAi8//h dqdy0Da/6EZMOOQZaBW7gAKZfoyPf9YAMneO3bIbDAv8UGqyv4Yi4KY1LQDh86Fy8/H7 R9hJd7ZsXlnbFmy1oGT9L+Ty0T+gmCO+7s0UagKemFNVljKFp02lVxqJsV630Fdr5PED t7oQ== X-Gm-Message-State: AOJu0YykorX0vF1f66AZu8U6LjB6pmk0T4APms0T+m/gU8hp2DhY3Y0Q t5hIy4UTCuXc9QDffanyjEhSdXRWGYvRa1x6j+pj/xw++WP+dks6 X-Gm-Gg: ASbGncvIf5Osarft+1b95CcXiMSFdmGGzSJknWFxWMcSsUMmYSYUok6pF4SZDZEkXuU u3jfVHTdjTTUrDU0vmCSnXRGkbCZkIOk5GS/A+ppYjmzSL56oFBmHrt15C15s90vxF0kNJj0XJY Hg/FfFsBKldOevxHcia1acPvU1x74d4GuCY2m9ECQzp0eSEueIkr3U+kvYHdxNntdLncVsFgYly mn9dZw/1kTFpSHEqKRy9dIzib15+7+gbMEhkHjCFBIPon1CA9IAP8Zswtf/quhj6Hg1oxOQQyaB xebpwpuSnauL X-Google-Smtp-Source: AGHT+IHCxh1VFxb9Ugv1vJEzDuzaTypewrMZQvsgZJTgy1ldjNT/y1pV1EpflJ2/7mHak/rVMvS0Ew== X-Received: by 2002:a17:902:f60a:b0:21d:ccec:b321 with SMTP id d9443c01a7336-21f4e75a0c2mr39332015ad.34.1738913726007; Thu, 06 Feb 2025 23:35:26 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f36551885sm24058825ad.88.2025.02.06.23.35.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 23:35:25 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <87pljv9jbu.fsf@HIDDEN> (Felix Lechner's message of "Thu, 06 Feb 2025 07:36:05 -0800") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <874j188pid.fsf@HIDDEN> <87o6zgbdqp.fsf@HIDDEN> <87seoraieg.fsf@HIDDEN> <87cyfvbqmj.fsf@HIDDEN> <87frkr8fpx.fsf@HIDDEN> <87pljv9jbu.fsf@HIDDEN> Date: Fri, 07 Feb 2025 16:35:13 +0900 Message-ID: <87v7tm5hse.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Liliana Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Felix, Felix Lechner <felix.lechner@HIDDEN> writes: > Hi Maxim, > > On Thu, Feb 06 2025, Maxim Cournoyer wrote: > >> Sorry for the reviews lagging behind. > > The initial report was reviewed within eighteen hours of filing. Good. >> We have more producers than reviewers, obviously. More eyes and hands >> welcome! > > I'll help a little. How many hours did you spend here, please? I didn't count. Perhaps two or three, to get familiar with the whole threads of the issue at hand, doing some research, producing the new revision, and finally communicating it. >> tagging with the 'reviewed-looks-good' user tag can make these stand >> out as potentially easier/faster targets. > > That workflow prioritizes easier/faster bugs, which is wrong. May > please I use Debbugs severities [1] to elevate serious bugs? You can, and it's useful if used wisely, but that will do little to lessen the load on the reviewers, as regular contributions still need to be processed, and they often require less time investment than serious issues, making them more suitable targets for the typical late evening contribution. > Also, while I have your attention: This Mumi patch [2] fixes the unicode > errors in Lily's message [3] and many others. [...] > [2] https://debbugs.gnu.org/69381 > [3] https://issues.guix.gnu.org/63508#4 OK, will try taking a look. -- Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 7 Feb 2025 07:00:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 07 02:00:49 2025 Received: from localhost ([127.0.0.1]:60591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tgIM4-0000xg-NI for submit <at> debbugs.gnu.org; Fri, 07 Feb 2025 02:00:48 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:59875) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tgIM2-0000xO-4L for 63508 <at> debbugs.gnu.org; Fri, 07 Feb 2025 02:00:46 -0500 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2166651f752so38066595ad.3 for <63508 <at> debbugs.gnu.org>; Thu, 06 Feb 2025 23:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738911640; x=1739516440; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nARoVwSt779U6lEAjc0J9e5QD0KsZapfORorLSdGEH8=; b=INiqmAkC3drZEX2ThD/jBL9m6Ujs+g5Ajj/DOA3iIwT6KAyf3eb9YS7tWNQYS3qwOk 9CS7o5CQv+u06T+fGlxZQqGFUK8hPYZVnpB99Q0umbWO8PDzlBQ6iFpyydrtGKTl2Qlv 2wxeppj3G6JgtPjik9/tGSGKUghKt9rOnJLcPxs+SUBrEgwrwKJ3bQAv5SJnRllF+Ezf c4fj9til1cauRiXCCTPK+j0RMbtP/A0iJqQNHilVXl8CXyryKbWSBhq3T/KIUUxZdr2e aAIrzZ7D8eYOHGdDNWqiE0gVRC2tbbKaQIIxvsN7GCiur4MHg6D8yqmsGBN/7jLHCGE2 tQRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738911640; x=1739516440; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nARoVwSt779U6lEAjc0J9e5QD0KsZapfORorLSdGEH8=; b=n8Lhl0whI4+Q8f2Opol1Xfsr6vNyd52P9S31RvMZ3/RTg/kMtuwsvlFk8XQOkGrR8b kgkopxtTF4YIS1VW52Eq37tAni525Cr/fgCyABJQetabZKT8/hrMN0DwJYHJvDSPtGWF 3y2L+Id8KmMVFAaanZbVMZd1ZMknHuUPfTNS7/Y2wxB5jWX/XrcMXwf/yLXJ299SbE6+ Shwyb2YPE6D30bUwhebEpJao6hT6VUtHicbh93EMIv4MQqghxRpEfewrkHGoDLvDFxzw 90LVloILehZZT4oQSIFJ4Q5kAP0BGhtnNgMOum/o8NO0w91/cD3aDrIFErQdeGqNuT3y yGGw== X-Gm-Message-State: AOJu0YweeQ+Iv3Kjzw50eRVQy8btHHkSs5iY4OFS5TRKlK8nQqppK/Fx Wd+p6/2gNjqDL8ik45kQo7rznKNSe1Nrfm+QwulfSmpoR+iaI3f1 X-Gm-Gg: ASbGncs0CXyPMOX0vumu5jkbJPLT+e/BAjFMqi8MMM5qJtHLG2JIv14+3GbPyM9uxwY JA6BJOr97DDpdswsQirccHuWczwcdSvMmm5ULGD/h4way6UUS7GUpbDcUP/BiFNKSIuUaJ4ZkVC g9xh+pvEfqv3PCGNDT7wcwWJA5D3dKRAoslfqCbUxacnCJpbK2rOTa4+6H6kJuWJ4KdHFeyXXzI oRbkzXgcPLCnto5w7l1A6ZDWJTx/gUrAUwlFg1e4xjXO9vaQBf90fLv8RcAzikwrD350CT/dMoI Nf86JbleDjOx X-Google-Smtp-Source: AGHT+IHHs5at8mqi5Kbl82Bg58X8glbXFzUOOowD2hQSXxYXt/RAY0eQ+t+a5KA+/w2/wwEisSRJmQ== X-Received: by 2002:a17:902:d482:b0:21f:1c9:ce4e with SMTP id d9443c01a7336-21f4e75e373mr32008025ad.34.1738911638978; Thu, 06 Feb 2025 23:00:38 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f368cff88sm23438085ad.242.2025.02.06.23.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 23:00:38 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: bug#63508: [PATCH] gnu: eudev: Look for rules in /etc/udev/rules.d In-Reply-To: <8fc89640aaa3849793fb087bd6ea29357b6f4c33.camel@HIDDEN> (Liliana Marie Prikler's message of "Thu, 06 Feb 2025 21:01:59 +0100") References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> <87jza38mip.fsf_-_@HIDDEN> <8fc89640aaa3849793fb087bd6ea29357b6f4c33.camel@HIDDEN> Date: Fri, 07 Feb 2025 16:00:25 +0900 Message-ID: <874j166xyu.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Wilko Meyer <w@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler <liliana.prikler@HIDDEN> writes: [...] >> I'd suggest if this feature really is important, we could rework the >> patch into a EUDEV_RULES_PATH, making it a true path accepting >> multiple entries, and try to have this upstreamed.=C2=A0 Then we could >> have a nice search path specification for it attached to eudev. >>=20 >> How does that sound? > Well, if we do widen the directory to a path, we still have the problem > that users would have to set it. Most likely, we will add a search- > path definition to udev and perhaps even catch the common use case in > doing so, but misalignment may still occur. Right. Especially for something like udevd designed to be used in a service, where profiles are not involved by default and search paths not being useful in this case (one would have to go through extra hoops to have it computed and set). > I think we should talk to upstream about the benefits/drawbacks of an > environment variable. In my personal opinion, this could very well use > a PATH, but I'm aware that I may be biased. I'd like to go with this v5 as-is, unless you have a problem with it, and we can see in time if there's a need for coming up with a UDEV_RULES_PATH environment variable, for the sake of not expending efforts where there is little reward. Do you agree? --=20 Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 20:01:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 15:01:43 2025 Received: from localhost ([127.0.0.1]:59543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tg84F-0000FC-CW for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 15:01:43 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:52548) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1tg84C-0000Eu-4q for 63508 <at> debbugs.gnu.org; Thu, 06 Feb 2025 15:01:40 -0500 Received: by mail-wr1-x444.google.com with SMTP id ffacd0b85a97d-38db104d35eso1106194f8f.1 for <63508 <at> debbugs.gnu.org>; Thu, 06 Feb 2025 12:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738872093; x=1739476893; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=17Pg6CcaE+gUCWwNG8tWRWwDuemGVpWbprHJ96pNRIw=; b=F1s6w1AKNEPt7bRK07QLq5FXK/y4ZyT74dEei+xOW/NpfkMAzVYGpKz6TBMCkC+UIE 0qXecznIaZIP7s9xsni0IH4zFJ83Nbeli5qoktP4QJx/+vlZuz+YCeO9wL9bGaFHJP1y hnrQk267D+g0Bkh6hfAtRKOYHPYMXgQa610pAni9XZFL0Kg7DPncEa4EmpX01/k+2gyT hVw33pDgKZWvtTvoEFK6uzDJua9wNH9gceGKP7JPvWcBLOs364h7RO0tKqCOiG+t6Cvo ztDO0bpqZkDTL/Uvm538UTfepuNOslqtDcSg14jQebnPKUZd0vrqvLo958PRQEO1oEfJ V/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738872093; x=1739476893; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=17Pg6CcaE+gUCWwNG8tWRWwDuemGVpWbprHJ96pNRIw=; b=G25O0oIEbXWN3BQXOAdkHW/MQHU5DViVFiip0RhG6HUtL4iDjc9PDmFjzAYujiG0gI rV22FzrfTggMnDqgsDyScjrr+Av97uKqmARgBBl5jH2R5VKsQqzz4LsTPnxbUaCeUWqS q6zx9SR97fsGHc84/S6yS4NUwt+8jDtGR7ZrqxPDn8jW6Y4LvH5BedY5mHeLJ0pj1s49 XENPm7WomjBvKlRtTjjxe1xxTREmR/v3DbcHl5IJGbtBu3dBfDLuNF0+ayeCCF24X5nP FvgpzNXr09wlmPkjYdZHE4Jkz5DAoJX7OJS5kfc4QPzsv4uLhHWE8cBOp3ZhXdkllGWU yS6Q== X-Gm-Message-State: AOJu0YypWeM/wx4ZHXMyDtrLZQK5z+eYVYnp0eiVRCBhKCDxJLg5SuzI OKQeWVVfVsdYWcuc78Bvrkf+4qhtH6sLmTxTDoxllE7H6xIZBGZq X-Gm-Gg: ASbGncvKkJKRXg/YLH3y0EFtOImvBJ76Yi63Vaz5jgdG24eXqgzw9UiQowy5A9kOzd7 xUj0wLkjWohu+2WjpXC9/V4VfsWIOKI1kppYEB/3UdLZZexuKmldIfxT2SZ4RqpT6F8bGqPegrS 1HAZUJkMmBOpe66gcXTn7GfIOGN7L9V5aAgH2APbs3TzFjAypoxVt/PKac5g1c74fzw/LqaeeWk O8NEn0pxa+QpPjDBYq7YXWUHSGlWzmGmxLS82rHpk3fWieYHojXzTgm8y5vd8Imb3Q7AARNXlxL /ghq3thSVYG4V1R3N+XNgDQTg1GGbXRS3XBvugH/LyztY4HNrYxph3nSSXPZxp1xlbQ= X-Google-Smtp-Source: AGHT+IHQzh2ia437KRZfzfpP91S22u6WYSTt6LPMzBzplZWRfDCyKBp7SU96l24ff8zVuW/cYOku6w== X-Received: by 2002:adf:f70b:0:b0:385:d7f9:f157 with SMTP id ffacd0b85a97d-38dc9135d53mr199697f8f.36.1738872093134; Thu, 06 Feb 2025 12:01:33 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dbdc30fbbsm2529635f8f.0.2025.02.06.12.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 12:01:32 -0800 (PST) Message-ID: <8fc89640aaa3849793fb087bd6ea29357b6f4c33.camel@HIDDEN> Subject: Re: bug#63508: [PATCH] gnu: eudev: Look for rules in /etc/udev/rules.d From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Date: Thu, 06 Feb 2025 21:01:59 +0100 In-Reply-To: <87jza38mip.fsf_-_@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> <87jza38mip.fsf_-_@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Wilko Meyer <w@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Donnerstag, dem 06.02.2025 um 18:12 +0900 schrieb Maxim Cournoyer: > Hello, >=20 > Liliana Marie Prikler <liliana.prikler@HIDDEN> writes: > > Now, we are losing some flexibility by removing the environment > > variable, but if that's what Nix does, it's what nix does =E2=80=BE\_(= =E3=83=84)_/=E2=80=BE >=20 > I sense some potential sarcasm here; if so, did you consider also my > second point, which was: >=20 > > 2. Users would have had to set EUDEV_RULES_DIRECTORY to the fixed > > directory themselves to have udevadm work as expected, which is > > inconvenient. I did, this wasn't supposed to be a value judgement. Doing things as Nix does does have the benefit of being tested already, even if it doesn't follow our usual style.=C2=B9 > We could also leave the patch in, to let potential users continue > making use of it, but being undocumented in a custom patch that we > haven't upstreamed, used only in the udev service and not in any > search path, it seems likely very few people knew about it (and we'd > have to rebase it from time to time, for dubious value). >=20 > I'd suggest if this feature really is important, we could rework the > patch into a EUDEV_RULES_PATH, making it a true path accepting > multiple entries, and try to have this upstreamed.=C2=A0 Then we could > have a nice search path specification for it attached to eudev. >=20 > How does that sound? Well, if we do widen the directory to a path, we still have the problem that users would have to set it. Most likely, we will add a search- path definition to udev and perhaps even catch the common use case in doing so, but misalignment may still occur. I think we should talk to upstream about the benefits/drawbacks of an environment variable. In my personal opinion, this could very well use a PATH, but I'm aware that I may be biased. Cheers =C2=B9 From a personal sense of aesthetics, building with one set of make- flags and installing with another feels weird. So does having UDEV_HWDB_PATH, but no UDEV_RULES_PATH. (:
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 15:36:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 10:36:13 2025 Received: from localhost ([127.0.0.1]:58947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tg3vJ-0004Oi-7H for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 10:36:13 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:46866) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1tg3vF-0004OY-L8 for 63508 <at> debbugs.gnu.org; Thu, 06 Feb 2025 10:36:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=ffGXf+PiV2L4iun VWq0vEXoDrzyt6G9CAp8z2+ZQeas=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=lGJlW7HxF3tKfMlTCYZLgM1cFRnJ+3ghtGGyc64Z IoeDXGQmSflv9h0HQU/pgUSFfUNu9oAENH8eXGxw9Oxj8hsCaOIQtfJlXduK4xZXq5Aw3+ VtNR7PX4O0eiflMC3PaF/CaIN+IMx2pPdSbKHuc0Ae5cH0gNcMqgHWvK0GsdE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id f7b78589 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 6 Feb 2025 15:36:06 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <87frkr8fpx.fsf@HIDDEN> (Maxim Cournoyer's message of "Thu, 06 Feb 2025 20:39:22 +0900") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <874j188pid.fsf@HIDDEN> <87o6zgbdqp.fsf@HIDDEN> <87seoraieg.fsf@HIDDEN> <87cyfvbqmj.fsf@HIDDEN> <87frkr8fpx.fsf@HIDDEN> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Thu, 06 Feb 2025 07:36:05 -0800 Message-ID: <87pljv9jbu.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Liliana Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxim, On Thu, Feb 06 2025, Maxim Cournoyer wrote: > Sorry for the reviews lagging behind. The initial report was reviewed within eighteen hours of filing. > We have more producers than reviewers, obviously. More eyes and hands > welcome! I'll help a little. How many hours did you spend here, please? > tagging with the 'reviewed-looks-good' user tag can make these stand > out as potentially easier/faster targets. That workflow prioritizes easier/faster bugs, which is wrong. May please I use Debbugs severities [1] to elevate serious bugs? Also, while I have your attention: This Mumi patch [2] fixes the unicode errors in Lily's message [3] and many others. Kind regards Felix [1] https://debbugs.gnu.org/Developer.html#severities [2] https://debbugs.gnu.org/69381 [3] https://issues.guix.gnu.org/63508#4
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 11:39:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 06:39:44 2025 Received: from localhost ([127.0.0.1]:54591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tg0ES-0004KQ-IF for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 06:39:44 -0500 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:44211) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tg0EP-0004K8-Mu for 63508 <at> debbugs.gnu.org; Thu, 06 Feb 2025 06:39:42 -0500 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2f44353649aso1062871a91.0 for <63508 <at> debbugs.gnu.org>; Thu, 06 Feb 2025 03:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738841975; x=1739446775; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vfAp2W63fJ+KQSnmADFAD1Df7GRHryTgZc6J5Mw2IIs=; b=lHb9O+R2vrVibuG3yO3xI48FYiviWRRfREVAMMQsQQV8E/FsT3US3PrgxbNacG10mj foIlzyqT3pFyfPJmOK8ppuGIFzWazQg/4D8s62XaTq+5nHmfAtAirAQw6eT3gSNzZ10w 2Eevx68/nRH2QdOarC4NHO5kxW2Yr30NdWEPaC8qUImmLoyBCP9GmpSIcC3FVrA2lAnr Sdsj+QNS6/U7OdW/PvjsL38IbNmcOqkT9CRXokvSHTLHJYlG2iJax3qbTCmfkgHTQr9w P4LDREcuU7iS6j2r0ZJsiSHGPtL58Y/4eIly4lKjWuU3G292S5VhSNBXrg0/wd+5JyXd dgSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738841975; x=1739446775; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vfAp2W63fJ+KQSnmADFAD1Df7GRHryTgZc6J5Mw2IIs=; b=kvzF8JrQqpNDQ+svPfGGSaBdWGYha73R7c9p94lHkCiBsJTu5tQs8vc3rYRXzycN1j QPpBJeaSPtSVAeoEM1KvhzMLhjGXyVPfgzhtzjuR+YooMibrsArrZpxVV/d1S7IN/odb OZITaCAXvAkHDkGarQpt7lPVmnZMw/gM71pz2FdkFvMUZb5SbSiLnazg14VkfMSwsLBg VOILVq0kf0shA1ZkivgzeVHbYNWREtFvmj6rbcUjgg9o5x2p9MOD7FMDsRaL0oxp5MRh NUPe8tD7KWNgzycYc315mLOf8dldfCTytAksciU3lFUwZSk2Zc0Z4xj4IYa68UdLF9fy Gu0Q== X-Gm-Message-State: AOJu0Yw+QMfWRz3nDUZtDwtYCW8BWuOwWyOvhCSuPW9jc2upFHIkaVf2 iGbyQSgpKyZrfIHmWNogeUkwmXxV8+6Cq6iQ9kBdoxNqJyzJ7WA3 X-Gm-Gg: ASbGncu/HSDF5B6dmkoH3mZ7UIIpJgN+NB+vLsbv2DEyK+MWeqH1dVvHoltAmv1JbNE 47VutMLksunaBjyQnpyvlvTGvdzkdpSoGeVcyLAGgk72pgj2t/zdr5FW6oLW92Gn7l3HJQ1yZh0 tvzVr5Lo1ohMmIRNOQqOU30xaiTXKA1eKWr9w3cjx7XcZNOJve+b6qOgu0XK4g8aqukwee3Jwpy uEVIDcjfcX2ZqqwygRSOjjAIW/bhQBpb6cQQdumlD4GKOX9rZnwfltwRi83B2Q84S+D09pTcrMa nSpBsqB1laTP X-Google-Smtp-Source: AGHT+IE5dEYAJT8DXutiztroiKEYmFFFx6nicoC5D4CSQiqiIVKeWpnG9RJ3lL7AGBszZfBHjx2rhA== X-Received: by 2002:a17:90b:4ccf:b0:2ee:ead6:6213 with SMTP id 98e67ed59e1d1-2f9e0798d4bmr9454708a91.19.1738841975264; Thu, 06 Feb 2025 03:39:35 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f368ce639sm10431625ad.243.2025.02.06.03.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 03:39:34 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <87cyfvbqmj.fsf@HIDDEN> (Felix Lechner's message of "Wed, 05 Feb 2025 21:15:32 -0800") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <874j188pid.fsf@HIDDEN> <87o6zgbdqp.fsf@HIDDEN> <87seoraieg.fsf@HIDDEN> <87cyfvbqmj.fsf@HIDDEN> Date: Thu, 06 Feb 2025 20:39:22 +0900 Message-ID: <87frkr8fpx.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Liliana Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hey Felix, Felix Lechner <felix.lechner@HIDDEN> writes: > Hi Maxim, > > On Thu, Feb 06 2025, Maxim Cournoyer wrote: > >> I've taken a look and came up with v5. > > Thank you so much for working on this! I can't believe it. Someone > please pinch me! Sorry for the reviews lagging behind. We have more producers than reviewers, obviously. More eyes and hands welcome! I think many reviewers like to keep an eye on https://qa.guix.gnu.org/patches (I do), so anyone reviewing and tagging with the 'reviewed-looks-good' user tag can make these stand out as potentially easier/faster targets. -- Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 09:12:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 04:12:53 2025 Received: from localhost ([127.0.0.1]:54305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfxwK-0005mw-Vf for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 04:12:53 -0500 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]:58841) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tfxwI-0005mb-Iq for 63508 <at> debbugs.gnu.org; Thu, 06 Feb 2025 04:12:51 -0500 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2f9dbd7d80dso1248009a91.1 for <63508 <at> debbugs.gnu.org>; Thu, 06 Feb 2025 01:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738833164; x=1739437964; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=shR9/tcV5tTgwLpFO/qzFPHUX+2MZNgSlcxLc8pQlUg=; b=JvZZAJqDbdEOP8b/PDu5HDD2atDxGgYC2YkkAAU7tCbPsexWIzEaF8lJ0zQeJsOFV4 sKGjXDtjaqtFG6UbqIbjkHzl1lvqdSZfEgxMGxhpBfdAMrcM9G++ECssedJacH95srQ5 iXf/m8EyN2pAVuzT44qeletgExvY4GVRyLw7SNDbXZyfxrYsjaVeb7hAHe10DiMI9tua N6fhf4WmpAr7aQUZbVOOWWsEtkChYy2UBKYuVSTqsyvqZcLa82h3K57Uk7/LDanpF7lR aaybk07wu+Gffhy68UWbWcJCjklkcT24qRASQV1w8HzHwfs19/QP0oAnVsvbCDpfONf8 meUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738833164; x=1739437964; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=shR9/tcV5tTgwLpFO/qzFPHUX+2MZNgSlcxLc8pQlUg=; b=Gmorf0zHcAlCInvNYhJ1KcZhFEL+gN/y6klVMnTGVnT7fR9K/COldJS77nIfPg9DQK MGjRBBxvAtImnWiGHEMQAEY0RIdpdq4wkfOV2pq1q41kvKUvy6R1dBr9xj1KAoIhYyV0 cXPnDK7R2nq3T5K9EAAdYjqGQ1YEAxYxGBSXf50F7s9px93MVP3meGaexvgR7iKl0Z9R 35e4wOlPjFfHbv3IIU7iKxTy7BVTcDnysSD+NPekDCqu908uM9RxwdIOTJPfIOoJ0qM7 olUDZeMcTK+xDLMjY7nnt7QyJRMxFBEur/3lWa6RpppYzqRMqP/zBQt0HtXF/cwzcsrb PQTA== X-Gm-Message-State: AOJu0Yz3HFofVpPDxtCk3wr8O9H1DvM8TUsA+DNpiWdLIE0k6W99Zue6 5bxDnQeH558i6P+KgTcrO7UVHKNiU5/2NY0M39bp5aq/nB0OnB0r X-Gm-Gg: ASbGncvxxTXbqrrCJ3LEilLPMbS2Ows4iHL8tzp1Nm9FQMxRIrQrQrr2Tfmpams02ku INlxolIPkCWh6ZWOy4wJw9QIF+I8FXE2JEYTBOPjwzaBVfWhSLf6i+bymLPSyvAlOGgWObjyDNt lm5TZsa+zLG30q4oIem92LFb/RA8wBrZKmgUI98nZVJc3MjgUj+uqkUIUs36MJtTn3KWNtKr+Nt 4Z450Nbv5B5Tnx9ay80qhido4UqYVEh7y7hzcTib/k0CWV9uHiRJiNu78jVpuPBxyKxk+5gM8C7 HdYrKVaWkr+J X-Google-Smtp-Source: AGHT+IEBfHhoEboIFXrkkEYAZjqwLfWc+FKhXLEMsbNUo9RWWpGzOVxGtp+OnSaoRet6EvhqvVwJQQ== X-Received: by 2002:a17:90b:3b8a:b0:2ee:cd83:8fe6 with SMTP id 98e67ed59e1d1-2f9e084fc9dmr9497388a91.35.1738833163896; Thu, 06 Feb 2025 01:12:43 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f9e1d5ff86sm3380257a91.3.2025.02.06.01.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 01:12:43 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Subject: Re: bug#63508: [PATCH] gnu: eudev: Look for rules in /etc/udev/rules.d In-Reply-To: <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> (Liliana Marie Prikler's message of "Thu, 06 Feb 2025 06:28:45 +0100") References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> Date: Thu, 06 Feb 2025 18:12:30 +0900 Message-ID: <87jza38mip.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Wilko Meyer <w@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Liliana Marie Prikler <liliana.prikler@HIDDEN> writes: > Should this still point to "core-updates"? > > Am Donnerstag, dem 06.02.2025 um 11:38 +0900 schrieb Maxim Cournoyer: >> Prior to this change, only the udev rules installed to eudev's prefix >> were consulted by tools such as udevadm, leading to problems such as >> when configuring network interfaces, or attempting to override its >> default rules. >>=20 >> While our custom eudev patch adding support for the >> EUDEV_RULES_DIRECTORY environment variable could have been refined to >> take precedence over the package's configured udevrulesdir, this was >> not pursued for the following reasons: >>=20 >> [=E2=80=A6] > Now, we are losing some flexibility by removing the environment > variable, but if that's what Nix does, it's what nix does =E2=80=BE\_(=E3= =83=84)_/=E2=80=BE I sense some potential sarcasm here; if so, did you consider also my second point, which was: > 2. Users would have had to set EUDEV_RULES_DIRECTORY to the fixed > directory themselves to have udevadm work as expected, which is > inconvenient. We could also leave the patch in, to let potential users continue making use of it, but being undocumented in a custom patch that we haven't upstreamed, used only in the udev service and not in any search path, it seems likely very few people knew about it (and we'd have to rebase it from time to time, for dubious value). I'd suggest if this feature really is important, we could rework the patch into a EUDEV_RULES_PATH, making it a true path accepting multiple entries, and try to have this upstreamed. Then we could have a nice search path specification for it attached to eudev. How does that sound? --=20 Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 05:28:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 00:28:30 2025 Received: from localhost ([127.0.0.1]:53811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfuRC-00032U-78 for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 00:28:30 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:50295) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1tfuR7-00032C-UI for 63508 <at> debbugs.gnu.org; Thu, 06 Feb 2025 00:28:27 -0500 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-43690d4605dso2825085e9.0 for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 21:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738819700; x=1739424500; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=oOzVmpVG+mwNC90qJFc082NT1EUzxmOug6KIeXDEq7g=; b=hw3CkySIMUTy/H3t8rUVPx8zjCJ2x+Br2MIHUp1IShaqTeziT/jJ6yaigl/+eyF36B fStBMqvMdf+u39ZNZSfwwdgBemXoecTYv9Z8TOvKeHoJhmmn7AkHUE1UroKN3mUR5c0x 9Nzk4iJsASbOqXCCukcrY0XkcvK5bl/rx0clzSUFZQygZ+7UV49wzIi41mQnay1xHC9R r09zbeqG3qTg/pXxEf9MzfShVFvV8iqQNMV/gSmsyqdrMTTA5dVnnF8hce2qe2iqP29E BpTUvl8c8pHi6mlys/1E2zwmtLZrJoFPNdujR380VOeuXPULgtTcVG8j2q0d3rgDjSwN p/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738819700; x=1739424500; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oOzVmpVG+mwNC90qJFc082NT1EUzxmOug6KIeXDEq7g=; b=eCsrpTr9OMVaNSVvyMfZcybO1Oy8ooOKNtBPQHfqr1K3sNOJhkyvlK4iWfQsu5l7uy uW1X8x74EyGa/QPADc2YqNF5+gN054OnII62XKiztVfTqxR6LO3lCX86QZBsPpOmFDOm wR6JBvNnlMoetLy9kBJ5VKBIVyanROwWcAGq0UOSeh0cB0yauXv2c/gGa934OikwwAkg /dfeS6iMFmE4r/4jgNyxUOJFSxIaS3vgBxsfJa3wf4tPRDXO4hTHVFCJqT95EkZLodUN WkkyEZVZ0e+oXxyqiWejzx8PCd3s3BlVpy45qs6hSXOrPwjeuEGoF1XY38BlC8MXDbwz MxyQ== X-Forwarded-Encrypted: i=1; AJvYcCUVIq/I6LKx6FxvAba1J5gNv9XogCqrG4XMEmIKD6rSpMPqRN6AYUG/auP+xDQNfzrZKNjtrQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YykQT4MpqZQ9hGJJDJPsT4RxxPHV4EYMmE4kL1dgDM+Q95JHZfm 0AOaKPrFzY2aG0DBBfqFQ6zudm46clO/3zDsqac07W0hwcQowzhu X-Gm-Gg: ASbGncuKj1V5OAd/fC9Uio5C47LLdrXJfJAsD86Ze3zGVVIo2hWZ9P3dj2th2/4nTVd ByA4YALUxDlpbAVqxHJ6I+ZpK7ik7syDoHxK6U8Tz2YUEHfI0IdRFyIakep+7DjGEI6wnYkj1cd 2hocdU37ERXmzKelm8VRSIyWLUkkb64B5wAfDBzlSRq8FQD6/tILCW6XI8+aCO4XatBFi9rrucL LQq8PbqdNN5xHA0cK6oqbhJUI9UQ5bvDvhYWU0EAiDvSuJSq30/nE+GwE9mbnEFKxiB2DaUIIW1 JrIC26NzsWP3rZ5D0yGozGfARqLOkBbSV9fXMS8WJH3u4fbDp17BH7s9QH5wa5Sytow= X-Google-Smtp-Source: AGHT+IGrRu8HZ1XzwSZkY0jl4DQSat9PLrSIENqMh5D2C6Qj56QtYhloJO5dgDADrwBoQ3aj3voqQg== X-Received: by 2002:a05:600c:1c9d:b0:434:a7f1:6545 with SMTP id 5b1f17b1804b1-4390d5a3a0fmr42099565e9.27.1738819699431; Wed, 05 Feb 2025 21:28:19 -0800 (PST) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4391dc9ff10sm6888095e9.12.2025.02.05.21.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 21:28:19 -0800 (PST) Message-ID: <4993fa8d776a6c488f8ea0529d8a145db8c96042.camel@HIDDEN> Subject: Re: [bug#63508] [PATCH core-updates v5 0/3] eudev: Build with udevrulesdir pointing to /etc/udev/rules.d From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, 63508 <at> debbugs.gnu.org Date: Thu, 06 Feb 2025 06:28:45 +0100 In-Reply-To: <cover.1738809478.git.maxim.cournoyer@HIDDEN> References: <cover.1684100044.git.felix.lechner@HIDDEN> <cover.1738809478.git.maxim.cournoyer@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: Wilko Meyer <w@HIDDEN>, Bruno Victal <mirai@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Leo Famulari <leo@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Should this still point to "core-updates"? Am Donnerstag, dem 06.02.2025 um 11:38 +0900 schrieb Maxim Cournoyer: > Prior to this change, only the udev rules installed to eudev's prefix > were consulted by tools such as udevadm, leading to problems such as > when configuring network interfaces, or attempting to override its > default rules. >=20 > While our custom eudev patch adding support for the > EUDEV_RULES_DIRECTORY environment variable could have been refined to > take precedence over the package's configured udevrulesdir, this was > not pursued for the following reasons: >=20 > [=E2=80=A6] Now, we are losing some flexibility by removing the environment variable, but if that's what Nix does, it's what nix does =E2=80=BE\_(=E3= =83=84)_/=E2=80=BE Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 05:15:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 06 00:15:39 2025 Received: from localhost ([127.0.0.1]:53786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfuEl-00018q-0N for submit <at> debbugs.gnu.org; Thu, 06 Feb 2025 00:15:39 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:48840) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1tfuEi-00010N-LK for 63508 <at> debbugs.gnu.org; Thu, 06 Feb 2025 00:15:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=9kYYDimTmILlSuf yPmOEydQvwtViLvdAQ6OQkHZNJ1g=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=U6YW7il1UzP8DzdPvm4JuCbrcyHZKVNQAB+7uJ7w Tc4WVRVcJGDA7sNRivuhQ5LaQBBFViYw+y4l+ery9jg0B1VFKhXuX21cZJy1vv3arfeikE AfRcMO01llkLC6VxBoo7Z8SDfM9vhD3MpIpOyMNUTag4Eus3alUuQIAWRKKQM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id d60ed9c6 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 6 Feb 2025 05:15:33 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <87seoraieg.fsf@HIDDEN> (Maxim Cournoyer's message of "Thu, 06 Feb 2025 11:58:31 +0900") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <874j188pid.fsf@HIDDEN> <87o6zgbdqp.fsf@HIDDEN> <87seoraieg.fsf@HIDDEN> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 05 Feb 2025 21:15:32 -0800 Message-ID: <87cyfvbqmj.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Liliana Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxim, On Thu, Feb 06 2025, Maxim Cournoyer wrote: > I've taken a look and came up with v5. Thank you so much for working on this! I can't believe it. Someone please pinch me! Kind regards Felix
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:58:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 21:58:53 2025 Received: from localhost ([127.0.0.1]:53494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfs6P-0006qc-3W for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:58:53 -0500 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:46334) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tfs6M-0006qL-9K for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:58:51 -0500 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-219f8263ae0so9561355ad.0 for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 18:58:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738810724; x=1739415524; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BpqQjHBhzlFv8TLJIkKpmLWQf66QBnMQEZGPjmop61Q=; b=bOewwyUqQvWjzV70dsF6AnZJfGTqs9VZ6xDl0iiSBhsinM4hyoQowoJvn8+Qgowx0C Eohrq9AeO3zp3Cd5BtPl01VKZZg3CdwAXWWjZmy2kpi6gLqxfxjhe44bi4xNIIM60cjx tDaOUl0Nwk3LJw1THvTiP9xYcM0APis3a4qrcuRa7NEOw0/uIzxmH7zxR7sgtSUc22Vw sxw9csrD1y5R6iqoVXbuXhTZX1tENh8mUBS3K7FKEUF97xD6bNExa26fnfXCHJ7A2VRi po7IrrjXLjtX1pIiZ8DXdC6eRWh+xvcPhvLu261+L71GwH4gI0TWbh9kCZEof3u3I1Wo qyMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738810724; x=1739415524; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BpqQjHBhzlFv8TLJIkKpmLWQf66QBnMQEZGPjmop61Q=; b=iG7P3+v1dS59dm08F+c2pAKqracZU9SCfSC27u+KC5B+df8ee0S9lAG0FdKDzVCHff 9wWzjcORdX8+79J8CLaxXN1p2OueC1e47twmAfTPkHv9WSLMdUcHbAFMAE4iuRYFeaOY 7a7cxUqgfdaHAIZkPY9rEe0TgvdRJt6KGr6pyaTDu8mAWg7rvHXv+AYYuAnvanIU77/d Zkql9jbBYIbpgnN/PQ0tE8kFcHyJ20UlzBOXUbm5m8JoD9wO7bwJe1yz3t456BKh5QRU lUhsPW18Smhp5HJsH4qU59sUxQAxC0i+DewZKQPRrNqsj1BYpGqYR327lxTHOLbGWF9j 2euw== X-Gm-Message-State: AOJu0YwN4yVrn1S2NOdEKp3eJz4PDbYgNk62yVbdVHEGXb4wVZAHzy39 IRL2x8YjYOg9cxuBFONqyuf8xA+D8j25+av/FW52NdxHueeGCa9O X-Gm-Gg: ASbGncu0VXz40oT24biPjk78DdpuHRHtdJiK+S7b1SDZNEFku0DuYPN3/2C4l9a8juI UML4f9IRJjvJRrJ8cw6kFl6Vgwl7c1lM91+hD0v2sP4P3yRizdBbQfitekYonbFdD2j21HArU9M 3vN+9I1XGYliRvm7IGeB88NcA/hzSeuon57T42+K9HDMmjiM7nGNamWC5bFcmGcOpWlTdkEbHZh VVZGeu90q7DkbhTZmTuROlEGAhdN/owMtWHnJ2pFKgSpnCC/ZZZwn6OnDx6BZTYa6byZvUJRAgK orHnAao5OUze X-Google-Smtp-Source: AGHT+IHJ9K8w45IfEVokAfhDZMwShIvDEMunJMa+0zDIac/hJasms0fmdfkTIvTspARcLOPCIBeUUQ== X-Received: by 2002:a05:6a21:78a6:b0:1e0:d934:6189 with SMTP id adf61e73a8af0-1ede88afa37mr11747352637.31.1738810723883; Wed, 05 Feb 2025 18:58:43 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ad51af649d2sm135131a12.56.2025.02.05.18.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 18:58:43 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <87o6zgbdqp.fsf@HIDDEN> (Felix Lechner's message of "Wed, 05 Feb 2025 07:41:34 -0800") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <874j188pid.fsf@HIDDEN> <87o6zgbdqp.fsf@HIDDEN> Date: Thu, 06 Feb 2025 11:58:31 +0900 Message-ID: <87seoraieg.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Liliana Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Felix, Felix Lechner <felix.lechner@HIDDEN> writes: > Hi Maxim, > > On Wed, Feb 05 2025, Maxim Cournoyer wrote: > >> It's something to be left to users to choose for themselves based on >> their own needs. > > You misunderstood. The patch merely allows users to choose > ID_NET_NAME_MAC. > > It does not change the default naming. > > Eudev on Guix is broken. It does not look in /etc/udev/rules.d even > though that's where udev-rules-service installs its rules. > > The confusion arose because v1 changed the default, but I realized > quickly that it went too far. Please have a look at v4 from May 2023. Yes I was answering to v1. Regarding v4, I've taken a look and came up with v5. -- Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:39:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 21:39:17 2025
Received: from localhost ([127.0.0.1]:53449 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tfrnQ-0005wf-R1
for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:39:17 -0500
Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:55673)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tfrnL-0005vv-3c
for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:39:14 -0500
Received: by mail-pj1-x1035.google.com with SMTP id
98e67ed59e1d1-2f9cd9601b8so639694a91.3
for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 18:39:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1738809544; x=1739414344; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=J45r67ZX2jsJtvHGocn8kUHyz6fGXjxbvJe/UNjG4yU=;
b=lDJ7TQJHAyfbDJGUVTfyrkUWCuHIoZbbXPX3YoChVc7hF+OGcbD6Mg+yNCI0/fIvI7
UWVRQ08NHDL+hdfsJSZdh9/ib++rToQiKRcJQJ9N656D0b+sZ3tzKK6aTmGfqOrw+N2b
6/y+70Heq7AUoY4qBAoTZHlcd7ZrqBquV3NrPRE+EibnIb4pJgeOERrZZnbry6Jx0I4l
6F6qH3kIVIDhESeDUebAYZkDXnHtWn9OFYnZeQjCTiRWm1hl2flg+LaVHZ1ZFzRpTQGh
eLyq97FsDf6JgZyWLpPF4i9oD1XhPzwotJB3B2D6ASSHld0ueX6Xo92JwSyLqOgmlSf4
tdRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738809544; x=1739414344;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=J45r67ZX2jsJtvHGocn8kUHyz6fGXjxbvJe/UNjG4yU=;
b=BTeMoFZtY3KB1yRl2RIEQfTC6iuNRGua8VyOw9Qmk19+U7nqZDyOxbHeCwMSL58dlQ
1RVvx+8g6wT+tktB1C+q6p8AjxFwVnAjSQAHnofwtZ7KI0SdoKhfTHsIvg0PLSfmrnfA
hK+G/+An/0hOr/48ClBOSeoqJBew/YcwEO+1Mde7f2S2mSxUNoPhJbKtZwWLV7UsmO7d
ZQBkadxBpUChhFR3D/XGji5c28ylCMLQPBz5YuM0wCy+zGdizDzPGpbFI0PDT0PJzqgI
PkU3IgyyJ+XdujiHF+e3vM7GjpcsICsR6XkGaQaNyExTM1TKwAa2NLq7PYI7Pi4mGnv/
vPkQ==
X-Gm-Message-State: AOJu0YzBFjVepcZbhjhKjpM83Zy3nAF9TpphiKCA4xNgHlDJDReGcyn5
zsjxrSa1nJ0ierM02BvGMXd88+aQTq5omgH7zUyUoJ0YycXzLQ7XB51aZw==
X-Gm-Gg: ASbGncvSL1eWRQuC9Pdj8lBC9boZ4BvpTtmmMxufVvhIVJwmaxa4cKe8/h4JA68SkCV
XpdtUPmVOqHhKfUyz9fniPNJaj50ox20U5O2ilu/EWflOHafZV1h9od6uSS/AlaFhRIqVPcYRuI
6XKomj8HCfvFY9yLRM9wKbUV8jwtA/ZB9Cvn+JEfNJhHIMauz9UPWqZSvWxP/0KWIxsw9ufeBHQ
jmIjDXNZS+gJGLP5uBLW/jOq0igTRNB+C/1xyb4r7+KOMN4nobgDErLgA3bB//X6YoG2vJIbt/n
KwSfEozvihNzLsoEUZD+JzN8pMz0BwjB8A==
X-Google-Smtp-Source: AGHT+IEjGP0xivT7QBvggWoV4OlbflLi8xNhQ3zsO6TC87coh4iliNzU02x5Syww8yox0HMih9LQXg==
X-Received: by 2002:a05:6a00:a81:b0:72d:3861:895c with SMTP id
d2e1a72fcca58-7303511d196mr9141174b3a.8.1738809544317;
Wed, 05 Feb 2025 18:39:04 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73048ad26c5sm179362b3a.46.2025.02.05.18.39.02
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 05 Feb 2025 18:39:03 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH core-updates v5 3/3] gnu: eudev: Build with udevrulesdir
pointing to /etc/udev/rules.d.
Date: Thu, 6 Feb 2025 11:38:08 +0900
Message-ID: <dfebb023dfbe4c1e8489a662f09a1e98fa0070fb.1738809478.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
References: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Felix Lechner <felix.lechner@HIDDEN>,
Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Bruno Victal <mirai@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Leo Famulari <leo@HIDDEN>, Wilko Meyer <w@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 63508
Cc: Felix Lechner <felix.lechner@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Prior to this change, only the udev rules installed to eudev's prefix were
consulted by tools such as udevadm, leading to problems such as when
configuring network interfaces, or attempting to override its default rules.
While our custom eudev patch adding support for the EUDEV_RULES_DIRECTORY
environment variable could have been refined to take precedence over the
package's configured udevrulesdir, this was not pursued for the following
reasons:
1. Due to eudev's using inotify to detect new rules, the EUDEV_RULES_DIRECTORY
is fixed in Guix System, per commit e9fa17eb98 ("services: udev: Use a fixed
location for the rules directory and config.")
2. Users would have had to set EUDEV_RULES_DIRECTORY to the fixed directory
themselves to have udevadm work as expected, which is inconvenient.
3. This simple solution is already implemented and tested in NixPkgs.
* gnu/packages/linux.scm (eudev) [source]: Remove custom patch.
[arguments] <#:make-flags>: New argument.
<#:phases>: Override install phase to alter installation make flags.
* gnu/services/base.scm (udev-shepherd-service): Do not set
EUDEV_RULES_DIRECTORY environment variable.
* gnu/packages/patches/eudev-rules-directory.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): De-register it.
Fixes: https://issues.guix.gnu.org/63508
Reported-by: Felix Lechner <felix.lechner@HIDDEN>
Change-Id: Ib8698f4b452f6fd0951bcd71831705b1be85e6e0
---
Changes in v5:
- Use #:make-flags to configure udev-rules.d prefix
- Remove now unused eudev patch
gnu/local.mk | 1 -
gnu/packages/linux.scm | 31 ++++++++++++----
.../patches/eudev-rules-directory.patch | 37 -------------------
gnu/services/base.scm | 1 -
4 files changed, 23 insertions(+), 47 deletions(-)
delete mode 100644 gnu/packages/patches/eudev-rules-directory.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 83abc86fe2..16978da169 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1240,7 +1240,6 @@ dist_patch_DATA = \
%D%/packages/patches/erlang-man-path.patch \
%D%/packages/patches/esmini-use-pkgconfig.patch \
%D%/packages/patches/esmtp-add-lesmtp.patch \
- %D%/packages/patches/eudev-rules-directory.patch \
%D%/packages/patches/exercism-disable-self-update.patch \
%D%/packages/patches/expat-CVE-2024-45490.patch \
%D%/packages/patches/expat-CVE-2024-45491.patch \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index e95d8587b4..f4e9e30a75 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4543,12 +4543,14 @@ (define-public eudev
(file-name (git-file-name name version))
(sha256
(base32
- "1f6lz57igi7iw2ls3fpzgw42bfznam4nf9368h7x8yf1mb737yxz"))
- (patches (search-patches "eudev-rules-directory.patch"))
- (modules '((guix build utils)))))
+ "1f6lz57igi7iw2ls3fpzgw42bfznam4nf9368h7x8yf1mb737yxz"))))
(build-system gnu-build-system)
(arguments
(list
+ ;; The binary should be built to look for its rules under
+ ;; /etc/udev/rules.d, which is where the udev-shepherd-service keeps
+ ;; them.
+ #:make-flags #~(list "udevrulesdir=/etc/udev/rules.d")
#:phases
#~(modify-phases %standard-phases
(add-before 'bootstrap 'patch-file-names
@@ -4592,7 +4594,20 @@ (define-public eudev
;; such that Libtool looks for it in the usual places.
(substitute* (string-append #$output "/lib/libudev.la")
(("old_library=.*")
- "old_library=''\n"))))))
+ "old_library=''\n")))))
+ (replace 'install
+ (lambda* (#:key make-flags #:allow-other-keys #:rest args)
+ ;; Although the runtime udevrulesdir is set to
+ ;; /etc/udev/rules.d, the package should provide its default
+ ;; rules under $libdir/udev/rules.d.
+ (let* ((default-udev-rules.d (string-append #$output
+ "/lib/udev/rules.d"))
+ (make-flags (cons (string-append "udevrulesdir="
+ default-udev-rules.d)
+ (delete "udevrulesdir=/etc/udev/rules.d"
+ make-flags))))
+ (apply (assoc-ref %standard-phases 'install)
+ `(,@args #:make-flags ,make-flags))))))
#:configure-flags
#~(list "--enable-manpages"
;; By default, autoconf uses $prefix/etc. The udev-service-type
@@ -4600,9 +4615,9 @@ (define-public eudev
;; descriptions.
"--sysconfdir=/etc")))
(native-search-paths
- (list (search-path-specification
- (variable "UDEV_HWDB_PATH")
- (files '("lib/udev/hwdb.d")))))
+ (list (search-path-specification
+ (variable "UDEV_HWDB_PATH")
+ (files '("lib/udev/hwdb.d")))))
(native-inputs
(list autoconf
automake
@@ -4620,7 +4635,7 @@ (define-public eudev
;; When linked against libblkid, eudev can populate /dev/disk/by-label
;; and similar; it also installs the '60-persistent-storage.rules' file,
;; which contains the rules to do that.
- (list `(,util-linux "lib") ;for blkid
+ (list `(,util-linux "lib") ;for blkid
kmod))
(outputs '("out" "static"))
(home-page "https://github.com/eudev-project/eudev")
diff --git a/gnu/packages/patches/eudev-rules-directory.patch b/gnu/packages/patches/eudev-rules-directory.patch
deleted file mode 100644
index c4b1cfae39..0000000000
--- a/gnu/packages/patches/eudev-rules-directory.patch
+++ /dev/null
@@ -1,37 +0,0 @@
-Add $EUDEV_RULES_DIRECTORY to the list of rules directories.
-
-The old udev 182 supported $UDEV_CONFIG_FILE, which in turn allowed
-the search path to be customized, but eudev no longer has this, hence
-this hack.
-
---- a/src/udev/udev-rules.c
-+++ b/src/udev/udev-rules.c
-@@ -48,16 +48,11 @@ struct uid_gid {
- };
- };
-
--static const char* const rules_dirs[] = {
-+static const char* rules_dirs[] = {
- UDEV_CONF_DIR "/rules.d",
- UDEV_RULES_DIR,
-- UDEV_ROOT_RUN "/udev/rules.d",
- UDEV_LIBEXEC_DIR "/rules.d",
--#ifdef HAVE_SPLIT_USR
-- "/lib/udev/rules.d",
-- "/usr/lib/udev/rules.d",
--#endif
-- "/usr/local/lib/udev/rules.d",
-+ NULL, /* placeholder for $EUDEV_RULES_DIRECTORY */
- NULL};
-
- struct udev_rules {
-@@ -1718,6 +1713,9 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names) {
-
- udev_rules_check_timestamp(rules);
-
-+ /* Allow the user to specify an additional rules directory. */
-+ rules_dirs[3] = getenv("EUDEV_RULES_DIRECTORY");
-+
- r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs);
- if (r < 0) {
- log_error_errno(r, "failed to enumerate rules files: %m");
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 654e9479f2..36fef00457 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2545,7 +2545,6 @@ (define (udev-shepherd-service config)
(list udevd)
#:environment-variables
(cons*
- "EUDEV_RULES_DIRECTORY=/etc/udev/rules.d"
(string-append "LINUX_MODULE_DIRECTORY="
(getenv "LINUX_MODULE_DIRECTORY"))
(default-environment-variables)))))
--
2.48.1
felix.lechner@HIDDEN, liliana.prikler@HIDDEN, mirai@HIDDEN, maxim.cournoyer@HIDDEN, leo@HIDDEN, w@HIDDEN, guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:39:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 21:39:11 2025
Received: from localhost ([127.0.0.1]:53446 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tfrnL-0005wL-6h
for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:39:11 -0500
Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:57453)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tfrnH-0005vS-7Y
for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:39:07 -0500
Received: by mail-pj1-x1032.google.com with SMTP id
98e67ed59e1d1-2f9b91dff71so530289a91.2
for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 18:39:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1738809541; x=1739414341; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=mxLlK0nu7D+q80CvU5ygc6t+/Oi7+qQIr03f00Fmwlg=;
b=Db9dhu4qm2devaAJMERQJjy7s6jbZgsw1scMRDEnUnoRLEWwFlgVYmnfodkvegQYnO
oQDLC1sfoBhSiqCTS1SFavPPu+BEE2/eIBuDrnryhPhuSStsCIGyX3p8cvGTknyP7GI1
jDwNpyEmJkw81PqrE8MQmSUTUgH8nFg6Zy8yMNaT1QVZNd+70QfAW93+xLTpfVxSTW9+
ZomW/X0NuHrXujp3rHgndB+XrCKQTvyltnO6IOQH+JVrDxho93SGyjBiZvuf3nq2DfPF
25JjPLG4wOWvc2c4A8UaRMKPQ48/FURDdyEd7NGi9+JD/9a4uj1q02D78F4erpkgReUP
s58Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738809541; x=1739414341;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=mxLlK0nu7D+q80CvU5ygc6t+/Oi7+qQIr03f00Fmwlg=;
b=xQ4wekJIi+PLCsYkcBZ+DxMDptwr1zgxUCWSsLmu4pZIrR61pFpMnw+9w25dId3/EV
miaIt4i+fKJlOOAqxaUKR8ZGl/J/jyLdBg50JhNPTxewqDcsa597Syifi07By9jeg4uz
UZ/asAgqsR3cAEqQbSqs7GZ93hUvuMpozYb6aM9vWV2gmajCqySZl8PkiQ0UD1ubDtMY
D9vK34gxkU6SnHiovsxRArvHdv+WJnRPvn7E1pIYFH2H3kk6yknQxLae8i5JT+gBWWjm
N1WSV5ofa2xuzDSNofygVrKhcUNO7t1sVRIk9tNFZWZvVqGkGDAtPZFGGL5+GYZFo0Sy
NM7Q==
X-Gm-Message-State: AOJu0Yy25nhD38D2s7VKjIBD9z3aTBStilXotEv27T1vGt+yXhEQXM7Q
tXiPJRVCkChAlBxjWEPbZPEVcf6i1VnCZJ6y48tEMevZ/nrhc71i36P09w==
X-Gm-Gg: ASbGncvdl5gfpamcwSD3zcv5f0JnRiS+v3ecj5zC8i5LR7l/1i1gmVwHHUHnkmcDcp8
efELhGddWS91Sq2elIN9Ifu+7uT8vpNd4h5kgc7r4Nx4NSl+LnJ4+dwhnhmhcfwh00XqjE43OiL
7xlfg2Nk7NWKb+y0N1aW2Fj0vcjA9B+tziRhvp/7e8xCBTgaZoRq43A8iGWlYBqyrcjWQlpcmj1
UXCJqelNjNXJG10rXMnX3zILgh0ZUocLvTPwyFy+PiCk2PcNDMcNeZj8KgjAVN2V9I/LoUcatyi
kQyz7MsPNs6bR0rRLC12uSUVVZlBedfoWA==
X-Google-Smtp-Source: AGHT+IG/J7RTNw9A/msYjmz1GSzpg1GL8TiGQEPw0ZjqMdyfW3WDMQGLBJXa56fiHkxJclk+wnZXzA==
X-Received: by 2002:a05:6a00:1d81:b0:728:e745:23cd with SMTP id
d2e1a72fcca58-730350fe222mr10157297b3a.3.1738809540687;
Wed, 05 Feb 2025 18:39:00 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73048ad26c5sm179362b3a.46.2025.02.05.18.38.59
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 05 Feb 2025 18:39:00 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH core-updates v5 2/3] services/base: Remove extraneous
UDEV_CONFIG_FILE environment variable.
Date: Thu, 6 Feb 2025 11:38:07 +0900
Message-ID: <48cd1aee0a5b0e140f003e04ac31bd374f0f07bb.1738809478.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
References: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Felix Lechner <felix.lechner@HIDDEN>,
Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Bruno Victal <mirai@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 63508
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This environment variable used to be honored by udevd, but that is no longer
the case (as shown by grepping its source).
* gnu/services/base.scm (udev-shepherd-service) <#:environment-variables>:
Remove UDEV_CONFIG_FILE.
Change-Id: I0828de76e8da429432bc0679903aa501c99625af
---
(no changes since v1)
gnu/services/base.scm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 7331c030d7..654e9479f2 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2545,9 +2545,6 @@ (define (udev-shepherd-service config)
(list udevd)
#:environment-variables
(cons*
- ;; The first one is for udev, the second one for
- ;; eudev.
- "UDEV_CONFIG_FILE=/etc/udev/udev.conf"
"EUDEV_RULES_DIRECTORY=/etc/udev/rules.d"
(string-append "LINUX_MODULE_DIRECTORY="
(getenv "LINUX_MODULE_DIRECTORY"))
--
2.48.1
felix.lechner@HIDDEN, liliana.prikler@HIDDEN, mirai@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:39:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 21:39:09 2025
Received: from localhost ([127.0.0.1]:53442 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tfrnI-0005wA-Mx
for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:39:09 -0500
Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:60589)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tfrnF-0005vL-0R
for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:39:06 -0500
Received: by mail-pl1-x62d.google.com with SMTP id
d9443c01a7336-216728b1836so8130355ad.0
for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 18:39:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1738809538; x=1739414338; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=hdUUkEQOZTJPrmxfVJMw/BOTZCGUGUrpzFJ4qYMixpk=;
b=PJkd3kHNlZh3Gu5s5+VRwGE0w+WKq35neNcxSovNBaoSZIUnclg346RXfilqYfWtGg
6ap1D/oit++UAV1zIFUfzD4oCpUNfLRfyYf/uIni0gWm1T+duF8IaXwtygMY8MN3yuAv
FSE2kn+1KvziFoWP3YbkjX2M56KvjWA0gPECGY7dWaIwO/Kpke9OkJhlmrROZf7oPsBe
X6A6WlB3u29bt3hNuRK0SwcHBt4fS9Ua9YrzvgHC3RG+/wkG74rCHIYCnMAbcACToOLI
gM6ysxLcAirv+R1DCoWuoE3zqweC6qoPbIG9fPwug9xIHw4+DNCBzAsm1VWsJi79qz98
GZpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738809538; x=1739414338;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=hdUUkEQOZTJPrmxfVJMw/BOTZCGUGUrpzFJ4qYMixpk=;
b=vTaLHNfIdWw7sOX/0vtF4AAnvrMplpb+P8Fj999vxYsvN9/reb9ftCdX6tulmnWggd
Nj/kKGyHRUJugEu2+FIlWqkm6i71VP15wkZQId2yjX8JJWW/q5es3ToC8UP0GDgmVnSX
0INQqgQitqKbQ3gskpzaJG/9qDbbTZPKB1wONq+Z+DndxaCuOd6x3v99Wfd2uk6WRD9x
Iyl/CxfB9txfo0JdwHYuzgspcxqpJQLzaX/ZYaZRRfr3AxY/oIRteirFVdji2f18ym2I
0ZHxDNTezV1py/hQ/QvvJc/MZT9yqTEtz7O+Ez294HmIcAJ1bKc7XpfZ6K0Xj2zTlQ7j
Cnsg==
X-Gm-Message-State: AOJu0YxVEOI39WBqcqks5jMu23DUj9Scur3i5jQhPrXGrvnAdzYNvw6x
jiGJZgSG2nZepA5F3Oi2zCVTkAVzjc/+VEc7DAeyS9wmxm3dVLeDnngL2w==
X-Gm-Gg: ASbGncvdEgUQBu9WJaXr+Nz+8U/8ywRJ9+bQ1OoYbCQT9LfZaIhsI41k+4Jc9AzuNzv
ucL/S/ENrX/cAPnavmayUkaCKrl3Qi5OQpunHWAYEGmXxrFCEwGPZcBh02veN69L0e4Ivu6PcnB
rcDfZWC2ryl1wCsrrH3DwIqglT0ElHxLW4alqCroSUdsfkJ/cH9Z4WMUlNYQlMJvuZnFNhvkCFN
irJWCtbBKCRLtqoHdXg9vqn0F1b01uAtTg6xj2zkD/LH1MRqw68lPg2hxzEQzmVAh6oEpzSyccY
B3CsM9SJOUkrFv09SvqTfWUK8q/qgoubdQ==
X-Google-Smtp-Source: AGHT+IFoGJhokyKyCy4AuvXXa0e8HdkCQkjKQKfJSNjl3d/YFULF0Li9sZwmF00sh/51cq+sghxgjg==
X-Received: by 2002:a05:6a00:4648:b0:725:db34:6a7d with SMTP id
d2e1a72fcca58-7303521c76dmr8090296b3a.23.1738809537224;
Wed, 05 Feb 2025 18:38:57 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73048ad26c5sm179362b3a.46.2025.02.05.18.38.55
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 05 Feb 2025 18:38:56 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH core-updates v5 1/3] gnu: eudev: Use new project URL for Git
repo and home page.
Date: Thu, 6 Feb 2025 11:38:06 +0900
Message-ID: <a4c0ebaa0f8055453187509a940b5161fcaf6341.1738809478.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
References: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Felix Lechner <felix.lechner@HIDDEN>,
Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Bruno Victal <mirai@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Leo Famulari <leo@HIDDEN>, Wilko Meyer <w@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 63508
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Felix Lechner <felix.lechner@HIDDEN>
* gnu/packages/linux.scm (eudev): Use new project URL
https://github.com/eudev-project/eudev for Git repo and home page.
---
(no changes since v1)
gnu/packages/linux.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 5c48aa7320..e95d8587b4 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4538,7 +4538,7 @@ (define-public eudev
(version "3.2.14")
(source (origin
(method git-fetch)
- (uri (git-reference (url "https://github.com/gentoo/eudev")
+ (uri (git-reference (url "https://github.com/eudev-project/eudev")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
@@ -4623,7 +4623,7 @@ (define-public eudev
(list `(,util-linux "lib") ;for blkid
kmod))
(outputs '("out" "static"))
- (home-page "https://wiki.gentoo.org/wiki/Project:Eudev")
+ (home-page "https://github.com/eudev-project/eudev")
(synopsis "Userspace device management")
(description "Udev is a daemon which dynamically creates and removes
device nodes from /dev/, handles hotplug events and loads drivers at boot
--
2.48.1
felix.lechner@HIDDEN, liliana.prikler@HIDDEN, mirai@HIDDEN, maxim.cournoyer@HIDDEN, leo@HIDDEN, w@HIDDEN, guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:38:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 21:38:55 2025
Received: from localhost ([127.0.0.1]:53434 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tfrn4-0005v7-V2
for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:38:55 -0500
Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:51570)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tfrn0-0005uo-2K
for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:38:52 -0500
Received: by mail-pl1-x632.google.com with SMTP id
d9443c01a7336-21effc750d2so7298735ad.3
for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 18:38:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1738809523; x=1739414323; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=1tpR/+QE+w8YcolRpBi+q7t1ni8/hePHFtcIeW9TCaY=;
b=TZbNH5tRdefspw33arBkRAWyNCgjdNhRS1sOTAEebwvepWidHiMqokDzxKbqiJ79p0
w3vcIYfxYut41/Z6RDjaxTX8aVlRvCuFQ8V06Z3FrQVCvxixWXZYqgvP/Hl/5TBffB9k
rYVtVRhAs2t2cFQb55lgDQECEBAp7OIKA0u33MdetxDHeRLNhcO0N+15RLxkOhfk40Wv
HLmII5JBtaDSjd8Vi59gAdhlXxHhIBxRczo0bdgd+N/92lppkBl3UNqhd+IM3JyDhzWf
74knL72BswwCi+Ez4S/PsECISJVz1qK3e6mrh5+BDpaaneG4aSQ+Z3cMOdDJ4MqU+Vep
Bxag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738809523; x=1739414323;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=1tpR/+QE+w8YcolRpBi+q7t1ni8/hePHFtcIeW9TCaY=;
b=Uuxb2heWky9wvwCzsTf3ZyB0ExE0vgB0hm8cqOoONIYDnbgEYTQy1c5LBEjhTK2xvU
VJBYuOHwvlwE/OmfVnBcnnHhzAUL91NAqtOIx9FW6F0T9N7M5Ck+YFoKWCr2XFWnSlKa
dxGmMdEAp0va/ilN0er5aJmUoJQ4i//CdWWbeipde+n7/wmhQPivCUTgfucIMp2zzfKi
zM76ZTYyOteeVJ+7g+oJorgb0zyrBVI3VPIorYPs+cBBbFKK+GJcOQA2FejR9F2b+zj8
6kpJyn0jR69DOXWZ0gXgEwI7tkPAmYcx3SwvUGxPfuvMQu/y5VDrFgDyVvSQdvAieF9A
Uvfw==
X-Gm-Message-State: AOJu0YxFU2I871sdt9LAp0YdFayTdXM0rmAgh7kKNs6BR5Y69QpdORUO
Ztfo1IcKRrsKXuc0sjxqNS9byo/AQC3qK5tDJVMgMdrnw4RVGao4SqesZg==
X-Gm-Gg: ASbGncttsNGrMkGutwupLzLG8ylp+kBZABJAFRfIav0k6vdA6ErbZ2ERP+Cp5ljYDZO
jA4it0TRe289Mg52B230NWCbEW02/SIJQ8JZoUtLZefxIlmAfAFQqVC4XMY4XrHdUgd/CJ6gGUH
8zyAbiYxkFvX+VgbSD8z3XEsc4uFihZ/db/s1WmDwgWhwKwG6dU+ojPyhymoItTFijrSWscuva2
X+B34vKauSRjYhWDpk9D3qLYzcbUh4hvy5uXb0JPOePULK4UncW05jG6rSmi7poEmAWbHj65+EK
2+vizOJal/YLlLWJ/1egRzE3MG3rbrAahw==
X-Google-Smtp-Source: AGHT+IE8RtJmCFwTDDGvpkF4upmMZzlLBUgcXBVIGG3UxJSefCftQjd44jfX7YRehOoaOWgU76evFw==
X-Received: by 2002:a05:6a21:32a8:b0:1e1:b60c:5bdb with SMTP id
adf61e73a8af0-1ede88b188emr8773630637.26.1738809523166;
Wed, 05 Feb 2025 18:38:43 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-73048ad26c5sm179362b3a.46.2025.02.05.18.38.41
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 05 Feb 2025 18:38:42 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH core-updates v5 0/3] eudev: Build with udevrulesdir pointing
to /etc/udev/rules.d
Date: Thu, 6 Feb 2025 11:38:05 +0900
Message-ID: <cover.1738809478.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
MIME-Version: 1.0
X-Debbugs-Cc: Felix Lechner <felix.lechner@HIDDEN>,
Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Bruno Victal <mirai@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>,
Leo Famulari <leo@HIDDEN>, Wilko Meyer <w@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 63508
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Prior to this change, only the udev rules installed to eudev's prefix were
consulted by tools such as udevadm, leading to problems such as when
configuring network interfaces, or attempting to override its default rules.
While our custom eudev patch adding support for the EUDEV_RULES_DIRECTORY
environment variable could have been refined to take precedence over the
package's configured udevrulesdir, this was not pursued for the following
reasons:
1. Due to eudev's using inotify to detect new rules, the EUDEV_RULES_DIRECTORY
is fixed in Guix System, per commit e9fa17eb98 ("services: udev: Use a fixed
location for the rules directory and config.")
2. Users would have had to set EUDEV_RULES_DIRECTORY to the fixed directory
themselves to have udevadm work as expected, which is inconvenient.
3. This simple solution is already implemented and tested in NixPkgs.
Changes in v5:
- Use #:make-flags to configure udev-rules.d prefix
- Remove now unused eudev patch
Felix Lechner (1):
gnu: eudev: Use new project URL for Git repo and home page.
Maxim Cournoyer (2):
services/base: Remove extraneous UDEV_CONFIG_FILE environment
variable.
gnu: eudev: Build with udevrulesdir pointing to /etc/udev/rules.d.
gnu/local.mk | 1 -
gnu/packages/linux.scm | 35 +++++++++++++-----
.../patches/eudev-rules-directory.patch | 37 -------------------
gnu/services/base.scm | 4 --
4 files changed, 25 insertions(+), 52 deletions(-)
delete mode 100644 gnu/packages/patches/eudev-rules-directory.patch
base-commit: 52c05f3b120e641c8bd2d68cfcf0d6af947de27b
--
2.48.1
felix.lechner@HIDDEN, liliana.prikler@HIDDEN, mirai@HIDDEN, maxim.cournoyer@HIDDEN, leo@HIDDEN, w@HIDDEN, guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:30:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 21:30:58 2025 Received: from localhost ([127.0.0.1]:53425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfrfN-0005cJ-H4 for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:30:58 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:55393) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tfrfK-0005c3-J9 for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 21:30:55 -0500 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2f9d627b5fbso633346a91.2 for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 18:30:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738809048; x=1739413848; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4LwGlqEbT7wCXAeHyfU2k4PCSwJjyjSTZvGrv7SKs8c=; b=NYo6Owrqc1y9gAakr4HuoQSf09jWXMyJtoSPS4IjHp0Vc2lyRM5g5QDTCrGxpBHakK 8JxDBaBptquupQgrYg/BfuZ2w8VruoevQJidKzIcSCQxRwgtFfcJ2pxXjMqAe/CT+CuC AuRuK985CFOnlUtPcCm807JReJQjx2xeS+L129K5HVmj3KbJV3Z58dVDQApKcjEqSKxF rlPVutpfVj5Z/NokaCxvwjZGQ9z305lDzpjqWaqMgo5FsZLMUMnSw2hGyVwa0W1f9Hp6 H4/+NnzV6HWXm0UHcYsGllJRKwYQKfd9mguRMC+3Qy/rYHK8KsXmyWmNGWwTEmAcTx1P w5xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738809048; x=1739413848; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4LwGlqEbT7wCXAeHyfU2k4PCSwJjyjSTZvGrv7SKs8c=; b=hkmhPS8GmvOjcvdtZITS8dCtRTYwuOIWKRlmQlAkhm+/fHB07Vnx3G98uxeJkL6XQm bKVqi/jN/1GbOAQ8uEpWIPS5Hk+UZ5skcmJYlzjsZcauQ3owY8nNMJAecSdDl6gofrVP 3RfkvSvLSX/rzNCjbog6BM6aBqPIpPYixAGewmHSAnpRu+i0ZM7hgJL5Gnj4cFQVzEql 9OLCwgHJ/wOF3LC5TdR/8q/6pKMZu11nq/4LO3KV8Fz1dMpOLmXVu8H8q0SEniSOAb2j R4O1tPQODyLa0WXW8fflc6mAeLzTc+uVVmDvkgwXlkuwPIn9WQxq292SizRMozexKs/A J0SQ== X-Forwarded-Encrypted: i=1; AJvYcCWVkFRZUFaBEiSnSXFzNxc4p/mjYJlGTJTTWKa22dKYmIibn8rT0cAW3hCy07sCQ3btfFDgCA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx55KVtMS2o9lAbLu4lzqnvoU8fb2GR2cTNkQNbSK2h+g/D0WWC bUTE2qJaPqRW/agKC+y8t+CD++d/6fDrAqpw8ohsrIa8Mx+TQg5X X-Gm-Gg: ASbGncsh3Utdpt+sWevA6v3TK6KjpiczhfzPUBWi9UdScdICwNP9rKooJwUKLIjbP1L YKPYtEO3YhwLw56QIMW/jZtMT2rntFskkmxcINKlnE03ADoQkrFpYKjBKzPU3piWoGGajkmO2Yq 7ZGrgjSZ7wiDxxmf3RrSBtRnUdtK5aHwdWcBreeXb9XNd9jvqX/6c+myTuHasaMlzFIHcwsiyA7 bYgQ7FyrT/Ul9HV9v8dLdfQDt+Z/iofZB7x6gBuUdP3jAPZ4AeM2vZFLovPsYJg5QcjD2N8WYg0 6FncZPzi4FuC X-Google-Smtp-Source: AGHT+IEF/IoeCnfiJK4qPWcwjjJcQnJXMK0k3kCg/ZXIUhbKSElDhe9/3CZFrROHos/5pfOZtUQZaQ== X-Received: by 2002:a17:90b:370c:b0:2f5:88bb:12f with SMTP id 98e67ed59e1d1-2f9e079b0admr6892272a91.21.1738809048174; Wed, 05 Feb 2025 18:30:48 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3683d535sm1020745ad.133.2025.02.05.18.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 18:30:47 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#63508] [PATCH v4 2/2] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) In-Reply-To: <CAFHYt54LpOV1oOJFRphDP8hduVCae68X0ytLw2iiSz3uobq8WA@HIDDEN> (Felix Lechner's message of "Mon, 29 May 2023 14:06:25 -0700") References: <d6fc82a44190d2c5b16d8f8f434102b68681ccfe.1685379443.git.felix.lechner@HIDDEN> <2d51ddd4e6865a40a15b8f7948d2479952571a4e.1685379443.git.felix.lechner@HIDDEN> <5543a014-6ace-f212-0dc2-046ef9e99086@HIDDEN> <CAFHYt54LpOV1oOJFRphDP8hduVCae68X0ytLw2iiSz3uobq8WA@HIDDEN> Date: Thu, 06 Feb 2025 11:30:35 +0900 Message-ID: <87zfiz7qk4.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Bruno Victal <mirai@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Felix Lechner <felix.lechner@HIDDEN> writes: > Hi Bruno, > > On Mon, May 29, 2023 at 1:28=E2=80=AFPM Bruno Victal <mirai@HIDDEN> = wrote: >> >> Perhaps instead of substituting, can you check if >> #:configure-flags or #:make-flags could be used instead? > > Thank you for that suggestion! I did, and I do not believe it is > possible to specify a separate runtime path for udevadm via > ./configure at this time. Turns out it's possible, and that's what NixPkgs does. I'll send a v5 soon implementing that. --=20 Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 5 Feb 2025 15:41:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 10:41:40 2025 Received: from localhost ([127.0.0.1]:51943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tfhX2-00073I-73 for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 10:41:40 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:36362) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1tfhX0-000739-2a for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 10:41:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=OPqhRYoiBOlJeXw ZBtoYayVz1+9Nnt/lprZqlfY72xk=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=HKTFAcs+DgU2SEwGyNgfDrczqPJSDsuB8zY+XNRd Yw8wbbqncwzcY+p1GrCSxK82Y++D7QZDWwdfHO5HyNQyjUz7cLDW6nxH5iTda//rNcaS2k EyIl/dnCVSfLnv0M9ii8GEJ7yJ9I6Pbz7cAvz/BbfoWk7M/PEWb97ZNkj+tdE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 42f48061 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 5 Feb 2025 15:41:34 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <874j188pid.fsf@HIDDEN> (Maxim Cournoyer's message of "Wed, 05 Feb 2025 22:55:38 +0900") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <874j188pid.fsf@HIDDEN> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 05 Feb 2025 07:41:34 -0800 Message-ID: <87o6zgbdqp.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxim, On Wed, Feb 05 2025, Maxim Cournoyer wrote: > It's something to be left to users to choose for themselves based on > their own needs. You misunderstood. The patch merely allows users to choose ID_NET_NAME_MAC. It does not change the default naming. Eudev on Guix is broken. It does not look in /etc/udev/rules.d even though that's where udev-rules-service installs its rules. The confusion arose because v1 changed the default, but I realized quickly that it went too far. Please have a look at v4 from May 2023. I have been using that patch in production in the two years since. Kind regards Felix
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Felix Lechner <felix.lechner@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 63508) by debbugs.gnu.org; 5 Feb 2025 13:55:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 08:55:59 2025 Received: from localhost ([127.0.0.1]:49135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tffsl-0003cR-6P for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 08:55:59 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:45524) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tffsi-0003cA-Qp for 63508 <at> debbugs.gnu.org; Wed, 05 Feb 2025 08:55:57 -0500 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-21f16af1f71so13341395ad.3 for <63508 <at> debbugs.gnu.org>; Wed, 05 Feb 2025 05:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738763750; x=1739368550; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=oIpkDavHv1mosrO35zWmOM/2kyS+6DaqY97DOGPHbr8=; b=HVr934rrYAocPfX3wQQ3egqYcsrLrqBUQtzahR4h7nWUsyLI/81evRvtqJ39fZYFhC myAHYFsDjGkSn8QxODq0BR/cDVBEVVtUhbbFM5uMR27WtGyW3yQtPXUJH8XmZqaeAVdZ L5E8sAri25G5Ji5E4fRY2z/VWnjXQYLSGdRh6zh8C3v23NWhxHxikcg4EzT5Q1bIK5II rstquFYpmzSZjjIx1v+XYiNV2XDxQL+RH0fLyqPSekvJHaRcc+lJHcRoINaMXDXR+J3B 0gnOD0n13IR+YoMeMZK0ALTTSje3q6wpW4Qf3QPHgoDgPUazOlPsPke+v9jVXicz6eAc CJJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738763750; x=1739368550; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oIpkDavHv1mosrO35zWmOM/2kyS+6DaqY97DOGPHbr8=; b=wT7aBtB5BgvDySRaM7522vPjCqwwxXLoGnlWWcXvu+QhYCFDoOe01SS4zU0Qxwique DwH5UTqOx/tP6SYNJgzhTA3woxdujIWBu/2MqaXDIwmbWZv3qxz2T5plWl0d/4aRd9nR ACgSl5Ou7Jfl0kreroC9XaNYjEawC2CgnqJHfeV3MjOXnZ6Bc66o5Z60swsyXKjvH8BP DtPE9N/+CuShal/lMDR5klA6cvhjBzKOheAcgsF7GR0126v2pV1CAA76e9PHudipX9w+ sTlbSCdex1UtUCe+S+7gVzXWW8tu/sjkDAOTSjeAVk+jvbw0SCy28rPa001x4lzkp3Bs ckpA== X-Gm-Message-State: AOJu0YxkHNtcyDFue8v0Gzm+A0XRHHN+AdWXtHqQRiDtmjIAsDQfrboE ZkhED9nIfS9Wm/9yBUyQ1b8CzDCtfiaiswuvHNeYL1LQ+FAKP8U3CNu20Q== X-Gm-Gg: ASbGnctfh9BrpyFtKghcxvPO/1m9MW18PRQL2Q/EqOzIMVzes7i2uHScoS+S1bDnmgt nrU+t6BCrRpmGIm2Lr/y6izM7CIrqiTvnBDncEP0hcdC1Yu1AP2h7UFbSiM/6Jph7dOLYOtusil Htnd4EP/IDXuKBQ87mkPhQOfGF0XYr+dx8eZ+3kTtpfGjv3Xv3RTxYF6YFAwEv6DP7ujBjxgWh1 BVYNqWM8yVgnMHD4ruZUSUFN9azecwtlWSE9xwwiNRp7dxcwkPblZ4R9ikUhg8EbALuxwWd09X7 BwdUjhA1GmR5 X-Google-Smtp-Source: AGHT+IHlk0ERZfejGDGJV9cam6trwRp85NeN1Cj32kG8LJLbvWL+zoVbvasTK/YkbMEVtX7vLcT+1g== X-Received: by 2002:a17:902:cccd:b0:21f:33:ad2 with SMTP id d9443c01a7336-21f17eddb4fmr49188895ad.52.1738763750150; Wed, 05 Feb 2025 05:55:50 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f07be072csm30934375ad.45.2025.02.05.05.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 05:55:49 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. In-Reply-To: <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> (Felix Lechner's message of "Sun, 14 May 2023 14:42:31 -0700") References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> Date: Wed, 05 Feb 2025 22:55:38 +0900 Message-ID: <874j188pid.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Felix, Felix Lechner <felix.lechner@HIDDEN> writes: > Upon personal reflection, a declarative operating system like Guix probably > ought to use only predictable interface names. > > While shorter names like 'eno1' offer an indisputable convenience and beauty > when typing on the command line, administrators in Guix are unlikely to do so > due to the declarative configuration system. While it's true that predictable interface names are nice, I thought they already were. But more to the point, I don't think we should change something that is the default and has been used for a long time without major complaints. I personally don't think we should merge this 3/3 patch. It's something to be left to users to choose for themselves based on their own needs. -- Thanks, Maxim
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 29 May 2023 21:07:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 17:07:10 2023 Received: from localhost ([127.0.0.1]:59345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3k58-0000Dx-1t for submit <at> debbugs.gnu.org; Mon, 29 May 2023 17:07:10 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:59698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1q3k55-0000Do-TF for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 17:07:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=+DAFuEbTLSh7oyz XwTejC52wMQyJGCXsw8pq/t9K5so=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=dtqwb+vRQm1q5nLObl7XAyVbPzVIJnREcg+ljBqZ q7KyLDmpX8XC/1Ow4By+VQh6Rkz4wfBQ4HXeUPkzuXK2746R26BRD2+HP8rmMgTDQYj7fH 4Gp5Z6GvFESGX0rLrPxDYtJmZ04x819ACIOFrB8kXk8cqXF9lLfZPlE8/J6UE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 6f5f53e3 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <63508 <at> debbugs.gnu.org>; Mon, 29 May 2023 21:07:06 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f004cc54f4so4141989e87.3 for <63508 <at> debbugs.gnu.org>; Mon, 29 May 2023 14:07:05 -0700 (PDT) X-Gm-Message-State: AC+VfDzfwrkTUaNROQNsY4WXhDax0taXtMWCwE0SxVpUpFgty7XSY0XY TGUOeVLy+D737Sh321uE9LPUDOyXoFKDuMjNxPM= X-Google-Smtp-Source: ACHHUZ6l4XLGgTSd7LAY+ahN+S2NBuLLu8TbDhEQ2jQGWQxOJz8tgfANQrZWJ1VbP/4ZAozlJccvpXybvneI2utU1/A= X-Received: by 2002:ac2:5298:0:b0:4f1:5010:4b34 with SMTP id q24-20020ac25298000000b004f150104b34mr4624944lfm.18.1685394422407; Mon, 29 May 2023 14:07:02 -0700 (PDT) MIME-Version: 1.0 References: <d6fc82a44190d2c5b16d8f8f434102b68681ccfe.1685379443.git.felix.lechner@HIDDEN> <2d51ddd4e6865a40a15b8f7948d2479952571a4e.1685379443.git.felix.lechner@HIDDEN> <5543a014-6ace-f212-0dc2-046ef9e99086@HIDDEN> In-Reply-To: <5543a014-6ace-f212-0dc2-046ef9e99086@HIDDEN> From: Felix Lechner <felix.lechner@HIDDEN> Date: Mon, 29 May 2023 14:06:25 -0700 X-Gmail-Original-Message-ID: <CAFHYt54LpOV1oOJFRphDP8hduVCae68X0ytLw2iiSz3uobq8WA@HIDDEN> Message-ID: <CAFHYt54LpOV1oOJFRphDP8hduVCae68X0ytLw2iiSz3uobq8WA@HIDDEN> Subject: Re: [bug#63508] [PATCH v4 2/2] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) To: Bruno Victal <mirai@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Bruno, On Mon, May 29, 2023 at 1:28=E2=80=AFPM Bruno Victal <mirai@HIDDEN> wr= ote: > > Perhaps instead of substituting, can you check if > #:configure-flags or #:make-flags could be used instead? Thank you for that suggestion! I did, and I do not believe it is possible to specify a separate runtime path for udevadm via ./configure at this time. It would be possible to add a second variable in configure.ac [1] and use that in the relevant Makefile.am. [2] The change would get picked up for the runtime search path throughout [3] and for the inotify watch in udevd. [4] In that scenario, it would be crucial not to modify the installation directory that was specified via the variable prefix "udevrules_" in several Makefiles.am, [5][6][7] which use Automake's "uniform" naming scheme that leaves off 'dir'. [8] Unfortunately, for most distros the distinctions are meaningless, and perhaps even incomprehensible. I estimated the chance of upstream acceptance as low. After some reflection, it was easier to patch the runtime path directly in the lone place that matters to Guix. [2, again] I also do not see how the second variable needed can be introduced by invoking 'make' in a different way. Please let me know if you find a way. Thanks! Kind regards Felix [1] https://github.com/eudev-project/eudev/blob/0a4dae19c1a191c8054fc2b9c2d= 592e797715a69/configure.ac#L180 [2] https://github.com/eudev-project/eudev/blob/0a4dae19c1a191c8054fc2b9c2d= 592e797715a69/src/udev/Makefile.am#L10 [3] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/src/udev/udev-rules.c#L53 [4] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/src/udev/udevd.c#L1306 [5] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/rules/Makefile.am#L9 [6] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/rules/Makefile.am#L35 [7] https://github.com/eudev-project/eudev/blob/2703baf55615b7554fb67c4f1c2= 41f057f8c0a79/rule_generator/Makefile.am#L12 [8] https://www.gnu.org/software/automake/manual/html_node/Uniform.html
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 29 May 2023 20:28:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 16:28:55 2023 Received: from localhost ([127.0.0.1]:59221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3jU7-0007Qo-Nv for submit <at> debbugs.gnu.org; Mon, 29 May 2023 16:28:55 -0400 Received: from smtpm5.myservices.hosting ([185.26.105.236]:42414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mirai@HIDDEN>) id 1q3jU5-0007Qb-AY for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 16:28:55 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm5.myservices.hosting (Postfix) with ESMTP id 7642B20CB0; Mon, 29 May 2023 22:28:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 462B780098; Mon, 29 May 2023 22:28:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9hzd6pKcP2Ou; Mon, 29 May 2023 22:28:46 +0200 (CEST) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@HIDDEN) by mail1.netim.hosting (Postfix) with ESMTPSA id ABE4980060; Mon, 29 May 2023 22:28:46 +0200 (CEST) Message-ID: <5543a014-6ace-f212-0dc2-046ef9e99086@HIDDEN> Date: Mon, 29 May 2023 21:28:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [bug#63508] [PATCH v4 2/2] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) Content-Language: en-US To: Felix Lechner <felix.lechner@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN> References: <d6fc82a44190d2c5b16d8f8f434102b68681ccfe.1685379443.git.felix.lechner@HIDDEN> <2d51ddd4e6865a40a15b8f7948d2479952571a4e.1685379443.git.felix.lechner@HIDDEN> From: Bruno Victal <mirai@HIDDEN> In-Reply-To: <2d51ddd4e6865a40a15b8f7948d2479952571a4e.1685379443.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) Hi Lechner, On 2023-05-29 17:57, Felix Lechner via Guix-patches via wrote: > #:phases > #~(modify-phases %standard-phases > + (add-before 'bootstrap 'hardcode-runtime-rules-dir > + (lambda _ > + (use-modules (ice-9 regex)) > + (substitute* "src/udev/Makefile.am" > + (((regexp-quote "$(udevrulesdir)")) "/etc/udev/rules.d")))) Perhaps instead of substituting, can you check if #:configure-flags or #:make-flags could be used instead? -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno.
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 29 May 2023 16:57:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 12:57:34 2023
Received: from localhost ([127.0.0.1]:59025 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q3gBa-0001ZP-8K
for submit <at> debbugs.gnu.org; Mon, 29 May 2023 12:57:34 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:49068)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1q3gBV-0001Yy-KR
for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 12:57:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=4L12ZmZoA0lQhr2
2HLtIQCB80Neo6GXwex5Bo85i3PE=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=rX+B1/KAEWIUhGCO2rzAT2K9a+anT0gEtop2penF
EBsFbIyAvyMH07fNcaprllO8etyqpLNOIaiRkK/ulAdqKqDWxZZCF9fYI2kB6qUNM8gcTg
KZ2fzzj+HyZtKp9Q8Ep1GZ4SECKaRr4oxu59Wyup12oE5XkuzXHuxplvYrVf0=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id db8d1774
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Mon, 29 May 2023 16:57:27 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 81cf9d46;
Mon, 29 May 2023 16:57:27 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v4 2/2] gnu: eudev: Have udevadm look in /etc/udev/rules.d.
(Closes: #63508)
Date: Mon, 29 May 2023 09:57:23 -0700
Message-Id: <2d51ddd4e6865a40a15b8f7948d2479952571a4e.1685379443.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <d6fc82a44190d2c5b16d8f8f434102b68681ccfe.1685379443.git.felix.lechner@HIDDEN>
References: <d6fc82a44190d2c5b16d8f8f434102b68681ccfe.1685379443.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
This substitution ensures that udevadm sees the rules that are actually in
effect for the declared operating system. It allows administrators to use the
udev-rules-service for network interfaces.
Some of Guix's customizations for udev rules appear to work as it is [1] but
that is not true for network interfaces (which invoke udevadm for naming
purposes). [2]
Without this commit, udevadm will consult the rules that were present at build
time and were installed in the store).
[1] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00195.html
[2] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00192.html
* gnu/packages/linux.scm (eudev): Have udevadm look in
/etc/udev/rules.d. (Closes: #63508)
---
gnu/packages/linux.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7a365e2e22..55255e576e 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4192,6 +4192,11 @@ (define-public eudev
(list
#:phases
#~(modify-phases %standard-phases
+ (add-before 'bootstrap 'hardcode-runtime-rules-dir
+ (lambda _
+ (use-modules (ice-9 regex))
+ (substitute* "src/udev/Makefile.am"
+ (((regexp-quote "$(udevrulesdir)")) "/etc/udev/rules.d"))))
(add-before 'bootstrap 'patch-file-names
(lambda* (#:key inputs native-inputs #:allow-other-keys)
(substitute* "man/make.sh"
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 29 May 2023 16:57:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 12:57:30 2023
Received: from localhost ([127.0.0.1]:59023 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q3gBV-0001Z7-UZ
for submit <at> debbugs.gnu.org; Mon, 29 May 2023 12:57:30 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:49068)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1q3gBU-0001Yy-2M
for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 12:57:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=hVRrnwy1necK4NN
AG6rxeieurbmWRd776zn7JjmdSJ4=; h=date:subject:cc:to:from;
d=lease-up.com; b=DaRHyDHGGxNc+XSQs4JYuobNcmwvfk+NzCa+Yw/m9nkK72c7pXV5
6lByZotoVADA98kQrp0RQsIJvPtkLfNC9jjbn4IiKU78RoVjZWvdNwiWaNZl76F4uIISO8
Qd4v0yXRbg/Vkt4gVmrg5fNLl+hoVZ55mT71pjk+2+Gm/NTtA=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id cbf830f1
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Mon, 29 May 2023 16:57:26 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id a069b5dd;
Mon, 29 May 2023 16:57:26 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v4 1/2] gnu: eudev: Use new project URL for Git repo and home
page.
Date: Mon, 29 May 2023 09:57:22 -0700
Message-Id: <d6fc82a44190d2c5b16d8f8f434102b68681ccfe.1685379443.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Use new project URL
https://github.com/eudev-project/eudev for Git repo and home page.
---
gnu/packages/linux.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ae2792825b..7a365e2e22 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4180,7 +4180,7 @@ (define-public eudev
(version "3.2.11")
(source (origin
(method git-fetch)
- (uri (git-reference (url "https://github.com/gentoo/eudev")
+ (uri (git-reference (url "https://github.com/eudev-project/eudev")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
@@ -4242,7 +4242,7 @@ (define-public eudev
(list `(,util-linux "lib") ;for blkid
kmod))
(outputs '("out" "static"))
- (home-page "https://wiki.gentoo.org/wiki/Project:Eudev")
+ (home-page "https://github.com/eudev-project/eudev")
(synopsis "Userspace device management")
(description "Udev is a daemon which dynamically creates and removes
device nodes from /dev/, handles hotplug events and loads drivers at boot
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 29 May 2023 08:30:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 04:30:00 2023 Received: from localhost ([127.0.0.1]:57030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3YGO-0004Hf-2H for submit <at> debbugs.gnu.org; Mon, 29 May 2023 04:30:00 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:46355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1q3YGM-0004HS-Hx for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 04:29:59 -0400 Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-96f6a9131fdso449936866b.1 for <63508 <at> debbugs.gnu.org>; Mon, 29 May 2023 01:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685348993; x=1687940993; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=RYCpWplS8fClxKIK+2cRi/yW+2K0fghEBnrNpQ6kBjU=; b=jWZmKp8Lzes+T/AkbE3zA2sFTHCSqWQSNk5elP4iCE7Bx4tMflpb1GW3e9rB7CC8C8 iVis5qWoENuu8wxfNOuxYmd49k2AEEwVgVp1S27kndLGfAUoTm2LSMIJK2jo4pNXbkwi BnvqbI5nbOEuj37cFt4KXyLWZx9HJOrBQWJpBPx93vK8CKGd5ShzH6SbGkxWfWG1nBSZ W3iQY0iPJz/CIz2fOwccg0LxMdYaKrw00SBzE2U04BJbd2GVBbJM9ev2FWJ/GJ4KduZ1 KUdITHHajOl3o87xVKRFMHu9WbUF96BGT6C5URnTEeWYVtEuNuPA+SqikR+7uOSwTWWu 62lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685348993; x=1687940993; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RYCpWplS8fClxKIK+2cRi/yW+2K0fghEBnrNpQ6kBjU=; b=c5T8qwkOsYK7IvDQnBEIuz9unQdaEf/j3fBN6aUgXTSQVECVWUjXbENtjpQemtU44M JsgpBI5+OQKAo/RMt8QO+MZgHGXFKuAHuPlcNitHX1GZrHXu5EXcPTyeIe94CkuD5SzN eVAzMrqVbTagRiH//lMH1SJ7YYgNbDC77ji47WS6vnom0/E8vGP+wbYZrN1oJYOoCOES LFIunY+yQKulwv2DX4U56WY7vTe6/fSKrsNim9HVW2ZWzKiiI/r3t4xXCIQ0rghlbw93 c0wpGSwCuLr0BxH73l+YkgC/6VJvWRvk1puXA9uhs1dUkyYQUNGOC/ciODdYQn9+ckTN eFHQ== X-Gm-Message-State: AC+VfDy3Am4xfTipjcxHTWOUIsE7rEAnVkS+nw3YYZn7fQRWv177Xi38 YH+R8boRMlI08JFV1/BaKak= X-Google-Smtp-Source: ACHHUZ4PJdQdNHBI/KdsFLfMi0cueO2+QvIUojZoVOCh7YJx/3IpSlkiUpBPhLIDOJsGprQM2cMwZg== X-Received: by 2002:a17:906:9b87:b0:966:484a:335e with SMTP id dd7-20020a1709069b8700b00966484a335emr10160814ejc.43.1685348992660; Mon, 29 May 2023 01:29:52 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a17-20020a17090680d100b0096739e10659sm5609853ejx.163.2023.05.29.01.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 01:29:52 -0700 (PDT) Message-ID: <b73727cc3da96e74a8205930829a762389867603.camel@HIDDEN> Subject: Re: [PATCH v2 4/4] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Date: Mon, 29 May 2023 10:29:51 +0200 In-Reply-To: <CAFHYt5554wnWZrL9H809xVj172Sd0_gB+QTpYvmWVKz1aoFA9w@HIDDEN> References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN> <e7aecfbe4642b43ea5837584b7666c87098ef15f.1684370595.git.felix.lechner@HIDDEN> <eeecf052fb86351d916c91f415dfe343069cdad2.camel@HIDDEN> <CAFHYt5554wnWZrL9H809xVj172Sd0_gB+QTpYvmWVKz1aoFA9w@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Sonntag, dem 28.05.2023 um 16:23 -0700 schrieb Felix Lechner: > Hi Liliana, >=20 > Thank you for your kind review! I will push a new version with > squashed commits you requested shortly. You mean "submit", right? > While I am new to Guix, I am not sure that Gexp conversions fall > under "style changes" in my book. I believe they are considerably > more complex, and fraught with greater error. True, but there is room for error in dropping input labels as well. In fact, eudev's labels do cause a rebuild, but I decided to push v3 1/3 anyway to get CI ready. > On Wed, May 17, 2023 at 9:19=E2=80=AFPM Liliana Marie Prikler > <liliana.prikler@HIDDEN> wrote: > >=20 > > you may object that this doesn't mention /etc/udev/rules.d and thus > > could be problematic on foreign distributions, but I argue that you > > probably shouldn't mess with foreign udev anyway, and if you do > > that setting EUDEV_RULES_DIRECTORY is appropriate. >=20 > The intent of my patch was not to mention /etc/udev/rules.d > explicitly, but rather to replace the store folder that holds the > upstream rules, which we are currently using, with the one Guix > constructs in order to use rules from other places. That just happens > to be /etc/udev/rules.d as well. >=20 > On that note, my patch is not suitable for upstream because it > hardcodes the location to the runtime path in Guix. Other > distributions may keep them in a different place. The current > Autoconf setup probably works well for them. The same reason why your patch wouldn't fly upstream is why it won't fly in Guix. We do have to consider foreign distributions as well. > Either way, udevadm in Guix is currently broken. This patch fixes it > and should please be accepted. Thanks! There is more than one way to fix a bug and I argue that the one you have chosen is not the right one. Granted, same could be said for my patch, but you have yet to file a formal complaint. The closest I can recall is "the resulting flexibility may not be needed", but here we are discussing foreign distros storing udev rules in some other location.=20 Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 29 May 2023 07:49:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 03:49:22 2023 Received: from localhost ([127.0.0.1]:57018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3Xd3-0003J9-Rn for submit <at> debbugs.gnu.org; Mon, 29 May 2023 03:49:22 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:49183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1q3Xd2-0003Iu-Jp for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 03:49:21 -0400 Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-96fb45a5258so557841166b.2 for <63508 <at> debbugs.gnu.org>; Mon, 29 May 2023 00:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685346555; x=1687938555; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=yi7Ea3mN6RE+LVEYSEPe/y5yDE8irZFBeVmRdTlBUmQ=; b=jTYbhflO7kJ2KGCZinWQcQDLkRcF1JwVUCp8KEoLrLwAg0O7FI4b/+76pWZmGj/GOM 7c7xPziWrmYtHyDGjCFJGnuswa50gz6X8TG6InD0MfEbWOeuveuZRr7zytqhx+5KnXAX hOwRuyoRPLPtT96X80OM4L+yUjQ3B6Cj/2iBkt1Dq2PhZnPqfQHLXz0TLjd/2gGYQtbu kTtUxFG7D60Sout0WOxyl6/cbpiUZ93cn+7zcsbweQgcKiwTiGM23HmXvC1YtQB25fTK a1KJPEoteeR7UIko3uOeeLenBwqDypcVF0OlgjagJ4sZGJDuDFnVvCdf2YYg+9YVjDlQ oSbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685346555; x=1687938555; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yi7Ea3mN6RE+LVEYSEPe/y5yDE8irZFBeVmRdTlBUmQ=; b=LvBfSmgx5HePS4ozn0TAUiFtYuE4i2AryV1nPyVvPEWZIDrlf5zNvncy7lKe1BSPW0 fmuI8rmAIrjnUOh+Hwa0LUsecJ4KKLrZt1YJpmDibq64ucBNLiuqGH0wdvE+vKobZyhV NmoNXQ9wdlThDUbVlpGRGWiVeDiaTtQ57hUR8kmXfDELtknCChFidszgOI6ASi42HR9P O/O0HsbNw3l62OiNVDMg89Wbl3AYpzaY5U5pMjt7LxTMCeZGEcxKCEoo7LIYXxWF1G3w gYZEF3ba+WpGJbUOpds88kiW5vu4BVp3jql44OR+wX7LvjBaDFF9aT9YYJMcVJc1S2v+ eQxA== X-Gm-Message-State: AC+VfDzkcgK+/HLVaJIL4tUmaHSo4B3ASyh2a3JkD1v/rOayJQrsTG4m mZ+vEjIOfaaK7F9A1s/DkPc= X-Google-Smtp-Source: ACHHUZ6UyncIpNKtIrWFhZYDsiNoFZsPA49H0KdsV1geDR1hqn+4O5wXptCqHoxG0fqUxsF/VNWGqQ== X-Received: by 2002:a17:907:9708:b0:970:925:6563 with SMTP id jg8-20020a170907970800b0097009256563mr10709648ejc.8.1685346554731; Mon, 29 May 2023 00:49:14 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id oz2-20020a170906cd0200b00932fa67b48fsm5576894ejb.183.2023.05.29.00.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 00:49:14 -0700 (PDT) Message-ID: <08c1b343addc553cf84c96fa062209e1682f43eb.camel@HIDDEN> Subject: Re: [PATCH v3 2/3] gnu: eudev: Use new project URL. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org Date: Mon, 29 May 2023 09:49:13 +0200 In-Reply-To: <bdcbcd3cafa77ffc0e156fa840ecbe5b61be763d.1685316502.git.felix.lechner@HIDDEN> References: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN> <bdcbcd3cafa77ffc0e156fa840ecbe5b61be763d.1685316502.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) QW0gU29ubnRhZywgZGVtIDI4LjA1LjIwMjMgdW0gMTY6MjggLTA3MDAgc2NocmllYiBGZWxpeCBM ZWNobmVyOgo+ICogZ251L3BhY2thZ2VzL2xpbnV4LnNjbSAoZXVkZXYpOiBVc2UgbmV3IHByb2pl Y3QgVVJMLgpCZSBzcGVjaWZpYyB3aGVuIGNoYW5nZXMgYWZmZWN0IHBhcnRzIG9mIGEgcGFja2Fn ZS4gIEFsc28sIGluIHRoZQpDaGFuZ2VMb2cgeW91IGNhbiBtZW50aW9uIHRoZSBmdWxsIFVSTC4K Cj4gLS0tCj4gwqBnbnUvcGFja2FnZXMvbGludXguc2NtIHwgMiArLQo+IMKgMSBmaWxlIGNoYW5n ZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2dudS9w YWNrYWdlcy9saW51eC5zY20gYi9nbnUvcGFja2FnZXMvbGludXguc2NtCj4gaW5kZXggYWUyNzky ODI1Yi4uOTBhNDRhNTE4ZCAxMDA2NDQKPiAtLS0gYS9nbnUvcGFja2FnZXMvbGludXguc2NtCj4g KysrIGIvZ251L3BhY2thZ2VzL2xpbnV4LnNjbQo+IEBAIC00MTgwLDcgKzQxODAsNyBAQCAoZGVm aW5lLXB1YmxpYyBldWRldgo+IMKgwqDCoMKgICh2ZXJzaW9uICIzLjIuMTEiKQo+IMKgwqDCoMKg IChzb3VyY2UgKG9yaWdpbgo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKG1ldGhvZCBn aXQtZmV0Y2gpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICh1cmkgKGdpdC1yZWZlcmVu Y2UgKHVybAo+ICJodHRwczovL2dpdGh1Yi5jb20vZ2VudG9vL2V1ZGV2IikKPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKHVyaSAoZ2l0LXJlZmVyZW5jZSAodXJsCj4gImh0dHBzOi8vZ2l0 aHViLmNvbS9ldWRldi1wcm9qZWN0L2V1ZGV2IikKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoY29tbWl0IChzdHJp bmctYXBwZW5kICJ2Igo+IHZlcnNpb24pKSkpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoZmlsZS1uYW1lIChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoc2hhMjU2CkFjY29yZGluZyB0byB0aGlzIHBhZ2UsIHRoZSBob21l LXBhZ2UgaXMgYWxzbwo8aHR0cHM6Ly9naXRodWIuY29tL2dlbnRvby9ldWRldj4gYW5kIHNob3Vs ZCB0aHVzIGJlIHVwZGF0ZWQgYXMgd2VsbC4KCkNoZWVycwo=
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 29 May 2023 07:41:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 03:41:04 2023 Received: from localhost ([127.0.0.1]:57014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3XV1-00031e-Sm for submit <at> debbugs.gnu.org; Mon, 29 May 2023 03:41:04 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:52565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1q3XV0-000311-Et for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 03:41:02 -0400 Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-51492ae66a4so2283232a12.1 for <63508 <at> debbugs.gnu.org>; Mon, 29 May 2023 00:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685346056; x=1687938056; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=C9FqTFlb5IeVi6FoF+ol3dhZAXopDnwwDAXvqsS/J74=; b=QMSuQrrza+3O2JBaJYZCuYC6MwrYYKSOtDzdUuqQNoaSVu2XJyiBPpLi31fm8YaJJO gj+aholKio+gBjTOk41CrrioTjIS86nM+894tstSOkGZjhzfgEhRzZw8GwFsCbMqk/+s KxpuRcEfzyAiGhSQIUFNaOKWAviRgoVuPUaraFvLqwud0Av2YDuTuuCzOFSh5VcBgOty LBOtBJUVNMFzFvULoz5BzyqffBDFKjUqNzWRFQh4GYvsTDV2k0vDLmUS9YFYFeeN0O+i YOvUasI4OnfjtWGK8mokiuYREmKGYGVVadUJv2J0+NF/QU7qzEUalXiVRIOB+rKyxx/U 33OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685346056; x=1687938056; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=C9FqTFlb5IeVi6FoF+ol3dhZAXopDnwwDAXvqsS/J74=; b=ZHi1jGMKbr7biZn5IFbIs0CkuCPHxpYKFXcqWsqYDMfIdr4sSNs8hFTXWkl6F3+Aus 5NmfpI5li8zaEanBVsXArmcht72YQfUhDwT69lZ6EBKPHlWnLkCD9z9GLmluKtN0b8fJ 6RZQmLdyjxiH2kdOCKAh/bmfDkn0eQENzoDPCNc+AhTIPE7jpqN1x+0HMGAInuDolQdb 0JNdpp8zms4NbMqfZSxzYxyvMDyEGbrChUDjeFMoBHkrfprv9i/N08qJ3bgde96gPFxS bPayxEm7NAz91+duVNk5CrJ4X+DS48V8puXYcnBiW7EC+K/3KjZhbAUL7147HAMUZz5t L2eQ== X-Gm-Message-State: AC+VfDzwg3UBiBOcPHY8sFXRpUg257M5anGw0nzn+VYZZ+qXooYZoWWJ 3V0SOkHxpR6zTmz2Iu0dVeo= X-Google-Smtp-Source: ACHHUZ73QSlq/g19AYkF41jkT0Br5ak+YThoY/p923FFld0ouH/i3RmZm/b+/hCcqAEL1v7GW9RgRA== X-Received: by 2002:a17:907:9813:b0:94f:956:b3f7 with SMTP id ji19-20020a170907981300b0094f0956b3f7mr10770062ejc.2.1685346056390; Mon, 29 May 2023 00:40:56 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id y11-20020a1709060a8b00b00965bf86c00asm5677592ejf.143.2023.05.29.00.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 00:40:56 -0700 (PDT) Message-ID: <42d5da6862685fef3cec7a8a79b32e0a89c0675d.camel@HIDDEN> Subject: Re: [PATCH v3 1/3] gnu: eudev: Convert native-inputs to new style, and build arguments to Gexps. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org Date: Mon, 29 May 2023 09:40:55 +0200 In-Reply-To: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN> References: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Sonntag, dem 28.05.2023 um 16:28 -0700 schrieb Felix Lechner: > * gnu/packages/linux.scm (eudev): Convert native-inputs to new style, > and build arguments to Gexps. > --- Proper subject is "gnu: eudev: Use new package style". Proper ChangeLog is * gnu/packages/linux.scm (eudev)[arguments]: Convert to list of=20 G-Expressions. [native-inputs]: Drop labels. The commit itself LGTM. Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 29 May 2023 07:39:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 29 03:39:02 2023 Received: from localhost ([127.0.0.1]:57010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3XT4-0002y0-3V for submit <at> debbugs.gnu.org; Mon, 29 May 2023 03:39:02 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:56558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1q3XT1-0002xa-E0 for 63508 <at> debbugs.gnu.org; Mon, 29 May 2023 03:39:00 -0400 Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-96ff9c0a103so429280566b.0 for <63508 <at> debbugs.gnu.org>; Mon, 29 May 2023 00:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685345933; x=1687937933; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=0DVeowvBjRs8DamtpWXgQe7QAdAtuHbQYIkh+Vw0q5Q=; b=sSWO2I3npWToItN3CekId4i4DZ9TL2XoqQhBdI2vG+byGEdb7R56nskqwO5RkYUGqr dXNPiko3du7s16Y9EYUieFeN+MojbqOaN0rDhV++bJXdQOR5qaIPsnyhiRSNS5xoUVKy p22F/LeivbH/Qxv3GrgA5WiMV+BE7wmAr0xbhimqspY508nACBUdhaoGgZaF/LF3Pf4v 8uuMTdvfhlqy0XDdTLNlPgKgxU55bc9cvqF98BmSQfWYHK3/N7oHiUdIDf+ZOHAB0Ksl riExX0TQlDrzTMGCKEzKC8blC45+h+sz99MCEqyTsLkI93fNu5yl77FQ4cEeW/keBmw7 oUGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685345933; x=1687937933; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0DVeowvBjRs8DamtpWXgQe7QAdAtuHbQYIkh+Vw0q5Q=; b=PjNIUCTS975rOIey44UTIJcjkFqRALahBjrop/YK0DepsHe9IF4jhOOLiAkYp1zD/y c/CXwg7FSRCVB4MxIwjVKdI0REt6OHEkxdCKhPYQhBJnIacjURsD6CG6g0Y0Gj4LZHbo KG+kayRjld2/Bcz8wNM/7jhefHUju1KmkjU447rbckPIcWs06i3jdoJ6wHxggwK7l7Q2 33yUoaxjO5Kjdkiosa8KS6gjlnx5x0ie3MKe5tZU/IHyfD0QxRT1zEeesyy7cRgs2l2Q 8s48t49mFTVhYZnMKhchmNcsNQI9anKVa4skYCYcsSUadcjZgoLQi+30vymP4iPrH8nL rhXg== X-Gm-Message-State: AC+VfDxeaUTnsXCpltYrcinixJPZv4W3nVVDJdnlQJdJY9yTqvg7Pvo0 Y0vJ1fMoTfc1TtN2aUG+O2vNsUMQOupMysgX X-Google-Smtp-Source: ACHHUZ5bVOkrNae0LJq2qKgw8CeLiNHUzD3jK+2RaLXRahqzHpr/N0ejUEoldZ1rl5zjgN/67k61uA== X-Received: by 2002:a17:907:9308:b0:96f:dd14:f749 with SMTP id bu8-20020a170907930800b0096fdd14f749mr10087625ejc.23.1685345933317; Mon, 29 May 2023 00:38:53 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n7-20020aa7c787000000b0050bc6c04a66sm2815601eds.40.2023.05.29.00.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 00:38:52 -0700 (PDT) Message-ID: <a7e91916fa699b179173124e90bf810f6264c8ac.camel@HIDDEN> Subject: Re: [PATCH v3 3/3] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org Date: Mon, 29 May 2023 09:38:51 +0200 In-Reply-To: <b68c9fa5ca46052aaf1d888a6eaf704614f96dec.1685316502.git.felix.lechner@HIDDEN> References: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN> <b68c9fa5ca46052aaf1d888a6eaf704614f96dec.1685316502.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Sonntag, dem 28.05.2023 um 16:28 -0700 schrieb Felix Lechner: > This substitution ensures that udevadm sees the rules that are > actually in effect for the declared operating system. It allows > administrators to use the udev-rules-service for network interfaces. >=20 > Some of Guix's customizations for udev rules appear to work as it is > [1] but that is not true for network interfaces (which invoke udevadm > for naming purposes). [2] >=20 > Without this commit, udevadm will consult the rules that were present > at build time and were installed in the store). >=20 > [1] > https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00195.html > [2] > https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00192.html >=20 > * gnu/packages/linux.scm (eudev): Have udevadm look in > /etc/udev/rules.d. (Closes: #63508) > --- > =C2=A0gnu/packages/linux.scm | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index 90a44a518d..57b722d97d 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -4192,6 +4192,11 @@ (define-public eudev > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:phases > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #~(modify-phases %standard-phases > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-before 'boot= strap 'hardcode-runtime-rules-dir > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lamb= da _ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (use-modules (ice-9 regex)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (substitute* "src/udev/Makefile.am" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (((regexp-quote "$(udevrulesdir)")) > "/etc/udev/rules.d")))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-before = 'bootstrap 'patch-file-names > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = (lambda* (#:key inputs native-inputs #:allow-other-keys) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (substitute* "man/make.sh" I still think the proper fix is to consult $EUDEV_RULES_DIRECTORY first as per <https://issues.guix.gnu.org/63508#6>. Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 28 May 2023 23:28:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 28 19:28:46 2023
Received: from localhost ([127.0.0.1]:56266 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q3PoY-0006PM-IU
for submit <at> debbugs.gnu.org; Sun, 28 May 2023 19:28:45 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:58770)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1q3PoQ-0006Oe-RN
for 63508 <at> debbugs.gnu.org; Sun, 28 May 2023 19:28:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=rvuSDwOb1nM9sop
TvUP85QLhEKeLTgbJ5fYKTjnRx8Y=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=a5c8E1KD51fSfuIh/ppn44HqakjlGHaoakRirH7z
cSXTUP9SlqTrmqqbo7jBp+/PdKE8G9cPbCdtCJET/H/06yuxAF5xDU8gK6CRvVBs5L5v/t
ymImqG6HtUcPZ5Y4NIGTGJd90rG1fVtdYuQ6s8Uo7O9ys7zVEHh+YGRVhKH8g=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 5f35fead
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 28 May 2023 23:28:34 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id bcd3a943;
Sun, 28 May 2023 23:28:33 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v3 3/3] gnu: eudev: Have udevadm look in /etc/udev/rules.d.
(Closes: #63508)
Date: Sun, 28 May 2023 16:28:22 -0700
Message-Id: <b68c9fa5ca46052aaf1d888a6eaf704614f96dec.1685316502.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN>
References: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
This substitution ensures that udevadm sees the rules that are actually in
effect for the declared operating system. It allows administrators to use the
udev-rules-service for network interfaces.
Some of Guix's customizations for udev rules appear to work as it is [1] but
that is not true for network interfaces (which invoke udevadm for naming
purposes). [2]
Without this commit, udevadm will consult the rules that were present at build
time and were installed in the store).
[1] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00195.html
[2] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00192.html
* gnu/packages/linux.scm (eudev): Have udevadm look in
/etc/udev/rules.d. (Closes: #63508)
---
gnu/packages/linux.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 90a44a518d..57b722d97d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4192,6 +4192,11 @@ (define-public eudev
(list
#:phases
#~(modify-phases %standard-phases
+ (add-before 'bootstrap 'hardcode-runtime-rules-dir
+ (lambda _
+ (use-modules (ice-9 regex))
+ (substitute* "src/udev/Makefile.am"
+ (((regexp-quote "$(udevrulesdir)")) "/etc/udev/rules.d"))))
(add-before 'bootstrap 'patch-file-names
(lambda* (#:key inputs native-inputs #:allow-other-keys)
(substitute* "man/make.sh"
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 28 May 2023 23:28:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 28 19:28:36 2023
Received: from localhost ([127.0.0.1]:56260 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q3PoS-0006P0-8r
for submit <at> debbugs.gnu.org; Sun, 28 May 2023 19:28:36 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:58770)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1q3PoQ-0006Oe-6z
for 63508 <at> debbugs.gnu.org; Sun, 28 May 2023 19:28:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=mkXmjKDjjedz6DL
YIL5yLYxRr4CuxoshEB/1tnElqWA=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=ZDQqz9RHeOW1LCrXp1mO+sEPrtW4/6roJnwA736P
GqcIkoiT6vlzcEi01NgFvLznn1HKroN6vRxrVSMGZfgc9Udh4Y0OqVzVSS/xPCCA4rCwto
0MgfRaH+jYlgzI6k5+/2FYaHkUZcxUOMJIk3pB6FWaEUwqAbs6j43dlUQTCXM=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id ccd1f60c
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 28 May 2023 23:28:33 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 0782d0b1;
Sun, 28 May 2023 23:28:33 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v3 2/3] gnu: eudev: Use new project URL.
Date: Sun, 28 May 2023 16:28:21 -0700
Message-Id: <bdcbcd3cafa77ffc0e156fa840ecbe5b61be763d.1685316502.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN>
References: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Use new project URL.
---
gnu/packages/linux.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ae2792825b..90a44a518d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4180,7 +4180,7 @@ (define-public eudev
(version "3.2.11")
(source (origin
(method git-fetch)
- (uri (git-reference (url "https://github.com/gentoo/eudev")
+ (uri (git-reference (url "https://github.com/eudev-project/eudev")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 28 May 2023 23:28:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 28 19:28:36 2023
Received: from localhost ([127.0.0.1]:56258 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q3PoR-0006Ox-Ms
for submit <at> debbugs.gnu.org; Sun, 28 May 2023 19:28:36 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:58770)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1q3PoP-0006Oe-6j
for 63508 <at> debbugs.gnu.org; Sun, 28 May 2023 19:28:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=5P5CGrcqFruYgDF
kFgOgpkp9GqZDJ6MI/mw1dhv1SgY=; h=date:subject:cc:to:from;
d=lease-up.com; b=nPJVo/PjEs9n+Ufv5E73vgBnBfGUtRJX0iiUcW8EwgvQRLF90tOa
y4DF4JIDr+wyMgSl5GrsmB7PyrGqvjB0bqO0P+K4psdTbZBJEouCowj863qt/sGlu10Vx4
UJrNCc+33eJA/BKlsIR+sXqYU8XazwlQ08wac+eAfo8Jzlxpk=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 17c3c3c2
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 28 May 2023 23:28:32 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id caf9a6b5;
Sun, 28 May 2023 23:28:31 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v3 1/3] gnu: eudev: Convert native-inputs to new style,
and build arguments to Gexps.
Date: Sun, 28 May 2023 16:28:20 -0700
Message-Id: <475e3d003e5a1edf2d57e61466aa646db0ad7ebc.1685316502.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Convert native-inputs to new style, and
build arguments to Gexps.
---
gnu/packages/linux.scm | 94 ++++++++++++++++++++----------------------
1 file changed, 45 insertions(+), 49 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 1be505d949..ae2792825b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4189,56 +4189,52 @@ (define-public eudev
(patches (search-patches "eudev-rules-directory.patch"))))
(build-system gnu-build-system)
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'bootstrap 'patch-file-names
- (lambda* (#:key inputs native-inputs #:allow-other-keys)
- (substitute* "man/make.sh"
- (("/usr/bin/xsltproc")
- (string-append (assoc-ref
- (or native-inputs inputs) "xsltproc")
- "/bin/xsltproc")))))
- (add-after 'install 'move-static-library
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (static (assoc-ref outputs "static"))
- (source (string-append out "/lib/libudev.a"))
- (target (string-append static "/lib/libudev.a")))
- (mkdir-p (dirname target))
- (link source target)
- (delete-file source)
- ;; Remove reference to the static library from the .la file
- ;; such that Libtool looks for it in the usual places.
- (substitute* (string-append out "/lib/libudev.la")
- (("old_library=.*")
- "old_library=''\n")))))
- (add-after 'install 'build-hwdb
- (lambda* (#:key outputs #:allow-other-keys)
- ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
- ;; similar tools to display product names.
- ;;
- ;; XXX: This can't be done when cross-compiling. Find another way
- ;; to generate hwdb.bin for cross-built systems.
- (let ((out (assoc-ref outputs "out")))
- ,@(if (%current-target-system)
- '(#t)
- '((invoke (string-append out "/bin/udevadm")
- "hwdb" "--update")))))))
- #:configure-flags (list "--enable-manpages")))
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-before 'bootstrap 'patch-file-names
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (substitute* "man/make.sh"
+ (("/usr/bin/xsltproc")
+ (search-input-file (or native-inputs inputs) "/bin/xsltproc")))))
+ (add-after 'install 'move-static-library
+ (lambda _
+ (let ((source (string-append #$output "/lib/libudev.a"))
+ (target (string-append #$output:static "/lib/libudev.a")))
+ (mkdir-p (dirname target))
+ (link source target)
+ (delete-file source)
+ ;; Remove reference to the static library from the .la file
+ ;; such that Libtool looks for it in the usual places.
+ (substitute* (string-append #$output "/lib/libudev.la")
+ (("old_library=.*")
+ "old_library=''\n")))))
+ (add-after 'install 'build-hwdb
+ (lambda _
+ ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
+ ;; similar tools to display product names.
+ ;;
+ ;; XXX: This can't be done when cross-compiling. Find another way
+ ;; to generate hwdb.bin for cross-built systems.
+ #$@(if (%current-target-system)
+ #~(#t)
+ #~((invoke (string-append #$output "/bin/udevadm")
+ "hwdb" "--update"))))))
+ #:configure-flags #~(list "--enable-manpages")))
(native-inputs
- `(("autoconf" ,autoconf)
- ("automake" ,automake)
- ("gperf" ,gperf)
- ("libtool" ,libtool)
- ("pkg-config" ,pkg-config)
- ;; For tests.
- ("perl" ,perl)
- ("python" ,python-wrapper)
- ;; For documentation.
- ("docbook-xml" ,docbook-xml-4.2)
- ("docbook-xsl" ,docbook-xsl)
- ("libxml2" ,libxml2) ;for $XML_CATALOG_FILES
- ("xsltproc" ,libxslt)))
+ (list autoconf
+ automake
+ gperf
+ libtool
+ pkg-config
+ ;; For tests.
+ perl
+ python-wrapper
+ ;; For documentation.
+ docbook-xml-4.2
+ docbook-xsl
+ libxml2 ;for $XML_CATALOG_FILES
+ libxslt))
(inputs
;; When linked against libblkid, eudev can populate /dev/disk/by-label
;; and similar; it also installs the '60-persistent-storage.rules' file,
base-commit: d64d6ea2cf5a1be801be355031fb2cfa5901a92a
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 28 May 2023 23:24:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 28 19:24:20 2023 Received: from localhost ([127.0.0.1]:56108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q3PkJ-0006I0-SR for submit <at> debbugs.gnu.org; Sun, 28 May 2023 19:24:20 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:39646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1q3PkI-0006Hr-9b for 63508 <at> debbugs.gnu.org; Sun, 28 May 2023 19:24:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=1yCXP2JveUQegx+ y47v//+dHkKfbiQbCKhvEWixnkLw=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=JAiLrz5ogP3MH5uYgaA+UQVbBahNdYlFw9Tlahym RqfysM71uEI7CXI3Qp0sdiKDT/5FCIgjLQ4po+WAwP2mhjIktRb/5X41OsmFzQLBdSmsK0 wpcNkC/D0IZn9B0v3U86x/4SBG6mW76o8DnfwBwC3ucdtx91QRTQ8xpZd21BM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 031624b5 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <63508 <at> debbugs.gnu.org>; Sun, 28 May 2023 23:24:16 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f3ba703b67so2858206e87.1 for <63508 <at> debbugs.gnu.org>; Sun, 28 May 2023 16:24:15 -0700 (PDT) X-Gm-Message-State: AC+VfDxkvfxGx0FPrVmbn/Fjmp6heGIDJZuW+UrTQ8uh8n9ncnrM05h6 3Pt+vtOT7IGKGQt3uPZ64hx5qfGGDA9Fs8eycRo= X-Google-Smtp-Source: ACHHUZ7dj6ln4yhaKSUaWqkxQViWAg/vzE4pbJQsqC/ACi5vcfaI8fxv6pm4JNJZevRAT2D5j2AOqXnUb0JM+Bt8OHM= X-Received: by 2002:a19:c50b:0:b0:4ed:bfcf:3109 with SMTP id w11-20020a19c50b000000b004edbfcf3109mr2921523lfe.56.1685316254071; Sun, 28 May 2023 16:24:14 -0700 (PDT) MIME-Version: 1.0 References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN> <e7aecfbe4642b43ea5837584b7666c87098ef15f.1684370595.git.felix.lechner@HIDDEN> <eeecf052fb86351d916c91f415dfe343069cdad2.camel@HIDDEN> In-Reply-To: <eeecf052fb86351d916c91f415dfe343069cdad2.camel@HIDDEN> From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 28 May 2023 16:23:37 -0700 X-Gmail-Original-Message-ID: <CAFHYt5554wnWZrL9H809xVj172Sd0_gB+QTpYvmWVKz1aoFA9w@HIDDEN> Message-ID: <CAFHYt5554wnWZrL9H809xVj172Sd0_gB+QTpYvmWVKz1aoFA9w@HIDDEN> Subject: Re: [PATCH v2 4/4] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Liliana, Thank you for your kind review! I will push a new version with squashed commits you requested shortly. While I am new to Guix, I am not sure that Gexp conversions fall under "style changes" in my book. I believe they are considerably more complex, and fraught with greater error. On Wed, May 17, 2023 at 9:19=E2=80=AFPM Liliana Marie Prikler <liliana.prikler@HIDDEN> wrote: > > you may object that > this doesn't mention /etc/udev/rules.d and thus could be problematic on > foreign distributions, but I argue that you probably shouldn't mess > with foreign udev anyway, and if you do that setting > EUDEV_RULES_DIRECTORY is appropriate. The intent of my patch was not to mention /etc/udev/rules.d explicitly, but rather to replace the store folder that holds the upstream rules, which we are currently using, with the one Guix constructs in order to use rules from other places. That just happens to be /etc/udev/rules.d as well. On that note, my patch is not suitable for upstream because it hardcodes the location to the runtime path in Guix. Other distributions may keep them in a different place. The current Autoconf setup probably works well for them. Either way, udevadm in Guix is currently broken. This patch fixes it and should please be accepted. Thanks! As noted elsewhere [1] I am separately working on an update to eudev 3.2.12 but that will require more testing locally before I can send it in. Kind regards Felix [1] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00217.html
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 18 May 2023 04:19:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 18 00:19:21 2023 Received: from localhost ([127.0.0.1]:51655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pzV6n-0000hA-32 for submit <at> debbugs.gnu.org; Thu, 18 May 2023 00:19:21 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:56380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1pzV6l-0000gy-Pe for 63508 <at> debbugs.gnu.org; Thu, 18 May 2023 00:19:20 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-50db91640d3so2361883a12.0 for <63508 <at> debbugs.gnu.org>; Wed, 17 May 2023 21:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684383554; x=1686975554; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=er5D4c6mQQSh/yPj7oM2xcGGl9yBYpcOTq0cUrDzUNI=; b=FtW8aMd3zVHhWkKPYJopm6o3rE19RYQqMzmuwLV9A620R/JzrjfFq9R1tMnZfQj+pl WS9hq73c5xBj2yPYRaiq4MuUFm3EGxtc1BjyxuoACWTxm144D1bqU+eF4BiDtsLTcjoC VpWph3Zx2EgJ9agBdYvGFaFmNePdMYn95wQ0zrzkmYEtznTw9XTY/onw3YUtn1FDXz0i nHr5+u1BOOpBBi/utmNji8pS94Z2/63ommXi6kQpyEJP+V834ijUV1cc6ZEns5itbQOp Vs2iX0OkBbuclyjIoMyLGqQx4b+qrW8sn3kOTpCaOBY0b3bnFFC2+Q46kGMy+stMxeGT YDiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684383554; x=1686975554; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=er5D4c6mQQSh/yPj7oM2xcGGl9yBYpcOTq0cUrDzUNI=; b=AaQtQrtx7VQ4Q0S9GXPehLWWukYVbV2XDtksx/z85acKaMJTjpNqqTd9kZeQs9rR8k 5iMpCqoX94Khnza6V2oK8JiiTQ/3bvsRoQmlECIU1y4eK3DwIjjjzz8t2o3Bj4kBMR+C r13U7f1hrlbNj+v06cg4h6WlyA9KT6CMO/RakcmN+8XXhGvdPKxXvBz7T5USIttbLjcn dW9XYRj0EVu22wQgL2e9Hgv01mFMhkyDpmhts9g0kAxPCcWlO8JLC3rQvC6aw59EwRit wOX7h0fEDQsIC2+XcvEfvyqsqW+Q+wWeIypnn8ft5FFJ0h2TsDQEOO++cNu5BXf/uYAk x/TA== X-Gm-Message-State: AC+VfDy0aiMIwYtBwbBR9DUHIhyFbovR1zUuNCYrqBYe2zfGoT3O1brd 53+RTgTn8+vXAZk8KlF1o96+i/Ay1TB3ag== X-Google-Smtp-Source: ACHHUZ6MQyphcRTBoOwRpB34MwZGU26tg1tyerIG4wL8nfIvXpqXsS1jOgkT4JVzIIpIUXjOB+uJjA== X-Received: by 2002:a17:907:1c19:b0:959:8cbe:63a5 with SMTP id nc25-20020a1709071c1900b009598cbe63a5mr46634604ejc.44.1684383553862; Wed, 17 May 2023 21:19:13 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id cd20-20020a170906b35400b0096a5eb2836asm400188ejb.203.2023.05.17.21.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 21:19:13 -0700 (PDT) Message-ID: <eeecf052fb86351d916c91f415dfe343069cdad2.camel@HIDDEN> Subject: Re: [PATCH v2 4/4] gnu: eudev: Have udevadm look in /etc/udev/rules.d. (Closes: #63508) From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org Date: Thu, 18 May 2023 06:19:12 +0200 In-Reply-To: <e7aecfbe4642b43ea5837584b7666c87098ef15f.1684370595.git.felix.lechner@HIDDEN> References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN> <e7aecfbe4642b43ea5837584b7666c87098ef15f.1684370595.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Mittwoch, dem 17.05.2023 um 17:52 -0700 schrieb Felix Lechner: > Note for Liliana (and not part of the commit message): Stuff that isn't part of the commit message ought to go below the dashed (---) line so it's automatically ignored by git. > Hi, I hope you are not offended by this patch. The one-line > substitution here makes the custom rule work, as well. The enviroment > variable you proposed is probably superior but the patch is > relatively complex and the resulting flexibility may not be needed. > Also, I retitled the bug to sidestep the controversy around the > default for now. I was surprised by your opposition and think that > should be a separate discussion. Thanks! Note that our udev already uses this environment variable, I am only changing how it is interpreted, i.e. allowing it to override built-in rules just as is needed for your use case. Now, you may object that this doesn't mention /etc/udev/rules.d and thus could be problematic on foreign distributions, but I argue that you probably shouldn't mess with foreign udev anyway, and if you do that setting EUDEV_RULES_DIRECTORY is appropriate. Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 18 May 2023 04:13:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 18 00:13:03 2023 Received: from localhost ([127.0.0.1]:51651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pzV0h-0000Xi-6q for submit <at> debbugs.gnu.org; Thu, 18 May 2023 00:13:03 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:58385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@HIDDEN>) id 1pzV0g-0000XC-3e for 63508 <at> debbugs.gnu.org; Thu, 18 May 2023 00:13:02 -0400 Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-966400ee79aso296140866b.0 for <63508 <at> debbugs.gnu.org>; Wed, 17 May 2023 21:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684383176; x=1686975176; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=xnhNvj9L9gK4s9MbuhvhEaihmJnMaf+JgijSnTBNBLc=; b=ryrARaMyMeqygDxqFDQbFOQzksHB2i2x3kk0G+A9qgxvmMz6jm5N2YMrAVzVch1uEe 5ClnR8kvGnFBxCkQ7VX8VNLuD9rn0vC/gfQ9omIxQg7qAClQR7u3+pcvpN7LpvHNfoyK yudG9LUyM5SXj50KvutaRdjDJ4e010XX3Wyp3Pnse6ihoXhKtkewSoKTPoQc1FIXyZhK d4ong/7zNAEK1fIII8htbeZe+zMy6PQEcxKxRLyHMBof+KzC6Y5vRfOJCEfZVdwx/w95 BILz3Z49blia1uelqAg2KM2EjUsNRGVouj+wfBBGATjVIbCXH1KDQu8rALVlm7X4xOrQ fANg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684383176; x=1686975176; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xnhNvj9L9gK4s9MbuhvhEaihmJnMaf+JgijSnTBNBLc=; b=l+5e8tYNJVSDKCepl670cxqjNaN7X4JY/q2tISB57UylIldE0ziy3rtnpVTjgvoknK MMmdf3ldF4A1+T1TcBoTKKrDzwXxFP1AAVcks4TONdb6GmQ2G2z0te1b8GSAGYst5rj8 VbKgDBMCUhDtJBo8OEYxzIJ99srXL1YcKgTLRzBfR6/hwBGWuNquLtsHdx10iZlv5k2L QgiMsyiqXP7/r5/GC103n9ieYXdXf7bJy9rBfhC5ReT4qx8RG6M5bzKOaxAil01Xm5eA eHJuekFgQSzJW4YD0Kr324bCeg7q9N4lle8FQyoUhQjcBmU7O2cqfPog8h43h0oQ5UN8 TJ3A== X-Gm-Message-State: AC+VfDzaFXlyY+23nwkp8V7TYvtjdoMtxisNq/bv83ShgsbR+qdOgV+K GW5SHFCFVQkhsoceNPry7xdHvmvnBcdDEg== X-Google-Smtp-Source: ACHHUZ5LRLUF18oMAGhPieMp9JGOE1gtsGqBtAZXD8/TGvFfuRz204LBHyOLJhJHQ4ZAU5np2uv2JA== X-Received: by 2002:a17:907:84a:b0:94e:bc04:c6f6 with SMTP id ww10-20020a170907084a00b0094ebc04c6f6mr35640491ejb.9.1684383175641; Wed, 17 May 2023 21:12:55 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g5-20020a1709061e0500b00968242f8c37sm408597ejj.50.2023.05.17.21.12.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 21:12:55 -0700 (PDT) Message-ID: <832ba582fd3da735ca64160c64d8bea843287076.camel@HIDDEN> Subject: Re: [PATCH v2 2/4] gnu: eudev: Convert build arguments to gexps. From: Liliana Marie Prikler <liliana.prikler@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org Date: Thu, 18 May 2023 06:12:54 +0200 In-Reply-To: <b0a81891c6d68a0fb0cd0c6fdebb3f522f8a2379.1684370595.git.felix.lechner@HIDDEN> References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN> <b0a81891c6d68a0fb0cd0c6fdebb3f522f8a2379.1684370595.git.felix.lechner@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Am Mittwoch, dem 17.05.2023 um 17:52 -0700 schrieb Felix Lechner: > * gnu/packages/linux.scm (eudev): Convert build arguments to gexps. > --- Since both this and 1/4 are style changes, they should be squashed into a single commit named "gnu: eudev: Use new package style". Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 18 May 2023 00:53:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 17 20:53:11 2023
Received: from localhost ([127.0.0.1]:51504 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pzRtG-0006gd-P6
for submit <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:11 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:57944)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pzRtA-0006fX-WF
for 63508 <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Fnqk/wYXfLS/fcx
Qyc8JKVGWZckJcEy+rbWZL3R4B1U=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=Qjr56EczfLaaGvWiP1+RcZJLnUznZDz9ALJicmrZ
ehz0IGJ72lhVyOJQQ87S6A2ukLooTzKyrxjj1kv//kfxPuIPgA2xSN1AZcgS1Vf1pFYfKH
0V9LRFmYdozZvHNk9WkE+CNh5vEr6wErsjvuGgy6b0mb+vEd52xWS895qyaDg=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id e0539734
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Thu, 18 May 2023 00:53:03 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 0ac46202;
Thu, 18 May 2023 00:53:03 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v2 4/4] gnu: eudev: Have udevadm look in /etc/udev/rules.d.
(Closes: #63508)
Date: Wed, 17 May 2023 17:52:41 -0700
Message-Id: <e7aecfbe4642b43ea5837584b7666c87098ef15f.1684370595.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
Note for Liliana (and not part of the commit message): Hi, I hope you
are not offended by this patch. The one-line substitution here makes
the custom rule work, as well. The enviroment variable you proposed is
probably superior but the patch is relatively complex and the
resulting flexibility may not be needed. Also, I retitled the bug to
sidestep the controversy around the default for now. I was surprised
by your opposition and think that should be a separate
discussion. Thanks!
This substitution ensures that udevadm sees the rules that are actually in
effect for the declared operating system. It allows administrators to use the
udev-rules-service for network interfaces.
Some of Guix's customizations for udev rules appear to work as it is [1] but
that is not true for network interfaces (which invoke udevadm for naming
purposes). [2]
The author uses this snippet to select MAC-based names for all network
interfaces:
(udev-rules-service 'net-name-mac
(udev-rule
"79-net-name-mac.rules"
"
SUBSYSTEM==\"net\", ACTION==\"add\", NAME=\"$env{ID_NET_NAME_MAC}\"
")))
Without this commit, udevadm will consult the rules that were present at build
time and were installed in the store).
[1] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00195.html
[2] https://lists.gnu.org/archive/html/guix-devel/2023-05/msg00192.html
* gnu/packages/linux.scm (eudev): Have udevadm look in
/etc/udev/rules.d. (Closes: #63508)
---
gnu/packages/linux.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7b989a466c..750016d572 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4156,6 +4156,11 @@ (define-public eudev
(list
#:phases
#~(modify-phases %standard-phases
+ (add-before 'bootstrap 'hardcode-runtime-rules-dir
+ (lambda _
+ (use-modules (ice-9 regex))
+ (substitute* "src/udev/Makefile.am"
+ (((regexp-quote "$(udevrulesdir)")) "/etc/udev/rules.d"))))
(add-before 'bootstrap 'patch-file-names
(lambda* (#:key inputs native-inputs #:allow-other-keys)
(substitute* "man/make.sh"
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 18 May 2023 00:53:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 17 20:53:06 2023
Received: from localhost ([127.0.0.1]:51502 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pzRtC-0006gN-Bz
for submit <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:06 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:57944)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pzRtA-0006fX-8l
for 63508 <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=J2eE1ZfgDDRtxHo
x8l+ZCI3W+5GGgZ9No7WsNJg8D+U=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=DZu+W/6nLB3JFDknpwbIo4lBvTfjIoFk0ya3K+Ya
NXRS+kSjGzYzErFGGVoOuLedogJYXo7gbGgWNIBagqV6fwxifynMVoWhNsoRlOui+APJqy
P0LgHrQy5VdxiqVqtbkf4VSCtRW3rka/7CCxSTvQ8H7dgYFzXHrVUhwh2ECKY=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 05d72d2a
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Thu, 18 May 2023 00:53:02 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 431c79bd;
Thu, 18 May 2023 00:53:01 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v2 3/4] gnu: eudev: Use new project URL.
Date: Wed, 17 May 2023 17:52:40 -0700
Message-Id: <771fb5f5b89e13b43d3efe9c455410f7e712a600.1684370595.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Use new project URL.
---
gnu/packages/linux.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 9058648700..7b989a466c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4144,7 +4144,7 @@ (define-public eudev
(version "3.2.11")
(source (origin
(method git-fetch)
- (uri (git-reference (url "https://github.com/gentoo/eudev")
+ (uri (git-reference (url "https://github.com/eudev-project/eudev")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 18 May 2023 00:53:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 17 20:53:06 2023
Received: from localhost ([127.0.0.1]:51500 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pzRtB-0006gL-VN
for submit <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:06 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:57944)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pzRt9-0006fX-0o
for 63508 <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=D8Xf6yKzYiSFV+j
ozi7bYwI1vK2K0oXLEE8lHVyfN4I=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=Sa8dTxIK/pjR+5mq96/dGFD/StrK7pTxO6+icueF
bjmnvs/ZsxaVEfMEy3By6TGYQ/iHXsFNbNWr7tsmN6S/ZVkTefd+qybzHlzD3fYoB2JeMe
rgjSwzNB95gmVNoWutzsm3bmjDeLrxjPbWZau0JEqDFL6vyW8txj3PbZbChxc=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id c75eedca
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Thu, 18 May 2023 00:53:01 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id 95be0def;
Thu, 18 May 2023 00:53:00 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v2 2/4] gnu: eudev: Convert build arguments to gexps.
Date: Wed, 17 May 2023 17:52:39 -0700
Message-Id: <b0a81891c6d68a0fb0cd0c6fdebb3f522f8a2379.1684370595.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
References: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Convert build arguments to gexps.
---
gnu/packages/linux.scm | 68 ++++++++++++++++++++----------------------
1 file changed, 32 insertions(+), 36 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 1f1b319dbf..9058648700 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4153,42 +4153,38 @@ (define-public eudev
(patches (search-patches "eudev-rules-directory.patch"))))
(build-system gnu-build-system)
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'bootstrap 'patch-file-names
- (lambda* (#:key inputs native-inputs #:allow-other-keys)
- (substitute* "man/make.sh"
- (("/usr/bin/xsltproc")
- (string-append (assoc-ref
- (or native-inputs inputs) "xsltproc")
- "/bin/xsltproc")))))
- (add-after 'install 'move-static-library
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (static (assoc-ref outputs "static"))
- (source (string-append out "/lib/libudev.a"))
- (target (string-append static "/lib/libudev.a")))
- (mkdir-p (dirname target))
- (link source target)
- (delete-file source)
- ;; Remove reference to the static library from the .la file
- ;; such that Libtool looks for it in the usual places.
- (substitute* (string-append out "/lib/libudev.la")
- (("old_library=.*")
- "old_library=''\n")))))
- (add-after 'install 'build-hwdb
- (lambda* (#:key outputs #:allow-other-keys)
- ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
- ;; similar tools to display product names.
- ;;
- ;; XXX: This can't be done when cross-compiling. Find another way
- ;; to generate hwdb.bin for cross-built systems.
- (let ((out (assoc-ref outputs "out")))
- ,@(if (%current-target-system)
- '(#t)
- '((invoke (string-append out "/bin/udevadm")
- "hwdb" "--update")))))))
- #:configure-flags (list "--enable-manpages")))
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-before 'bootstrap 'patch-file-names
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (substitute* "man/make.sh"
+ (("/usr/bin/xsltproc")
+ (search-input-file (or native-inputs inputs) "/bin/xsltproc")))))
+ (add-after 'install 'move-static-library
+ (lambda _
+ (let ((source (string-append #$output "/lib/libudev.a"))
+ (target (string-append #$output:static "/lib/libudev.a")))
+ (mkdir-p (dirname target))
+ (link source target)
+ (delete-file source)
+ ;; Remove reference to the static library from the .la file
+ ;; such that Libtool looks for it in the usual places.
+ (substitute* (string-append #$output "/lib/libudev.la")
+ (("old_library=.*")
+ "old_library=''\n")))))
+ (add-after 'install 'build-hwdb
+ (lambda _
+ ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
+ ;; similar tools to display product names.
+ ;;
+ ;; XXX: This can't be done when cross-compiling. Find another way
+ ;; to generate hwdb.bin for cross-built systems.
+ #$@(if (%current-target-system)
+ #~(#t)
+ #~((invoke (string-append #$output "/bin/udevadm")
+ "hwdb" "--update"))))))
+ #:configure-flags #~(list "--enable-manpages")))
(native-inputs
(list autoconf
automake
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 18 May 2023 00:53:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 17 20:53:02 2023
Received: from localhost ([127.0.0.1]:51495 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pzRt8-0006fw-Ku
for submit <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:02 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:57944)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pzRt6-0006fX-Kx
for 63508 <at> debbugs.gnu.org; Wed, 17 May 2023 20:53:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=pq2XQP9Roy0aL/5
cQm6XbSluG0Mn/hEia0/M3z7on08=; h=date:subject:cc:to:from;
d=lease-up.com; b=oEqBGv25A6GAr+lIXXapmhv3GIdI1JAbsoH2NRwXlmBsclcBboWh
n02gOdXjCAsfquAEfwAOLS0oOhRfE+F73KP9CSfu8p2sbB574ggrBqpelYZ51yWsls1NmJ
C0025s8EWDi4nrB2cQMzbQ2AdeL84pQe3KedyV7PMRzRs1vU0=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 62cde05e
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Thu, 18 May 2023 00:52:59 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id e2444611;
Thu, 18 May 2023 00:52:59 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH v2 1/4] gnu: eudev: Convert native-inputs to new style.
Date: Wed, 17 May 2023 17:52:38 -0700
Message-Id: <29b8c15130a15487142ecf2089cba2a76ee8cb6d.1684370595.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Liliana Marie Prikler <liliana.prikler@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Convert native-inputs to new style.
---
gnu/packages/linux.scm | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 90c1adde53..1f1b319dbf 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4190,19 +4190,19 @@ (define-public eudev
"hwdb" "--update")))))))
#:configure-flags (list "--enable-manpages")))
(native-inputs
- `(("autoconf" ,autoconf)
- ("automake" ,automake)
- ("gperf" ,gperf)
- ("libtool" ,libtool)
- ("pkg-config" ,pkg-config)
- ;; For tests.
- ("perl" ,perl)
- ("python" ,python-wrapper)
- ;; For documentation.
- ("docbook-xml" ,docbook-xml-4.2)
- ("docbook-xsl" ,docbook-xsl)
- ("libxml2" ,libxml2) ;for $XML_CATALOG_FILES
- ("xsltproc" ,libxslt)))
+ (list autoconf
+ automake
+ gperf
+ libtool
+ pkg-config
+ ;; For tests.
+ perl
+ python-wrapper
+ ;; For documentation.
+ docbook-xml-4.2
+ docbook-xsl
+ libxml2 ;for $XML_CATALOG_FILES
+ libxslt))
(inputs
;; When linked against libblkid, eudev can populate /dev/disk/by-label
;; and similar; it also installs the '60-persistent-storage.rules' file,
base-commit: 6e38ec447f98383e0722ac300734f8d7c8c5c7b0
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Felix Lechner <felix.lechner@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Felix Lechner <felix.lechner@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 15 May 2023 19:25:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 15 15:25:51 2023
Received: from localhost ([127.0.0.1]:44448 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pydpP-0003sk-3i
for submit <at> debbugs.gnu.org; Mon, 15 May 2023 15:25:51 -0400
Received: from mail-ej1-f67.google.com ([209.85.218.67]:52598)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1pydpM-0003sW-Eg
for 63508 <at> debbugs.gnu.org; Mon, 15 May 2023 15:25:50 -0400
Received: by mail-ej1-f67.google.com with SMTP id
a640c23a62f3a-96a2b6de3cbso1147459766b.1
for <63508 <at> debbugs.gnu.org>; Mon, 15 May 2023 12:25:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1684178743; x=1686770743;
h=mime-version:cc:to:subject:date:from:message-id:from:to:cc:subject
:date:message-id:reply-to;
bh=FeY6+KzMjQmBKIrDRUrCJ1KwhvXb8omWfbyqtvqGnhg=;
b=jG47v5gqvR5zKd6IOFDlQ6Jgi3f4KM11PM0XHUxEFHIF8ACcY34k+p5n2Rp+CSMqPV
uYkl81ngpDTmRrPaSfzFRZ5K/nRwlyQaiqvSHOjCarKRyOZgGoByx4Ep2V03H+ofQW4v
tNgbfN0o9Ds9EOWoaqX7vqu1YE28OWbBAfxmGSIQPUbOtwLaT/cm9tSzarzEr+6V/HuS
RNbwSRFc0knNu/fd+Nu7G7rG/sQj7lg1nzIsRoYaoP83B3GB6c5xmrDPH70CKrCaVfDt
H3tVrz/t68dRad5i1WXNWLH3ab85w0eAVLWZ0nUR1R3lD5ehfL0UeknBF9a5rAL3TAFm
EzVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1684178743; x=1686770743;
h=mime-version:cc:to:subject:date:from:message-id:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=FeY6+KzMjQmBKIrDRUrCJ1KwhvXb8omWfbyqtvqGnhg=;
b=ghz1MEUa1xbkE6xx0UbJas+Rl+ZQp4bLip4FXAWNmTa3Erq4Fs/vewbFr4No/REieW
0x2giTjTkUU+Q7IZk5Zquyixok9a9RRxU6UUudQWXp4JMkXPaqNqWfy5XqDOjorWD2OH
gDxWh6CAnIG9yaOyHjQ5BNw5jgzvVrpRutTybYUHa3bv03DMJUgrdVvTi+ndPk42lZgE
I9Y15hxG3rBcmgQTK96XpI4Taj8fTAhA5+Fwxda4WfK1zvTmO3g6rzk08n5zKP7BcrR6
b7vKOuC+7R/mKH+ZiQsJQjU4eluk4yhUV+S+kIKVRDUT9dRFkK4wXPxstq1yBk3qGHz0
dbFw==
X-Gm-Message-State: AC+VfDx3pBmHmTlUgz7TNudEhvswSR4l1uWVh2OwREN9EiE7IhOQCn37
QUFqw8eYj7f76rBIhdZrsA03G8dGvUTpKA==
X-Google-Smtp-Source: ACHHUZ4aL1LH20S7c4oxB0S/ICW5pCUjs6jpYazCHRG5K2Yrk+iwE9zvmr3EN/tS9qc+nZ8s8XTNIg==
X-Received: by 2002:a17:907:3683:b0:966:dd1:bae2 with SMTP id
bi3-20020a170907368300b009660dd1bae2mr29721094ejc.73.1684178742346;
Mon, 15 May 2023 12:25:42 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
va8-20020a17090711c800b0094f282fc29asm9722291ejb.207.2023.05.15.12.25.41
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 15 May 2023 12:25:42 -0700 (PDT)
Message-Id: <06ea6673ca13ed6bc7fb00336dafc7a3457412ee.1684178049.git.liliana.prikler@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Mon, 15 May 2023 21:11:54 +0200
Subject: [PATCH] gnu: udev: Allow EUDEV_RULES_DIRECTORY to shadow built-in
rules.
to: 63508 <at> debbugs.gnu.org
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/packages/patches/eudev-rules-directory.patch
(rules_dirs):
Move placeholder to the start of the array. (rules_dirs_real): New procedure.
(udev_rules_dirs_new, udev_rules_check_timestamp): Adjust [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (liliana.prikler[at]gmail.com)
1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL,
https://senderscore.org/blocklistlookup/
[209.85.218.67 listed in bl.score.senderscore.com]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[209.85.218.67 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.218.67 listed in list.dnswl.org]
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
X-Debbugs-Envelope-To: 63508
Cc: felix.lechner@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.3 (/)
* gnu/packages/patches/eudev-rules-directory.patch (rules_dirs):
Move placeholder to the start of the array.
(rules_dirs_real): New procedure.
(udev_rules_dirs_new, udev_rules_check_timestamp): Adjust accordingly.
---
Hi Felix,
Am Sonntag, dem 14.05.2023 um 21:56 -0700 schrieb Felix Lechner:
> > I don't see how this change allows users *or upstream package
> > maintainers* to continue using onboard names as they have done for
> > ages and as they would want to continue to do.
>
> I have one of those cards. While the interface name did not change
> when I fiddled with the PCI configuration, I am not sure that
> prioritizing ID_NET_NAME_ONBOARD over ID_NET_NAME_MAC is a reasonable
> default for Guix.
>
> To rank ID_NET_NAME_ONBOARD below ID_NET_NAME_MAC would not address
> the shortcoming you perceived because the latter always exists.
>
> Instead, I think people wishing to use ID_NET_NAME_ONBOARD should
> install a custom udev script (and those should be recognized by the
> udevadm we ship).
I think the current default is probably fine for more users than the
proposed change (ain't no one got the time to type their MAC addresses).
I do however see your point in that udev should let you choose to prefer
ID_NET_NAME_MAC over the other rules. Now, the shortcoming here
actually lies with our incomplete support for EUDEV_RULES_DIRECTORY,
see the patch :)
> For Guix, I think we would like to see ID_NET_NAME_MAC at the top.
Now, I respectully disagree on that proposition, but am here to fix the
original bug of udev not honouring your preference. With the following
patch your udev-rule-service should be able to override the default
behaviour. If not, try matching the file name. There shouldn't be any
weird predicates on the name, but if there are, that's how we'll find
out.
Cheers
.../patches/eudev-rules-directory.patch | 44 ++++++++++++++++---
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/gnu/packages/patches/eudev-rules-directory.patch b/gnu/packages/patches/eudev-rules-directory.patch
index 54fc01c6d5..7cc3f97451 100644
--- a/gnu/packages/patches/eudev-rules-directory.patch
+++ b/gnu/packages/patches/eudev-rules-directory.patch
@@ -4,14 +4,17 @@ The old udev 182 supported $UDEV_CONFIG_FILE, which in turn allowed
the search path to be customized, but eudev no longer has this, hence
this hack.
---- eudev-3.1.5/src/udev/udev-rules.c 2015-10-13 06:22:14.000000000 +0800
-+++ eudev-3.1.5/src/udev/udev-rules.c 2015-10-16 20:45:38.491934336 +0800
-@@ -47,15 +47,11 @@
+Index: eudev/src/udev/udev-rules.c
+===================================================================
+--- eudev.orig/src/udev/udev-rules.c
++++ eudev/src/udev/udev-rules.c
+@@ -48,15 +48,11 @@ struct uid_gid {
};
};
-static const char* const rules_dirs[] = {
+static const char* rules_dirs[] = {
++ NULL, /* placeholder for $EUDEV_RULES_DIRECTORY */
UDEV_CONF_DIR "/rules.d",
UDEV_RULES_DIR,
- UDEV_ROOT_RUN "/udev/rules.d",
@@ -20,17 +23,44 @@ this hack.
- "/lib/udev/rules.d",
- "/usr/lib/udev/rules.d",
-#endif
-+ NULL, /* placeholder for $EUDEV_RULES_DIRECTORY */
NULL};
struct udev_rules {
-@@ -1704,6 +1700,9 @@
+@@ -1691,6 +1687,14 @@ static int parse_file(struct udev_rules
+ return 0;
+ }
+
++static const char** rules_dirs_real()
++{
++ if (rules_dirs[0])
++ return rules_dirs;
++ else
++ return rules_dirs + 1;
++}
++
+ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names) {
+ struct udev_rules *rules;
+ struct udev_list file_list;
+@@ -1717,7 +1721,10 @@ struct udev_rules *udev_rules_new(struct
udev_rules_check_timestamp(rules);
+- r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs);
+ /* Allow the user to specify an additional rules directory. */
-+ rules_dirs[3] = getenv("EUDEV_RULES_DIRECTORY");
++ rules_dirs[0] = getenv("EUDEV_RULES_DIRECTORY");
+
- r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs);
++ r = conf_files_list_strv(&files, ".rules", NULL, rules_dirs_real ());
if (r < 0) {
log_error_errno(r, "failed to enumerate rules files: %m");
+ return udev_rules_unref(rules);
+@@ -1776,7 +1783,9 @@ bool udev_rules_check_timestamp(struct u
+ if (!rules)
+ return false;
+
+- return paths_check_timestamp(rules_dirs, &rules->dirs_ts_usec, true);
++ return paths_check_timestamp(rules_dirs_real (),
++ &rules->dirs_ts_usec,
++ true);
+ }
+
+ static int match_key(struct udev_rules *rules, struct token *token, const char *val) {
base-commit: 28bfc5cd081458313fa8601133386209b23deb12
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at 63508) by debbugs.gnu.org; 15 May 2023 04:56:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 15 00:56:59 2023 Received: from localhost ([127.0.0.1]:42452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyQGZ-0006wH-8c for submit <at> debbugs.gnu.org; Mon, 15 May 2023 00:56:59 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:45040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyQGW-0006w8-UV for 63508 <at> debbugs.gnu.org; Mon, 15 May 2023 00:56:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=EeR96zzSaUhRLLp zF0wuGySRv6ta3pAZOW28A3cAENY=; h=cc:to:subject:date:from:in-reply-to: references; d=lease-up.com; b=oQzPFCo6PfjxVfz6TmfFQizK8lygJIS2dysvTSNl kDQc6h9bw+uPNEtkRMgQkjCV3TnKW4ocwRS+2A409U5+cGsbdtqLkAfDPAN2m5XvFbgigz h9bQlEGP5+OREqnlSGA3zX6/Zoe8X4QxbfB2fmyyUbBDCwdY/jROcjrTWGt0Y= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 72a5276e (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <63508 <at> debbugs.gnu.org>; Mon, 15 May 2023 04:56:54 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-4f13c577e36so13884334e87.1 for <63508 <at> debbugs.gnu.org>; Sun, 14 May 2023 21:56:54 -0700 (PDT) X-Gm-Message-State: AC+VfDwGu7/+ew34Ug+b9vnu0J+nPYednK9FpAn1AqLQm2BdKnTCJxFM OlnkxtcjYZUKyVuUQ/YNp6JkuqQMzyoDI2kqSeA= X-Google-Smtp-Source: ACHHUZ4efeiYYKwZdEEawxBbsAGIRIiBhdw0vnEjLBp+IzUQl09+EUJy6w5bqls0gaHaKYU28Iu/NR/TyCHxps7Et8Y= X-Received: by 2002:ac2:558c:0:b0:4f2:56ed:f22f with SMTP id v12-20020ac2558c000000b004f256edf22fmr6568030lfg.22.1684126612522; Sun, 14 May 2023 21:56:52 -0700 (PDT) MIME-Version: 1.0 References: <cover.1684100044.git.felix.lechner@HIDDEN> <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN> <9f3182a690a147e440cef8dc414365730383172d.camel@HIDDEN> In-Reply-To: <9f3182a690a147e440cef8dc414365730383172d.camel@HIDDEN> From: Felix Lechner <felix.lechner@HIDDEN> Date: Sun, 14 May 2023 21:56:16 -0700 X-Gmail-Original-Message-ID: <CAFHYt55dZUXX0MkXr32216foTxJvJD-49_aJ0nYdj5Ki2PVb6w@HIDDEN> Message-ID: <CAFHYt55dZUXX0MkXr32216foTxJvJD-49_aJ0nYdj5Ki2PVb6w@HIDDEN> Subject: Re: [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces. To: Liliana Marie Prikler <liliana.prikler@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63508 Cc: 63508 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Liliana, Thank you for your review! On Sun, May 14, 2023 at 9:31=E2=80=AFPM Liliana Marie Prikler <liliana.prikler@HIDDEN> wrote: > > Wherefore the regexp-quote? Whoops! That was left over from the attempt to get udevadm to use /etc/udev/rules.d as it should. Thanks for the pointer! > I don't see how this change allows users *or upstream package > maintainers* to continue using onboard names as they have done for ages > and as they would want to continue to do. I have one of those cards. While the interface name did not change when I fiddled with the PCI configuration, I am not sure that prioritizing ID_NET_NAME_ONBOARD over ID_NET_NAME_MAC is a reasonable default for Guix. To rank ID_NET_NAME_ONBOARD below ID_NET_NAME_MAC would not address the shortcoming you perceived because the latter always exists. Instead, I think people wishing to use ID_NET_NAME_ONBOARD should install a custom udev script (and those should be recognized by the udevadm we ship). > a) File a patch upstream to add ID_NET_NAME_MAC into net-name- > slot.rules If upstream accepts such a patch, I believe they would give ID_NET_NAME_MAC the lowest possible priority, but that does nothing for Guix. Common relative priorities are outlined here. [1] For Guix, I think we would like to see ID_NET_NAME_MAC at the top. Kind regards Felix [1] https://wiki.debian.org/NetworkInterfaceNames#How_to_migrate_to_this_sc= heme_on_upgraded_systems
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 15 May 2023 04:32:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 15 00:32:03 2023
Received: from localhost ([127.0.0.1]:42434 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pyPsR-0006Gj-Cv
for submit <at> debbugs.gnu.org; Mon, 15 May 2023 00:32:03 -0400
Received: from mail-ed1-f66.google.com ([209.85.208.66]:61594)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1pyPsO-0006GC-8h
for 63508 <at> debbugs.gnu.org; Mon, 15 May 2023 00:32:01 -0400
Received: by mail-ed1-f66.google.com with SMTP id
4fb4d7f45d1cf-50db7ec8188so10756428a12.2
for <63508 <at> debbugs.gnu.org>; Sun, 14 May 2023 21:32:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1684125114; x=1686717114;
h=mime-version:user-agent:content-transfer-encoding:references
:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date
:message-id:reply-to;
bh=pW0wz6uO3B9vFz6znhz9s4GuexRsZuOMIJw9y3qCv7Q=;
b=KjlwFQx6imfXIVcEwLB1CedhjzLz5xe0IDOJREXMG9Ozmuc7GOsAo/cDvzA1H+6MDk
vryfM7sXgc+XIpBCUjdAETEI8Zowx0UmgLZ7sFJfDNM8iJjw7fR/kb8i0RNh46MCSViF
QSgVYvcwGIWgNCjNflmy1GRvuMQzj4Xwe7j/XyPjGjWxPQ0pFuB9XqjrSDDiRr8VvzD/
CTL6v7qAnqEkO2qaBiNHEtcPghE0ITNR9HNVsVDk+fnqGCBaf8yAfXlZMemzqBbY59FQ
+4w69JR1muJ32gN9nmEymOeF/I70IEr6LBiOTP5OmvqRPdlnjlX9dQpl9YndF0as6V3J
4IZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1684125114; x=1686717114;
h=mime-version:user-agent:content-transfer-encoding:references
:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=pW0wz6uO3B9vFz6znhz9s4GuexRsZuOMIJw9y3qCv7Q=;
b=Is4I0kq0YszwXY3Zoij+T3QooJAYgWGlUSUvo+1BwJqmajQa4+ui1jIO3HV4RfPgkp
OVDvq0ulyHNostJ4TZNn4U8KoZ/fNA1PRBRAvMTHtontf152NyLcdX+27hQrtjnrRYQJ
RugBM3NXGWDCEYF+qJ6BO0FcqPMRvlD3l1gi6M3jz3PrYm77/SRmLISOPkaZv5iUd1bS
q3Xiz/tYGdSe3FHbOvLyaiany24tkeEPgwY+sGYn84f6Vk+ThgU+AsU3J5LNi5kyzG2h
Crgt44cmLtcCvEojFii7Uv1OcTVJ3nwc8ZJLXQXs1I9hs+7LFGJitLFuwcJCWGnV5HiY
XA0A==
X-Gm-Message-State: AC+VfDxvxjRFgjfyhzlnSFF7a89jr6v2WB7G4ahGHOR6JY/Xowv93Qfd
krzYDsFZlvXyJFPhZSw3gWgm2dOEii+GaQ==
X-Google-Smtp-Source: ACHHUZ5vHmI6aLKEH1arIau8i4qjV46/T2J86dKe3k2w86RmV9b0p9ffXiW80UJKTJbnmMCBK+mnIw==
X-Received: by 2002:a05:6402:202a:b0:504:8c1a:70db with SMTP id
ay10-20020a056402202a00b005048c1a70dbmr28191283edb.32.1684125113942;
Sun, 14 May 2023 21:31:53 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
n21-20020aa7c695000000b0050bdd7fafd8sm6895816edq.29.2023.05.14.21.31.53
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 14 May 2023 21:31:53 -0700 (PDT)
Message-ID: <9f3182a690a147e440cef8dc414365730383172d.camel@HIDDEN>
Subject: Re: [PATCH 3/3] gnu: eudev: Always use MAC-based names for network
interfaces.
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
To: Felix Lechner <felix.lechner@HIDDEN>, 63508 <at> debbugs.gnu.org
Date: Mon, 15 May 2023 06:31:52 +0200
In-Reply-To: <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN>
References: <cover.1684100044.git.felix.lechner@HIDDEN>
<89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 63508
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am Sonntag, dem 14.05.2023 um 14:42 -0700 schrieb Felix Lechner:
> The change here resulted in the recompilation of several seemingly
> unrelated packages such as Emacs and GTK. Perhaps those dependency
> relationships should be examined.
What? GUI libraries and packages that depend on them need to be
rebuilt when we change the way we handle our (input, media) devices?!=20
Can't have that!
> =C2=A0gnu/packages/linux.scm | 6 ++++++
> =C2=A01 file changed, 6 insertions(+)
>=20
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 98e683bdb0..724c621fed 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -4173,6 +4173,12 @@ (define-public eudev
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 (substitute* (string-append #$output
> "/lib/libudev.la")
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (("old_library=3D.*")
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "old_library=3D''\n")))))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-before 'inst=
all 'net-name-mac
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lamb=
da _
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 (use-modules (ice-9 regex))
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 (substitute* "rules/80-net-name-slot.rules"
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 (((regexp-quote "ID_NET_NAME_ONBOARD"))
Wherefore the regexp-quote? There is no regexp to be found here, is
there?
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 "ID_NET_NAME_MAC"))))
I don't see how this change allows users *or upstream package
maintainers* to continue using onboard names as they have done for ages
and as they would want to continue to do. I think you should
a) File a patch upstream to add ID_NET_NAME_MAC into net-name-
slot.rules
b) Add that patch to our eudev package with a reference to the upstream
bug report.
Cheers
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 14 May 2023 21:43:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 14 17:43:15 2023
Received: from localhost ([127.0.0.1]:41744 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pyJUo-0002aM-Uu
for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:43:15 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:32996)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pyJUm-0002aE-Ut
for 63508 <at> debbugs.gnu.org; Sun, 14 May 2023 17:43:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=fC2CYLR1lmV1uOU
ma/pvUAIDHZcg8CHbRYntjbFUTmE=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=Yh4xiZoSo0L8qrfIKVTpP8OpXPDhg6YudiMxFUx+
rW+IzrVCGsjAeHbEXNg68piV3W/TtZ7pLZMhqAsJUYvQDGwc6Cxq5JGDHnpkPcvlOtFM4V
QrDhpMxr9VJlTBhDfA2+4G2CT47SJaHinB3gv8G/fhtBi7aq1fUKTgzFtsaPA=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id e5c0cad7
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 14 May 2023 21:43:12 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id a993efe7;
Sun, 14 May 2023 21:43:11 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: eudev: Always use MAC-based names for network
interfaces.
Date: Sun, 14 May 2023 14:42:31 -0700
Message-Id: <89b635e974a7d570cbd19b847fc3eb8ac903103b.1684100044.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN>
References: <cover.1684100044.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
Upon personal reflection, a declarative operating system like Guix probably
ought to use only predictable interface names.
While shorter names like 'eno1' offer an indisputable convenience and beauty
when typing on the command line, administrators in Guix are unlikely to do so
due to the declarative configuration system.
Some system services may explicitly refer to interface names in their
configuration. They would also benefit from the predictable and constant
nature of MAC-based names.
The latter is particularly relevant on multi-homed machines, i.e. those with
more than one network connection.
A MAC-based interface name as issued by 'eudev' looks like this:
enx0123456789af (fictitious)
This commit was deployed on two production machines. The migration to
MAC-based interface names took place without issues. A second reconfiguration
was the used to add the new interface name in services tha needed it. The
second step can be skipped, since the name is known with certainty in advance.
The current naming scheme is less desirable because some services may silently
refuse to start after equipment was added or removed. A removal may take
place, for example, when something broke or when equipment was sold.
The device enumeration may also change when a CMOS battery fails and system
options are lost. In the author's option, Guix should not depend on BIOS
enumeration for device names.
In the author's case, the name of the sole network interface changed from
enp3s0 to enp4s0 when a PCIe disk controller (a SAS host-based adapter) was
installed. As a result, OpenSMTPd silently failed to start.
This commit switches 'eudev' from the standard naming order
ID_NET_NAME_ONBOARD
ID_NET_NAME_SLOT
ID_NET_NAME_PATH
to ID_NET_NAME_MAC, which is always available. [1]
The author initially attempted to achieve the same result via
(udev-rules-service 'net-name-mac
(udev-rule
"01-net-name-mac.rules"
"SUBSYSTEM==\"net\", ACTION==\"add\", NAME=\"$env{ID_NET_NAME_MAC}\"
")))
but that did not work. While the situation was not examined exhaustively, it
was not clear that udevadm can currently work because the standard command to
test udev setups: [2]
$ udevadm --debug test /sys/class/net/*
did not find the script installed via the 'udev-service-type'.
A review of the 'eudev' sources indicated that the path to find rules [3] is
hard-coded to the store location during installation. An attempt to set the
path to /etc/udev/rules.d yielded a build error because that target folder
outside the store was understandably not writable.
The manual page for udevadm did not offer a way to select the runtime location
of the udev/rules.d folder via environment variables or a command-line option.
Anyone for whom such a setup is working properly should please contact the
author. Thank you!
This commit may result in some loss of privacy, although it is presently not
clear how meaningful that is. With this commit, anyone using privacy-enhanced
IPv6 addresses risks having their MAC exposed when they publish their
configuration files in Git or post a well-meant sample in a chat rooms,
because that configuration may mention the MAC address.
Moreover, the compatibilty with schemes to generate fake one-time MAC
addresses upon boot should be evaluated. One concern is that the explicit
reference to a network interface in a configuration file would likely force
the use of a single and constant MAC address for that interface.
This commit was tested in production and is currently being used.
The change here resulted in the recompilation of several seemingly unrelated
packages such as Emacs and GTK. Perhaps those dependency relationships should
be examined.
[1] https://wiki.debian.org/NetworkInterfaceNames#How_to_migrate_to_this_scheme_on_upgraded_systems
[2] https://wiki.archlinux.org/title/Udev#Testing_rules_before_loading
[3] https://github.com/eudev-project/eudev/blob/39979ddf46e75d1b75bf381e1c73914c226c4302/configure.ac#L180
[4] https://en.wikipedia.org/wiki/IPv6_address#Temporary_addresses
* gnu/packages/linux.scm (eudev): Always use MAC-based names for network
interfaces.
---
gnu/packages/linux.scm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 98e683bdb0..724c621fed 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4173,6 +4173,12 @@ (define-public eudev
(substitute* (string-append #$output "/lib/libudev.la")
(("old_library=.*")
"old_library=''\n")))))
+ (add-before 'install 'net-name-mac
+ (lambda _
+ (use-modules (ice-9 regex))
+ (substitute* "rules/80-net-name-slot.rules"
+ (((regexp-quote "ID_NET_NAME_ONBOARD"))
+ "ID_NET_NAME_MAC"))))
(add-after 'install 'build-hwdb
(lambda _
;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 14 May 2023 21:42:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 14 17:42:45 2023
Received: from localhost ([127.0.0.1]:41734 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pyJUL-0002Ym-D7
for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:45 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:39696)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pyJUJ-0002YI-GM
for 63508 <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=bglLQLbZ+wT7DhV
TX6m8DFjNzcNQ01DSOtqRaqcTcD0=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=XW1klxHvLwtijsKX9DRf3G1t81QbALAzSA5U6S1r
lDrA5zXLLS1u/RogfoPkZ0opgzxaj1NF4cKI1VObOrWjtaQKu+OwL47ZUqlA/VLDwSrZ8T
GZF7DnyI5yQgky0mlZvKL4mqd0cIm7ipEa8Mb1C11bkvFpdM7kbErqmk+EhZA=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id e61cb43a
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 14 May 2023 21:42:42 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id c38e0e3f;
Sun, 14 May 2023 21:42:41 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: eudev: Convert build arguments to gexps.
Date: Sun, 14 May 2023 14:42:30 -0700
Message-Id: <85af3647b4729638ce33464c835095edc6e208bd.1684100044.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN>
References: <cover.1684100044.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Convert build arguments to gexps.
---
gnu/packages/linux.scm | 68 ++++++++++++++++++++----------------------
1 file changed, 32 insertions(+), 36 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 7ae34d1d4a..98e683bdb0 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4153,42 +4153,38 @@ (define-public eudev
(patches (search-patches "eudev-rules-directory.patch"))))
(build-system gnu-build-system)
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'bootstrap 'patch-file-names
- (lambda* (#:key inputs native-inputs #:allow-other-keys)
- (substitute* "man/make.sh"
- (("/usr/bin/xsltproc")
- (string-append (assoc-ref
- (or native-inputs inputs) "xsltproc")
- "/bin/xsltproc")))))
- (add-after 'install 'move-static-library
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (static (assoc-ref outputs "static"))
- (source (string-append out "/lib/libudev.a"))
- (target (string-append static "/lib/libudev.a")))
- (mkdir-p (dirname target))
- (link source target)
- (delete-file source)
- ;; Remove reference to the static library from the .la file
- ;; such that Libtool looks for it in the usual places.
- (substitute* (string-append out "/lib/libudev.la")
- (("old_library=.*")
- "old_library=''\n")))))
- (add-after 'install 'build-hwdb
- (lambda* (#:key outputs #:allow-other-keys)
- ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
- ;; similar tools to display product names.
- ;;
- ;; XXX: This can't be done when cross-compiling. Find another way
- ;; to generate hwdb.bin for cross-built systems.
- (let ((out (assoc-ref outputs "out")))
- ,@(if (%current-target-system)
- '(#t)
- '((invoke (string-append out "/bin/udevadm")
- "hwdb" "--update")))))))
- #:configure-flags (list "--enable-manpages")))
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-before 'bootstrap 'patch-file-names
+ (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (substitute* "man/make.sh"
+ (("/usr/bin/xsltproc")
+ (search-input-file (or native-inputs inputs) "/bin/xsltproc")))))
+ (add-after 'install 'move-static-library
+ (lambda _
+ (let ((source (string-append #$output "/lib/libudev.a"))
+ (target (string-append #$output:static "/lib/libudev.a")))
+ (mkdir-p (dirname target))
+ (link source target)
+ (delete-file source)
+ ;; Remove reference to the static library from the .la file
+ ;; such that Libtool looks for it in the usual places.
+ (substitute* (string-append #$output "/lib/libudev.la")
+ (("old_library=.*")
+ "old_library=''\n")))))
+ (add-after 'install 'build-hwdb
+ (lambda _
+ ;; Build OUT/etc/udev/hwdb.bin. This allows 'lsusb' and
+ ;; similar tools to display product names.
+ ;;
+ ;; XXX: This can't be done when cross-compiling. Find another way
+ ;; to generate hwdb.bin for cross-built systems.
+ #$@(if (%current-target-system)
+ #~(#t)
+ #~((invoke (string-append #$output "/bin/udevadm")
+ "hwdb" "--update"))))))
+ #:configure-flags #~(list "--enable-manpages")))
(native-inputs
(list autoconf
automake
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
Received: (at 63508) by debbugs.gnu.org; 14 May 2023 21:42:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 14 17:42:42 2023
Received: from localhost ([127.0.0.1]:41731 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pyJUI-0002YT-4t
for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:42 -0400
Received: from sail-ipv4.us-core.com ([208.82.101.137]:39696)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <felix.lechner@HIDDEN>) id 1pyJUG-0002YI-Pe
for 63508 <at> debbugs.gnu.org; Sun, 14 May 2023 17:42:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=mpp6MnNmVmkOKyI
1MJNfzCCwsceYki24Tq1JXp/0CdM=;
h=references:in-reply-to:date:subject:
cc:to:from; d=lease-up.com; b=qszSSu/HfCz03MZCaXepP6O0e5O22fMlPgUg67qq
ykvU4hbh8Mm1ElU3NzrzRaFzIbMUzDOKyQOpK8BgwRXMSn/lvwVFN51+r2zCERUNDx0s97
ivVMraEcKhAQyLDSgWPvnMaFdfTwgJBsf7rwihDRazabWoP/UnvwxXUGxPYPg=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id beac318e
(TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO);
Sun, 14 May 2023 21:42:39 +0000 (UTC)
Received: from localhost (localhost [local])
by localhost (OpenSMTPD) with ESMTPA id c22bc855;
Sun, 14 May 2023 21:42:39 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: 63508 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: eudev: Convert native-inputs to new style.
Date: Sun, 14 May 2023 14:42:29 -0700
Message-Id: <efe9ecb3d2c22fe20c82dd92dceaf992ef954b04.1684100044.git.felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.40.1
In-Reply-To: <cover.1684100044.git.felix.lechner@HIDDEN>
References: <cover.1684100044.git.felix.lechner@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 63508
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
* gnu/packages/linux.scm (eudev): Convert native-inputs to new style.
---
gnu/packages/linux.scm | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ea64e9d241..7ae34d1d4a 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4190,19 +4190,19 @@ (define-public eudev
"hwdb" "--update")))))))
#:configure-flags (list "--enable-manpages")))
(native-inputs
- `(("autoconf" ,autoconf)
- ("automake" ,automake)
- ("gperf" ,gperf)
- ("libtool" ,libtool)
- ("pkg-config" ,pkg-config)
- ;; For tests.
- ("perl" ,perl)
- ("python" ,python-wrapper)
- ;; For documentation.
- ("docbook-xml" ,docbook-xml-4.2)
- ("docbook-xsl" ,docbook-xsl)
- ("libxml2" ,libxml2) ;for $XML_CATALOG_FILES
- ("xsltproc" ,libxslt)))
+ (list autoconf
+ automake
+ gperf
+ libtool
+ pkg-config
+ ;; For tests.
+ perl
+ python-wrapper
+ ;; For documentation.
+ docbook-xml-4.2
+ docbook-xsl
+ libxml2 ;for $XML_CATALOG_FILES
+ libxslt))
(inputs
;; When linked against libblkid, eudev can populate /dev/disk/by-label
;; and similar; it also installs the '60-persistent-storage.rules' file,
--
2.40.1
guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 May 2023 21:41:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 14 17:41:26 2023 Received: from localhost ([127.0.0.1]:41726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyJT3-0002W0-Ne for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:41:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:42580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1pyJT1-0002Vs-OP for submit <at> debbugs.gnu.org; Sun, 14 May 2023 17:41:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>) id 1pyJT1-0001WN-9n for guix-patches@HIDDEN; Sun, 14 May 2023 17:41:23 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>) id 1pyJSz-0003j1-Ju for guix-patches@HIDDEN; Sun, 14 May 2023 17:41:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Au9qeyvClO9fqur HqS7bI5JwpmNc4n0sHSg4B112z74=; h=date:subject:cc:to:from; d=lease-up.com; b=KzxhE4OwHQ4xh1V1PLwJwVKmSnbaFwP7xMTTsCCI11HtgZiEvnMC R/TLZ+7sqb+G/MRjNbl0buYsAYtmfu5rmS0XsF4ENEVAae4UIITkNMI2uzqr+GZdEm98RZ msaOSzwYrZPu44Q2Rq1poX9eUsMNe+f6KtrNB09PA0+SKO5gE= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 95121349 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sun, 14 May 2023 21:41:15 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id f65f633a; Sun, 14 May 2023 21:41:15 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH 0/3] Use MAC-based names for network interfaces Date: Sun, 14 May 2023 14:41:07 -0700 Message-Id: <cover.1684100044.git.felix.lechner@HIDDEN> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: Felix Lechner <felix.lechner@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) Hi, This patch set proposes the use of ID_NET_NAME_MAC for standard network interfaces. In the author's opinion, predictable names for interfaces work better with the declarative configuration style used in Guix. Kind regards Felix Felix Lechner (3): gnu: eudev: Convert native-inputs to new style. gnu: eudev: Convert build arguments to gexps. gnu: eudev: Always use MAC-based names for network interfaces. gnu/packages/linux.scm | 100 +++++++++++++++++++++-------------------- 1 file changed, 51 insertions(+), 49 deletions(-) base-commit: 263f235cd0a2955e865fe38036f84c2bf34375ff -- 2.40.1
Felix Lechner <felix.lechner@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#63508; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.