GNU bug report logs - #63531
[PATCH] View DICOM and Sixel images using image-convert

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Severity: wishlist; Reported by: Antero Mejr <antero@HIDDEN>; Keywords: patch; dated Mon, 15 May 2023 23:31:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 63531 <at> debbugs.gnu.org:


Received: (at 63531) by debbugs.gnu.org; 16 May 2023 17:38:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 16 13:38:20 2023
Received: from localhost ([127.0.0.1]:47628 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pyycu-00006y-2w
	for submit <at> debbugs.gnu.org; Tue, 16 May 2023 13:38:20 -0400
Received: from mout-p-101.mailbox.org ([80.241.56.151]:34648)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <antero@HIDDEN>) id 1pyycr-00006b-Cx
 for 63531 <at> debbugs.gnu.org; Tue, 16 May 2023 13:38:18 -0400
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4QLNk947x4z9sWp;
 Tue, 16 May 2023 19:38:09 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1684258689;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=dTty6g0u38EW5Shzdv3oqc3sP1CiQaaeaF0uBOQPCT8=;
 b=yGyFlwo7EvNTKecifLTjIKPi3DxRZPSgIaI95dI12uUxAS0KurF6m4nC8W97lqchVGE7wo
 5CaEwHxiHuPnUO/lBWlr58LIGXM+8qqPouP3PcWro/X/ALIMHCYAVMDtRlUkdGpgV9CxTi
 Ba3Rq4yYzIIWBU3Twy8Ru4By9skiARsODJYvS12lrXMIUJS2VNH8soqC3RZjSol/Aqg6ku
 MvrXbhMfUu8ePoPgKZIUOuKi6CWqgCyiu3F7QAnImx7z8ktzhXQiTv4F73IxrAr5vT08Fh
 6NulAkxV3+AEkO0s3Pnk2LqsXuifWKKPXFHQEk44abmEpPsrp0US2h4s5oJdXg==
From: Antero Mejr <antero@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#63531: [PATCH] View DICOM and Sixel images using image-convert
In-Reply-To: <871qjgtc37.fsf@HIDDEN> (Antero Mejr's message of "Tue, 16
 May 2023 17:34:04 +0000")
References: <87cz31fa0q.fsf@HIDDEN> <83h6scz1ma.fsf@HIDDEN>
 <871qjgtc37.fsf@HIDDEN>
Date: Tue, 16 May 2023 17:38:06 +0000
Message-ID: <87ttwcrxc1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-MBO-RS-ID: f6c6e70a3f44e990795
X-MBO-RS-META: 8x7dtaqpgqkfd1irk6yyj9689juskzox
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 63531
Cc: 63531 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Antero Mejr <antero@HIDDEN> writes:

> Eli Zaretskii <eliz@HIDDEN> writes:
>
>>> Date: Mon, 15 May 2023 23:30:13 +0000
>>> From:  Antero Mejr via "Bug reports for GNU Emacs,
>>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>> 
>>> These patches add .dcm and .six to auto-mode-alist, so they can be
>>> viewed with image-convert. The Six patch also adds SIX as an ImageMagick
>>> type.
>>
>> Do we want to include their support in Emacs?  AFAIU, these aren't
>> free formats.
>
> I'm not an lawyer but to the best of my knowledge neither format has any
> sort of licensing, trademark, or patent encumberances.
>
> DICOM is free to implement and view without licenses. The specification
> is available online but the spec itself is copyright of NEMA. It's a
> metadata wrapper over JPEG mainly.
>
> I think the Sixel "format" is more of a simple convention than a formal
> specification with licenses, patents, etc. Implementations use the DEC
> VT330 manual as a "spec" I guess.
>
>> And since supporting them boils down to customizing
>> auto-mode-alist, why cannot users do that themselves?
>
> For usability I think it's good for things to (mostly) work out of the
> box.

Forgot to CC the mailing list, sorry.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#63531; Package emacs. Full text available.

Message received at 63531 <at> debbugs.gnu.org:


Received: (at 63531) by debbugs.gnu.org; 16 May 2023 16:23:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 16 12:23:45 2023
Received: from localhost ([127.0.0.1]:47125 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pyxSj-0006HV-IO
	for submit <at> debbugs.gnu.org; Tue, 16 May 2023 12:23:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50726)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pyxSe-0006HF-Qs
 for 63531 <at> debbugs.gnu.org; Tue, 16 May 2023 12:23:43 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pyxSY-0001sB-Eo; Tue, 16 May 2023 12:23:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=1mtLKFXTHJOeQ4W+1QUVei87Gc5HhCS0JqNplddzkic=; b=dX/IMKL6QhMG
 vaTRhtL2MQT8lfVGLPfbFdUOmaWV3sz1wx8LY0EHEsLeZu3xEv3e9oDQZHJjOE8ZunQebfHgbbZpX
 M9vwY4XXYsuUdQuNn/HmNmrJhW+OhuK9U1p4CxnSUPW7e189CJguLtqGcM8ojFVV9Y4uuq+Sgi9vH
 IVdLHMIucxmBXKYlvX+oBe88au73chDIlOcWnLfzcHYTk1Iwan5/bd3rR3/jVQtJxyYSvF+vu5O6b
 UAyDQvvbu8/xqJSwEI9TZTO2aHB5ZnuDaY0LJ6r4cy8PxGAlDxzZxpwisHphGWa207+IbSD4YDIoZ
 r6PvtqErAQVs/kMkLfpyVA==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pyxSX-0000Ox-VB; Tue, 16 May 2023 12:23:34 -0400
Date: Tue, 16 May 2023 19:23:41 +0300
Message-Id: <83h6scz1ma.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Antero Mejr <antero@HIDDEN>
In-Reply-To: <87cz31fa0q.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#63531: [PATCH] View DICOM and Sixel images using image-convert
References: <87cz31fa0q.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63531
Cc: 63531 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Mon, 15 May 2023 23:30:13 +0000
> From:  Antero Mejr via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> These patches add .dcm and .six to auto-mode-alist, so they can be
> viewed with image-convert. The Six patch also adds SIX as an ImageMagick
> type.

Do we want to include their support in Emacs?  AFAIU, these aren't
free formats.  And since supporting them boils down to customizing
auto-mode-alist, why cannot users do that themselves?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#63531; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 15 May 2023 23:30:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 15 19:30:48 2023
Received: from localhost ([127.0.0.1]:44700 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pyheS-0002Vo-Am
	for submit <at> debbugs.gnu.org; Mon, 15 May 2023 19:30:48 -0400
Received: from lists.gnu.org ([209.51.188.17]:46990)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <antero@HIDDEN>) id 1pyheM-0002Vc-Tz
 for submit <at> debbugs.gnu.org; Mon, 15 May 2023 19:30:47 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <antero@HIDDEN>)
 id 1pyheL-0007ye-Lb
 for bug-gnu-emacs@HIDDEN; Mon, 15 May 2023 19:30:41 -0400
Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <antero@HIDDEN>)
 id 1pyheC-0002eh-5o
 for bug-gnu-emacs@HIDDEN; Mon, 15 May 2023 19:30:37 -0400
Received: from smtp202.mailbox.org (smtp202.mailbox.org
 [IPv6:2001:67c:2050:b231:465::202])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4QKwZv6zNzz9sW0
 for <bug-gnu-emacs@HIDDEN>; Tue, 16 May 2023 01:30:15 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;
 s=mail20150812; t=1684193415;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=gUSFpt++gA0y3msOxzIMT2iHu1OefJWkN3HfTS2HnM8=;
 b=ggTQ9TpPO6joM5Jg+JNfnbeDGZK3A30cat0k+lCDQ6ZM2xhn8OsNxC0NdEUnUYXS41j0ct
 qs4mPdukp1iqu1eQQgt/QGk9irLrkESCbIxbhtM/e+e+/Rk+r6X9XMAaTXm5gQky7aabMU
 ZUkZYm40F6bowpXuNjTuc7xbvBC8QGL3Qbd7g5fsLTSSJkpxV5tkt43j2yiGdfrgQ9i13q
 oY76u+FhgiDY+ehDAfC3c2UhviytLW4olmGm94EvGDre91gebdJ+wzQpVwkwG0ZC0GEwsi
 keWY0355/W8eFYYGwqAJqs7gW9y2zo483sDw7MGObDyUCaS6/+cHpoVvV7i00Q==
From: Antero Mejr <antero@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] View DICOM and Sixel images using image-convert
Date: Mon, 15 May 2023 23:30:13 +0000
Message-ID: <87cz31fa0q.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-MBO-RS-META: rb77qbnzka5htmj1rww5ggichige3dhg
X-MBO-RS-ID: 07a42a90b1486ec5b12
Received-SPF: pass client-ip=2001:67c:2050:0:465::102;
 envelope-from=antero@HIDDEN; helo=mout-p-102.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--=-=-=
Content-Type: text/plain

These patches add .dcm and .six to auto-mode-alist, so they can be
viewed with image-convert. The Six patch also adds SIX as an ImageMagick
type.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Allow-viewing-.six-images-via-image-convert.patch

From d03709e75696c7d081012eade721d80f5b725b42 Mon Sep 17 00:00:00 2001
From: Antero Mejr <antero@HIDDEN>
Date: Mon, 15 May 2023 21:21:12 +0000
Subject: [PATCH 1/2] Allow viewing .six images via image-convert.

* lisp/files.el (auto-mode-alist): Support the Sixel .six image
format.
* lisp/image.el (imagemagick-enabled-types): Add SIX.
---
 lisp/files.el | 1 +
 lisp/image.el | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/files.el b/lisp/files.el
index 148f47cbc97..ba338e01c6b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3082,6 +3082,7 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|CBR\\|7Z\\|SQUASHFS\\)\\'" .
      ("\\.pict\\'" . image-mode)
      ("\\.rgb\\'" . image-mode)
      ("\\.rgba\\'" . image-mode)
+     ("\\.six\\'" . image-mode)
      ("\\.tga\\'" . image-mode)
      ("\\.wbmp\\'" . image-mode)
      ("\\.webp\\'" . image-mode)
diff --git a/lisp/image.el b/lisp/image.el
index 08190cf86bc..72811b2b197 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -1127,7 +1127,7 @@ has no effect."
     KDC MIFF MNG MRW MSL MSVG MTV NEF ORF OTB PBM PCD PCDS PCL
     PCT PCX PDB PEF PGM PICT PIX PJPEG PNG PNG24 PNG32 PNG8 PNM
     PPM PSD PTIF PWP RAF RAS RBG RGB RGBA RGBO RLA RLE SCR SCT
-    SFW SGI SR2 SRF SUN SVG SVGZ TGA TIFF TIFF64 TILE TIM TTF
+    SFW SGI SIX SR2 SRF SUN SVG SVGZ TGA TIFF TIFF64 TILE TIM TTF
     UYVY VDA VICAR VID VIFF VST WBMP WPG X3F XBM XC XCF XPM XV
     XWD YCbCr YCbCrA YUV)
   "List of ImageMagick types to treat as images.
-- 
2.39.2


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0002-Allow-viewing-.dcm-images-via-image-convert.patch

From aaeac0b37bd35792dc55fbccc9d5c53e606ac3f1 Mon Sep 17 00:00:00 2001
From: Antero Mejr <antero@HIDDEN>
Date: Mon, 15 May 2023 23:15:33 +0000
Subject: [PATCH 2/2] Allow viewing .dcm images via image-convert.

* lisp/files.el (auto-mode-alist): Support the DICOM .dcm image
format.
---
 lisp/files.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/files.el b/lisp/files.el
index ba338e01c6b..2e42d0e74d1 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3053,6 +3053,7 @@ ARC\\|ZIP\\|LZH\\|LHA\\|ZOO\\|[JEW]AR\\|XPI\\|RAR\\|CBR\\|7Z\\|SQUASHFS\\)\\'" .
      ("\\.cmyk\\'" . image-mode)
      ("\\.cmyka\\'" . image-mode)
      ("\\.crw\\'" . image-mode)
+     ("\\.dcm\\'" . image-mode)
      ("\\.dcr\\'" . image-mode)
      ("\\.dcx\\'" . image-mode)
      ("\\.dng\\'" . image-mode)
-- 
2.39.2


--=-=-=--
Acknowledgement sent to Antero Mejr <antero@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#63531; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 4 Sep 2023 08:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.