GNU bug report logs - #63566
[PATCH] gnu: add tcptrack

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63566 in the body.
You can then email your comments to 63566 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jakob Kirsch <jakob.kirsch <at> web.de>
To: guix-patches <at> gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: [PATCH] gnu: add tcptrack
Date: Wed, 17 May 2023 20:35:53 +0200

---
 gnu/packages/admin.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 047b0ebcc6..0ae883e0b4 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -4255,6 +4255,30 @@ (define-public thermald
     (supported-systems '("i686-linux" "x86_64-linux"))
     (license license:gpl2)))

+(define-public tcptrack
+  (package
+    (name "tcptrack")
+    (version "1.4.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/bchretien/tcptrack")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f))
+    (inputs (list libpcap ncurses))
+    (synopsis "Display information about TCP connections")
+    (description
+     "A sniffer which displays information about TCP connections it
+sees on a network interface. (backup from Steve Bensons's tcptrack)")
+    (home-page "https://github.com/bchretien/tcptrack")
+    (license license:lgpl2.1)))
+
 (define-public masscan
   (package
     (name "masscan")

base-commit: c8e599b9391f789a8a3e2183fc8f0c2a5061ceb0
--
2.39.2

Message #8 received at 63566 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Jakob Kirsch <jakob.kirsch <at> web.de>, 63566 <at> debbugs.gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: Re: [bug#63566] [PATCH] gnu: add tcptrack
Date: Tue, 20 Jun 2023 22:29:41 +0200

Hi Jakob,

Thank you for the patch! Delayed as it may be, I have some small points
of order to share.

We try to follow the Changelog format in commit logs, see
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
for the thorough explanation (or just have a look at commit logs for
some of the other packages that were added by people).

Jakob Kirsch <jakob.kirsch <at> web.de> writes:
> ---
>  gnu/packages/admin.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 047b0ebcc6..0ae883e0b4 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4255,6 +4255,30 @@ (define-public thermald
>      (supported-systems '("i686-linux" "x86_64-linux"))
>      (license license:gpl2)))
>
> +(define-public tcptrack
> +  (package
> +    (name "tcptrack")
> +    (version "1.4.3")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/bchretien/tcptrack")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f))
Please add a comment explaining why tests are disabled (e.g. `; no
tests')

> +    (inputs (list libpcap ncurses))
> +    (synopsis "Display information about TCP connections")
> +    (description
> +     "A sniffer which displays information about TCP connections it
> +sees on a network interface. (backup from Steve Bensons's tcptrack)")

The description should contain complete sentences, if possible.
How about something like this:

Tcptrack is a sniffer which displays information about TCP connections
it sees on a network interface.  This is a fork of Steve Benson’s
tcptrack.

(Note the double spacing after the .)

> +    (home-page "https://github.com/bchretien/tcptrack")
> +    (license license:lgpl2.1)))

Having looked at the source archives, I think there are a bunch of
GPLv2+ licensed source files in the tarball (note the missing L). Could
you perhaps open an issue so the author(s) could (re)confirm the status
of these source files? The folks over at [1] also indicate the package
is licensed as GPLv2+, so there may be some confusion about the
licensing status of the package.

Cheers,
 Jelle

[1]: https://directory.fsf.org/wiki/Tcptrack#tab=Overview

Message #11 received at 63566 <at> debbugs.gnu.org (full text, mbox):

From: Jakob Kirsch <jakob.kirsch <at> web.de>
To: 63566 <at> debbugs.gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: [PATCH v1] gnu: add tcptrack
Date: Wed, 21 Jun 2023 22:14:55 +0200

* gnu/packages/admin.scm (tcptrack): New variable
---
 gnu/packages/admin.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 529a477ed0..3dd8b25836 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -4256,6 +4256,29 @@ (define-public thermald
     (supported-systems '("i686-linux" "x86_64-linux"))
     (license license:gpl2)))

+(define-public tcptrack
+  (package
+    (name "tcptrack")
+    (version "1.4.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/bchretien/tcptrack")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
+    (build-system gnu-build-system)
+    (inputs (list libpcap ncurses))
+    (synopsis "Display information about TCP connections")
+    (description
+     "Tcptrack is a sniffer which displays information about TCP connections
+it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
+    (home-page "https://github.com/bchretien/tcptrack")
+    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
+    (license license:lgpl2.1)))
+
 (define-public masscan
   (package
     (name "masscan")

base-commit: dcca13ed7340f17a33a4c0907c13b64d5da66a8e
--
2.39.3

Message #16 received at 63566-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jakob Kirsch <jakob.kirsch <at> web.de>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 63566-done <at> debbugs.gnu.org
Subject: Re: bug#63566: [PATCH] gnu: add tcptrack
Date: Fri, 01 Sep 2023 10:38:50 -0400

Hi,

Jakob Kirsch <jakob.kirsch <at> web.de> writes:

> * gnu/packages/admin.scm (tcptrack): New variable
> ---
>  gnu/packages/admin.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 529a477ed0..3dd8b25836 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4256,6 +4256,29 @@ (define-public thermald
>      (supported-systems '("i686-linux" "x86_64-linux"))
>      (license license:gpl2)))
>
> +(define-public tcptrack
> +  (package
> +    (name "tcptrack")
> +    (version "1.4.3")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/bchretien/tcptrack")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
> +    (build-system gnu-build-system)
> +    (inputs (list libpcap ncurses))
> +    (synopsis "Display information about TCP connections")
> +    (description
> +     "Tcptrack is a sniffer which displays information about TCP connections
> +it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
> +    (home-page "https://github.com/bchretien/tcptrack")
> +    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
> +    (license license:lgpl2.1)))

I've made the following small changes:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/admin.scm
@@ -4291,13 +4291,12 @@ (define-public tcptrack
                 "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
     (build-system gnu-build-system)
     (inputs (list libpcap ncurses))
-    (synopsis "Display information about TCP connections")
+    (synopsis "TCP connections sniffer")
     (description
      "Tcptrack is a sniffer which displays information about TCP connections
 it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
     (home-page "https://github.com/bchretien/tcptrack")
-    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
-    (license license:lgpl2.1)))
+    (license license:lgpl2.1+)))
 
 (define-public masscan
   (package
--8<---------------cut here---------------end--------------->8---

Fixing the license (note the + which means 'or later').  Conventionally
the synopsis is worded to describe what it *is* rather than what it
does (the later is kept for the description).

I've now installed the change, thank you!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.