GNU bug report logs - #63580
[PATCH] gnu: lolcat: Update to 1.4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63580 in the body.
You can then email your comments to 63580 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: kiasoc5 <kiasoc5 <at> disroot.org>
Subject: [PATCH] gnu: lolcat: Update to 1.4.
Date: Fri, 19 May 2023 01:23:26 -0400

* gnu/packages/toys.scm (lolcat): Update to 1.4.
[version]: Switch to release tag.
[arguments]: Use G-expressions. Remove trailing #t.
<#:phases>: Replace assoc-ref with #$output.
---
 gnu/packages/toys.scm | 70 +++++++++++++++++++++----------------------
 1 file changed, 34 insertions(+), 36 deletions(-)

diff --git a/gnu/packages/toys.scm b/gnu/packages/toys.scm
index 8967c0c25b..ca2abc8ac9 100644
--- a/gnu/packages/toys.scm
+++ b/gnu/packages/toys.scm
@@ -137,44 +137,42 @@ (define-public fortunes-jkirchartz
       (license license:unlicense))))
 
 (define-public lolcat
-  (let ((commit "35dca3d0a381496d7195cd78f5b24aa7b62f2154")
-        (revision "0"))
-    (package
-      (name "lolcat")
-      (version (git-version "1.0" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/jaseg/lolcat")
-               (commit commit)))
-         (sha256
-          (base32
-           "0jjbkqcc2ikjxd1xgdyv4rb0vsw218181h89f2ywg29ffs3ypd8g"))
-         (file-name (git-file-name name version))))
-      (build-system gnu-build-system)
-      (arguments
-       `(#:tests? #f                    ; no check target
-         #:make-flags
-         (list ,(string-append "CC=" (cc-for-target)))
-         #:phases
-         (modify-phases %standard-phases
-           (delete 'bootstrap)
-           (delete 'configure)
-           (replace 'install
-             (lambda* (#:key outputs #:allow-other-keys)
-               (let* ((out  (assoc-ref outputs "out"))
-                      (dest (string-append out "/bin")))
-                 (mkdir-p dest)
-                 (install-file "lolcat" dest)
-                 (install-file "censor" dest)
-                 #t))))))
-      (home-page "https://github.com/jaseg/lolcat")
-      (synopsis "Rainbow coloring effect for text console display")
-      (description "@command{lolcat} concatenates files and streams like
+  (package
+    (name "lolcat")
+    (version "1.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jaseg/lolcat")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32
+         "0wyx184072z820njlc6qkvpxwcpjhj25gq4j0iw3jqzv3sk7mg7q"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:tests? #f                    ; no check target
+      #:make-flags
+      #~(list (string-append "CC=" #$(cc-for-target)))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'bootstrap)
+          (delete 'configure)
+          (replace 'install
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let* ((out  (assoc-ref outputs "out"))
+                     (dest (string-append out "/bin")))
+                (mkdir-p dest)
+                (install-file "lolcat" dest)
+                (install-file "censor" dest)))))))
+    (home-page "https://github.com/jaseg/lolcat")
+    (synopsis "Rainbow coloring effect for text console display")
+    (description "@command{lolcat} concatenates files and streams like
 regular @command{cat}, but it also adds terminal escape codes between
 characters and lines resulting in a rainbow effect.")
-      (license license:wtfpl2))))
+    (license license:wtfpl2)))
 
 (define-public oneko
   (package

base-commit: 321ae25a26986c4ac06e5c0c99d19e1c808da6ac
-- 
2.40.1

Message #8 received at 63580 <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: 63580 <at> debbugs.gnu.org
Cc: kiasoc5 <kiasoc5 <at> disroot.org>
Subject: [PATCH v2] gnu: lolcat: Update to 1.4.
Date: Fri, 19 May 2023 01:30:14 -0400

Forgot to add the #$output part last time. 

* gnu/packages/toys.scm (lolcat): Update to 1.4.
[version]: Switch to release tag.
[arguments]: Use G-expressions. Remove trailing #t.
<#:phases>: Replace assoc-ref with #$output.
---
 gnu/packages/toys.scm | 69 +++++++++++++++++++++----------------------
 1 file changed, 33 insertions(+), 36 deletions(-)

diff --git a/gnu/packages/toys.scm b/gnu/packages/toys.scm
index 8967c0c25b..21d5279e85 100644
--- a/gnu/packages/toys.scm
+++ b/gnu/packages/toys.scm
@@ -137,44 +137,41 @@ (define-public fortunes-jkirchartz
       (license license:unlicense))))
 
 (define-public lolcat
-  (let ((commit "35dca3d0a381496d7195cd78f5b24aa7b62f2154")
-        (revision "0"))
-    (package
-      (name "lolcat")
-      (version (git-version "1.0" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/jaseg/lolcat")
-               (commit commit)))
-         (sha256
-          (base32
-           "0jjbkqcc2ikjxd1xgdyv4rb0vsw218181h89f2ywg29ffs3ypd8g"))
-         (file-name (git-file-name name version))))
-      (build-system gnu-build-system)
-      (arguments
-       `(#:tests? #f                    ; no check target
-         #:make-flags
-         (list ,(string-append "CC=" (cc-for-target)))
-         #:phases
-         (modify-phases %standard-phases
-           (delete 'bootstrap)
-           (delete 'configure)
-           (replace 'install
-             (lambda* (#:key outputs #:allow-other-keys)
-               (let* ((out  (assoc-ref outputs "out"))
-                      (dest (string-append out "/bin")))
-                 (mkdir-p dest)
-                 (install-file "lolcat" dest)
-                 (install-file "censor" dest)
-                 #t))))))
-      (home-page "https://github.com/jaseg/lolcat")
-      (synopsis "Rainbow coloring effect for text console display")
-      (description "@command{lolcat} concatenates files and streams like
+  (package
+    (name "lolcat")
+    (version "1.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jaseg/lolcat")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32
+         "0wyx184072z820njlc6qkvpxwcpjhj25gq4j0iw3jqzv3sk7mg7q"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:tests? #f                    ; no check target
+      #:make-flags
+      #~(list (string-append "CC=" #$(cc-for-target)))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'bootstrap)
+          (delete 'configure)
+          (replace 'install
+            (lambda _
+              (let ((dest (string-append #$output "/bin")))
+                (mkdir-p dest)
+                (install-file "lolcat" dest)
+                (install-file "censor" dest)))))))
+    (home-page "https://github.com/jaseg/lolcat")
+    (synopsis "Rainbow coloring effect for text console display")
+    (description "@command{lolcat} concatenates files and streams like
 regular @command{cat}, but it also adds terminal escape codes between
 characters and lines resulting in a rainbow effect.")
-      (license license:wtfpl2))))
+    (license license:wtfpl2)))
 
 (define-public oneko
   (package

base-commit: 321ae25a26986c4ac06e5c0c99d19e1c808da6ac
-- 
2.40.1

Message #13 received at 63580-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: kiasoc5 <kiasoc5 <at> disroot.org>
Cc: 63580-done <at> debbugs.gnu.org
Subject: Re: bug#63580: [PATCH] gnu: lolcat: Update to 1.4.
Date: Wed, 24 May 2023 20:38:21 +0800

kiasoc5 <kiasoc5 <at> disroot.org> writes:

> * gnu/packages/toys.scm (lolcat): Update to 1.4.

Pushed, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.