GNU bug report logs - #63627
Improve plstore.el and fix various issues of it

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63627 in the body.
You can then email your comments to 63627 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Improve plstore.el and fix various issues of it
Date: Sun, 21 May 2023 17:45:39 +0200

Placeholder bug for a number of patches related to plstore.el, hopefully 
soon to follow.  Please leave open for the time being.

Message #8 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: 63627 <at> debbugs.gnu.org
Subject: Re: Improve plstore.el and fix various issues of it
Date: Mon, 22 May 2023 22:11:19 +0200

[Message part 1 (text/plain, inline)]

Tag: patch

Here come the first two patches:


0001-Add-internal-documentation-on-plstore.el.patch

Few but large changes, mostly in the commentary section, to describe 
internal structures and nail down terminology.


0002-Brush-up-doc-strings-and-terminology-in-plstore.el.patch

Many but small changes, building on the work from the first patch.


All of these changes so far are doc fixes or message changes, none of 
them touches any code.  Not sure whether they qualify for emacs-29, but 
I guess it would be easier to have them there to have the diff context 
ready for any following bug fixes.

The further plan is: Provide bug fixes, ERT tests for existing code, new 
features, ERT tests for new features (roughly in that order, new 
features last).  So please don't close this bug yet.

Comments welcome.

[0001-Add-internal-documentation-on-plstore.el.patch (text/x-patch, attachment)]

[0002-Brush-up-doc-strings-and-terminology-in-plstore.el.patch (text/x-patch, attachment)]

Message #11 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Wed, 31 May 2023 15:54:35 +0300

> Date: Mon, 22 May 2023 22:11:19 +0200
> From:  Jens Schmidt via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> All of these changes so far are doc fixes or message changes, none of 
> them touches any code.  Not sure whether they qualify for emacs-29, but 
> I guess it would be easier to have them there to have the diff context 
> ready for any following bug fixes.

Thanks, installed on the emacs-29 branch.

Message #14 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Fri, 16 Jun 2023 21:43:50 +0200

Eli, if you have some time could you probably give this patch

  https://lists.gnu.org/archive/html/emacs-devel/2023-06/msg00260.html

a cursory review?  I started writing user documentation for plstore when 
I thought that this would fit better into the EasyPG Assistant's manual.

What do you think?

If I should go for the EPA manual, would this ("missing documentation 
for existing emacs-29 features") go on emacs-29?

Thanks

Message #17 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Wed, 30 Aug 2023 21:28:10 +0200

[Message part 1 (text/plain, inline)]

On 2023-05-31  14:54, Eli Zaretskii wrote:
>> Date: Mon, 22 May 2023 22:11:19 +0200
>> From:  Jens Schmidt via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>
>> All of these changes so far are doc fixes or message changes, none of 
>> them touches any code.  Not sure whether they qualify for emacs-29, but 
>> I guess it would be easier to have them there to have the diff context 
>> ready for any following bug fixes.
> 
> Thanks, installed on the emacs-29 branch.

Next set of patches, I hope they are still eligible for emacs-29.

The first patch fixes more documentation and terminology issues in
plstore.el, still without touching any code.  The second patch
comprise ERT tests for plstore.el.  Since that requires interaction
with GnuPG, these tests are rather platform-dependent.  Test setup
should ensure that all tests are skipped if GnuPG is missing or not
appropriate for the tests.

Please check.

Thanks.

[0001-Add-documentation-to-plstore.el.patch (text/x-patch, attachment)]

[0002-Add-tests-for-plstore.el.patch (text/x-patch, attachment)]

Message #20 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Thu, 31 Aug 2023 07:46:43 +0300

> Date: Wed, 30 Aug 2023 21:28:10 +0200
> Cc: 63627 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> On 2023-05-31  14:54, Eli Zaretskii wrote:
> >> Date: Mon, 22 May 2023 22:11:19 +0200
> >> From:  Jens Schmidt via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >>
> >> All of these changes so far are doc fixes or message changes, none of 
> >> them touches any code.  Not sure whether they qualify for emacs-29, but 
> >> I guess it would be easier to have them there to have the diff context 
> >> ready for any following bug fixes.
> > 
> > Thanks, installed on the emacs-29 branch.
> 
> Next set of patches, I hope they are still eligible for emacs-29.
> 
> The first patch fixes more documentation and terminology issues in
> plstore.el, still without touching any code.  The second patch
> comprise ERT tests for plstore.el.  Since that requires interaction
> with GnuPG, these tests are rather platform-dependent.  Test setup
> should ensure that all tests are skipped if GnuPG is missing or not
> appropriate for the tests.

Documentation fixes are always welcome on the release branch.

As for tests: I don't really object, but what would be the purpose of
extending the test suite on the release branch? why not install that
on master instead?

> Please check.

What would you like me to check?

Message #23 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Thu, 31 Aug 2023 12:21:38 +0200

On 2023-08-31  06:46, Eli Zaretskii wrote:
>> Date: Wed, 30 Aug 2023 21:28:10 +0200
>> Cc: 63627 <at> debbugs.gnu.org
>> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>

>> Next set of patches, I hope they are still eligible for emacs-29.
>>
>> The first patch fixes more documentation and terminology issues in
>> plstore.el, still without touching any code.  The second patch
>> comprise ERT tests for plstore.el.  Since that requires interaction
>> with GnuPG, these tests are rather platform-dependent.  Test setup
>> should ensure that all tests are skipped if GnuPG is missing or not
>> appropriate for the tests.
> 
> Documentation fixes are always welcome on the release branch.
> 
> As for tests: I don't really object, but what would be the purpose of
> extending the test suite on the release branch? why not install that
> on master instead?

I thought about adding tests for 1-2 pending bugs in plstore.el in near
future.  But OTOH, these bugs are really not that significant, so
probably it makes indeed more sense to add the tests to master only.

>> Please check.
> 
> What would you like me to check?

Nothing in particular.  Like: "Please check whatever you must check
before committing such changes."

Actually, it *would* be interesting to know what you check in such a
situation, if it could be easily described.

Thanks.

Message #26 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Sat, 02 Sep 2023 10:41:53 +0300

> Date: Thu, 31 Aug 2023 12:21:38 +0200
> Cc: 63627 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> On 2023-08-31  06:46, Eli Zaretskii wrote:
> >> Date: Wed, 30 Aug 2023 21:28:10 +0200
> >> Cc: 63627 <at> debbugs.gnu.org
> >> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> >> Next set of patches, I hope they are still eligible for emacs-29.
> >>
> >> The first patch fixes more documentation and terminology issues in
> >> plstore.el, still without touching any code.  The second patch
> >> comprise ERT tests for plstore.el.  Since that requires interaction
> >> with GnuPG, these tests are rather platform-dependent.  Test setup
> >> should ensure that all tests are skipped if GnuPG is missing or not
> >> appropriate for the tests.
> > 
> > Documentation fixes are always welcome on the release branch.
> > 
> > As for tests: I don't really object, but what would be the purpose of
> > extending the test suite on the release branch? why not install that
> > on master instead?
> 
> I thought about adding tests for 1-2 pending bugs in plstore.el in near
> future.  But OTOH, these bugs are really not that significant, so
> probably it makes indeed more sense to add the tests to master only.

OK, so I've now installed the documentation changes on emacs-29.
Please prepare the other patch for master, and let's install it there.

> >> Please check.
> > 
> > What would you like me to check?
> 
> Nothing in particular.  Like: "Please check whatever you must check
> before committing such changes."
> 
> Actually, it *would* be interesting to know what you check in such a
> situation, if it could be easily described.

I look at the commit log message, make sure the relevant tests still
pass, and do anything else my eyes suggest while looking at the patch.

Thanks.

Message #29 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Mon, 4 Sep 2023 00:22:52 +0200

[Message part 1 (text/plain, inline)]

On 2023-09-02  09:41, Eli Zaretskii wrote:

> Date: Thu, 31 Aug 2023 12:21:38 +0200
> Cc: 63627 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>

> OK, so I've now installed the documentation changes on emacs-29.
Thanks.

> Please prepare the other patch for master, and let's install it there.

Done, please see attached patch.

>> Actually, it *would* be interesting to know what you check in such a
>> situation, if it could be easily described.
> 
> I look at the commit log message, make sure the relevant tests still
> pass, and do anything else my eyes suggest while looking at the patch.

Ok.

Please let your eyes rest in particular on lines 310 and following of
test/lisp/plstore-tests.el, where I have tried to detect and avoid
hangs related to GnuPG 2.4.*.

I have executed the new tests on GNU/Linux only, since that is the only
platform I have available.  Should I take extra steps to get these tests
executed on other platforms than GNU/Linux *before* you commit them?  If
yes, which steps?

The rest of the tests should be more or less standard.  Except
probably for the fact that there is still much infrastructure and few
actual tests, but I plan to change that.

Thanks.

[0001-Add-tests-for-plstore.el.patch (text/x-patch, attachment)]

Message #36 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Thu, 07 Sep 2023 12:12:14 +0300

> Date: Mon, 4 Sep 2023 00:22:52 +0200
> Cc: 63627 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> Please let your eyes rest in particular on lines 310 and following of
> test/lisp/plstore-tests.el, where I have tried to detect and avoid
> hangs related to GnuPG 2.4.*.

Looks reasonable.

> I have executed the new tests on GNU/Linux only, since that is the only
> platform I have available.  Should I take extra steps to get these tests
> executed on other platforms than GNU/Linux *before* you commit them?  If
> yes, which steps?

I think GNU/Linux alone is good enough.

If the changeset is now ready to be installed on master, please tell.

> The rest of the tests should be more or less standard.  Except
> probably for the fact that there is still much infrastructure and few
> actual tests, but I plan to change that.

This seems to imply that you are still working on this changeset?

Message #39 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Thu, 7 Sep 2023 21:27:13 +0200

On 2023-09-07  11:12, Eli Zaretskii wrote:
>> Date: Mon, 4 Sep 2023 00:22:52 +0200
>> Cc: 63627 <at> debbugs.gnu.org
>> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> If the changeset is now ready to be installed on master, please tell.

I consider it ready to be installed on master, yes, and self-contained,
but:

>> The rest of the tests should be more or less standard.  Except
>> probably for the fact that there is still much infrastructure and few
>> actual tests, but I plan to change that.
> 
> This seems to imply that you are still working on this changeset?

I plan for plstore.el:

1. Two bug fixes on emacs-29 that I would like to add tests for on
   master once the bug fixes have made their way to master.

2. More tests and new features on emacs-master.

All of the above will still take some time to implement due to time
constraints.

For all of the above it would be convenient to have the infrastructure
of the plstore tests committed on master or at least agreed upon so
that I can build on that.

Not sure how you prefer to get such long-running projects presented -
as a series of minor (but self-contained!) patches over time or at
once as one big set of patches.

Thanks.

Message #42 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Fri, 08 Sep 2023 08:40:18 +0300

> Date: Thu, 7 Sep 2023 21:27:13 +0200
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> Cc: 63627 <at> debbugs.gnu.org
> 
> > This seems to imply that you are still working on this changeset?
> 
> I plan for plstore.el:
> 
> 1. Two bug fixes on emacs-29 that I would like to add tests for on
>    master once the bug fixes have made their way to master.
> 
> 2. More tests and new features on emacs-master.
> 
> All of the above will still take some time to implement due to time
> constraints.
> 
> For all of the above it would be convenient to have the infrastructure
> of the plstore tests committed on master or at least agreed upon so
> that I can build on that.
> 
> Not sure how you prefer to get such long-running projects presented -
> as a series of minor (but self-contained!) patches over time or at
> once as one big set of patches.

It is preferable to install separate patches only if each one of them
has merit on its own.  E.g., imagine that some "force majeure" will
prevent you from working on further changes, and ask yourself whether
what you already have would make an improvement if installed.

Changes that only make sense together are better submitted and
installed as a single patch.

But if you personally prefer to submit a series of patches even when
they should be installed together, that's fine, it will just make them
slightly harder to review, especially if they touch the same code.

Message #45 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Fri, 8 Sep 2023 11:16:50 +0200

On 2023-09-08  07:40, Eli Zaretskii wrote:
>> Date: Thu, 7 Sep 2023 21:27:13 +0200
>> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
>> Cc: 63627 <at> debbugs.gnu.org

>> Not sure how you prefer to get such long-running projects presented -
>> as a series of minor (but self-contained!) patches over time or at
>> once as one big set of patches.
> 
> It is preferable to install separate patches only if each one of them
> has merit on its own.  E.g., imagine that some "force majeure" will
> prevent you from working on further changes, and ask yourself whether
> what you already have would make an improvement if installed.
> 
> Changes that only make sense together are better submitted and
> installed as a single patch.

Good to know, thanks.

> But if you personally prefer to submit a series of patches even when> they should be installed together, that's fine, it will just make them
> slightly harder to review, especially if they touch the same code.

Let's postpone the addition of the last outstanding patch, then.  I'll
add more tests to it and will come back to you later on this bug.

Independently of the tests, I'll do the Emacs 29 bugs next, also on this
bug.

Message #48 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Fri, 08 Sep 2023 14:34:17 +0300

> Date: Fri, 8 Sep 2023 11:16:50 +0200
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> Cc: 63627 <at> debbugs.gnu.org
> 
> > But if you personally prefer to submit a series of patches even when> they should be installed together, that's fine, it will just make them
> > slightly harder to review, especially if they touch the same code.
> 
> Let's postpone the addition of the last outstanding patch, then.  I'll
> add more tests to it and will come back to you later on this bug.

You mean the patch you posted in

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63627#29

should not yet be installed?  (Please try to identify patches in as
clear way as possible, as it is very hard for me to understand vague
descriptions like "last outstanding patch" in a thread where several
patches were posted.)

> Independently of the tests, I'll do the Emacs 29 bugs next, also on this
> bug.

Thanks.

Message #51 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Fri, 8 Sep 2023 23:24:17 +0200

On 2023-09-08  13:34, Eli Zaretskii wrote:
>> Date: Fri, 8 Sep 2023 11:16:50 +0200
>> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
>> Cc: 63627 <at> debbugs.gnu.org

>> Let's postpone the addition of the last outstanding patch, then.  I'll
>> add more tests to it and will come back to you later on this bug.
> 
> You mean the patch you posted in
> 
>   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63627#29
> 
> should not yet be installed?

Exactly.

> (Please try to identify patches in as
> clear way as possible, as it is very hard for me to understand vague
> descriptions like "last outstanding patch" in a thread where several
> patches were posted.)

Will do.

Message #54 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Thu, 14 Sep 2023 23:24:54 +0200

[Message part 1 (text/plain, inline)]

On 2023-09-08  13:34, Eli Zaretskii wrote:
>> Date: Fri, 8 Sep 2023 11:16:50 +0200
>> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
>> Cc: 63627 <at> debbugs.gnu.org
>>
>> Independently of the tests, I'll do the Emacs 29 bugs next, also on this
>> bug.
> 
> Thanks.

After some consideration actually only one Emacs 29 bug requires fixing.
Namely that the sequence:

    (setq plstore (plstore-open plstore-test-file))
    (plstore-save plstore)
    (plstore-close plstore)

silently drops any encrypted data in PLSTORE.  Verified in my local
master with the new ERT tests, and also verified that the attached patch
fixes the issue.

Please consider for committing on emacs-29.

Thanks

[0001-Fix-loss-of-encrypted-data-in-plstore.el.patch (text/x-patch, attachment)]

Message #57 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Sat, 16 Sep 2023 13:13:38 +0300

> Date: Thu, 14 Sep 2023 23:24:54 +0200
> Cc: 63627 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> After some consideration actually only one Emacs 29 bug requires fixing.
> Namely that the sequence:
> 
>     (setq plstore (plstore-open plstore-test-file))
>     (plstore-save plstore)
>     (plstore-close plstore)
> 
> silently drops any encrypted data in PLSTORE.  Verified in my local
> master with the new ERT tests, and also verified that the attached patch
> fixes the issue.
> 
> Please consider for committing on emacs-29.

Thanks, but did you mean to say this should not be subsequently merged
to master?  If so, you should tell that in the commit log message.

Message #60 received at 63627 <at> debbugs.gnu.org (full text, mbox):

From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63627 <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Sat, 16 Sep 2023 12:35:51 +0200

On 2023-09-16  12:13, Eli Zaretskii wrote:
>> Date: Thu, 14 Sep 2023 23:24:54 +0200
>> Cc: 63627 <at> debbugs.gnu.org
>> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
>>
>> Please consider for committing on emacs-29.
> 
> Thanks, but did you mean to say this should not be subsequently merged
> to master?  If so, you should tell that in the commit log message.

No, this should go to both emacs-29 and (by "automatic" subsequent
merging) also to master.  Sorry, I thought that was the default.

Thanks.

Message #65 received at 63627-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
Cc: 63627-done <at> debbugs.gnu.org
Subject: Re: bug#63627: Improve plstore.el and fix various issues of it
Date: Sat, 16 Sep 2023 14:07:31 +0300

> Date: Sat, 16 Sep 2023 12:35:51 +0200
> Cc: 63627 <at> debbugs.gnu.org
> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> 
> On 2023-09-16  12:13, Eli Zaretskii wrote:
> >> Date: Thu, 14 Sep 2023 23:24:54 +0200
> >> Cc: 63627 <at> debbugs.gnu.org
> >> From: Jens Schmidt <jschmidt4gnu <at> vodafonemail.de>
> >>
> >> Please consider for committing on emacs-29.
> > 
> > Thanks, but did you mean to say this should not be subsequently merged
> > to master?  If so, you should tell that in the commit log message.
> 
> No, this should go to both emacs-29 and (by "automatic" subsequent
> merging) also to master.

Thanks, installed on the emacs-29 branch, and closing the bug.

> Sorry, I thought that was the default.

It is indeed the default, but the non-trivial changes and something
you said about "only emacs-29 bugs" made me doubt that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.