GNU bug report logs - #63639
[PATCH] gnu: password-store: Fix program name in usage and tmpdir.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63639 in the body.
You can then email your comments to 63639 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Kortkamp <tobias.kortkamp <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Tobias Kortkamp <tobias.kortkamp <at> gmail.com>
Subject: [PATCH] gnu: password-store: Fix program name in usage and tmpdir.
Date: Mon, 22 May 2023 09:44:47 +0200

* gnu/packages/password-utils.scm (password-store): Fix program name in
usage and tmpdir.
---
 gnu/packages/password-utils.scm | 6 ++++++
 1 file changed, 6 insertions(+)

Hi,

pass from password-store uses the wrong programn name in its usage. The
program name is also used when creating temporary directories/files during
'pass edit'. It doesn't break anything though AFAICT, so this is purely a
cosmetic issue:

#+begin_src
$ pass help
[...]
Usage:
    .pass-real init [--path=subfolder,-p subfolder] gpg-id...
        Initialize new password storage and use gpg-id for encryption.
        Selectively reencrypt existing passwords using new gpg-id.
[...]
#+end_src

Thanks.

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index f5f301308a..b4cd866514 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -563,6 +563,12 @@ (define-public password-store
                                  "${PASSWORD_STORE_SYSTEM_EXTENSION_DIR:-"
                                  extension-dir
                                  "}\"\n"))))))
+         (add-before 'install 'patch-program-name
+           ;; Use pass not .pass-real in tmpdir and cmd_usage
+           (lambda _
+             (substitute* "src/password-store.sh"
+               (("^PROGRAM=.*$")
+                "PROGRAM=\"pass\"\n"))))
          (add-before 'install 'patch-passmenu-path
            ;; FIXME Wayland support requires ydotool and dmenu-wl packages
            ;; We are ignoring part of the script that gets executed if

base-commit: 849286ba66c96534bddc04df1a47d5692cbc977e
-- 
2.40.1

Message #10 received at 63639-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Tobias Kortkamp <tobias.kortkamp <at> gmail.com>
Cc: 63639-done <at> debbugs.gnu.org
Subject: Re: [bug#63639] [PATCH] gnu: password-store: Fix program name in
 usage and tmpdir.
Date: Sat, 01 Jul 2023 13:15:54 +0200

Hello,

Tobias Kortkamp <tobias.kortkamp <at> gmail.com> writes:

> * gnu/packages/password-utils.scm (password-store): Fix program name in
> usage and tmpdir.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.