GNU logs - #63651, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#63651: possible eglot xref-find-references optimization
Resent-From: Alan Donovan <adonovan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 22 May 2023 17:47:02 +0000
Resent-Message-ID: <handler.63651.B.168477758011689 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 63651 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAPVWWDXj+au=50v00jK7DNGFX33p7uyz_x+iQMGxk6Gu2p5saA@HIDDEN>
In-Reply-To: <CAPVWWDXj+au=50v00jK7DNGFX33p7uyz_x+iQMGxk6Gu2p5saA@HIDDEN>
From: Alan Donovan <adonovan@HIDDEN>
Date: Mon, 22 May 2023 13:45:57 -0400
Message-ID: <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2607:f8b0:4864:20::62a;
 envelope-from=adonovan@HIDDEN; helo=mail-pl1-x62a.google.com
X-Spam_score_int: -175
X-Spam_score: -17.6
X-Spam_bar: -----------------
X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_DEF_DKIM_WL=-7.5,
 USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hi Jo=C3=A3o & other eglot folks,

I've been doing a small amount of digging into what makes VSCode so
relatively fast. One item that I noticed is that eglot, in the loop
that it does over the references obtained from the LSP server, calls
find-buffer-visiting to avoid re-reading files that are already open
in buffers. I'm not sure whether this is just an optimization, or
whether it is necessary to ensure that modified buffer contents are
rendered correctly, but it's noticeably slow: for one large query that
results in an xref buffer of 1300 lines, the operation takes about 2s
normally, but only about 0.8s when I replace the find-buffer-visiting
call with false. (According to the elisp CPU profiler,
find-buffer-visiting calls file-truename, recursively, a lot.)

(defun eglot--xref-make-match (name uri range)
  "Like `xref-make-match' but with LSP's NAME, URI and RANGE.
Try to visit the target file for a richer summary line."
  (pcase-let*
      ((file (eglot--uri-to-path uri))
       (visiting (or (find-buffer-visiting file) ;; <--- replace this with =
false
                     (gethash uri eglot--temp-location-buffers)))
       (collect (lambda ()
...

Would that change be sound? Or is it necessary for the reason I
guessed at (or some other reason)?

cheers
alan

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Alan Donovan <adonovan@HIDDEN>
Subject: bug#63651: Acknowledgement (possible eglot xref-find-references
 optimization)
Message-ID: <handler.63651.B.168477758011689.ack <at> debbugs.gnu.org>
References: <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
X-Gnu-PR-Message: ack 63651
X-Gnu-PR-Package: emacs
Reply-To: 63651 <at> debbugs.gnu.org
Date: Mon, 22 May 2023 17:47:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 63651 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
63651: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63651
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#63651: possible eglot xref-find-references optimization
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 24 May 2023 16:30:03 +0000
Resent-Message-ID: <handler.63651.B63651.168494575927471 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Alan Donovan <adonovan@HIDDEN>
Cc: 63651 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAPVWWDXj+au=50v00jK7DNGFX33p7uyz_x+iQMGxk6Gu2p5saA@HIDDEN>
 <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
In-Reply-To: <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Wed, 24 May 2023 17:28:58 +0100
Message-ID: <CALDnm51L=uL3nmh3Zj6AGh3pma9b7p5paJXVX7=2=DxUYDopRA@HIDDEN>
Content-Type: multipart/alternative; boundary="000000000000ee784605fc730060"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--000000000000ee784605fc730060
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for reporting this Alan, it is an interesting point. (Next time you
can add me on CC directly so that i don't miss the message in this list,
which i don't always track closely)

Could you provide a test case where these ~=3D 1300 xref matches are
produced? I suppose it is some Go repository? With a standard gopls? But
which file/position and which command should one use?

Thanks,
Jo=C3=A3o

--000000000000ee784605fc730060
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div>Thanks for reporting this Alan, it is an interesting=
 point. (Next time you can add me on CC directly so that i don&#39;t miss t=
he message in this list, which i don&#39;t always track closely)</div><div =
dir=3D"auto"><br></div><div dir=3D"auto">Could you provide a test case wher=
e these ~=3D 1300 xref matches are produced? I suppose it is some Go reposi=
tory? With a standard gopls? But which file/position and which command shou=
ld one use?</div><div dir=3D"auto"><br></div><div dir=3D"auto">Thanks,</div=
><div dir=3D"auto">Jo=C3=A3o</div></div>

--000000000000ee784605fc730060--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#63651: possible eglot xref-find-references optimization
Resent-From: Alan Donovan <adonovan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 24 May 2023 21:24:02 +0000
Resent-Message-ID: <handler.63651.B63651.16849633905935 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 63651 <at> debbugs.gnu.org
MIME-Version: 1.0
References: <CAPVWWDXj+au=50v00jK7DNGFX33p7uyz_x+iQMGxk6Gu2p5saA@HIDDEN>
 <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
 <CALDnm51L=uL3nmh3Zj6AGh3pma9b7p5paJXVX7=2=DxUYDopRA@HIDDEN>
In-Reply-To: <CALDnm51L=uL3nmh3Zj6AGh3pma9b7p5paJXVX7=2=DxUYDopRA@HIDDEN>
From: Alan Donovan <adonovan@HIDDEN>
Date: Wed, 24 May 2023 17:22:48 -0400
Message-ID: <CAPVWWDUqoJWUEF9-2ziMiTtFdA_EqV07ME-uSjGv+GWp=cgO0Q@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Wed, 24 May 2023 at 12:29, Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> =
wrote:
> Thanks for reporting this Alan, it is an interesting point. (Next time yo=
u can add me on CC directly so that i don't miss the message in this list, =
which i don't always track closely)

Will do.

> Could you provide a test case where these ~=3D 1300 xref matches are prod=
uced? I suppose it is some Go repository? With a standard gopls? But which =
file/position and which command should one use?

$ git clone https://github.com/golang/tools
$ cd tools
$ (cd gopls && go install)   # if you don't have it already
$ emacs gopls/internal/lsp/cache/analysis.go
Then search for fmt.Sprintf (e.g. on L246) and do xref-find-references
on it. I get about 1300 matches.

cheers
alan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#63651: possible eglot xref-find-references optimization
Resent-From: Alan Donovan <adonovan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Jul 2023 13:57:01 +0000
Resent-Message-ID: <handler.63651.B63651.168847898118920 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 63651
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 63651 <at> debbugs.gnu.org
Received: via spool by 63651-submit <at> debbugs.gnu.org id=B63651.168847898118920
          (code B ref 63651); Tue, 04 Jul 2023 13:57:01 +0000
Received: (at 63651) by debbugs.gnu.org; 4 Jul 2023 13:56:21 +0000
Received: from localhost ([127.0.0.1]:36387 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qGgVx-0004v6-FV
	for submit <at> debbugs.gnu.org; Tue, 04 Jul 2023 09:56:21 -0400
Received: from mail-pl1-f175.google.com ([209.85.214.175]:36118)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <adonovan@HIDDEN>) id 1qGgVr-0004uz-FS
 for 63651 <at> debbugs.gnu.org; Tue, 04 Jul 2023 09:56:20 -0400
Received: by mail-pl1-f175.google.com with SMTP id
 d9443c01a7336-1b8161f564dso491665ad.1
 for <63651 <at> debbugs.gnu.org>; Tue, 04 Jul 2023 06:56:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20221208; t=1688478969; x=1691070969;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=tS7/4BHRg0i3eUf70kn3Z0ziiP0o/bI6LQnzMzoQKsM=;
 b=bSB9unV3pU3vThCTO5nBR1f0Dm2eorMlsYZdsKc1v4TJW4xTQGk1d0rw68M3M8OhLF
 55faofl3dqc3g9G5vbACchc9AVZ07epP5QVoHXZLFHWLIm7MfWqsXy4T3zAZrdFwLLer
 FDhJxyV768O4sDrJPE59gxwLz49g28yLJlFyAY34ZNTgGybBjhoINOvYvW37YPD2XaEB
 lYXkoiyWdDxSsZv5eruScm3tWGYGO25MBWMgIXgGUmiw/SfCcegvkKpcEJu2hTDg4eiU
 XKSXa5hLhqvA18Q0Of/suF8YIQ8KYoiIinoitAILs0fkGuHnmBGezwvSCE/gvOz8I+fI
 XlbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1688478969; x=1691070969;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=tS7/4BHRg0i3eUf70kn3Z0ziiP0o/bI6LQnzMzoQKsM=;
 b=kk2i6fpZ8jI6XM65rxQjD8sY2s1FQIQHR2f44cVl+P3EXHqQi6eqo7DKy11scikk7U
 F8nHFpOVPH8KaoNN61jVek/F/wS3J1qkNpOu8FwP9iDIm18uQasB00H37GLZxjh7uEDO
 6Sq+T2Km0GCD9UfjrisC0u7xfgf4qW8DcCR/F7m49B96p61DH+0+4RMwIkOAsFQ7iIAL
 CHHs2A3HQYO0QaooX7wWUWk5rrVwoHsme7H++pxADIPVM97xlE7MCAzmUVEgV6qXYnSg
 Pe8AszPTCGiPLPt44XS2XBfuZn47+LoVH2mRHdEuiZMpcj6xxiDMj8Vs72qdlsrlQ6pr
 5KZw==
X-Gm-Message-State: ABy/qLaedccoDMyTXcjw3aidqum8ZH5Xzn5Dz8YQww8YTWOSdqMs5ywo
 s1UMiFH0SrBQ/yEwsfrwu3/K6aNqLy0dkVJckjuGXQ==
X-Google-Smtp-Source: APBJJlFbq8IDVdx5Ru6uozYCH8Ud/dJGe7KeelxMzn+FbLak0uCX7Z9smAVmZxUExwCezsc6J2da1ugmkgYpxKIVZHk=
X-Received: by 2002:a17:902:e742:b0:1ae:4bbb:e971 with SMTP id
 p2-20020a170902e74200b001ae4bbbe971mr151167plf.19.1688478969275; Tue, 04 Jul
 2023 06:56:09 -0700 (PDT)
MIME-Version: 1.0
References: <CAPVWWDXj+au=50v00jK7DNGFX33p7uyz_x+iQMGxk6Gu2p5saA@HIDDEN>
 <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
 <CALDnm51L=uL3nmh3Zj6AGh3pma9b7p5paJXVX7=2=DxUYDopRA@HIDDEN>
 <CAPVWWDUqoJWUEF9-2ziMiTtFdA_EqV07ME-uSjGv+GWp=cgO0Q@HIDDEN>
In-Reply-To: <CAPVWWDUqoJWUEF9-2ziMiTtFdA_EqV07ME-uSjGv+GWp=cgO0Q@HIDDEN>
From: Alan Donovan <adonovan@HIDDEN>
Date: Tue, 4 Jul 2023 09:55:57 -0400
Message-ID: <CAPVWWDVZBOT7zddtgksGUsZgX1T_ALDrxeNixePJY4bmUVjw4A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -8.0 (--------)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -9.0 (---------)

Any progress? Were you able to observe the problem?

cheers
alan

On Wed, 24 May 2023 at 17:22, Alan Donovan <adonovan@HIDDEN> wrote:
>
> On Wed, 24 May 2023 at 12:29, Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN=
> wrote:
> > Thanks for reporting this Alan, it is an interesting point. (Next time =
you can add me on CC directly so that i don't miss the message in this list=
, which i don't always track closely)
>
> Will do.
>
> > Could you provide a test case where these ~=3D 1300 xref matches are pr=
oduced? I suppose it is some Go repository? With a standard gopls? But whic=
h file/position and which command should one use?
>
> $ git clone https://github.com/golang/tools
> $ cd tools
> $ (cd gopls && go install)   # if you don't have it already
> $ emacs gopls/internal/lsp/cache/analysis.go
> Then search for fmt.Sprintf (e.g. on L246) and do xref-find-references
> on it. I get about 1300 matches.
>
> cheers
> alan

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Sep 2023 23:10:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 11 19:10:51 2023
Received: from localhost ([127.0.0.1]:55097 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qfq3O-0002cZ-Nq
	for submit <at> debbugs.gnu.org; Mon, 11 Sep 2023 19:10:50 -0400
Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:54658)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1qfq3L-0002cK-9g
 for control <at> debbugs.gnu.org; Mon, 11 Sep 2023 19:10:49 -0400
Received: by mail-lj1-x233.google.com with SMTP id
 38308e7fff4ca-2bce552508fso82556171fa.1
 for <control <at> debbugs.gnu.org>; Mon, 11 Sep 2023 16:10:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1694473837; x=1695078637; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=GgnH+3ZH43XUL2sEk5N3bB6gsfqL4UzfPOHacr21WDM=;
 b=JuQr1I75gRUKwA7IGeXKXI+CG+/NC7RmmXCSipWYsC9SD9V0KjVgRDa0KBW24SqSlr
 oYWN0BRCG8J+6ZJaWavVEr8NY14KxuL0DUAWNJXK9KtT3/9rA6golNdwelp4Anm8xnsV
 GQ28MUZg/UHDD8c89ol1tbdjdjnRLXCaFtFYTVjeNPh698hvfLFEO78Kr7Qqgp6keybZ
 CSrh1jo1zisSZOLXXUuE01QODnBjbJN1ok+GUu4DWmfbccE3HWztc2AIYb7HqR5bnUYl
 Ky8DN1XUVYXPMQd/RRL18NcFWghfMbkCqHAVvnIr9vPE8WwTihvml5f3bDMVsJ9VLh+0
 VZfA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1694473837; x=1695078637;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=GgnH+3ZH43XUL2sEk5N3bB6gsfqL4UzfPOHacr21WDM=;
 b=vBFnK9vyLOFurcs7+Y3hQMaeD6JJ6F1mrIvPcFxvan8XIroMbZnhgBh7k3540jpvdb
 tVhVOZevr61CCJBXAxBrA9mzSyygE9XOYPiIcCR4JbNralML/C1kK1V89QtlxxRI0l+u
 mgl0Iz7ybnU24j1fEFyMcCqPrhaaa1+PsngXYGyZZFL0uOQCnc/rHg+QBeeE3w8u5IhZ
 94/DlE5HCvr9ULPrb2alCkrfhPA1/NY2wxy+QkliTPidFNOXPf3T7JUKXaNUEK5D6ZBH
 vfdjNBSFljPW9v2stj78I5IX1rfGdIl6gRsLNTHlD59eV3FP+xeFBH6CYGOWFVDocOJW
 4IMg==
X-Gm-Message-State: AOJu0YwHP4lDVuOdtVfTS8KuxBjwhSNIkGb4ARmktIAGPuRELwIycF8Z
 6pKNaestWPX94Si3V/cIeXblzNQh+hGptRqjHZ9LAZn4
X-Google-Smtp-Source: AGHT+IHYMELfKeS45DrekAI6MsTM7zdGQU+ZgxM2GL7sftHW/yU2xKW+Xh4VOdn16nRa/Mcfs2yR6887G0u7uEffvKs=
X-Received: by 2002:a2e:9c94:0:b0:2bc:e02f:8f50 with SMTP id
 x20-20020a2e9c94000000b002bce02f8f50mr8146964lji.14.1694473836563; Mon, 11
 Sep 2023 16:10:36 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 11 Sep 2023 16:10:36 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 11 Sep 2023 16:10:36 -0700
Message-ID: <CADwFkmn2xwDt4Qmj19U+4n0OKetTCUojgVkpJnHjNZeKk15ECg@HIDDEN>
Subject: control message for bug #63651
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 63651 wishlist
quit

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#63651: possible eglot xref-find-references optimization
Resent-From: Dmitry Gutov <dmitry@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 04 Oct 2024 23:37:01 +0000
Resent-Message-ID: <handler.63651.B63651.172808500918361 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 63651
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Alan Donovan <adonovan@HIDDEN>, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 63651 <at> debbugs.gnu.org
Received: via spool by 63651-submit <at> debbugs.gnu.org id=B63651.172808500918361
          (code B ref 63651); Fri, 04 Oct 2024 23:37:01 +0000
Received: (at 63651) by debbugs.gnu.org; 4 Oct 2024 23:36:49 +0000
Received: from localhost ([127.0.0.1]:36846 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1swrqq-0004m5-Kx
	for submit <at> debbugs.gnu.org; Fri, 04 Oct 2024 19:36:48 -0400
Received: from fhigh-a3-smtp.messagingengine.com ([103.168.172.154]:44889)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1swrqo-0004lq-3K
 for 63651 <at> debbugs.gnu.org; Fri, 04 Oct 2024 19:36:47 -0400
Received: from phl-compute-08.internal (phl-compute-08.phl.internal
 [10.202.2.48])
 by mailfhigh.phl.internal (Postfix) with ESMTP id E3A8E11401B9;
 Fri,  4 Oct 2024 19:36:35 -0400 (EDT)
Received: from phl-mailfrontend-02 ([10.202.2.163])
 by phl-compute-08.internal (MEProxy); Fri, 04 Oct 2024 19:36:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm1; t=1728084995;
 x=1728171395; bh=BQB0djYY0FwPzAMUl3fu0ClYwyyCn8RXizz+vj7Drvo=; b=
 Aix49RM2e2L2LUlvIcK8maXEznDphHl144RzF3vH6de1nRGUYmSdE52OFq/L3f1q
 EeaYkjnTQdmgnWO6pwIxrh1WZepvFOVPR0mh3Ah9g6Xz2FlGIezCN4FjnzDCEwvV
 lpXxQdg4wcpCW85ajyEkP7f5k1Ct69CEdcQi96ShI0nOsMpSWp7odsxpNp0GNt+I
 jnu4JYnz8giWthEYCyGSOAnP7bnO10We6mHusnKB0rHxcXOFa2Crrw5x2aSj3xPi
 zHLL7epzM6iOd34nIQ0ISeIlyU2q8WxWNkIY8byHqpwq7rGxk6EKgrNsZseCRFUV
 MZLSegqHdhksa62XtHwRwg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728084995; x=
 1728171395; bh=BQB0djYY0FwPzAMUl3fu0ClYwyyCn8RXizz+vj7Drvo=; b=c
 7eRZdNjAu6PbvGjHD2e7yOIO/S698t42SSGQ5Xo+qfLRLmZtxTdBchMip5YEiqH0
 /kOUpC2X7/6NIeT7xC/4nwMquVPaShicIvNtb4/cFzZi7qHQr3lE/inqIpE8Uqif
 Y96dSLjmA7V9VCm8DTbd3k8PeKx0rt7lR+ZbwB5XTE3ZCBpb7Mh3qDi2S8+kEMm/
 zPQJcX4NZ3DpFbOTdZCt+MVArSFu3DeYd3gQf/qWT1uCNNPPF8FrZbFcFethq3IO
 32cp8b2cf11M/RBSnq00fpoYYnb6OMLKWfcTLCT5wMI7f7TX01YABfJfhVzfAovu
 2bn5LsZ6KSYMgdBXFzoQg==
X-ME-Sender: <xms:A3wAZ7OhxxlIgGAWPivKkA1Fkpv_1cvK-Y-tAqVpXxOFFnPyTvJBCg>
 <xme:A3wAZ1_HQOh5x4Z2UzcMWXd1iTS2sH-YlYf3MgaTwrWj3Qi3KqPBExx2UBwLLWu06
 TCd-TQG-bEjTdO96pM>
X-ME-Received: <xmr:A3wAZ6SVqDu3lERDaywY5KV1JasI_xkHL_gSC0cskZZvid-f_pySd16nRxEcTUkWugI>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvgedgvdehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
 rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
 htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej
 necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug
 gvvheqnecuggftrfgrthhtvghrnhepvddttdefvdfhhffglefhleejtefhueetkeejhfeh
 ieekheefveegtefgieekteevnecuffhomhgrihhnpehgnhhurdhorhhgpdhgihhthhhusg
 drtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm
 pegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthhtohepfedpmhhouggvpe
 hsmhhtphhouhhtpdhrtghpthhtoheprgguohhnohhvrghnsehgohhoghhlvgdrtghomhdp
 rhgtphhtthhopehjohgrohhtrghvohhrrgesghhmrghilhdrtghomhdprhgtphhtthhope
 eifeeiheduseguvggssghughhsrdhgnhhurdhorhhg
X-ME-Proxy: <xmx:A3wAZ_t6TE1mElo147OpVcinregBgaaOm4ZsJUgnC-Q9Lk_d1ThY2g>
 <xmx:A3wAZzejteUmIlsaQppIC9UMYCXajhW33SY99Nine3XOYswiqXdSBA>
 <xmx:A3wAZ72ElKhszKUicZd3AEipY861eQhKme89S83gIVr4laqM0rDThw>
 <xmx:A3wAZ__jV-2gtT3o7fBYXdRRW_zEtac3tKNVAVYzolg7oc5YDHUP8g>
 <xmx:A3wAZ_7kj3GM3N6b_-6ktIZOwufxNaglOF91RlkR3Ru0KzI3Kk5Kt12A>
Feedback-ID: i07de48aa:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
 4 Oct 2024 19:36:33 -0400 (EDT)
Message-ID: <bccc9e43-038b-47d8-b346-1885da777aa1@HIDDEN>
Date: Sat, 5 Oct 2024 02:36:30 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <CAPVWWDXj+au=50v00jK7DNGFX33p7uyz_x+iQMGxk6Gu2p5saA@HIDDEN>
 <CAPVWWDVVA+pp6Yo4e=hDysii_0HL8pJQ+HzLXUPWNePxcdnQfQ@HIDDEN>
 <CALDnm51L=uL3nmh3Zj6AGh3pma9b7p5paJXVX7=2=DxUYDopRA@HIDDEN>
 <CAPVWWDUqoJWUEF9-2ziMiTtFdA_EqV07ME-uSjGv+GWp=cgO0Q@HIDDEN>
 <CAPVWWDVZBOT7zddtgksGUsZgX1T_ALDrxeNixePJY4bmUVjw4A@HIDDEN>
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <CAPVWWDVZBOT7zddtgksGUsZgX1T_ALDrxeNixePJY4bmUVjw4A@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi!

On 04/07/2023 16:55, Alan Donovan via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> Any progress? Were you able to observe the problem?

Sorry this report got dropped.

I've tried reproducing and see some difference when using Emacs 29. 
Since as you mention it's due to find-buffer-visiting call, this likely 
only manifests with a significant number of buffers open.

'git blame' on the call in question leads to 
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=306feb7d967e - I 
haven't dug in too much further to say more.

But I suggest you retry your scenario using Emacs 30 (currently in 
pretest) - performance of find-buffer-visiting is improve in it. Seems 
to make a difference here.

> cheers
> alan
> 
> On Wed, 24 May 2023 at 17:22, Alan Donovan <adonovan@HIDDEN> wrote:
>>
>> On Wed, 24 May 2023 at 12:29, João Távora <joaotavora@HIDDEN> wrote:
>>> Thanks for reporting this Alan, it is an interesting point. (Next time you can add me on CC directly so that i don't miss the message in this list, which i don't always track closely)
>>
>> Will do.
>>
>>> Could you provide a test case where these ~= 1300 xref matches are produced? I suppose it is some Go repository? With a standard gopls? But which file/position and which command should one use?
>>
>> $ git clone https://github.com/golang/tools
>> $ cd tools
>> $ (cd gopls && go install)   # if you don't have it already
>> $ emacs gopls/internal/lsp/cache/analysis.go
>> Then search for fmt.Sprintf (e.g. on L246) and do xref-find-references
>> on it. I get about 1300 matches.
>>
>> cheers
>> alan
> 
> 
>

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.