GNU bug report logs - #63653
29.0.91; [PATCH] More fix for loading SQLite extensions

Previous Next

Package: emacs;

Reported by: lin Sun <sunlin7 <at> yahoo.com>

Date: Tue, 23 May 2023 04:30:03 UTC

Severity: normal

Tags: patch

Found in version 29.0.91

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63653 in the body.
You can then email your comments to 63653 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#63653; Package emacs. (Tue, 23 May 2023 04:30:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to lin Sun <sunlin7 <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 23 May 2023 04:30:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7 <at> yahoo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 04:28:34 +0000
Hi Eli,

There is a build error after I pull the last emacs-29 branch, tried
build on CentOS 7.
> use of undeclared identifier emacs 'SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION'
The macro SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION is defined since
SQLite 3.13 (2016 May).
CentOS 7 will end by 2024 June 30, so this patch is still useful.

Best Regards
Lin




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63653; Package emacs. (Tue, 23 May 2023 07:10:01 GMT) Full text and rfc822 format available.

Message #8 received at 63653 <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7.mail <at> gmail.com>
To: 63653 <at> debbugs.gnu.org
Subject: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 04:36:08 +0000
[Message part 1 (text/plain, inline)]
Attachments
[0001-More-fix-for-loading-SQLite-extensions.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63653; Package emacs. (Tue, 23 May 2023 07:10:02 GMT) Full text and rfc822 format available.

Message #11 received at 63653 <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7.mail <at> gmail.com>
To: 63653 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 04:52:45 +0000
[Message part 1 (text/plain, inline)]
Sorry for no PATH file in my previous mail.
Here's the path file.
[0001-More-fix-for-loading-SQLite-extensions.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63653; Package emacs. (Tue, 23 May 2023 11:33:01 GMT) Full text and rfc822 format available.

Message #14 received at 63653 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lin Sun <sunlin7.mail <at> gmail.com>
Cc: 63653 <at> debbugs.gnu.org
Subject: Re: bug#63653: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 14:33:13 +0300
> From: lin Sun <sunlin7.mail <at> gmail.com>
> Date: Tue, 23 May 2023 04:36:08 +0000
> 
> Attachments

Thanks.  But in that case this is not the right patch.  If SQLite3
cannot support enabling and disabling loading of extensions, it means
we cannot support extension loading with such old SQLite3 versions.

So I've now installed a slightly different fix on the emacs-29 branch;
please try it.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63653; Package emacs. (Tue, 23 May 2023 14:23:01 GMT) Full text and rfc822 format available.

Message #17 received at 63653 <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7.mail <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63653 <at> debbugs.gnu.org
Subject: Re: bug#63653: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 13:40:39 +0000
[Message part 1 (text/plain, inline)]
Hi Eli,

It works for me with the latest change on sqlite.c. Thank you !
And now I want add one line to support loading extensions with *.dylib,
Please help review the patch . Thanks
[0001-src-sqlite.c-sqlite-load-extension-Also-load-from-th.patch (text/x-patch, attachment)]

Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Tue, 23 May 2023 14:55:01 GMT) Full text and rfc822 format available.

Notification sent to lin Sun <sunlin7 <at> yahoo.com>:
bug acknowledged by developer. (Tue, 23 May 2023 14:55:02 GMT) Full text and rfc822 format available.

Message #22 received at 63653-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lin Sun <sunlin7.mail <at> gmail.com>
Cc: 63653-done <at> debbugs.gnu.org
Subject: Re: bug#63653: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 17:54:32 +0300
> From: lin Sun <sunlin7.mail <at> gmail.com>
> Date: Tue, 23 May 2023 13:40:39 +0000
> Cc: 63653 <at> debbugs.gnu.org
> 
> And now I want add one line to support loading extensions with *.dylib,
> Please help review the patch . Thanks

Thanks, I installed something similar.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63653; Package emacs. (Tue, 23 May 2023 16:38:01 GMT) Full text and rfc822 format available.

Message #25 received at 63653-done <at> debbugs.gnu.org (full text, mbox):

From: lin Sun <sunlin7.mail <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63653-done <at> debbugs.gnu.org
Subject: Re: bug#63653: 29.0.91; [PATCH] More fix for loading SQLite extensions
Date: Tue, 23 May 2023 08:01:17 -0700
[Message part 1 (text/plain, inline)]
Great, see the changes. Thanks!

On Tue, May 23, 2023, 07:54 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: lin Sun <sunlin7.mail <at> gmail.com>
> > Date: Tue, 23 May 2023 13:40:39 +0000
> > Cc: 63653 <at> debbugs.gnu.org
> >
> > And now I want add one line to support loading extensions with *.dylib,
> > Please help review the patch . Thanks
>
> Thanks, I installed something similar.
>
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 21 Jun 2023 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 310 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.