GNU bug report logs - #63669
Cutter package is heavily outdated and uses wrong backend

Previous Next

Package: guix;

Reported by: XVilka Haos of System <xvilka <at> gmail.com>

Date: Tue, 23 May 2023 16:39:02 UTC

Severity: normal

Merged with 60413

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63669 in the body.
You can then email your comments to 63669 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#63669; Package guix. (Tue, 23 May 2023 16:39:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to XVilka Haos of System <xvilka <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Tue, 23 May 2023 16:39:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: XVilka Haos of System <xvilka <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: Cutter package is heavily outdated and uses wrong backend
Date: Tue, 23 May 2023 22:34:31 +0800
Hi!
Regarding the package https://packages.guix.gnu.org/packages/cutter/

Since Cutter 2.x versions, it switched from Radare2 to Rizin as a
backend (a fork of Radare2). Meanwhile, Radare2 developers renamed
their GUI to "Iaito":

The latest available Cutter release at this time (May 23, 2023) is
2.2.1, and the corresponding Rizin release is 0.5.2

Since Guix already has packaged Rizin, upgrading the Cutter package
should be straightforward:
https://packages.guix.gnu.org/packages/rizin

**Links for the reference**

- https://cutter.re
- https://github.com/rizinorg/cutter
- https://rizin.re/posts/faq/
- https://github.com/radareorg/iaito
- https://repology.org/project/cutter-re/versions
- https://repology.org/project/rizin/versions

**Release links**

- https://github.com/rizinorg/cutter/releases/tag/v2.2.1
- https://github.com/rizinorg/rizin/releases/tag/v0.5.2

Best regards,
XVilka.




Merged 60413 63669. Request was from Csepp <raingloom <at> riseup.net> to control <at> debbugs.gnu.org. (Wed, 24 May 2023 06:14:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#63669; Package guix. (Thu, 25 May 2023 18:34:04 GMT) Full text and rfc822 format available.

Message #10 received at 63669 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: XVilka Haos of System <xvilka <at> gmail.com>, 63669 <at> debbugs.gnu.org
Subject: Re: bug#63669: Cutter package is heavily outdated and uses wrong
 backend
Date: Thu, 25 May 2023 20:33:32 +0200
Hi,

On mar., 23 mai 2023 at 22:34, XVilka Haos of System <xvilka <at> gmail.com> wrote:

> Since Guix already has packaged Rizin, upgrading the Cutter package
> should be straightforward:
> https://packages.guix.gnu.org/packages/rizin

Do you want to give a try?  Maybe this update is a good candidate for a
contribution. :-)


Cheers,
simon




Information forwarded to bug-guix <at> gnu.org:
bug#63669; Package guix. (Sat, 13 Apr 2024 20:37:02 GMT) Full text and rfc822 format available.

Message #13 received at 63669 <at> debbugs.gnu.org (full text, mbox):

From: Juliana Sims <juli <at> incana.org>
To: zimon.toutoune <at> gmail.com
Cc: 63669 <at> debbugs.gnu.org, xvilka <at> gmail.com, raingloom <at> riseup.net
Subject: Re: Cutter package is heavily outdated and uses wrong backend
Date: Sat, 13 Apr 2024 16:36:06 -0400
Hello,

I've managed to package the latest version of Cutter, thanks in part to 
Rizin now being in Guix.

I was not able to enable Python-based plugins because python-pyside-2 
was unable to find the include directory for one of its inputs (also an 
input to Cutter), specifically <QtQml/qqml.h>. I suspect this is due to 
the way python-pyside-2 is packaged. Input include paths are manually 
exposed to the C++ compiler by an environment variable rather than 
through the build system itself. I'm already several tangents away from 
where I started before deciding to update Cutter, though, so I don't 
think I'll bother with that for this patchset. From what I understand, 
the version of Cutter this package definition builds already has more 
functionality than the version that existed before the update, backend 
change aside.

I'm now trying to get the rz-ghidra and jsdec decompiler plugins 
(recommended to Linux distribution packagers by the Cutter build docs) 
to work as well, but I'm having trouble making sure Cutter can find 
them. Specifically, I have rz-ghidra successfully building and 
installing where it probably should, 
"/share/rizin/cutter/plugins/native" in its package directory. Since I 
don't know for sure how to install plugins yet I haven't started on 
jsdec.

I'm tempted to just abandon the plugins idea and say this is good 
enough. Anyone have thoughts or opinions about that?

Thanks,
Juli






Information forwarded to bug-guix <at> gnu.org:
bug#63669; Package guix. (Sun, 14 Apr 2024 03:03:05 GMT) Full text and rfc822 format available.

Message #16 received at 63669 <at> debbugs.gnu.org (full text, mbox):

From: Juliana Sims <juli <at> incana.org>
To: guix-patches <at> gnu.org
Cc: Juliana Sims <juli <at> incana.org>, 63669 <at> debbugs.gnu.org, raingloom <at> riseup.net,
 xvilka <at> gmail.com, zimon.toutoune <at> gmail.com
Subject: [PATCH] gnu: cutter: Update to 2.3.4.
Date: Sat, 13 Apr 2024 22:54:56 -0400
Hello,

This patch updates Cutter to the latest version and removes an unneeded radare2
package. It closes issue 63669.

Disregard my comments on that issue. I decided against packaging the decompilers
so there is no reason to enable all of the other options. This is great because
enabling all of them increases the package closure's size by 1.5GB. By contrast,
this version's entire closure is more like 1.1GB.

I do have patches for both rz-ghidra and the "full" version of Cutter if they
prove desirable. I did not manage to resolve the plugin discovery issue, but I
did manage to build Cutter with Python plugin support.

Thanks,
Juli

* gnu/packages/engineering.scm (cutter): Update to 2.3.4.
(radare2-for-cutter): Delete.
---
 gnu/packages/engineering.scm | 75 +++++++++++++-----------------------
 1 file changed, 26 insertions(+), 49 deletions(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 6f42d674e51..c68c49adf0f 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2023 Theofilos Pechlivanis <theofilos.pechlivanis <at> gmail.com>
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2023 pinoaffe <pinoaffe <at> gmail.com>
+;;; Copyright © 2024 Juliana Sims <juli <at> incana.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2491,67 +2492,43 @@ (define-public gnucap
 simulation.")
     (license license:gpl3+)))
 
-(define-public radare2-for-cutter
-  (package
-    (inherit radare2)
-    (name "radare2")
-    (version "5.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/radareorg/radare2")
-                    (commit version)))
-              (sha256
-               (base32
-                "0aa7c27kd0l55fy5qfvxqmakp4pz6240v3hn84095qmqkzcbs420"))
-              (file-name (git-file-name name version))))))
-
 (define-public cutter
   (package
     (name "cutter")
-    (version "1.12.0")
+    (version "2.3.4")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/rizinorg/cutter")
-             (commit (string-append "v" version))))
+             (commit (string-append "v" version))
+             (recursive? #t)))
+       (snippet #~((@ (guix build utils) delete-file-recursively)
+                   "rizin"))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0ljj3j3apbbw628n2nyrxpbnclixx20bqjxm0xwggqzz9vywsar0"))))
-    (build-system gnu-build-system)
+        (base32 "0d10g1wpw8p8hcxvw5q7ymfdxyrp4xqs6a49lf3gdgnmcpb248ad"))))
+    (build-system qt-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out"))
-                   (radare2 (assoc-ref inputs "radare2")))
-               ;; Fix pkg-config detection ./src/lib_radare2.pri:PREFIX=/usr/lib
-               ;; override `qmake PREFIX=`.
-               (substitute* "./src/lib_radare2.pri"
-                 (("PREFIX") "R2PREFIX")
-                 (("R2PREFIX=/usr") (string-append "R2PREFIX=" radare2)))
-               (invoke "qmake"
-                       (string-append "PREFIX=" out)
-                       "./src/Cutter.pro")))))))
-    (native-inputs
-     (list pkg-config))
-    (inputs
-     (list qtbase-5
-           qtsvg-5
-           openssl
-           ;; Depends on radare2 4.5.1 officially, builds and works fine with
-           ;; radare2 5.0.0 but fails to build with radare2 5.1.1.
-           radare2-for-cutter))
+     (list
+      #:configure-flags #~(list "-DCUTTER_USE_BUNDLED_RIZIN=OFF")
+      #:tests? #f)) ;no tests
+    (native-inputs (list pkgconf))
+    (inputs (list libzip
+                  openssl
+                  qtsvg-5
+                  qttools-5
+                  rizin
+                  zlib))
     (home-page "https://cutter.re")
-    (synopsis "GUI for radare2 reverse engineering framework")
-    (description "Cutter is a GUI for radare2 reverse engineering framework.
-Its goal is making an advanced andcustomizable reverse-engineering platform
-while keeping the user experience at mind.  Cutter is created by reverse
-engineers for reverse engineers.")
-    (license (list license:cc-by-sa3.0  ;the "Iconic" icon set
-                   license:gpl3+))))    ;everything else
+    (synopsis "Software reverse engineering platform")
+    (description
+     "Cutter is a free and open-source reverse engineering platform powered by
+@code{rizin}.  It aims to be an advanced and customizable reverse engineering
+platform while keeping the user experience in mind.  Cutter is created by
+reverse engineers for reverse engineers.")
+    (license (list license:cc-by-sa3.0 ;the "Iconic" icon set
+                   license:gpl3+))))   ;everything else
 
 (define-public lib3mf
   (package

base-commit: 238e4ec73e4143f3a5a85b56ca00d395cdf60197
-- 
2.41.0





Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Tue, 11 Jun 2024 21:57:02 GMT) Full text and rfc822 format available.

Notification sent to XVilka Haos of System <xvilka <at> gmail.com>:
bug acknowledged by developer. (Tue, 11 Jun 2024 21:57:02 GMT) Full text and rfc822 format available.

Message #21 received at 63669-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Juliana Sims <juli <at> incana.org>
Cc: 70371-done <at> debbugs.gnu.org, zimon.toutoune <at> gmail.com, raingloom <at> riseup.net,
 xvilka <at> gmail.com, 63669-done <at> debbugs.gnu.org
Subject: Re: [bug#70371] [PATCH] gnu: cutter: Update to 2.3.4.
Date: Tue, 11 Jun 2024 23:56:21 +0200
[Message part 1 (text/plain, inline)]
Hi Juliana,

Juliana Sims <juli <at> incana.org> skribis:

> * gnu/packages/engineering.scm (cutter): Update to 2.3.4.
> (radare2-for-cutter): Delete.

Applied with the cosmetic changes below.  Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 2dbbaaa040f..e518d24fa2f 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2504,8 +2504,8 @@ (define-public cutter
              (url "https://github.com/rizinorg/cutter")
              (commit (string-append "v" version))
              (recursive? #t)))
-       (snippet #~((@ (guix build utils) delete-file-recursively)
-                   "rizin"))
+       (modules '((guix build utils)))
+       (snippet #~(delete-file-recursively "rizin"))
        (file-name (git-file-name name version))
        (sha256
         (base32 "0d10g1wpw8p8hcxvw5q7ymfdxyrp4xqs6a49lf3gdgnmcpb248ad"))))
@@ -2524,10 +2524,10 @@ (define-public cutter
     (home-page "https://cutter.re")
     (synopsis "Software reverse engineering platform")
     (description
-     "Cutter is a free and open-source reverse engineering platform powered by
-@code{rizin}.  It aims to be an advanced and customizable reverse engineering
-platform while keeping the user experience in mind.  Cutter is created by
-reverse engineers for reverse engineers.")
+     "Cutter is a reverse engineering platform powered by @code{rizin}.  It
+aims to be an advanced and customizable reverse engineering platform while
+keeping the user experience in mind.  Cutter is created by reverse engineers
+for reverse engineers.")
     (license (list license:cc-by-sa3.0 ;the "Iconic" icon set
                    license:gpl3+))))   ;everything else
 

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Tue, 11 Jun 2024 21:57:02 GMT) Full text and rfc822 format available.

Notification sent to Csepp <raingloom <at> riseup.net>:
bug acknowledged by developer. (Tue, 11 Jun 2024 21:57:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Jul 2024 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 303 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.