GNU bug report logs - #63674
30.0.50; Possible miscompilation of cl-structs?

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> posteo.net>

Date: Wed, 24 May 2023 03:49:02 UTC

Severity: normal

Found in version 30.0.50

Done: Brian Leung <leungbk <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63674 in the body.
You can then email your comments to 63674 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Wed, 24 May 2023 03:49:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Brian Leung <leungbk <at> posteo.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 24 May 2023 03:49:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Cc: akrl <at> sdf.org
Subject: 30.0.50; Possible miscompilation of cl-structs?
Date: Wed, 24 May 2023 03:48:21 +0000

After the latest changes to native compilation, I see a failure here: https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Wed, 24 May 2023 10:11:02 GMT) Full text and rfc822 format available.

Message #8 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Brian Leung <leungbk <at> posteo.net>
Cc: 63674 <at> debbugs.gnu.org, Andrea Corallo <akrl <at> sdf.org>
Subject: bug#63674: 30.0.50; Possible miscompilation of cl-structs? 
Date: Wed, 24 May 2023 12:09:59 +0200

> After the latest changes to native compilation, I see a failure here:
> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 

CC:ing Andrea.

Could you help him by explaining exactly what we are looking at here? What Emacs revision is this based on, and from what revision is it a regression?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Wed, 24 May 2023 10:44:02 GMT) Full text and rfc822 format available.

Message #11 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 63674 <at> debbugs.gnu.org, Andrea Corallo <akrl <at> sdf.org>
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Wed, 24 May 2023 10:39:14 +0000

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

>> After the latest changes to native compilation, I see a failure 
>> here:
>> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 
>
> CC:ing Andrea.
>
> Could you help him by explaining exactly what we are looking at 
> here? What Emacs revision is this based on, and from what 
> revision is it a regression?

This error occurs after Emacs commit 
9ad997cd68981fe6c6933b6977fdae23e84e6a75 (see 
https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:2657). Our 
last successful run used Emacs commit 
d4ff1d74209e97730c52ddd50c4d643c79087a33.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Wed, 24 May 2023 13:19:01 GMT) Full text and rfc822 format available.

Message #14 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Brian Leung <leungbk <at> posteo.net>, 63674 <at> debbugs.gnu.org
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Wed, 24 May 2023 13:18:34 +0000

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

>> After the latest changes to native compilation, I see a failure here:
>> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 
>
> CC:ing Andrea.

Thanks, will look at as soon as I can.

PS I merged 63679 63679 63681 as I believe are the same.

Best Regards

  Andrea
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Wed, 24 May 2023 15:28:02 GMT) Full text and rfc822 format available.

Message #17 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Brian Leung <leungbk <at> posteo.net>, 63674 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Wed, 24 May 2023 15:27:07 +0000

Andrea Corallo <akrl <at> sdf.org> writes:

> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>
>>> After the latest changes to native compilation, I see a failure here:
>>> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 
>>
>> CC:ing Andrea.
>
> Thanks, will look at as soon as I can.
>
> PS I merged 63679 63679 63681 as I believe are the same.
>
> Best Regards
>
>   Andrea

Okay I've just pushed b2b2be98da5 to fix this.

Essentially the native compiler needs `cl-typep' to be functional at
compile time for the types being defined in the compiled code.

It works for me, let's see if the fix is acceptable.

Thanks

  Andrea
Reply sent to Brian Leung <leungbk <at> posteo.net>:
You have taken responsibility. (Thu, 25 May 2023 00:11:02 GMT) Full text and rfc822 format available.
Notification sent to Brian Leung <leungbk <at> posteo.net>:
bug acknowledged by developer. (Thu, 25 May 2023 00:11:02 GMT) Full text and rfc822 format available.

Message #22 received at 63674-done <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: 63674-done <at> debbugs.gnu.org
Cc: Andrea Corallo <akrl <at> sdf.org>
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Thu, 25 May 2023 00:09:02 +0000

Thanks for the quick fix.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Sat, 27 May 2023 06:41:01 GMT) Full text and rfc822 format available.

Message #25 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: leungbk <at> posteo.net, mattias.engdegard <at> gmail.com, 63674 <at> debbugs.gnu.org
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Sat, 27 May 2023 09:41:05 +0300

> Cc: Brian Leung <leungbk <at> posteo.net>, 63674 <at> debbugs.gnu.org
> From: Andrea Corallo <akrl <at> sdf.org>
> Date: Wed, 24 May 2023 13:18:34 +0000
> 
> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
> 
> >> After the latest changes to native compilation, I see a failure here:
> >> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 
> >
> > CC:ing Andrea.
> 
> Thanks, will look at as soon as I can.
> 
> PS I merged 63679 63679 63681 as I believe are the same.

Your merge didn't succeed, it seems.

And people are still complaining about problems with package.el that
seem to be related to native compilation.  So could you please look
into those other issues (bug#63742, bug#63710)?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Sun, 28 May 2023 08:33:01 GMT) Full text and rfc822 format available.

Message #28 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: leungbk <at> posteo.net, mattias.engdegard <at> gmail.com, 63674 <at> debbugs.gnu.org
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Sun, 28 May 2023 08:31:48 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Brian Leung <leungbk <at> posteo.net>, 63674 <at> debbugs.gnu.org
>> From: Andrea Corallo <akrl <at> sdf.org>
>> Date: Wed, 24 May 2023 13:18:34 +0000
>> 
>> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>> 
>> >> After the latest changes to native compilation, I see a failure here:
>> >> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 
>> >
>> > CC:ing Andrea.
>> 
>> Thanks, will look at as soon as I can.
>> 
>> PS I merged 63679 63679 63681 as I believe are the same.
>
> Your merge didn't succeed, it seems.

That's strange I think I got the message confirming that.

> And people are still complaining about problems with package.el that
> seem to be related to native compilation.  So could you please look
> into those other issues (bug#63742, bug#63710)?

Sure, I did already some work on that and today is dedicated to this
bug.

BR

  Andrea
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Sun, 28 May 2023 10:43:02 GMT) Full text and rfc822 format available.

Message #31 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: leungbk <at> posteo.net, mattias.engdegard <at> gmail.com, 63674 <at> debbugs.gnu.org
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Sun, 28 May 2023 10:42:15 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Brian Leung <leungbk <at> posteo.net>, 63674 <at> debbugs.gnu.org
>> From: Andrea Corallo <akrl <at> sdf.org>
>> Date: Wed, 24 May 2023 13:18:34 +0000
>> 
>> Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:
>> 
>> >> After the latest changes to native compilation, I see a failure here:
>> >> https://github.com/nix-community/emacs-overlay/actions/runs/5059662673/jobs/9081521991#step:6:7010. 
>> >
>> > CC:ing Andrea.
>> 
>> Thanks, will look at as soon as I can.
>> 
>> PS I merged 63679 63679 63681 as I believe are the same.
>
> Your merge didn't succeed, it seems.

Ah this is the mail I've got back form debbugs:

=====

Processing commands for control <at> debbugs.gnu.org:

> merge 63679 63679 63681
bug#63679: 30.0.50; package-delete: native-compile warning on startup
bug#63681: build error from native-comp: void function ("emacs-lisp/package.el" package-desc-p)
Merged 63679 63681.

>
End of message, stopping processing here.

Please contact help-debbugs <at> gnu.org if you need assistance.

GNU bugs database, https://debbugs.gnu.org/

=====

Not sure why it didn't work then, I assumed it did but maybe I read this
wrong.

Thanks

  Andrea
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63674; Package emacs. (Sun, 28 May 2023 12:40:02 GMT) Full text and rfc822 format available.

Message #34 received at 63674 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: leungbk <at> posteo.net, mattias.engdegard <at> gmail.com, 63674 <at> debbugs.gnu.org
Subject: Re: bug#63674: 30.0.50; Possible miscompilation of cl-structs?
Date: Sun, 28 May 2023 15:39:50 +0300

> From: Andrea Corallo <akrl <at> sdf.org>
> Cc: mattias.engdegard <at> gmail.com,  leungbk <at> posteo.net,  63674 <at> debbugs.gnu.org
> Date: Sun, 28 May 2023 10:42:15 +0000
> 
> Not sure why it didn't work then, I assumed it did but maybe I read this
> wrong.

Or maybe I was confused regarding which bugs we were talking about.

Never mind, the important thing is that now all the related bugs are
merged.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 26 Jun 2023 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 319 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.