GNU bug report logs - #63689
29.0.91; vc-annotate-mode-menu: Cannot open file vc-nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63689 in the body.
You can then email your comments to 63689 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.91; vc-annotate-mode-menu: Cannot open file vc-nil
Date: Wed, 24 May 2023 19:09:40 +0300

0. emacs-29 -Q
1. Eval:

   (context-menu-mode)
   (setq debug-on-error t)
   (require 'vc-annotate)

2. Open any vc-controlled file and type 'C-x v g' (vc-annotate)

3. Click the right mouse button for Context menu with "VC-Annotate" submenu

  Debugger entered--Lisp error: (file-missing "Cannot open load file" "No such file or directory" "vc-nil")
    vc-find-backend-function(nil revision-granularity)
    vc-call-backend(nil revision-granularity)
    (eq 'repository (vc-call-backend nil 'revision-granularity))

The error is caused by 'vc-annotate-mode-menu' that contains:

  (keymap "VC-Annotate" ...
    (Show\ changeset\ diff\ of\ revision\ at\ line
     menu-item
     "Show changeset diff of revision at line"
     vc-annotate-show-changeset-diff-revision-at-line
     :enable (eq 'repository (vc-call-backend nil 'revision-granularity))

Note how it tries to use the backend 'nil'.

This is because 'vc-annotate-backend' is evaluated when calling
(require 'vc-annotate) in the *scratch* buffer where it's nil.

Here is the fix for emacs-29:

diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el
index 70057a6aac7..d83660f9d79 100644
--- a/lisp/vc/vc-annotate.el
+++ b/lisp/vc/vc-annotate.el
@@ -330,7 +330,7 @@ vc-annotate-mode-menu
     ["Show changeset diff of revision at line"
      vc-annotate-show-changeset-diff-revision-at-line
      :enable
-     (eq 'repository (vc-call-backend ,vc-annotate-backend 'revision-granularity))
+     (eq 'repository (vc-call-backend vc-annotate-backend 'revision-granularity))
      :help "Visit the diff of the revision at line from its previous revision"]
     ["Visit revision at line" vc-annotate-find-revision-at-line
      :help "Visit the revision identified in the current line"]))

Message #8 received at 63689 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 63689 <at> debbugs.gnu.org
Subject: Re: bug#63689: 29.0.91; vc-annotate-mode-menu: Cannot open file vc-nil
Date: Thu, 25 May 2023 21:33:45 +0300

close 63689 29.0.60
quit

> Here is the fix for emacs-29:
>
> diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el
> index 70057a6aac7..d83660f9d79 100644
> --- a/lisp/vc/vc-annotate.el
> +++ b/lisp/vc/vc-annotate.el
> @@ -330,7 +330,7 @@ vc-annotate-mode-menu
>      ["Show changeset diff of revision at line"
>       vc-annotate-show-changeset-diff-revision-at-line
>       :enable
> -     (eq 'repository (vc-call-backend ,vc-annotate-backend 'revision-granularity))
> +     (eq 'repository (vc-call-backend vc-annotate-backend 'revision-granularity))
>       :help "Visit the diff of the revision at line from its previous revision"]

Pushed to emacs-29, and closed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.