GNU bug report logs - #63691
[PATCH] Add emacs-prism package

Previous Next

Package: guix-patches;

Reported by: Maciej Kalandyk <m.kalandyk <at> outlook.com>

Date: Wed, 24 May 2023 17:47:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63691 in the body.
You can then email your comments to 63691 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#63691; Package guix-patches. (Wed, 24 May 2023 17:47:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Maciej Kalandyk <m.kalandyk <at> outlook.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 24 May 2023 17:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maciej Kalandyk <m.kalandyk <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: Maciej Kalandyk <m.kalandyk <at> outlook.com>
Subject: [PATCH] Add emacs-prism package
Date: Wed, 24 May 2023 18:53:00 +0200
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0ea9732bfa..1747e62433 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1161,6 +1161,27 @@ (define-public emacs-spongebob
 buffer.")
       (license license:gpl3+))))
 
+(define-public emacs-prism
+  (package
+    (name "emacs-prism")
+    (version "0.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/alphapapa/prism.el.git")
+                    (commit version)))
+              (sha256
+               (base32
+                "1750s161ck83lcl36rm2jbkssbgpa9hfx1gbv2r582381q1p4kwp"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-dash))
+    (home-page "https://github.com/alphapapa/prism.el")
+    (synopsis
+     "Disperses lisp forms (and other languages) into a spectrum of color >
+    (description
+     "prism is an \"rainbow-blocks\" like mode for Emacs, but it respects >
+    (license license:gpl3+)))
+
 (define-public emacs-project
   (package
     (name "emacs-project")

base-commit: 297ba5c15a32845ab8514aeb6f405ebd4290142d
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63691; Package guix-patches. (Thu, 25 May 2023 03:58:03 GMT) Full text and rfc822 format available.

Message #8 received at 63691 <at> debbugs.gnu.org (full text, mbox):

From: Maciej Kalandyk <m.kalandyk <at> outlook.com>
To: 63691 <at> debbugs.gnu.org
Cc: Maciej Kalandyk <m.kalandyk <at> outlook.com>
Subject: [PATCH vREVISION] Add emacs-prism package
Date: Thu, 25 May 2023 04:15:40 +0200
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0ea9732bfa..95d476b12b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1161,6 +1161,27 @@ (define-public emacs-spongebob
 buffer.")
       (license license:gpl3+))))
 
+(define-public emacs-prism
+  (package
+    (name "emacs-prism")
+    (version "0.3.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+		    (url "https://github.com/alphapapa/prism.el.git")
+		    (commit version)))
+              (sha256
+               (base32
+                "1750s161ck83lcl36rm2jbkssbgpa9hfx1gbv2r582381q1p4kwp"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-dash))
+    (home-page "https://github.com/alphapapa/prism.el")
+    (synopsis
+     "Disperses lisp forms (and other languages) into a spectrum of color by depth")
+    (description
+     "prism is an \"rainbow-blocks\" like mode for Emacs, but it respects existing non-color face properties, and allows flexible configuration of faces and colors.")
+    (license license:gpl3+)))
+
 (define-public emacs-project
   (package
     (name "emacs-project")

base-commit: 297ba5c15a32845ab8514aeb6f405ebd4290142d
prerequisite-patch-id: bde021d358061ddf7418cf9007728e29b0a484e7
prerequisite-patch-id: d036219d9808390a95ce79eab308394a35fb11f4
prerequisite-patch-id: b5a5ddc30aa4c6eab627e90bfea924b549e72f65
prerequisite-patch-id: d60f368cd1bc31306ecd174a426dadd7d8c99c30
prerequisite-patch-id: dc5475a7173f78da07abee9e12f678be9c130324
prerequisite-patch-id: 32c40bb389b4fe60717a74f0e1d4f85027b6c536
prerequisite-patch-id: 1399adfffe1dc58ddfd8c576de8a35dc0cba686c
prerequisite-patch-id: a98d8fd12f3f0e29cacff0e635627bef17e7b340
prerequisite-patch-id: 51a5ae56b1f2adfb2c32863fae668575eabd0459
prerequisite-patch-id: 33981018a5333b547be6e792f8254d53e60c6528
prerequisite-patch-id: 21b2102fe7004d64c33c560042d806c65b54c85d
prerequisite-patch-id: 3b4fb2c60fe043b041d76aee56c3979439fbdc3e
prerequisite-patch-id: c12d40b1babc901b613d731a2f1769ed1fd44fb4
prerequisite-patch-id: 17bb1afa675ba8929ae6b35138432aa176bec594
prerequisite-patch-id: 7181cbce5bb938f93e539a54f1b062cb40a84e50
prerequisite-patch-id: 5ddd2c15a8b6972d71bf23868fdb7e403b02f1a1
prerequisite-patch-id: a1557107aaaa0ea314daced5dddac5432573fb8e
prerequisite-patch-id: 1bb4ff40995d453529bcf08bf04e96a2251e0e67
prerequisite-patch-id: a58b350e2933ca918441512081bd86f07c0e7689
prerequisite-patch-id: e5e4b5078457272c40136083ada87084b7cf789c
prerequisite-patch-id: 04959264b838474b05ccfe8459daa74ea0b60345
prerequisite-patch-id: 48fad5111c84540939ce092d05894c2a7b7043d9
prerequisite-patch-id: 913efa97fcf5f87a8ea36987321fb2a4789f8456
prerequisite-patch-id: 8c7d814de0854f22e3b492f7eef9e59a586485a0
prerequisite-patch-id: 126e8575449ac1e62ec7ce8c229939caa7a8b9c4
prerequisite-patch-id: f3b43fe639f8d4bff9d019244592f9ffb48b07ff
prerequisite-patch-id: 70f1a13fc509ab6b2af92c8deef537154b8f430c
prerequisite-patch-id: 5544eab70ffc2eb4521bec1d9ee6b74c71f3844c
prerequisite-patch-id: de4c46d605075aa3223b6aaed403ece4d66fba8e
prerequisite-patch-id: 592de527a3e0f924732b7727c4b853cadce3cd9e
prerequisite-patch-id: 5b6e0e030c6b1c973d747f1ca27368d1537392de
prerequisite-patch-id: 33950bd38744331ed6fee227923ae2a096e6464b
prerequisite-patch-id: 053f0b22e7bcaf2b55a2dfd7a77aab1fb217d083
prerequisite-patch-id: 2357c7b9b15fa3d96be0045f5f52451027fc6252
prerequisite-patch-id: 14a012c5d972452eef7a5645239b386c7d5e8c31
prerequisite-patch-id: 48b4936aca8407e6777ae731017bbec2935cc1a9
prerequisite-patch-id: aca9740b2ee2c511494b07683934a1de89e7d86f
prerequisite-patch-id: 099c86a514fe01cb2a2032e7dad8f320399b8601
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63691; Package guix-patches. (Thu, 25 May 2023 10:51:01 GMT) Full text and rfc822 format available.

Message #11 received at 63691 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Maciej Kalandyk <m.kalandyk <at> outlook.com>
Cc: 63691 <at> debbugs.gnu.org
Subject: Re: [bug#63691] [PATCH vREVISION] Add emacs-prism package
Date: Thu, 25 May 2023 12:49:46 +0200
Hello,

Maciej Kalandyk <m.kalandyk <at> outlook.com> writes:

> +(define-public emacs-prism

Thank you.

You need to add a proper commit message with your patch. For a new
variable, it is pretty much normalized:

  gnu: Add emacs-prism.

  * gnu/packages/emacs-xyz.scm (emacs-prism): New variable.

> +  (package
> +    (name "emacs-prism")
> +    (version "0.3.1")

Version 0.3.2 was released yesterday, you may want to provide it
instead.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +		    (url "https://github.com/alphapapa/prism.el.git")

There's a habit of dropping ".git" suffix in URL, so the above should be:

  (url "https://github.com/alphapapa/prism.el")

> +		    (commit version)))
> +              (sha256
> +               (base32
> +                "1750s161ck83lcl36rm2jbkssbgpa9hfx1gbv2r582381q1p4kwp"))))
> +    (build-system emacs-build-system)
> +    (inputs (list emacs-dash))
> +    (home-page "https://github.com/alphapapa/prism.el")
> +    (synopsis
> +     "Disperses lisp forms (and other languages) into a spectrum of color by depth")

I suggest:

  Disperse Lisp forms...

> +    (description
> +     "prism is an \"rainbow-blocks\" like mode for Emacs, but it
> respects existing non-color face properties, and allows flexible
> configuration of faces and colors.")

I suggest:

  Prism is a Rainbow Blocks-like mode for Emacs.  It preserves non-color
  face properties and allows configuration of faces and colors.

Also mind keeping line lengths below 80 columns.

Could you send an updated patch? (note it should be -v3 in the git
command line)?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#63691; Package guix-patches. (Thu, 25 May 2023 12:55:02 GMT) Full text and rfc822 format available.

Message #14 received at 63691 <at> debbugs.gnu.org (full text, mbox):

From: Maciej Kalandyk <m.kalandyk <at> outlook.com>
To: 63691 <at> debbugs.gnu.org
Cc: Maciej Kalandyk <m.kalandyk <at> outlook.com>
Subject: [PATCH v3] Add emacs-prism package
Date: Thu, 25 May 2023 14:54:06 +0200
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0ea9732bfa..356a7f2199 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1161,6 +1161,28 @@ (define-public emacs-spongebob
 buffer.")
       (license license:gpl3+))))
 
+(define-public emacs-prism
+  (package
+    (name "emacs-prism")
+    (version "0.3.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+		    (url "https://github.com/alphapapa/prism.el")
+		    (commit version)))
+              (sha256
+               (base32
+                "0n2gf7302hqdnhsax1y3ahksfmmpd8cmiv1zgb7rjg8qhcs0iqp2"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-dash))
+    (home-page "https://github.com/alphapapa/prism.el")
+    (synopsis
+     "Disperses Lisp forms (and other languages) into a spectrum of color by depth")
+    (description
+     "Prism is a Rainbow Blocks-like mode for Emacs. It preserves non-color
+face properties and allows configuration of faces and colors.")
+    (license license:gpl3+)))
+
 (define-public emacs-project
   (package
     (name "emacs-project")

base-commit: 1be6baed2b58a75868cdcc9f51b78624c2fefc4f
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63691; Package guix-patches. (Thu, 25 May 2023 18:30:01 GMT) Full text and rfc822 format available.

Message #17 received at 63691 <at> debbugs.gnu.org (full text, mbox):

From: Maciej Kalandyk <m.kalandyk <at> outlook.com>
To: 63691 <at> debbugs.gnu.org
Cc: Maciej Kalandyk <m.kalandyk <at> outlook.com>
Subject: [PATCH v4] gnu: Add emacs-prism.
Date: Thu, 25 May 2023 20:29:07 +0200
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0ea9732bfa..356a7f2199 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1161,6 +1161,28 @@ (define-public emacs-spongebob
 buffer.")
       (license license:gpl3+))))
 
+(define-public emacs-prism
+  (package
+    (name "emacs-prism")
+    (version "0.3.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+		    (url "https://github.com/alphapapa/prism.el")
+		    (commit version)))
+              (sha256
+               (base32
+                "0n2gf7302hqdnhsax1y3ahksfmmpd8cmiv1zgb7rjg8qhcs0iqp2"))))
+    (build-system emacs-build-system)
+    (inputs (list emacs-dash))
+    (home-page "https://github.com/alphapapa/prism.el")
+    (synopsis
+     "Disperses Lisp forms (and other languages) into a spectrum of color by depth")
+    (description
+     "Prism is a Rainbow Blocks-like mode for Emacs. It preserves non-color
+face properties and allows configuration of faces and colors.")
+    (license license:gpl3+)))
+
 (define-public emacs-project
   (package
     (name "emacs-project")
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63691; Package guix-patches. (Thu, 25 May 2023 18:33:02 GMT) Full text and rfc822 format available.

Message #20 received at 63691 <at> debbugs.gnu.org (full text, mbox):

From: Maciej Kalandyk <m.kalandyk <at> outlook.com>
To: "63691 <at> debbugs.gnu.org" <63691 <at> debbugs.gnu.org>
Date: Thu, 25 May 2023 18:32:38 +0000
[Message part 1 (text/plain, inline)]
Hello
I believe I have accounted for requested changes.
Sorry for late reply, i am bit new to using mailing lists...
[Message part 2 (text/html, inline)]

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Thu, 25 May 2023 20:23:02 GMT) Full text and rfc822 format available.

Notification sent to Maciej Kalandyk <m.kalandyk <at> outlook.com>:
bug acknowledged by developer. (Thu, 25 May 2023 20:23:02 GMT) Full text and rfc822 format available.

Message #25 received at 63691-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Maciej Kalandyk <m.kalandyk <at> outlook.com>
Cc: 63691-done <at> debbugs.gnu.org
Subject: Re: [bug#63691] [PATCH v4] gnu: Add emacs-prism.
Date: Thu, 25 May 2023 22:22:37 +0200
Hello,

Maciej Kalandyk <m.kalandyk <at> outlook.com> writes:

> +(define-public emacs-prism

I added a commit message and applied your patch. Thank you.

> +    (description
> +     "Prism is a Rainbow Blocks-like mode for Emacs. It preserves non-color
> +face properties and allows configuration of faces and colors.")

I added two spaces between sentences.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Jun 2023 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 280 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.