GNU bug report logs - #63707
[PATCH] gnu: Add font-ipa.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63707 in the body.
You can then email your comments to 63707 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wolf <wolf <at> wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Wolf <wolf <at> wolfsden.cz>
Subject: [PATCH] gnu: Add font-ipa.
Date: Wed, 24 May 2023 23:22:53 +0200

* gnu/packages/fonts.scm (font-ipa): New variable.
---
 gnu/packages/fonts.scm | 46 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 12c6b04bd7..b159eb7ab0 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -2515,6 +2515,52 @@ (define-public font-meera-inimai
 characteristic so that they sit smoothly with the Tamil glyphs.")
     (license license:silofl1.1)))
 
+(define-public font-ipa
+  (package
+    (name "font-ipa")
+    (version "003.03")
+    (source (origin
+              (method url-fetch/zipbomb)
+              (uri (string-append
+                    "https://moji.or.jp/wp-content/ipafont/IPAfont/" "IPAfont"
+                    (string-join (string-split version #\.) "") ".zip"))
+              (sha256
+               (base32
+                "1rbgfq14ld0cwas6bx5h7pwyv2hkfa8ihnphsaz1brxqliwysmgp"))))
+    (build-system font-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'make-read-only
+                          (lambda _
+                            ;; Otherwise the files have the executable bit set.
+                            (for-each (lambda (file)
+                                        (chmod file #o444))
+                                      (find-files "."
+                                                  #:directories? #f))))
+                        (add-after 'install 'install-doc
+                          (lambda* (#:key outputs #:allow-other-keys)
+                            (let ((font+version #$(string-append "IPAfont"
+                                                                 (string-join (string-split
+                                                                               version
+                                                                               #\.)
+                                                                  "")))
+                                  (doc-dir (string-append #$output
+                                                          "/share/doc/"
+                                                          #$name)))
+                              (with-directory-excursion font+version
+                                (mkdir-p doc-dir)
+                                (copy-file (string-append "Readme_"
+                                                          font+version ".txt")
+                                           (string-append doc-dir "/README"))
+                                (copy-file
+                                 "IPA_Font_License_Agreement_v1.0.txt"
+                                 (string-append doc-dir "/LICENSE")))))))))
+    (home-page "https://moji.or.jp/ipafont/")
+    (synopsis "Japanese font from the Information-technology Promotion Agency")
+    (description "Japanese outline fonts by Information-technology Promotion
+Agency, Japan (IPA)")
+    (license license:ipa)))
+
 (define-public font-ipa-ex
   (package
     (name "font-ipa-ex")

base-commit: 6d0571215d661d21cac2150ca45906e77a79a5fb
-- 
2.40.1

Message #8 received at 63707 <at> debbugs.gnu.org (full text, mbox):

From: wolf <wolf <at> wolfsden.cz>
To: 63707 <at> debbugs.gnu.org
Subject: Ping
Date: Wed, 21 Jun 2023 18:36:12 +0200

[Message part 1 (text/plain, inline)]

Hi,

anything I can do to help this getting merged?

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 63707-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Wolf <wolf <at> wolfsden.cz>
Cc: 63707-done <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#63707] [PATCH] gnu: Add font-ipa.
Date: Sat, 01 Jul 2023 12:23:34 +0200

Hello,

Wolf <wolf <at> wolfsden.cz> writes:

> * gnu/packages/fonts.scm (font-ipa): New variable.

Applied with the changes below. Thank you.
> ---
> +    (build-system font-build-system)
> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'make-read-only

I fixed indentation, which consumes way too much horizontal space here.

> +                        (add-after 'install 'install-doc
> +                          (lambda* (#:key outputs #:allow-other-keys)

outputs argument is not necessary when using G-expressions. You don't
use it either in your phases.

> +    (description "Japanese outline fonts by Information-technology Promotion
> +Agency, Japan (IPA)")

The description should consist of full sentences:

  "These package provides Japanese outline fonts..."

Regards,
-- 
Nicolas Goaziou

Message #16 received at 63707-done <at> debbugs.gnu.org (full text, mbox):

From: wolf <wolf <at> wolfsden.cz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 63707-done <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#63707] [PATCH] gnu: Add font-ipa.
Date: Sun, 2 Jul 2023 20:10:48 +0200

[Message part 1 (text/plain, inline)]

On 2023-07-01 12:23:34 +0200, Nicolas Goaziou wrote:
> Hello,
> 
> Wolf <wolf <at> wolfsden.cz> writes:
> 
> > * gnu/packages/fonts.scm (font-ipa): New variable.
> 
> Applied with the changes below. Thank you.

Thank you for merging it.

> > ---
> > +    (build-system font-build-system)
> > +    (arguments
> > +     (list #:phases #~(modify-phases %standard-phases
> > +                        (add-after 'unpack 'make-read-only
> 
> I fixed indentation, which consumes way too much horizontal space here.
> 
> > +                        (add-after 'install 'install-doc
> > +                          (lambda* (#:key outputs #:allow-other-keys)
> 
> outputs argument is not necessary when using G-expressions. You don't
> use it either in your phases.

I admit I just copied over the package for font-ipa-ex and adjusted it, not
realizing that this part is not necessary.

> 
> > +    (description "Japanese outline fonts by Information-technology Promotion
> > +Agency, Japan (IPA)")
> 
> The description should consist of full sentences:
> 
>   "These package provides Japanese outline fonts..."

Will keep that in mind.

> 
> Regards,
> -- 
> Nicolas Goaziou

Have a nice day,
W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.