GNU bug report logs - #63714
[PATCH] gnu: Add emacs-x509

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63714 in the body.
You can then email your comments to 63714 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Conner <aionfork <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: David Conner <dconner.pro <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-x509
Date: Thu, 25 May 2023 06:08:59 -0400

From: David Conner <dconner.pro <at> gmail.com>

* gnu/packages/emacs-xyz.scm (emacs-x509): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0ea9732bfa..e8965c7d90 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -37093,6 +37093,32 @@ (define-public emacs-tintin-mode
 accomplish different tasks.")
       (license license:asl2.0))))
 
+(define-public emacs-x509-mode
+  (package
+    (name "emacs-x509-mode")
+    (version "20230430.1518")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/x509-mode-"
+                           version ".tar"))
+       (sha256
+        (base32 "195gn14qn22aqclwz2i9w2qq9bxabwcasfkna1fj41jwv2bpbykc"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:include (cons* "^keywords.txt"
+                        "^keyword\\+constant.txt"
+                        "^constants.txt"
+                        "^long-name.txt"
+                        %default-include)))
+    (home-page "https://github.com/jobbflykt/x509-mode")
+    (synopsis "Major mode for viewing certificates, CRLs, and other
+PKI-related files")
+    (description "Major mode for viewing certificates, CRLs, and other
+PKI-related files.  Uses OpenSSL for viewing PEM and DER encoded PKI
+entities.")
+    (license license:expat)))
+
 (define-public emacs-totp
   (let ((commit "a5e059b8475b32bc7f5ddadda248cf84449ed722") ;no releases
         (revision "0"))

base-commit: 0b0c2ef6381e05f87aa5c4a99d05054a0b677662
-- 
2.40.1

Message #8 received at 63714 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: David Conner <aionfork <at> gmail.com>
Cc: 63714 <at> debbugs.gnu.org, David Conner <dconner.pro <at> gmail.com>
Subject: Re: [bug#63714] [PATCH] gnu: Add emacs-x509
Date: Thu, 25 May 2023 22:29:34 +0200

Hello,

David Conner <aionfork <at> gmail.com> writes:

> From: David Conner <dconner.pro <at> gmail.com>
>
> * gnu/packages/emacs-xyz.scm (emacs-x509): New variable.

Thank you. Some comments follow.

> +(define-public emacs-x509-mode
> +  (package
> +    (name "emacs-x509-mode")
> +    (version "20230430.1518")

Guix doesn't use versioning system from MELPA. Unfortunately, this
package doesn't seem to set a Version keyword. So the version should be "0".

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/x509-mode-"
> +                           version ".tar"))

Please use GitHub as upstream.

> +    (arguments
> +     `(#:include (cons* "^keywords.txt"
> +                        "^keyword\\+constant.txt"
> +                        "^constants.txt"
> +                        "^long-name.txt"
> +                        %default-include)))

What about something like:

  (list #:include (cons "\\.txt$" %default-include))

> +    (description "Major mode for viewing certificates, CRLs, and other
> +PKI-related files.  Uses OpenSSL for viewing PEM and DER encoded PKI
> +entities.")

The description should consist of complete sentences.

Could you send an updated patch? Also, could you run tests?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 63714 <at> debbugs.gnu.org (full text, mbox):

From: David Conner <aionfork <at> gmail.com>
To: 63714 <at> debbugs.gnu.org
Subject: [bug#63714] [PATCH] gnu: Add emacs-x509
Date: Sat, 27 May 2023 10:37:58 -0400

I'm still getting used to GNUS and debbugs. I've only just gotten GNUS
set up in Emacs with email.

> Guix doesn't use versioning system from MELPA. Unfortunately, this
> package doesn't seem to set a Version keyword. So the version should
> be "0".

I can try to get in touch with the package maintainers to convince them
to add semantic versioning. I think the package was dormant for quite
some time until I created a Github issue on it. It appears to be active
again.

> Could you send an updated patch? Also, could you run tests?

Yes, I'll take care of this soon.

As for tests, do you mean Guix tests or x509-mode.el tests? If the
latter, then I believe openssl should be a propagated input. I left it
out, as this should be a dependency on most machines anyways.

Thanks

Message #16 received at 63714-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: David Conner <aionfork <at> gmail.com>
Cc: 63714-done <at> debbugs.gnu.org
Subject: Re: [bug#63714] [PATCH] gnu: Add emacs-x509
Date: Sun, 25 Jun 2023 08:51:51 +0200

Hello,

David Conner <aionfork <at> gmail.com> writes:

> I'm still getting used to GNUS and debbugs. I've only just gotten GNUS
> set up in Emacs with email.
>
>> Guix doesn't use versioning system from MELPA. Unfortunately, this
>> package doesn't seem to set a Version keyword. So the version should
>> be "0".
>
> I can try to get in touch with the package maintainers to convince them
> to add semantic versioning. I think the package was dormant for quite
> some time until I created a Github issue on it. It appears to be active
> again.
>
>> Could you send an updated patch? Also, could you run tests?
>
> Yes, I'll take care of this soon.
>
> As for tests, do you mean Guix tests or x509-mode.el tests? If the
> latter, then I believe openssl should be a propagated input. I left it
> out, as this should be a dependency on most machines anyways.

I went ahead, applied suggested changes, added openssl as an input, and
ran tests.

Thank you for the initial work!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.