GNU bug report logs - #63720
[PATCH] website: List languages in two columns.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63720 in the body.
You can then email your comments to 63720 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] website: List languages in two columns.
Date: Thu, 25 May 2023 17:41:45 +0200

* website/apps/base/templates/components.scm (navbar): Specify a CSS
class for the languages dropdown list.
* website/static/base/css/navbar.css (languages-dropdown-list): New
rule.
---

The translations dropdown is too long and high.  It seems to me
adjusting the number of columns dynamically and limiting the height is
not possible, unless we rewrite dropdowns to use CSS flexbox in <div>
elements instead of lists.  Instead, this patch sets a fixed column
number of two, which should be appropriate for the foreseeable future.

Also, there is only one languages dropdown, so this patch could
specify an id and not a new class for the languages dropdown.  But a
class works too and works always, so using a class seems better (?).

 website/apps/base/templates/components.scm | 3 ++-
 website/static/base/css/navbar.css         | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
index 5f4af9c..241c27e 100644
--- a/website/apps/base/templates/components.scm
+++ b/website/apps/base/templates/components.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix web site
-;;; Copyright © 2019 Florian Pelz <pelzflorian <at> pelzflorian.de>
+;;; Copyright © 2019, 2023 Florian Pelz <pelzflorian <at> pelzflorian.de>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Initially written by sirgazil who waives all
 ;;; copyright interest on this file.
@@ -501,6 +501,7 @@ manual.
       ,(menu-dropdown #:label (locale-display-name) #:active-item active-item
         #:items
         (append
+          (list '(@ (class "languages-dropdown-list")))
           (map-in-order
            (lambda (ietf-info)
              (let ((lingua (car ietf-info))
diff --git a/website/static/base/css/navbar.css b/website/static/base/css/navbar.css
index 974516a..c2dce90 100644
--- a/website/static/base/css/navbar.css
+++ b/website/static/base/css/navbar.css
@@ -117,6 +117,9 @@ label.menu-item {
     display: none;
 }
 
+.languages-dropdown-list {
+    columns: 2;
+}
 
 
 

base-commit: c4df5a59a97bce391e1be68dd8b4c1107cce4b23
-- 
2.39.2

Message #8 received at 63720 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 63720 <at> debbugs.gnu.org
Subject: Re: bug#63720: [PATCH] website: List languages in two columns.
Date: Mon, 05 Jun 2023 14:47:04 +0200

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> skribis:

> * website/apps/base/templates/components.scm (navbar): Specify a CSS
> class for the languages dropdown list.
> * website/static/base/css/navbar.css (languages-dropdown-list): New
> rule.
> ---
>
> The translations dropdown is too long and high.  It seems to me
> adjusting the number of columns dynamically and limiting the height is
> not possible, unless we rewrite dropdowns to use CSS flexbox in <div>
> elements instead of lists.  Instead, this patch sets a fixed column
> number of two, which should be appropriate for the foreseeable future.
>
> Also, there is only one languages dropdown, so this patch could
> specify an id and not a new class for the languages dropdown.  But a
> class works too and works always, so using a class seems better (?).

No opinion on this, but two columns sounds like a good idea to me.

Thanks,
Ludo’.

Message #13 received at 63720-done <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: 63720-done <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#63720: [PATCH] website: List languages in two columns.
Date: Tue, 06 Jun 2023 08:29:18 +0200

Pushed as a076562297db72b45ac82f7627a23e4be615d558.

Thank you Ludo for confirming the columns number.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.