GNU bug report logs - #63750
30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable

Previous Next

To reply to this bug, email your comments to 63750 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mickey Petersen <mickey <at> masteringemacs.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; tree-sitter: `treesit-language-source-alist' is not
 customisable
Date: Sat, 27 May 2023 13:01:40 +0100

Given the simple alist structure, and that its intent is to be used
with the interactive function `treesit-install-language-grammar', it'd
make sense to turn it into a Customize option.

Message #8 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mickey Petersen <mickey <at> masteringemacs.org>, Yuan Fu <casouri <at> gmail.com>
Cc: 63750 <at> debbugs.gnu.org
Subject: Re: bug#63750: 30.0.50;
 tree-sitter: `treesit-language-source-alist' is not customisable
Date: Sat, 27 May 2023 15:32:00 +0300

> From: Mickey Petersen <mickey <at> masteringemacs.org>
> Date: Sat, 27 May 2023 13:01:40 +0100
> 
> 
> Given the simple alist structure, and that its intent is to be used
> with the interactive function `treesit-install-language-grammar', it'd
> make sense to turn it into a Customize option.

We deliberately decided not to make it a defcustom, and not to provide
any non-trivial default value, so as to avoid the impression that we
as a project want to be responsible for the language grammars, their
correctness, up-to-date sites, and their licenses.  It should be
entirely up to the user and/or the Emacs distros.

However, I think we decided to make it so that each installation
should update the value of the variable with the data of the grammar
just installed.  I see that we don't actually do that -- Yuan, am I
misremembering this?  If not, would you please add code to add to the
variable's value the data of every grammar that is installed?

Message #11 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63750 <at> debbugs.gnu.org, Mickey Petersen <mickey <at> masteringemacs.org>
Subject: Re: bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist'
 is not customisable
Date: Sat, 27 May 2023 16:12:18 -0700

> On May 27, 2023, at 5:32 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Mickey Petersen <mickey <at> masteringemacs.org>
>> Date: Sat, 27 May 2023 13:01:40 +0100
>> 
>> 
>> Given the simple alist structure, and that its intent is to be used
>> with the interactive function `treesit-install-language-grammar', it'd
>> make sense to turn it into a Customize option.
> 
> We deliberately decided not to make it a defcustom, and not to provide
> any non-trivial default value, so as to avoid the impression that we
> as a project want to be responsible for the language grammars, their
> correctness, up-to-date sites, and their licenses.  It should be
> entirely up to the user and/or the Emacs distros.
> 
> However, I think we decided to make it so that each installation
> should update the value of the variable with the data of the grammar
> just installed.  I see that we don't actually do that -- Yuan, am I
> misremembering this?  If not, would you please add code to add to the
> variable's value the data of every grammar that is installed?

Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?

Yuan

Message #14 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 63750 <at> debbugs.gnu.org, mickey <at> masteringemacs.org
Subject: Re: bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist'
 is not customisable
Date: Sun, 28 May 2023 08:32:59 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 27 May 2023 16:12:18 -0700
> Cc: Mickey Petersen <mickey <at> masteringemacs.org>,
>  63750 <at> debbugs.gnu.org
> 
> > However, I think we decided to make it so that each installation
> > should update the value of the variable with the data of the grammar
> > just installed.  I see that we don't actually do that -- Yuan, am I
> > misremembering this?  If not, would you please add code to add to the
> > variable's value the data of every grammar that is installed?
> 
> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?

Only for the current session.  Users who want it preserved should do
it themselves (I will add that to the doc string when the code which
updates the variable is installed).

Thanks.

Message #17 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63750 <at> debbugs.gnu.org, mickey <at> masteringemacs.org
Subject: Re: bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist'
 is not customisable
Date: Sun, 28 May 2023 15:51:05 -0700

> On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sat, 27 May 2023 16:12:18 -0700
>> Cc: Mickey Petersen <mickey <at> masteringemacs.org>,
>> 63750 <at> debbugs.gnu.org
>> 
>>> However, I think we decided to make it so that each installation
>>> should update the value of the variable with the data of the grammar
>>> just installed.  I see that we don't actually do that -- Yuan, am I
>>> misremembering this?  If not, would you please add code to add to the
>>> variable's value the data of every grammar that is installed?
>> 
>> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
> 
> Only for the current session.  Users who want it preserved should do
> it themselves (I will add that to the doc string when the code which
> updates the variable is installed).

Done.

Yuan

Message #20 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 63750 <at> debbugs.gnu.org, mickey <at> masteringemacs.org
Subject: Re: bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist'
 is not customisable
Date: Mon, 29 May 2023 17:40:26 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sun, 28 May 2023 15:51:05 -0700
> Cc: mickey <at> masteringemacs.org,
>  63750 <at> debbugs.gnu.org
> 
> 
> 
> > On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> >> From: Yuan Fu <casouri <at> gmail.com>
> >> Date: Sat, 27 May 2023 16:12:18 -0700
> >> Cc: Mickey Petersen <mickey <at> masteringemacs.org>,
> >> 63750 <at> debbugs.gnu.org
> >> 
> >>> However, I think we decided to make it so that each installation
> >>> should update the value of the variable with the data of the grammar
> >>> just installed.  I see that we don't actually do that -- Yuan, am I
> >>> misremembering this?  If not, would you please add code to add to the
> >>> variable's value the data of every grammar that is installed?
> >> 
> >> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
> > 
> > Only for the current session.  Users who want it preserved should do
> > it themselves (I will add that to the doc string when the code which
> > updates the variable is installed).
> 
> Done.

Thanks.  And I see that you have updated the doc string accordingly.

Message #23 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63750 <at> debbugs.gnu.org, Mickey Petersen <mickey <at> masteringemacs.org>
Subject: Re: bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist'
 is not customisable
Date: Mon, 29 May 2023 13:37:06 -0700

> On May 29, 2023, at 7:40 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sun, 28 May 2023 15:51:05 -0700
>> Cc: mickey <at> masteringemacs.org,
>> 63750 <at> debbugs.gnu.org
>> 
>> 
>> 
>>> On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> 
>>>> From: Yuan Fu <casouri <at> gmail.com>
>>>> Date: Sat, 27 May 2023 16:12:18 -0700
>>>> Cc: Mickey Petersen <mickey <at> masteringemacs.org>,
>>>> 63750 <at> debbugs.gnu.org
>>>> 
>>>>> However, I think we decided to make it so that each installation
>>>>> should update the value of the variable with the data of the grammar
>>>>> just installed.  I see that we don't actually do that -- Yuan, am I
>>>>> misremembering this?  If not, would you please add code to add to the
>>>>> variable's value the data of every grammar that is installed?
>>>> 
>>>> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
>>> 
>>> Only for the current session.  Users who want it preserved should do
>>> it themselves (I will add that to the doc string when the code which
>>> updates the variable is installed).
>> 
>> Done.
> 
> Thanks.  And I see that you have updated the doc string accordingly.

Glad my docstring worked out this time ;-)

Yuan

Message #26 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, 63750 <at> debbugs.gnu.org
Cc: Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist'
 is not customisable
Date: Wed, 2 Apr 2025 07:47:30 -0300

Yuan Fu <casouri <at> gmail.com> writes:

>> On May 29, 2023, at 7:40 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> From: Yuan Fu <casouri <at> gmail.com>
>>> Date: Sun, 28 May 2023 15:51:05 -0700
>>> Cc: mickey <at> masteringemacs.org,
>>> 63750 <at> debbugs.gnu.org
>>>
>>>
>>>
>>>> On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>>>
>>>>> From: Yuan Fu <casouri <at> gmail.com>
>>>>> Date: Sat, 27 May 2023 16:12:18 -0700
>>>>> Cc: Mickey Petersen <mickey <at> masteringemacs.org>,
>>>>> 63750 <at> debbugs.gnu.org
>>>>>
>>>>>> However, I think we decided to make it so that each installation
>>>>>> should update the value of the variable with the data of the grammar
>>>>>> just installed.  I see that we don't actually do that -- Yuan, am I
>>>>>> misremembering this?  If not, would you please add code to add 
to the
>>>>>> variable's value the data of every grammar that is installed?
>>>>>
>>>>> Sure. Does it need to be preserved across sessions (ie, use 
custom)? Or just add for the current session?
>>>>
>>>> Only for the current session.  Users who want it preserved should do
>>>> it themselves (I will add that to the doc string when the code which
>>>> updates the variable is installed).
>>>
>>> Done.
>>
>> Thanks.  And I see that you have updated the doc string accordingly.
>
> Glad my docstring worked out this time ;-)
>
> Yuan

Should we close this bug report?

Message #29 received at 63750 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 63750 <at> debbugs.gnu.org,
 Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#63750: 30.0.50; tree-sitter:
 `treesit-language-source-alist' is not customisable
Date: Wed, 02 Apr 2025 21:19:25 +0300

> Should we close this bug report?

https://lists.gnu.org/archive/html/emacs-devel/2025-03/msg01516.html
recently proposed to add the language-source information
inside every ts-mode.  So instead of a plain comment like

  ;; c-ts-mode is known to work with the following languages and version:
  ;; - tree-sitter-c: v0.23.4-1-g3aa2995
  ;;
  ;; c++-ts-mode is known to work with the following languages and version:
  ;; - tree-sitter-cpp: v0.23.4-1-gf41b4f6

we could prove the same for more easier installation by users
in an internal variable:

  (defvar c-ts-mode--language-source-alist
    '((c
       "https://github.com/tree-sitter/tree-sitter-c";
       "v0.23.4-1-g3aa2995")
      (cpp
       "https://github.com/tree-sitter/tree-sitter-cpp";
       "v0.23.4-1-gf41b4f6"))
    "Tree-sitter language parsers required by `c-ts-mode' and `c++-ts-mode'.")

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.