GNU bug report logs - #63751
[PATCH 0/3] zita-alsa-pcmi: remove -march=native, fix cross-build, and use new style.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63751 in the body.
You can then email your comments to 63751 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] zita-alsa-pcmi: remove -march=native, fix cross-build,
 and use new style.
Date: Sat, 27 May 2023 20:12:34 +0800

Zheng Junjie (3):
  gnu: zita-alsa-pcmi: Do not build with "-march=native".
  gnu: zita-alsa-pcmi: fix cross-build.
  gnu: zita-alsa-pcmi: Use new style for arguments.

 gnu/packages/audio.scm | 57 ++++++++++++++++++++++--------------------
 1 file changed, 30 insertions(+), 27 deletions(-)


base-commit: 3299b40b3599371890816b52d65a6a5ada1b1131
-- 
2.40.1

Message #8 received at 63751 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: 63751 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: zita-alsa-pcmi: fix cross-build.
Date: Sat, 27 May 2023 20:16:09 +0800

* gnu/packages/audio.scm (zita-alsa-pcmi): fix cross-build.
[arguments]: use CXX-FOR-TARGET.
---
 gnu/packages/audio.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6a24c5b9c6..a3873e7631 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -4460,7 +4460,8 @@ (define-public zita-alsa-pcmi
      `(#:tests? #f ; no "check" target
        #:make-flags
        (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
-             (string-append "SUFFIX="))
+             (string-append "SUFFIX=")
+             (string-append "CXX=" ,(cxx-for-target)))
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-makefile-and-enter-directory
-- 
2.40.1

Message #11 received at 63751 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: 63751 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: zita-alsa-pcmi: Do not build with "-march=native".
Date: Sat, 27 May 2023 20:16:08 +0800

* gnu/packages/audio.scm (zita-alsa-pcmi): Do not build with "-march=native".
[arguments]<#:phases>: remove '-march=native' form source/Makefile.
[properties]: New field.
---
 gnu/packages/audio.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 58a981b2fe..6a24c5b9c6 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -44,6 +44,7 @@
 ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2023 Gabriel Wicki <gabriel <at> erlikon.ch>
+;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4466,7 +4467,8 @@ (define-public zita-alsa-pcmi
            (lambda _
              (substitute* "source/Makefile"
                (("ldconfig") "true")
-               (("^LIBDIR =.*") "LIBDIR = lib\n"))
+               (("^LIBDIR =.*") "LIBDIR = lib\n")
+               (("CXXFLAGS \\+= -march=native") ""))
              (chdir "source")
              #t))
          (add-after 'install 'install-symlink
@@ -4479,6 +4481,7 @@ (define-public zita-alsa-pcmi
           (delete 'configure))))
     (inputs
      (list alsa-lib fftw))
+    (properties `((tunable? . #t)))
     (home-page "https://kokkinizita.linuxaudio.org")
     (synopsis "C++ wrapper around the ALSA API")
     (description
-- 
2.40.1

Message #14 received at 63751 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: 63751 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: zita-alsa-pcmi: Use new style for arguments.
Date: Sat, 27 May 2023 20:16:10 +0800

* gnu/packages/audio.scm(zita-alsa-pcmi)[arguments]: Use
G-Expressions.  Delete trailing #ts.
---
 gnu/packages/audio.scm | 57 +++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 29 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index a3873e7631..97a4061324 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -4448,40 +4448,39 @@ (define-public zita-alsa-pcmi
     (version "0.3.2")
     (source (origin
               (method url-fetch)
-              (uri (string-append
-                    "http://kokkinizita.linuxaudio.org"
-                    "/linuxaudio/downloads/zita-alsa-pcmi-"
-                    version ".tar.bz2"))
+              (uri (string-append "http://kokkinizita.linuxaudio.org"
+                                  "/linuxaudio/downloads/zita-alsa-pcmi-"
+                                  version ".tar.bz2"))
               (sha256
                (base32
                 "12d7vdg74yh21w69qi0wg57iz4876j94qbiq09bvscih6xz9y78s"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f ; no "check" target
-       #:make-flags
-       (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
-             (string-append "SUFFIX=")
-             (string-append "CXX=" ,(cxx-for-target)))
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'patch-makefile-and-enter-directory
-           (lambda _
-             (substitute* "source/Makefile"
-               (("ldconfig") "true")
-               (("^LIBDIR =.*") "LIBDIR = lib\n")
-               (("CXXFLAGS \\+= -march=native") ""))
-             (chdir "source")
-             #t))
-         (add-after 'install 'install-symlink
-           (lambda _
-             (symlink "libzita-alsa-pcmi.so"
-                      (string-append (assoc-ref %outputs "out")
-                                     "/lib/libzita-alsa-pcmi.so.0"))
-             #t))
-          ;; no configure script
-          (delete 'configure))))
-    (inputs
-     (list alsa-lib fftw))
+     (list #:tests? #f ;no "check" target
+           #:make-flags #~(list (string-append "PREFIX="
+                                               (assoc-ref %outputs "out"))
+                                (string-append "SUFFIX=")
+                                (string-append "CXX="
+                                               #$(cxx-for-target)))
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'unpack 'patch-makefile-and-enter-directory
+                          (lambda _
+                            (substitute* "source/Makefile"
+                              (("ldconfig")
+                               "true")
+                              (("^LIBDIR =.*")
+                               "LIBDIR = lib\n")
+                              (("CXXFLAGS \\+= -march=native")
+                               ""))
+                            (chdir "source")))
+                        (add-after 'install 'install-symlink
+                          (lambda _
+                            (symlink "libzita-alsa-pcmi.so"
+                                     (string-append (assoc-ref %outputs "out")
+                                      "/lib/libzita-alsa-pcmi.so.0"))))
+                        ;; no configure script
+                        (delete 'configure))))
+    (inputs (list alsa-lib fftw))
     (properties `((tunable? . #t)))
     (home-page "https://kokkinizita.linuxaudio.org")
     (synopsis "C++ wrapper around the ALSA API")
-- 
2.40.1

Message #19 received at 63751-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Z572 <873216071 <at> qq.com>
Cc: 63751-done <at> debbugs.gnu.org
Subject: Re: bug#63751: [PATCH 0/3] zita-alsa-pcmi: remove -march=native,
 fix cross-build, and use new style.
Date: Sat, 01 Jul 2023 16:33:58 +0200

Hi,

Z572 <873216071 <at> qq.com> skribis:

>   gnu: zita-alsa-pcmi: Do not build with "-march=native".
>   gnu: zita-alsa-pcmi: fix cross-build.
>   gnu: zita-alsa-pcmi: Use new style for arguments.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.