GNU bug report logs - #63798
[PATCH] Fix Erlang package substitutions

Previous Next

Package: guix-patches;

Reported by: wrobell <wrobell <at> riseup.net>

Date: Tue, 30 May 2023 05:45:03 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63798 in the body.
You can then email your comments to 63798 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#63798; Package guix-patches. (Tue, 30 May 2023 05:45:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to wrobell <wrobell <at> riseup.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 30 May 2023 05:45:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: wrobell <wrobell <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: wrobell <wrobell <at> riseup.net>
Subject: [PATCH] Fix Erlang package substitutions
Date: Mon, 29 May 2023 23:22:24 +0100
Both `dirname` and `basename` need to be substituted. There is no need
for `sed` substitution in Erlag 25.3.
---
 gnu/packages/erlang.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index 7564c2a560..b6e82e0109 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2021 Oskar Köök <oskar <at> maatriks.ee>
 ;;; Copyright © 2021 Cees de Groot <cg <at> evrl.com>
 ;;; Copyright © 2022 jgart <jgart <at> dismail.de>
+;;; Copyright © 2023 wrobell <wrobell <at> riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -168,7 +169,8 @@ (define-public erlang
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (substitute* (string-append out "/bin/erl")
-                 (("sed") (which "sed"))))))
+                 (("basename") (which "basename"))
+                 (("dirname") (which "dirname"))))))
          (add-after 'install 'install-doc
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))

base-commit: 7b400e7f8751e6b0cc6e66d3f7ecfb7f5bd51309
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63798; Package guix-patches. (Tue, 20 Jun 2023 10:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 63798 <at> debbugs.gnu.org (full text, mbox):

From: wrobell <wrobell <at> riseup.net>
To: 63798 <at> debbugs.gnu.org
Subject: Re: [PATCH] Fix Erlang package substitutions
Date: Tue, 20 Jun 2023 11:48:24 +0100
I believe, the fix is required when I run my custom RabbitMQ package.

Also, some other user experiences the same issue

    https://lists.gnu.org/archive/html/guix-devel/2023-04/msg00003.html

Best regards,

w

--
https://mortgage.diy-labs.eu/




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Sat, 01 Jul 2023 10:08:02 GMT) Full text and rfc822 format available.

Notification sent to wrobell <wrobell <at> riseup.net>:
bug acknowledged by developer. (Sat, 01 Jul 2023 10:08:02 GMT) Full text and rfc822 format available.

Message #13 received at 63798-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: wrobell <wrobell <at> riseup.net>
Cc: 63798-done <at> debbugs.gnu.org
Subject: Re: [bug#63798] [PATCH] Fix Erlang package substitutions
Date: Sat, 01 Jul 2023 12:07:18 +0200
Hello,

wrobell <wrobell <at> riseup.net> writes:

> Both `dirname` and `basename` need to be substituted. There is no need
> for `sed` substitution in Erlag 25.3.

Applied, with a proper commit message. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 29 Jul 2023 11:24:15 GMT) Full text and rfc822 format available.

This bug report was last modified 243 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.