GNU bug report logs - #63880
29.0.91; typescript-ts-mode fails to highlight infer keyword

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63880 in the body.
You can then email your comments to 63880 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.91; typescript-ts-mode fails to highlight infer keyword
Date: Sun, 04 Jun 2023 00:57:19 +0100

Reproduction:

1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
Type;' > test.ts
2. C-x C-f test.ts
3. M-x typescript-ts-mode
4. Observe the infer keyword is not highlighted

Expectation:

Typescript has an
[`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
keyword, it should be highlighted.

Message #8 received at 63880 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>,
 Theodor Thornhill <theo <at> thornhill.no>, Yuan Fu <casouri <at> gmail.com>
Cc: 63880 <at> debbugs.gnu.org
Subject: Re: bug#63880: 29.0.91;
 typescript-ts-mode fails to highlight infer keyword
Date: Sun, 04 Jun 2023 08:09:28 +0300

> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> Date: Sun, 04 Jun 2023 00:57:19 +0100
> 
> 
> Reproduction:
> 
> 1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
> Type;' > test.ts
> 2. C-x C-f test.ts
> 3. M-x typescript-ts-mode
> 4. Observe the infer keyword is not highlighted
> 
> Expectation:
> 
> Typescript has an
> [`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
> keyword, it should be highlighted.

Thanks.  CC'ing the relevant developers.

Message #11 received at 63880 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>
Cc: 63880 <at> debbugs.gnu.org
Subject: Re: bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer keyword
Date: Sun, 04 Jun 2023 10:11:50 +0200

On 4 June 2023 07:09:28 CEST, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
>> Date: Sun, 04 Jun 2023 00:57:19 +0100
>> 
>> 
>> Reproduction:
>> 
>> 1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
>> Type;' > test.ts
>> 2. C-x C-f test.ts
>> 3. M-x typescript-ts-mode
>> 4. Observe the infer keyword is not highlighted
>> 
>> Expectation:
>> 
>> Typescript has an
>> [`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
>> keyword, it should be highlighted.
>
>Thanks.  CC'ing the relevant developers.


Thanks, I'll look at it :)

I'll try to follow the bugtracker a little more closely going forwards. Apologies for the absence :)

Theo

Message #14 received at 63880 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>
Cc: 63880 <at> debbugs.gnu.org
Subject: Re: bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer
 keyword
Date: Tue, 06 Jun 2023 06:28:03 +0200

Theodor Thornhill <theo <at> thornhill.no> writes:

> On 4 June 2023 07:09:28 CEST, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
>>> Date: Sun, 04 Jun 2023 00:57:19 +0100
>>> 
>>> 
>>> Reproduction:
>>> 
>>> 1. echo 'type Flatten<Type> = Type extends Array<infer Item> ? Item :
>>> Type;' > test.ts
>>> 2. C-x C-f test.ts
>>> 3. M-x typescript-ts-mode
>>> 4. Observe the infer keyword is not highlighted
>>> 
>>> Expectation:
>>> 
>>> Typescript has an
>>> [`infer`](https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#inferring-within-conditional-types)
>>> keyword, it should be highlighted.
>>
>>Thanks.  CC'ing the relevant developers.
>
>
> Thanks, I'll look at it :)
>
> I'll try to follow the bugtracker a little more closely going forwards. Apologies for the absence :)
>
> Theo


Now fixed in emacs-29.

Thanks for the report.

Theo

Message #17 received at 63880 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 63880 <at> debbugs.gnu.org, casouri <at> gmail.com, jostein <at> kjonigsen.net,
 wyuenho <at> gmail.com
Subject: Re: bug#63880: 29.0.91; typescript-ts-mode fails to highlight infer
 keyword
Date: Tue, 06 Jun 2023 14:51:33 +0300

> From: Theodor Thornhill <theo <at> thornhill.no>
> Cc: 63880 <at> debbugs.gnu.org
> Date: Tue, 06 Jun 2023 06:28:03 +0200
> 
> Now fixed in emacs-29.

Thanks.

Message #22 received at 63880-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: theo <at> thornhill.no
Cc: jostein <at> kjonigsen.net, casouri <at> gmail.com, 63880-done <at> debbugs.gnu.org,
 wyuenho <at> gmail.com
Subject: Re: bug#63880: 29.0.91;
 typescript-ts-mode fails to highlight infer keyword
Date: Thu, 08 Jun 2023 12:28:02 +0300

> Cc: 63880 <at> debbugs.gnu.org, casouri <at> gmail.com, jostein <at> kjonigsen.net,
>  wyuenho <at> gmail.com
> Date: Tue, 06 Jun 2023 14:51:33 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Theodor Thornhill <theo <at> thornhill.no>
> > Cc: 63880 <at> debbugs.gnu.org
> > Date: Tue, 06 Jun 2023 06:28:03 +0200
> > 
> > Now fixed in emacs-29.
> 
> Thanks.

No further comments, so I'm closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.