Received: (at 63916) by debbugs.gnu.org; 27 Sep 2023 10:54:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Sep 27 06:54:18 2023
Received: from localhost ([127.0.0.1]:50621 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qlSBN-0000TH-NH
for submit <at> debbugs.gnu.org; Wed, 27 Sep 2023 06:54:18 -0400
Received: from mailproxy05.manitu.net ([217.11.48.69]:51802)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <benjamin@HIDDEN>) id 1qlSBK-0000T8-U2
for 63916 <at> debbugs.gnu.org; Wed, 27 Sep 2023 06:54:16 -0400
Message-ID: <dff27967c005dad89d4ff231fb36c1716def8409.camel@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
From: Benjamin Orthen <benjamin@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Date: Wed, 27 Sep 2023 12:53:59 +0200
In-Reply-To: <647c4e7a08e8a4b048b3fe386ac67604d79198c2.camel@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
<87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN>
<87fs6y6jkq.fsf@HIDDEN> <jwvmt16ueib.fsf-monnier+emacs@HIDDEN>
<bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN>
<db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN>
<jwvil8kbhm6.fsf-monnier+emacs@HIDDEN>
<647c4e7a08e8a4b048b3fe386ac67604d79198c2.camel@HIDDEN>
Content-Type: multipart/alternative; boundary="=-2BVGFyMQFwRSXY+UZH2A"
MIME-Version: 1.0
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Philip Kaludercic <philipk@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--=-2BVGFyMQFwRSXY+UZH2A
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hi,
the assignment/disclaimer process has been completed, so this is not
blocking the patch anymore.
Best,
Benjamin
On Mon, 2023-09-11 at 11:58 +0200, Benjamin Orthen wrote:
> Hi,
>=20
> I've sent the mail to assign@HIDDEN=C2=A0and request the assignment form=
.
>=20
> I modified the changes according to your and Philip's remarks.
>=20
> On Fri, 2023-09-08 at 15:35 -0400, Stefan Monnier wrote:
> > Hi,
> >=20
> > > Instead of looking only at the git log of the main package file,
> > > we
> > > look instead at the git log of all files of the core package.
> > > This way, a new devel version is created when any other package
> > > file is
> > > changed, not just the main file.
> >=20
> > It has a minor downside which is that it slows down the
> > overwhelming
> > cases (where there are no changes), but it's probably lost in the
> > noise,
> > so it sounds like a very good idea, thank you.
> >=20
> > > Is this the right mailing list to send the patch?
> >=20
> > Yes.
> >=20
> > [ BTW, Philip's `list-ensure` is called `ensure-list` :-)
> > =C2=A0 And yes, I think it's OK to use functionality from Emacs-28.=C2=
=A0 ]
> >=20
> > > +=C2=A0 (when-let
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((core (elpaa--spec-get pkg-spec :cor=
e)))
> >=20
> > AFAICT this code is only used when `:core` is non-nil, so better
> > either
> > not test for it redundantly, or do it via `cl-assert`.
>=20
> Done
> >=20
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (member item exclu=
des)
> >=20
> > The code looks generally good, but I'm not sure about the one line
> > above:
> > - I know it won't do the right thing for ERC's
> > "lisp/erc/ChangeLog.*"
> > =C2=A0 but it's probably harmless (those files basically never change
> > =C2=A0 anyway).
> > - I have the impression that it won't do the right thing for
> > =C2=A0 `use-package`'s "bind-key.el"
>=20
> I changed the code to ignore files using the wildcards in :excludes.
> This still does not work for "bind-key.el", but IMO this can and
> should be solved by changing it to "lisp/use-package/bind-key.el",=C2=A0
> similar to how erc is doing it ("lisp/erc/erc-loaddefs.el" ).
>=20
> (The commentary says: ";; Exclude matches must be against the full
> file-name, substring matches don't
> ;; work unless wildcards are used (e.g. use "etc/*" instead of
> "etc/").")
>=20
> >=20
> > Also, I see you do (concat item file) but you only know that `item`
> > is
> > a directory, not that it ends with a `/`.=C2=A0 Better use `file-name-
> > concat`.
>=20
> With `directory-files-recursively` this has resolved itself.
> >=20
> > Last but not least: I think this doesn't quite qualify as "trivial"
> > so
> > we'd need you to sign the copyright paperwork (well, maybe with
> > some of
> > the suggested simplifications, it could qualify as "trivial", but
> > it's
> > easier if you sign the paperwork so we don't have to worry about
> > it,
> > especially if you ever submit more code, which I hope you will).
> > To that end, please fill the form below and email it to the FSF as
> > instructed so they can send you the appropriate paperwork to sign.
> >=20
> >=20
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan
> >=20
> >=20
> > Please email the following information to assign@HIDDEN, and we
> > will send you the assignment form for your past and future changes.
> >=20
> > Please use your full legal name (in ASCII characters) as the
> > subject
> > line of the message.
> > -------------------------------------------------------------------
> > ---
> > REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
> >=20
> > [What is the name of the program or package you're contributing
> > to?]
> > Emacs
> >=20
> > [Did you copy any files or text written by someone else in these
> > changes?
> > Even if that material is free software, we need to know about it.]
> >=20
> >=20
> > [Do you have an employer who might have a basis to claim to own
> > your changes?=C2=A0 Do you attend a school which might make such a
> > claim?]
> >=20
> >=20
> > [For the copyright registration, what country are you a citizen
> > of?]
> >=20
> >=20
> > [What year were you born?]
> >=20
> >=20
> > [Please write your email address here.]
> >=20
> >=20
> > [Please write your postal address here.]
> >=20
> >=20
> >=20
> >=20
> >=20
> > [Which files have you changed so far, and which new files have you
> > written
> > so far?]
> >=20
>=20
--=-2BVGFyMQFwRSXY+UZH2A
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
<html><head><style>pre,code,address {
margin: 0px;
}
h1,h2,h3,h4,h5,h6 {
margin-top: 0.2em;
margin-bottom: 0.2em;
}
ol,ul {
margin-top: 0em;
margin-bottom: 0em;
}
blockquote {
margin-top: 0em;
margin-bottom: 0em;
}
</style><style>pre,code,address {
margin: 0px;
}
h1,h2,h3,h4,h5,h6 {
margin-top: 0.2em;
margin-bottom: 0.2em;
}
ol,ul {
margin-top: 0em;
margin-bottom: 0em;
}
blockquote {
margin-top: 0em;
margin-bottom: 0em;
}
</style></head><body><div>Hi,</div><div><br></div><div>the assignment/discl=
aimer process has been completed, so this is not blocking the patch anymore=
.</div><div><br></div><div><br></div><div>Best,</div><div>Benjamin</div><di=
v><br></div><div><br></div><div>On Mon, 2023-09-11 at 11:58 +0200, Benjamin=
Orthen wrote:</div><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; b=
order-left:2px #729fcf solid;padding-left:1ex"><div>Hi,</div><div><br></div=
><div>I've sent the mail to <a href=3D"mailto:assign@HIDDEN">assign@HIDDEN=
g</a> and request the assignment form.</div><div><br></div><div>I modi=
fied the changes according to your and Philip's remarks.</div><div><br></di=
v><div>On Fri, 2023-09-08 at 15:35 -0400, Stefan Monnier wrote:</div><block=
quote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf sol=
id;padding-left:1ex"><div>Hi,<br></div><div><br></div><blockquote type=3D"c=
ite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left=
:1ex"><div>Instead of looking only at the git log of the main package file,=
we<br></div><div>look instead at the git log of all files of the core pack=
age.<br></div><div>This way, a new devel version is created when any other =
package file is<br></div><div>changed, not just the main file.<br></div></b=
lockquote><div><br></div><div>It has a minor downside which is that it slow=
s down the overwhelming<br></div><div>cases (where there are no changes), b=
ut it's probably lost in the noise,<br></div><div>so it sounds like a very =
good idea, thank you.<br></div><div><br></div><blockquote type=3D"cite" sty=
le=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><d=
iv>Is this the right mailing list to send the patch?<br></div></blockquote>=
<div><br></div><div>Yes.<br></div><div><br></div><div>[ BTW, Philip's `list=
-ensure` is called `ensure-list` :-)<br></div><div> And yes, I think =
it's OK to use functionality from Emacs-28. ]<br></div><div><br></div=
><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729=
fcf solid;padding-left:1ex"><div>+ (when-let<br></div><div>+ &nb=
sp; ((core (elpaa--spec-get pkg-spec :core)))<br></div></=
blockquote><div><br></div><div>AFAICT this code is only used when `:core` i=
s non-nil, so better either<br></div><div>not test for it redundantly, or d=
o it via `cl-assert`.<br></div></blockquote><div><br></div><div>Done</div><=
blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fc=
f solid;padding-left:1ex"><div><br></div><blockquote type=3D"cite" style=3D=
"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>+&=
nbsp; &nbs=
p; (unless (member item excludes)<br></=
div></blockquote><div><br></div><div>The code looks generally good, but I'm=
not sure about the one line<br></div><div>above:<br></div><div>- I know it=
won't do the right thing for ERC's "lisp/erc/ChangeLog.*"<br></div><div>&n=
bsp; but it's probably harmless (those files basically never change<br></di=
v><div> anyway).<br></div><div>- I have the impression that it won't =
do the right thing for<br></div><div> `use-package`'s "bind-key.el"<b=
r></div></blockquote><div><br></div><div>I changed the code to ignore files=
using the wildcards in :excludes.</div><div>This still does not work for "=
bind-key.el", but IMO this can and should be solved by changing it to "lisp=
/use-package/bind-key.el", </div><div>similar to how erc is doing it (=
"lisp/erc/erc-loaddefs.el" ).</div><div><br></div><div>(The commentary says=
: ";; Exclude matches must be against the full file-name, substring matches=
don't</div><div>;; work unless wildcards are used (e.g. use "etc/*" instea=
d of "etc/").")</div><div><br></div><blockquote type=3D"cite" style=3D"marg=
in:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></d=
iv><div>Also, I see you do (concat item file) but you only know that `item`=
is<br></div><div>a directory, not that it ends with a `/`. Better us=
e `file-name-concat`.<br></div></blockquote><div><br></div><div>With `direc=
tory-files-recursively` this has resolved itself.</div><blockquote type=3D"=
cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-lef=
t:1ex"><div><br></div><div>Last but not least: I think this doesn't quite q=
ualify as "trivial" so<br></div><div>we'd need you to sign the copyright pa=
perwork (well, maybe with some of<br></div><div>the suggested simplificatio=
ns, it could qualify as "trivial", but it's<br></div><div>easier if you sig=
n the paperwork so we don't have to worry about it,<br></div><div>especiall=
y if you ever submit more code, which I hope you will).<br></div><div>To th=
at end, please fill the form below and email it to the FSF as<br></div><div=
>instructed so they can send you the appropriate paperwork to sign.<br></di=
v><div><br></div><div><br></div><div> &n=
bsp; Stefan<br></div><div><br></div><div><br></div><div>Please email the fo=
llowing information to <a href=3D"mailto:assign@HIDDEN">assign@HIDDEN</a>=
, and we<br></div><div>will send you the assignment form for your past and =
future changes.<br></div><div><br></div><div>Please use your full legal nam=
e (in ASCII characters) as the subject<br></div><div>line of the message.<b=
r></div><div>--------------------------------------------------------------=
--------<br></div><div>REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES<br></=
div><div><br></div><div>[What is the name of the program or package you're =
contributing to?]<br></div><div>Emacs<br></div><div><br></div><div>[Did you=
copy any files or text written by someone else in these changes?<br></div>=
<div>Even if that material is free software, we need to know about it.]<br>=
</div><div><br></div><div><br></div><div>[Do you have an employer who might=
have a basis to claim to own<br></div><div>your changes? Do you atte=
nd a school which might make such a claim?]<br></div><div><br></div><div><b=
r></div><div>[For the copyright registration, what country are you a citize=
n of?]<br></div><div><br></div><div><br></div><div>[What year were you born=
?]<br></div><div><br></div><div><br></div><div>[Please write your email add=
ress here.]<br></div><div><br></div><div><br></div><div>[Please write your =
postal address here.]<br></div><div><br></div><div><br></div><div><br></div=
><div><br></div><div><br></div><div>[Which files have you changed so far, a=
nd which new files have you written<br></div><div>so far?]<br></div><div><b=
r></div></blockquote><div><br></div><div><span></span></div></blockquote><d=
iv><br></div><div><span></span></div></body></html>
--=-2BVGFyMQFwRSXY+UZH2A--
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 11 Sep 2023 09:58:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 11 05:58:55 2023
Received: from localhost ([127.0.0.1]:52164 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qfdh0-0005CT-Hd
for submit <at> debbugs.gnu.org; Mon, 11 Sep 2023 05:58:55 -0400
Received: from mailproxy01.manitu.net ([217.11.48.65]:56676)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <benjamin@HIDDEN>) id 1qfdgx-0005CH-8o
for 63916 <at> debbugs.gnu.org; Mon, 11 Sep 2023 05:58:52 -0400
Message-ID: <647c4e7a08e8a4b048b3fe386ac67604d79198c2.camel@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
From: Benjamin Orthen <benjamin@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Date: Mon, 11 Sep 2023 11:58:45 +0200
In-Reply-To: <jwvil8kbhm6.fsf-monnier+emacs@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
<87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN>
<87fs6y6jkq.fsf@HIDDEN> <jwvmt16ueib.fsf-monnier+emacs@HIDDEN>
<bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN>
<db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN>
<jwvil8kbhm6.fsf-monnier+emacs@HIDDEN>
Content-Type: multipart/mixed; boundary="=-Tyq70y3UDtGxMBjrIX7n"
MIME-Version: 1.0
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Philip Kaludercic <philipk@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--=-Tyq70y3UDtGxMBjrIX7n
Content-Type: multipart/alternative; boundary="=-J6iBT+L5Q00JwpFQK48i"
--=-J6iBT+L5Q00JwpFQK48i
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Hi,
I've sent the mail to assign@HIDDEN=C2=A0and request the assignment form.
I modified the changes according to your and Philip's remarks.
On Fri, 2023-09-08 at 15:35 -0400, Stefan Monnier wrote:
> Hi,
>=20
> > Instead of looking only at the git log of the main package file, we
> > look instead at the git log of all files of the core package.
> > This way, a new devel version is created when any other package
> > file is
> > changed, not just the main file.
>=20
> It has a minor downside which is that it slows down the overwhelming
> cases (where there are no changes), but it's probably lost in the
> noise,
> so it sounds like a very good idea, thank you.
>=20
> > Is this the right mailing list to send the patch?
>=20
> Yes.
>=20
> [ BTW, Philip's `list-ensure` is called `ensure-list` :-)
> =C2=A0 And yes, I think it's OK to use functionality from Emacs-28.=C2=A0=
]
>=20
> > +=C2=A0 (when-let
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((core (elpaa--spec-get pkg-spec :core)=
))
>=20
> AFAICT this code is only used when `:core` is non-nil, so better
> either
> not test for it redundantly, or do it via `cl-assert`.
Done
>=20
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (member item excludes=
)
>=20
> The code looks generally good, but I'm not sure about the one line
> above:
> - I know it won't do the right thing for ERC's "lisp/erc/ChangeLog.*"
> =C2=A0 but it's probably harmless (those files basically never change
> =C2=A0 anyway).
> - I have the impression that it won't do the right thing for
> =C2=A0 `use-package`'s "bind-key.el"
I changed the code to ignore files using the wildcards in :excludes.
This still does not work for "bind-key.el", but IMO this can and should
be solved by changing it to "lisp/use-package/bind-key.el",=C2=A0
similar to how erc is doing it ("lisp/erc/erc-loaddefs.el" ).
(The commentary says: ";; Exclude matches must be against the full
file-name, substring matches don't
;; work unless wildcards are used (e.g. use "etc/*" instead of
"etc/").")
>=20
> Also, I see you do (concat item file) but you only know that `item`
> is
> a directory, not that it ends with a `/`.=C2=A0 Better use `file-name-
> concat`.
With `directory-files-recursively` this has resolved itself.
>=20
> Last but not least: I think this doesn't quite qualify as "trivial"
> so
> we'd need you to sign the copyright paperwork (well, maybe with some
> of
> the suggested simplifications, it could qualify as "trivial", but
> it's
> easier if you sign the paperwork so we don't have to worry about it,
> especially if you ever submit more code, which I hope you will).
> To that end, please fill the form below and email it to the FSF as
> instructed so they can send you the appropriate paperwork to sign.
>=20
>=20
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan
>=20
>=20
> Please email the following information to assign@HIDDEN, and we
> will send you the assignment form for your past and future changes.
>=20
> Please use your full legal name (in ASCII characters) as the subject
> line of the message.
> ----------------------------------------------------------------------
> REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
>=20
> [What is the name of the program or package you're contributing to?]
> Emacs
>=20
> [Did you copy any files or text written by someone else in these
> changes?
> Even if that material is free software, we need to know about it.]
>=20
>=20
> [Do you have an employer who might have a basis to claim to own
> your changes?=C2=A0 Do you attend a school which might make such a claim?=
]
>=20
>=20
> [For the copyright registration, what country are you a citizen of?]
>=20
>=20
> [What year were you born?]
>=20
>=20
> [Please write your email address here.]
>=20
>=20
> [Please write your postal address here.]
>=20
>=20
>=20
>=20
>=20
> [Which files have you changed so far, and which new files have you
> written
> so far?]
>=20
--=-J6iBT+L5Q00JwpFQK48i
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
<html><head><style>pre,code,address {
margin: 0px;
}
h1,h2,h3,h4,h5,h6 {
margin-top: 0.2em;
margin-bottom: 0.2em;
}
ol,ul {
margin-top: 0em;
margin-bottom: 0em;
}
blockquote {
margin-top: 0em;
margin-bottom: 0em;
}
</style></head><body><div>Hi,</div><div><br></div><div>I've sent the mail t=
o <a href=3D"mailto:assign@HIDDEN">assign@HIDDEN</a> and request the=
assignment form.</div><div><br></div><div>I modified the changes according=
to your and Philip's remarks.</div><div><br></div><div>On Fri, 2023-09-08 =
at 15:35 -0400, Stefan Monnier wrote:</div><blockquote type=3D"cite" style=
=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div=
>Hi,<br></div><div><br></div><blockquote type=3D"cite" style=3D"margin:0 0 =
0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Instead of loo=
king only at the git log of the main package file, we<br></div><div>look in=
stead at the git log of all files of the core package.<br></div><div>This w=
ay, a new devel version is created when any other package file is<br></div>=
<div>changed, not just the main file.<br></div></blockquote><div><br></div>=
<div>It has a minor downside which is that it slows down the overwhelming<b=
r></div><div>cases (where there are no changes), but it's probably lost in =
the noise,<br></div><div>so it sounds like a very good idea, thank you.<br>=
</div><div><br></div><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; =
border-left:2px #729fcf solid;padding-left:1ex"><div>Is this the right mail=
ing list to send the patch?<br></div></blockquote><div><br></div><div>Yes.<=
br></div><div><br></div><div>[ BTW, Philip's `list-ensure` is called `ensur=
e-list` :-)<br></div><div> And yes, I think it's OK to use functional=
ity from Emacs-28. ]<br></div><div><br></div><blockquote type=3D"cite=
" style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1e=
x"><div>+ (when-let<br></div><div>+ ((c=
ore (elpaa--spec-get pkg-spec :core)))<br></div></blockquote><div><br></div=
><div>AFAICT this code is only used when `:core` is non-nil, so better eith=
er<br></div><div>not test for it redundantly, or do it via `cl-assert`.<br>=
</div></blockquote><div><br></div><div>Done</div><blockquote type=3D"cite" =
style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"=
><div><br></div><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; borde=
r-left:2px #729fcf solid;padding-left:1ex"><div>+ &n=
bsp;  =
; (unless (member item excludes)<br></div></blockquote><div><br=
></div><div>The code looks generally good, but I'm not sure about the one l=
ine<br></div><div>above:<br></div><div>- I know it won't do the right thing=
for ERC's "lisp/erc/ChangeLog.*"<br></div><div> but it's probably ha=
rmless (those files basically never change<br></div><div> anyway).<br=
></div><div>- I have the impression that it won't do the right thing for<br=
></div><div> `use-package`'s "bind-key.el"<br></div></blockquote><div=
><br></div><div>I changed the code to ignore files using the wildcards in :=
excludes.</div><div>This still does not work for "bind-key.el", but IMO thi=
s can and should be solved by changing it to "lisp/use-package/bind-key.el"=
, </div><div>similar to how erc is doing it ("lisp/erc/erc-loaddefs.el=
" ).</div><div><br></div><div>(The commentary says: ";; Exclude matches mus=
t be against the full file-name, substring matches don't</div><div>;; work =
unless wildcards are used (e.g. use "etc/*" instead of "etc/").")</div><div=
><br></div><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-lef=
t:2px #729fcf solid;padding-left:1ex"><div><br></div><div>Also, I see you d=
o (concat item file) but you only know that `item` is<br></div><div>a direc=
tory, not that it ends with a `/`. Better use `file-name-concat`.<br>=
</div></blockquote><div><br></div><div>With `directory-files-recursively` t=
his has resolved itself.</div><blockquote type=3D"cite" style=3D"margin:0 0=
0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div><br></div><di=
v>Last but not least: I think this doesn't quite qualify as "trivial" so<br=
></div><div>we'd need you to sign the copyright paperwork (well, maybe with=
some of<br></div><div>the suggested simplifications, it could qualify as "=
trivial", but it's<br></div><div>easier if you sign the paperwork so we don=
't have to worry about it,<br></div><div>especially if you ever submit more=
code, which I hope you will).<br></div><div>To that end, please fill the f=
orm below and email it to the FSF as<br></div><div>instructed so they can s=
end you the appropriate paperwork to sign.<br></div><div><br></div><div><br=
></div><div> Stefan<br></div><div=
><br></div><div><br></div><div>Please email the following information to <a=
href=3D"mailto:assign@HIDDEN">assign@HIDDEN</a>, and we<br></div><div>wi=
ll send you the assignment form for your past and future changes.<br></div>=
<div><br></div><div>Please use your full legal name (in ASCII characters) a=
s the subject<br></div><div>line of the message.<br></div><div>------------=
----------------------------------------------------------<br></div><div>RE=
QUEST: SEND FORM FOR PAST AND FUTURE CHANGES<br></div><div><br></div><div>[=
What is the name of the program or package you're contributing to?]<br></di=
v><div>Emacs<br></div><div><br></div><div>[Did you copy any files or text w=
ritten by someone else in these changes?<br></div><div>Even if that materia=
l is free software, we need to know about it.]<br></div><div><br></div><div=
><br></div><div>[Do you have an employer who might have a basis to claim to=
own<br></div><div>your changes? Do you attend a school which might m=
ake such a claim?]<br></div><div><br></div><div><br></div><div>[For the cop=
yright registration, what country are you a citizen of?]<br></div><div><br>=
</div><div><br></div><div>[What year were you born?]<br></div><div><br></di=
v><div><br></div><div>[Please write your email address here.]<br></div><div=
><br></div><div><br></div><div>[Please write your postal address here.]<br>=
</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br>=
</div><div>[Which files have you changed so far, and which new files have y=
ou written<br></div><div>so far?]<br></div><div><br></div></blockquote><div=
><br></div><div><span></span></div></body></html>
--=-J6iBT+L5Q00JwpFQK48i--
--=-Tyq70y3UDtGxMBjrIX7n
Content-Disposition: attachment;
filename*0=0001-Add-elpa-core-files-to-get-more-exact-devel-versions.pat;
filename*1=ch
Content-Type: text/x-patch;
name="0001-Add-elpa-core-files-to-get-more-exact-devel-versions.patch";
charset="UTF-8"
Content-Transfer-Encoding: base64
RnJvbSAwMjkwZTJmMmU5YmM1YTM2MTVkZGU1NGMxNDJhZTNjYjU0ZGMyMjc0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBPcnRoZW4gPGdpdEBvcnRoZW4ubmV0PgpEYXRl
OiBGcmksIDggU2VwIDIwMjMgMTI6MDU6MTQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBBZGQgZWxw
YS0tY29yZS1maWxlcyB0byBnZXQgbW9yZSBleGFjdCBkZXZlbC12ZXJzaW9ucyBmb3IKIGNvcmUg
cGFja2FnZXMKCi0tLQogZWxwYS1hZG1pbi5lbCB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQzIGluc2VydGlv
bnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2VscGEtYWRtaW4uZWwgYi9lbHBh
LWFkbWluLmVsCmluZGV4IDJjMmQyYWVhYjcuLmQ5YTIyYjAwNTUgMTAwNjQ0Ci0tLSBhL2VscGEt
YWRtaW4uZWwKKysrIGIvZWxwYS1hZG1pbi5lbApAQCAtOTA4LDIwICs5MDgsNTIgQEAgb2YgdGhl
IGN1cnJlbnQgYHByb2Nlc3MtZW52aXJvbm1lbnQnLiAgUmV0dXJuIHRoZSBtb2RpZmllZCBjb3B5
LiIKICAgICAgICAgICAgICAgIDApKSkKICAgICAoZW5jb2RlLXRpbWUgKGxpc3QgcyBtaSBoIGQg
bW8geSBuaWwgbmlsIHpzKSkpKQogCisoZGVmdW4gZWxwYWEtLWNvcmUtZmlsZXMgKHBrZy1zcGVj
KQorICAiR2V0IGEgbGlzdCBvZiBjb3JlIGZpbGVzIChhbmQgb25seSBmaWxlcykgZm9yIFBLRy1T
UEVDLgorQ29yZSBmb2xkZXJzIGFyZSByZWN1cnNpdmVseSBzZWFyY2hlZCwgZXhjbHVkZWQgZmls
ZXMgYXJlIGlnbm9yZWQuIgorICAobGV0KiAoKGZpbGUtcGF0dGVybnMgKGVuc3VyZS1saXN0IChl
bHBhYS0tc3BlYy1nZXQgcGtnLXNwZWMgOmNvcmUpKSkKKyAgICAgICAgIChleGNsdWRlcyAoZWxw
YWEtLXNwZWMtZ2V0IHBrZy1zcGVjIDpleGNsdWRlcykpCisgICAgICAgICAoZW1hY3MtcmVwby1y
b290IChleHBhbmQtZmlsZS1uYW1lICJlbWFjcyIpKQorICAgICAgICAgKGRlZmF1bHQtZGlyZWN0
b3J5IGVtYWNzLXJlcG8tcm9vdCkKKyAgICAgICAgIChjb3JlLWZpbGVzIG5pbCkpCisKKyAgICA7
OyBlbnN1cmUgd2UgbG9vayBhdCBmaWxlcyBmcm9tIGEgY29yZSBwYWNrYWdlCisgICAgKGNsLWFz
c2VydCBmaWxlLXBhdHRlcm5zKQorCisgICAgOzsgd2UgbG9vayBhdCBlYWNoIGZpbGUgb3IgZmls
ZXMgaW4gZm9sZGVyIGFuZCBhZGQgdGhlbQorICAgIDs7IHRvIGNvcmUtZmlsZXMKKyAgICAoZG9s
aXN0IChpdGVtIGZpbGUtcGF0dGVybnMpCisgICAgICAoaWYgKGZpbGUtZGlyZWN0b3J5LXAgaXRl
bSkKKyAgICAgICAgICAoc2V0cSBjb3JlLWZpbGVzIChhcHBlbmQgY29yZS1maWxlcyAoZGlyZWN0
b3J5LWZpbGVzLXJlY3Vyc2l2ZWx5IGl0ZW0gIi4qIikpKQorICAgICAgICAocHVzaCBpdGVtIGNv
cmUtZmlsZXMpKSkKKworICAgIDs7IHJlbW92ZSBhbGwgZmlsZXMgd2hpY2ggbWF0Y2ggYSB3aWxk
Y2FyZCBpbiB0aGUgZXhjbHVkZXMKKyAgICAoc2V0cSBjb3JlLWZpbGVzIChjbC1yZW1vdmUtaWYK
KyAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhIChmaWxlLW5hbWUpCisgICAgICAgICAgICAg
ICAgICAgICAgICAoc2VxLXNvbWUKKyAgICAgICAgICAgICAgICAgICAgICAgICAobGFtYmRhICh3
aWxkY2FyZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctbWF0Y2gtcCAod2ls
ZGNhcmQtdG8tcmVnZXhwIHdpbGRjYXJkKSBmaWxlLW5hbWUpKQorICAgICAgICAgICAgICAgICAg
ICAgICAgIGV4Y2x1ZGVzKSkKKyAgICAgICAgICAgICAgICAgICAgICBjb3JlLWZpbGVzKSkKKyAg
ICBjb3JlLWZpbGVzKSkKKwogKGRlZnVuIGVscGFhLS1nZXQtZGV2ZWwtdmVyc2lvbiAoZGlyIHBr
Zy1zcGVjKQogICAiQ29tcHV0ZSB0aGUgZGF0ZS1iYXNlZCBwc2V1ZG8tdmVyc2lvbiB1c2VkIGZv
ciBkZXZlbCBidWlsZHMuIgotICAobGV0KiAoKGZ0biAoZmlsZS10cnVlbmFtZSAgICAgIDs7IEZv
bGxvdyBzeW1saW5rcyEKLSAgICAgICAgICAgICAgKGV4cGFuZC1maWxlLW5hbWUgKGVscGFhLS1t
YWluLWZpbGUgcGtnLXNwZWMpIGRpcikpKQotICAgICAgICAgKGRlZmF1bHQtZGlyZWN0b3J5IChm
aWxlLW5hbWUtZGlyZWN0b3J5IGZ0bikpCi0gICAgICAgICAoZ2l0ZGF0ZQorICAobGV0KiAoKGdp
dGRhdGUKICAgICAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgotICAgICAgICAgICAoaWYgKHBsaXN0
LWdldCAoY2RyIHBrZy1zcGVjKSA6Y29yZSkKLSAgICAgICAgICAgICAgIDs7IEZvciBjb3JlIHBh
Y2thZ2VzLCBkb24ndCB1c2UgdGhlIGRhdGUgb2YgdGhlIGxhc3QKLSAgICAgICAgICAgICAgIDs7
IGNvbW1pdCB0byB0aGUgYnJhbmNoLCBidXQgdGhhdCBvZiB0aGUgbGFzdCBjb21taXQKLSAgICAg
ICAgICAgICAgIDs7IHRvIHRoZSBtYWluIGZpbGUuCi0gICAgICAgICAgICAgICAoZWxwYWEtLWNh
bGwgdCAiZ2l0IiAibG9nIiAiLS1wcmV0dHk9Zm9ybWF0OiVjSSIgIi0tbm8tcGF0Y2giCi0gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIi0xIiAiLS0iIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5
IGZ0bikpCi0gICAgICAgICAgICAgKGVscGFhLS1jYWxsIHQgImdpdCIgInNob3ciICItLXByZXR0
eT1mb3JtYXQ6JWNJIiAiLS1uby1wYXRjaCIpKQorICAgICAgICAgICAgKGlmIChwbGlzdC1nZXQg
KGNkciBwa2ctc3BlYykgOmNvcmUpCisgICAgICAgICAgICAgICAgKGxldAorICAgICAgICAgICAg
ICAgICAgICAoKGNvcmUtZmlsZXMgKGVscGFhLS1jb3JlLWZpbGVzIHBrZy1zcGVjKSkKKyAgICAg
ICAgICAgICAgICAgICAgIChkZWZhdWx0LWRpcmVjdG9yeSAoZXhwYW5kLWZpbGUtbmFtZSAiZW1h
Y3MiKSkpCisgICAgICAgICAgICAgICAgICA7OyBGb3IgY29yZSBwYWNrYWdlcywgZG9uJ3QgdXNl
IHRoZSBkYXRlIG9mIHRoZSBsYXN0CisgICAgICAgICAgICAgICAgICA7OyBjb21taXQgdG8gdGhl
IGJyYW5jaCwgYnV0IHRoYXQgb2YgdGhlIGxhc3QgY29tbWl0CisgICAgICAgICAgICAgICAgICA7
OyB0byB0aGUgY29yZSBmaWxlcy4KKyAgICAgICAgICAgICAgICAgIChhcHBseSAjJ2VscGFhLS1j
YWxsIHQgImdpdCIgImxvZyIgIi0tcHJldHR5PWZvcm1hdDolY0kiICItLW5vLXBhdGNoIgorICAg
ICAgICAgICAgICAgICAgICAgICAgICItMSIgIi0tIiBjb3JlLWZpbGVzKSkKKyAgICAgICAgICAg
ICAgKGxldCogKChmdG4gKGZpbGUtdHJ1ZW5hbWUgICAgICA7OyBGb2xsb3cgc3ltbGlua3MhCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAoZXhwYW5kLWZpbGUtbmFtZSAoZWxwYWEtLW1haW4t
ZmlsZSBwa2ctc3BlYykgZGlyKSkpCisgICAgICAgICAgICAgICAgICAgICAoZGVmYXVsdC1kaXJl
Y3RvcnkgKGZpbGUtbmFtZS1kaXJlY3RvcnkgZnRuKSkpCisgICAgICAgICAgICAgICAgKGVscGFh
LS1jYWxsIHQgImdpdCIgInNob3ciICItLXByZXR0eT1mb3JtYXQ6JWNJIiAiLS1uby1wYXRjaCIp
KSkKICAgICAgICAgICAgIChidWZmZXItc3RyaW5nKSkpCiAgICAgICAgICAodmVyZGF0ZQogICAg
ICAgICAgIDs7IENvbnZlcnQgR2l0J3MgZGF0ZSBpbnRvIHNvbWV0aGluZyB0aGF0IGxvb2tzIGxp
a2UgYSB2ZXJzaW9uIG51bWJlci4KLS0gCjIuNDEuMAoK
--=-Tyq70y3UDtGxMBjrIX7n--
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 8 Sep 2023 19:35:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 08 15:35:39 2023
Received: from localhost ([127.0.0.1]:45657 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qehGH-0003EA-VQ
for submit <at> debbugs.gnu.org; Fri, 08 Sep 2023 15:35:39 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43013)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1qehGC-0003Dq-AC
for 63916 <at> debbugs.gnu.org; Fri, 08 Sep 2023 15:35:24 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 075A310009E;
Fri, 8 Sep 2023 15:35:12 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1694201706;
bh=lvtw9odQlwb6qQJyUztuc/ngaZxKYywlrRuG8RUJFvA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=ZxDoMqg7p+kkqc6KgtLDLIFCa92Hd8u/cf+jwk+k95JfU/GNvgFLkFtw/Jsz04BOA
FoN43FDgQYd0VnwqJTuINF5wqg33P7dr0PfQZ+dfud6lAjpSlKZU4rzb7e+K6/ahnh
hbCbz/JfclTFGlFauCP/23OqboeFY+4p79b3VmBco8q+FAOWKHI7fZNpJko+WNRdUZ
pW9S+Z2T9sIc1ohEy6m0C+4iRh+W45jl6FvNX3FojAXaCqgoecQw7a2oc+Jrg/jd2U
UqDXBWAiGOf7QqobfDypfnXkRb+9sI2Rka6XsroJRLZDGEuZNKabcNUEB1We0AJvh5
w1W7IuS8/4R6g==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 595D9100064;
Fri, 8 Sep 2023 15:35:06 -0400 (EDT)
Received: from pastel (unknown [104.247.229.91])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 35A80120370;
Fri, 8 Sep 2023 15:35:06 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Benjamin Orthen <benjamin@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
In-Reply-To: <db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN>
(Benjamin Orthen's message of "Fri, 08 Sep 2023 12:55:38 +0200")
Message-ID: <jwvil8kbhm6.fsf-monnier+emacs@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
<87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN>
<87fs6y6jkq.fsf@HIDDEN> <jwvmt16ueib.fsf-monnier+emacs@HIDDEN>
<bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN>
<db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN>
Date: Fri, 08 Sep 2023 15:35:04 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.076 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Philip Kaludercic <philipk@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
> Instead of looking only at the git log of the main package file, we
> look instead at the git log of all files of the core package.
> This way, a new devel version is created when any other package file is
> changed, not just the main file.
It has a minor downside which is that it slows down the overwhelming
cases (where there are no changes), but it's probably lost in the noise,
so it sounds like a very good idea, thank you.
> Is this the right mailing list to send the patch?
Yes.
[ BTW, Philip's `list-ensure` is called `ensure-list` :-)
And yes, I think it's OK to use functionality from Emacs-28. ]
>+ (when-let
>+ ((core (elpaa--spec-get pkg-spec :core)))
AFAICT this code is only used when `:core` is non-nil, so better either
not test for it redundantly, or do it via `cl-assert`.
>+ (unless (member item excludes)
The code looks generally good, but I'm not sure about the one line
above:
- I know it won't do the right thing for ERC's "lisp/erc/ChangeLog.*"
but it's probably harmless (those files basically never change
anyway).
- I have the impression that it won't do the right thing for
`use-package`'s "bind-key.el"
Also, I see you do (concat item file) but you only know that `item` is
a directory, not that it ends with a `/`. Better use `file-name-concat`.
Last but not least: I think this doesn't quite qualify as "trivial" so
we'd need you to sign the copyright paperwork (well, maybe with some of
the suggested simplifications, it could qualify as "trivial", but it's
easier if you sign the paperwork so we don't have to worry about it,
especially if you ever submit more code, which I hope you will).
To that end, please fill the form below and email it to the FSF as
instructed so they can send you the appropriate paperwork to sign.
Stefan
Please email the following information to assign@HIDDEN, and we
will send you the assignment form for your past and future changes.
Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
[What is the name of the program or package you're contributing to?]
Emacs
[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]
[Do you have an employer who might have a basis to claim to own
your changes? Do you attend a school which might make such a claim?]
[For the copyright registration, what country are you a citizen of?]
[What year were you born?]
[Please write your email address here.]
[Please write your postal address here.]
[Which files have you changed so far, and which new files have you written
so far?]
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.Received: (at 63916) by debbugs.gnu.org; 8 Sep 2023 17:14:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 08 13:14:24 2023 Received: from localhost ([127.0.0.1]:45461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qef3n-0005O6-O3 for submit <at> debbugs.gnu.org; Fri, 08 Sep 2023 13:14:24 -0400 Received: from mout01.posteo.de ([185.67.36.65]:41407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1qef3i-0005Nq-Rs for 63916 <at> debbugs.gnu.org; Fri, 08 Sep 2023 13:14:22 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D3157240029 for <63916 <at> debbugs.gnu.org>; Fri, 8 Sep 2023 19:14:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694193250; bh=C+WJUlZyahbV+b4tCJGHZ8tQdu91hWuRIa1NQA2vpWE=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=HhCFhw/wb84CZWDdtW3XbjlecSppKPdvf1v+n5I66ngUNBA6ewG0b+LKpwcJAppHT rtRD8b5AUYZgDKS0Lm+wg6nnsnlATh8FADl8KlEp8ugRzp+Nvc04/idjPYXDriwFpn NhXRgxvVL+SFd+RbE5/JI5bRGR8U7l+W+imfZRSTKCoZZidWmWcdXayVFIXzx0sBpd axCO0a3XoM7tS3j0D5kQB9mZJ7k4vowQSkx1hrDfQ1ydQ64ou4JzXCN2CXawP5cYgG XkBlPMhEI2OV8R/C3W6huJahHt3/TEr3QPEgPnVXhuaY12GW1lZqmAh0wUxLvQaUWm fl3hSXdgEpCYg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rj2lQ2zvdz6tsj; Fri, 8 Sep 2023 19:14:10 +0200 (CEST) From: Philip Kaludercic <philipk@HIDDEN> To: Benjamin Orthen <benjamin@HIDDEN> Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel In-Reply-To: <db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN> (Benjamin Orthen's message of "Fri, 08 Sep 2023 12:55:38 +0200") References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN> <874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN> <87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN> <87fs6y6jkq.fsf@HIDDEN> <jwvmt16ueib.fsf-monnier+emacs@HIDDEN> <bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN> <db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 08 Sep 2023 17:14:10 +0000 Message-ID: <87edj837vh.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63916 Cc: 63916 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) To: Benjamin Orthen <benjamin@HIDDEN> Cc: Stefan Monnier <monnier@HIDDEN>, 63916 <at> debbugs.gnu.org Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to e= lpa-devel From: Philip Kaludercic <philipk@HIDDEN> Gcc: nnimap+posteo.de:Sent --text follows this line-- Benjamin Orthen <benjamin@HIDDEN> writes: > Related to this, > > I have a patch for elpa-admin.el (in the elpa repository) which would > improve devel versioning for core packages: > > Instead of looking only at the git log of the main package file, we > look instead at the git log of all files of the core package. > This way, a new devel version is created when any other package file is > changed, not just the main file. This seems to make sense. > Is this the right mailing list to send the patch? If not, where could I > send it to? This is fine, the main thing is that someone has a patch that can be applied. > > Best, > Benjamin > > On Sun, 2023-06-11 at 19:32 +0200, Benjamin Orthen wrote: >> Hi, >>=20 >> I think I figured out why elpa does not build a new version of use- >> package. >>=20 >> To determine the devel version, it looks only at the git log of >> `(elpa- >> -main-file pkg-spec)`, which in this case turns out to be use- >> package.el. However, use-package.el has not been changed since >> 20230115, I suppose this is why no new version is built. >>=20 >> Best, Benjamin >>=20 >>=20 >> On Sun, 2023-06-11 at 12:55 -0400, Stefan Monnier wrote: >> > > > I agree that these kinds of problems are annoying to debug.=C2=A0 = It >> > > > would be >> > > > nice to offer a "debug mode" where the user can see what's >> > > > going >> > > > on >> > > > within the sandbox.=C2=A0 Maybe we could do that by opening an >> > > > interactive >> > > > shell with a message saying "this is the command that we want >> > > > to >> > > > run" >> > > > and then let the user run that command? >> > > Shouldn't just invoking bash do that? >> >=20 >> > Yes, it should be fairly easy to do. >> >=20 >> > > But returning to the initial issue (hoping I did not miss >> > > anything), if >> > > the issue is not what I mentioned, then why is use-package not >> > > building? >> >=20 >> > You did not miss anything: it's not building simply because the >> > process >> > run within the sandbox cannot read the target of the `use- >> > package.texi` >> > symlink because the sandbox does not expose this target. >> >=20 >> >=20 >> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan > > From d29163e00313690435b2baacc770a734598dd956 Mon Sep 17 00:00:00 2001 > From: Benjamin Orthen <git@HIDDEN> > Date: Fri, 8 Sep 2023 12:05:14 +0200 > Subject: [PATCH] Add elpa--core-files to get more exact devel-versions for > core packages > > --- > elpa-admin.el | 51 ++++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 40 insertions(+), 11 deletions(-) > > diff --git a/elpa-admin.el b/elpa-admin.el > index 2c2d2aeab7..57dfee8f18 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -908,20 +908,49 @@ of the current `process-environment'. Return the m= odified copy." > 0))) > (encode-time (list s mi h d mo y nil nil zs)))) >=20=20 > +(defun elpaa--core-files (pkg-spec) > + "Get a list of core files (and only files) for PKG-SPEC. > +Core folders are recursively searched, excluded files are ignored." > + (when-let > + ((core (elpaa--spec-get pkg-spec :core))) There is no need to fold this. > + (let* Or this. > + ((excludes (elpaa--spec-get pkg-spec :excludes)) > + (emacs-repo-root (expand-file-name "emacs")) > + (default-directory emacs-repo-root) > + (file-patterns > + (if (listp core) > + core > + (list core))) > + (core-files nil)) You can use list-ensure here. > + ;; we look at each file or files in folder and add them > + ;; to core-files if they are in the excludes > + (cl-labels ((process-item (item) > + (unless (member item excludes) > + (if (file-directory-p item) > + (dolist (file (directory-files item nil direct= ory-files-no-dot-files-regexp)) > + (process-item (concat item file))) > + (push item core-files))))) > + (dolist (item file-patterns) > + (process-item item))) Couldn't `directory-files-recursively' be useful here? > + core-files))) > + > (defun elpaa--get-devel-version (dir pkg-spec) > "Compute the date-based pseudo-version used for devel builds." > - (let* ((ftn (file-truename ;; Follow symlinks! > - (expand-file-name (elpaa--main-file pkg-spec) dir))) > - (default-directory (file-name-directory ftn)) > - (gitdate > + (let* ((gitdate > (with-temp-buffer > - (if (plist-get (cdr pkg-spec) :core) > - ;; For core packages, don't use the date of the last > - ;; commit to the branch, but that of the last commit > - ;; to the main file. > - (elpaa--call t "git" "log" "--pretty=3Dformat:%cI" "--no-= patch" > - "-1" "--" (file-name-nondirectory ftn)) > - (elpaa--call t "git" "show" "--pretty=3Dformat:%cI" "--no-p= atch")) > + (if (plist-get (cdr pkg-spec) :core) > + (let > + ((core-files (elpaa--core-files pkg-spec)) > + (default-directory (expand-file-name "emacs"))) > + ;; For core packages, don't use the date of the last > + ;; commit to the branch, but that of the last commit > + ;; to the core files. > + (apply 'elpaa--call t "git" "log" "--pretty=3Dformat:%= cI" "--no-patch" While we are at it, you might as well sharp-quote the `elpaa-call' here. > + "-1" "--" core-files)) > + (let* ((ftn (file-truename ;; Follow symlinks! > + (expand-file-name (elpaa--main-file pkg-spec)= dir))) > + (default-directory (file-name-directory ftn))) > + (elpaa--call t "git" "show" "--pretty=3Dformat:%cI" "--n= o-patch"))) > (buffer-string))) > (verdate > ;; Convert Git's date into something that looks like a version= number.
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 8 Sep 2023 10:55:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 08 06:55:46 2023
Received: from localhost ([127.0.0.1]:42292 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qeZ9O-00046i-7I
for submit <at> debbugs.gnu.org; Fri, 08 Sep 2023 06:55:46 -0400
Received: from mailproxy01.manitu.net ([217.11.48.65]:50502)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <benjamin@HIDDEN>) id 1qeZ9L-00046Z-FP
for 63916 <at> debbugs.gnu.org; Fri, 08 Sep 2023 06:55:44 -0400
Message-ID: <db97512773b995b351782a1c62eb5537fcbc9182.camel@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
From: Benjamin Orthen <benjamin@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>, Philip Kaludercic
<philipk@HIDDEN>
Date: Fri, 08 Sep 2023 12:55:38 +0200
In-Reply-To: <bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
<87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN>
<87fs6y6jkq.fsf@HIDDEN> <jwvmt16ueib.fsf-monnier+emacs@HIDDEN>
<bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN>
Content-Type: multipart/mixed; boundary="=-u9i+kT17SsRoEkMBV6cQ"
MIME-Version: 1.0
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--=-u9i+kT17SsRoEkMBV6cQ
Content-Type: multipart/alternative; boundary="=-zmT79MLTb0ALixNJKJ1c"
--=-zmT79MLTb0ALixNJKJ1c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Related to this,
I have a patch for elpa-admin.el (in the elpa repository) which would
improve devel versioning for core packages:
Instead of looking only at the git log of the main package file, we
look instead at the git log of all files of the core package.
This way, a new devel version is created when any other package file is
changed, not just the main file.
Is this the right mailing list to send the patch? If not, where could I
send it to?
Best,
Benjamin
On Sun, 2023-06-11 at 19:32 +0200, Benjamin Orthen wrote:
> Hi,
>=20
> I think I figured out why elpa does not build a new version of use-
> package.
>=20
> To determine the devel version, it looks only at the git log of
> `(elpa-
> -main-file pkg-spec)`, which in this case turns out to be use-
> package.el. However, use-package.el has not been changed since
> 20230115, I suppose this is why no new version is built.
>=20
> Best, Benjamin
>=20
>=20
> On Sun, 2023-06-11 at 12:55 -0400, Stefan Monnier wrote:
> > > > I agree that these kinds of problems are annoying to debug.=C2=A0 I=
t
> > > > would be
> > > > nice to offer a "debug mode" where the user can see what's
> > > > going
> > > > on
> > > > within the sandbox.=C2=A0 Maybe we could do that by opening an
> > > > interactive
> > > > shell with a message saying "this is the command that we want
> > > > to
> > > > run"
> > > > and then let the user run that command?
> > > Shouldn't just invoking bash do that?
> >=20
> > Yes, it should be fairly easy to do.
> >=20
> > > But returning to the initial issue (hoping I did not miss
> > > anything), if
> > > the issue is not what I mentioned, then why is use-package not
> > > building?
> >=20
> > You did not miss anything: it's not building simply because the
> > process
> > run within the sandbox cannot read the target of the `use-
> > package.texi`
> > symlink because the sandbox does not expose this target.
> >=20
> >=20
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan
> >=20
>=20
--=-zmT79MLTb0ALixNJKJ1c
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
<html><head><style>pre,code,address {
margin: 0px;
}
h1,h2,h3,h4,h5,h6 {
margin-top: 0.2em;
margin-bottom: 0.2em;
}
ol,ul {
margin-top: 0em;
margin-bottom: 0em;
}
blockquote {
margin-top: 0em;
margin-bottom: 0em;
}
</style></head><body><div>Related to this,</div><div><br></div><div>I have =
a patch for elpa-admin.el (in the elpa repository) which would improve deve=
l versioning for core packages:</div><div><br></div><div>Instead of looking=
only at the git log of the main package file, we look instead at the git l=
og of all files of the core package.</div><div>This way, a new devel versio=
n is created when any other package file is changed, not just the main file=
.</div><div><br></div><div>Is this the right mailing list to send the patch=
? If not, where could I send it to?</div><div><br></div><div><br></div><div=
>Best,</div><div>Benjamin</div><div><br></div><div>On Sun, 2023-06-11 at 19=
:32 +0200, Benjamin Orthen wrote:</div><blockquote type=3D"cite" style=3D"m=
argin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Hi,<=
br></div><div><br></div><div>I think I figured out why elpa does not build =
a new version of use-<br></div><div>package.<br></div><div><br></div><div>T=
o determine the devel version, it looks only at the git log of `(elpa-<br><=
/div><div>-main-file pkg-spec)`, which in this case turns out to be use-<br=
></div><div>package.el. However, use-package.el has not been changed since<=
br></div><div>20230115, I suppose this is why no new version is built.<br><=
/div><div><br></div><div>Best, Benjamin<br></div><div><br></div><div><br></=
div><div>On Sun, 2023-06-11 at 12:55 -0400, Stefan Monnier wrote:<br></div>=
<blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729f=
cf solid;padding-left:1ex"><blockquote type=3D"cite" style=3D"margin:0 0 0 =
.8ex; border-left:2px #729fcf solid;padding-left:1ex"><blockquote type=3D"c=
ite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left=
:1ex"><div>I agree that these kinds of problems are annoying to debug. =
; It<br></div><div>would be<br></div><div>nice to offer a "debug mode" wher=
e the user can see what's going<br></div><div>on<br></div><div>within the s=
andbox. Maybe we could do that by opening an<br></div><div>interactiv=
e<br></div><div>shell with a message saying "this is the command that we wa=
nt to<br></div><div>run"<br></div><div>and then let the user run that comma=
nd?<br></div></blockquote><div>Shouldn't just invoking bash do that?<br></d=
iv></blockquote><div><br></div><div>Yes, it should be fairly easy to do.<br=
></div><div><br></div><blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex;=
border-left:2px #729fcf solid;padding-left:1ex"><div>But returning to the =
initial issue (hoping I did not miss<br></div><div>anything), if<br></div><=
div>the issue is not what I mentioned, then why is use-package not<br></div=
><div>building?<br></div></blockquote><div><br></div><div>You did not miss =
anything: it's not building simply because the<br></div><div>process<br></d=
iv><div>run within the sandbox cannot read the target of the `use-<br></div=
><div>package.texi`<br></div><div>symlink because the sandbox does not expo=
se this target.<br></div><div><br></div><div><br></div><div> &nb=
sp; Stefan<br></div><div><br></div></blockquote><di=
v><br></div></blockquote><div><br></div><div><span></span></div></body></ht=
ml>
--=-zmT79MLTb0ALixNJKJ1c--
--=-u9i+kT17SsRoEkMBV6cQ
Content-Disposition: attachment;
filename*0=0001-Add-elpa-core-files-to-get-more-exact-devel-versions.pat;
filename*1=ch
Content-Type: text/x-patch;
name="0001-Add-elpa-core-files-to-get-more-exact-devel-versions.patch";
charset="UTF-8"
Content-Transfer-Encoding: base64
RnJvbSBkMjkxNjNlMDAzMTM2OTA0MzViMmJhYWNjNzcwYTczNDU5OGRkOTU2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBPcnRoZW4gPGdpdEBvcnRoZW4ubmV0PgpEYXRl
OiBGcmksIDggU2VwIDIwMjMgMTI6MDU6MTQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBBZGQgZWxw
YS0tY29yZS1maWxlcyB0byBnZXQgbW9yZSBleGFjdCBkZXZlbC12ZXJzaW9ucyBmb3IKIGNvcmUg
cGFja2FnZXMKCi0tLQogZWxwYS1hZG1pbi5lbCB8IDUxICsrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlv
bnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2VscGEtYWRtaW4uZWwgYi9lbHBh
LWFkbWluLmVsCmluZGV4IDJjMmQyYWVhYjcuLjU3ZGZlZThmMTggMTAwNjQ0Ci0tLSBhL2VscGEt
YWRtaW4uZWwKKysrIGIvZWxwYS1hZG1pbi5lbApAQCAtOTA4LDIwICs5MDgsNDkgQEAgb2YgdGhl
IGN1cnJlbnQgYHByb2Nlc3MtZW52aXJvbm1lbnQnLiAgUmV0dXJuIHRoZSBtb2RpZmllZCBjb3B5
LiIKICAgICAgICAgICAgICAgIDApKSkKICAgICAoZW5jb2RlLXRpbWUgKGxpc3QgcyBtaSBoIGQg
bW8geSBuaWwgbmlsIHpzKSkpKQogCisoZGVmdW4gZWxwYWEtLWNvcmUtZmlsZXMgKHBrZy1zcGVj
KQorICAiR2V0IGEgbGlzdCBvZiBjb3JlIGZpbGVzIChhbmQgb25seSBmaWxlcykgZm9yIFBLRy1T
UEVDLgorQ29yZSBmb2xkZXJzIGFyZSByZWN1cnNpdmVseSBzZWFyY2hlZCwgZXhjbHVkZWQgZmls
ZXMgYXJlIGlnbm9yZWQuIgorICAod2hlbi1sZXQKKyAgICAgICgoY29yZSAoZWxwYWEtLXNwZWMt
Z2V0IHBrZy1zcGVjIDpjb3JlKSkpCisgICAgKGxldCoKKyAgICAgICAgKChleGNsdWRlcyAoZWxw
YWEtLXNwZWMtZ2V0IHBrZy1zcGVjIDpleGNsdWRlcykpCisgICAgICAgICAoZW1hY3MtcmVwby1y
b290IChleHBhbmQtZmlsZS1uYW1lICJlbWFjcyIpKQorICAgICAgICAgKGRlZmF1bHQtZGlyZWN0
b3J5IGVtYWNzLXJlcG8tcm9vdCkKKyAgICAgICAgIChmaWxlLXBhdHRlcm5zCisgICAgICAgICAg
KGlmIChsaXN0cCBjb3JlKQorICAgICAgICAgICAgICBjb3JlCisgICAgICAgICAgICAobGlzdCBj
b3JlKSkpCisgICAgICAgICAoY29yZS1maWxlcyBuaWwpKQorICAgICAgOzsgd2UgbG9vayBhdCBl
YWNoIGZpbGUgb3IgZmlsZXMgaW4gZm9sZGVyIGFuZCBhZGQgdGhlbQorICAgICAgOzsgdG8gY29y
ZS1maWxlcyBpZiB0aGV5IGFyZSBpbiB0aGUgZXhjbHVkZXMKKyAgICAgIChjbC1sYWJlbHMgKChw
cm9jZXNzLWl0ZW0gKGl0ZW0pCisgICAgICAgICAgICAgICAgICAgICh1bmxlc3MgKG1lbWJlciBp
dGVtIGV4Y2x1ZGVzKQorICAgICAgICAgICAgICAgICAgICAgIChpZiAoZmlsZS1kaXJlY3Rvcnkt
cCBpdGVtKQorICAgICAgICAgICAgICAgICAgICAgICAgICAoZG9saXN0IChmaWxlIChkaXJlY3Rv
cnktZmlsZXMgaXRlbSBuaWwgZGlyZWN0b3J5LWZpbGVzLW5vLWRvdC1maWxlcy1yZWdleHApKQor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChwcm9jZXNzLWl0ZW0gKGNvbmNhdCBpdGVtIGZp
bGUpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChwdXNoIGl0ZW0gY29yZS1maWxlcykpKSkp
CisgICAgICAgIChkb2xpc3QgKGl0ZW0gZmlsZS1wYXR0ZXJucykKKyAgICAgICAgICAocHJvY2Vz
cy1pdGVtIGl0ZW0pKSkKKyAgICAgIGNvcmUtZmlsZXMpKSkKKwogKGRlZnVuIGVscGFhLS1nZXQt
ZGV2ZWwtdmVyc2lvbiAoZGlyIHBrZy1zcGVjKQogICAiQ29tcHV0ZSB0aGUgZGF0ZS1iYXNlZCBw
c2V1ZG8tdmVyc2lvbiB1c2VkIGZvciBkZXZlbCBidWlsZHMuIgotICAobGV0KiAoKGZ0biAoZmls
ZS10cnVlbmFtZSAgICAgIDs7IEZvbGxvdyBzeW1saW5rcyEKLSAgICAgICAgICAgICAgKGV4cGFu
ZC1maWxlLW5hbWUgKGVscGFhLS1tYWluLWZpbGUgcGtnLXNwZWMpIGRpcikpKQotICAgICAgICAg
KGRlZmF1bHQtZGlyZWN0b3J5IChmaWxlLW5hbWUtZGlyZWN0b3J5IGZ0bikpCi0gICAgICAgICAo
Z2l0ZGF0ZQorICAobGV0KiAoKGdpdGRhdGUKICAgICAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgot
ICAgICAgICAgICAoaWYgKHBsaXN0LWdldCAoY2RyIHBrZy1zcGVjKSA6Y29yZSkKLSAgICAgICAg
ICAgICAgIDs7IEZvciBjb3JlIHBhY2thZ2VzLCBkb24ndCB1c2UgdGhlIGRhdGUgb2YgdGhlIGxh
c3QKLSAgICAgICAgICAgICAgIDs7IGNvbW1pdCB0byB0aGUgYnJhbmNoLCBidXQgdGhhdCBvZiB0
aGUgbGFzdCBjb21taXQKLSAgICAgICAgICAgICAgIDs7IHRvIHRoZSBtYWluIGZpbGUuCi0gICAg
ICAgICAgICAgICAoZWxwYWEtLWNhbGwgdCAiZ2l0IiAibG9nIiAiLS1wcmV0dHk9Zm9ybWF0OiVj
SSIgIi0tbm8tcGF0Y2giCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIi0xIiAiLS0iIChm
aWxlLW5hbWUtbm9uZGlyZWN0b3J5IGZ0bikpCi0gICAgICAgICAgICAgKGVscGFhLS1jYWxsIHQg
ImdpdCIgInNob3ciICItLXByZXR0eT1mb3JtYXQ6JWNJIiAiLS1uby1wYXRjaCIpKQorICAgICAg
ICAgICAgKGlmIChwbGlzdC1nZXQgKGNkciBwa2ctc3BlYykgOmNvcmUpCisgICAgICAgICAgICAg
ICAgKGxldAorICAgICAgICAgICAgICAgICAgICAoKGNvcmUtZmlsZXMgKGVscGFhLS1jb3JlLWZp
bGVzIHBrZy1zcGVjKSkKKyAgICAgICAgICAgICAgICAgICAgIChkZWZhdWx0LWRpcmVjdG9yeSAo
ZXhwYW5kLWZpbGUtbmFtZSAiZW1hY3MiKSkpCisgICAgICAgICAgICAgICAgICA7OyBGb3IgY29y
ZSBwYWNrYWdlcywgZG9uJ3QgdXNlIHRoZSBkYXRlIG9mIHRoZSBsYXN0CisgICAgICAgICAgICAg
ICAgICA7OyBjb21taXQgdG8gdGhlIGJyYW5jaCwgYnV0IHRoYXQgb2YgdGhlIGxhc3QgY29tbWl0
CisgICAgICAgICAgICAgICAgICA7OyB0byB0aGUgY29yZSBmaWxlcy4KKyAgICAgICAgICAgICAg
ICAgIChhcHBseSAnZWxwYWEtLWNhbGwgdCAiZ2l0IiAibG9nIiAiLS1wcmV0dHk9Zm9ybWF0OiVj
SSIgIi0tbm8tcGF0Y2giCisgICAgICAgICAgICAgICAgICAgICAgICAgIi0xIiAiLS0iIGNvcmUt
ZmlsZXMpKQorICAgICAgICAgICAgICAobGV0KiAoKGZ0biAoZmlsZS10cnVlbmFtZSAgICAgIDs7
IEZvbGxvdyBzeW1saW5rcyEKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChleHBhbmQtZmls
ZS1uYW1lIChlbHBhYS0tbWFpbi1maWxlIHBrZy1zcGVjKSBkaXIpKSkKKyAgICAgICAgICAgICAg
ICAgICAgIChkZWZhdWx0LWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVjdG9yeSBmdG4pKSkKKyAg
ICAgICAgICAgICAgICAoZWxwYWEtLWNhbGwgdCAiZ2l0IiAic2hvdyIgIi0tcHJldHR5PWZvcm1h
dDolY0kiICItLW5vLXBhdGNoIikpKQogICAgICAgICAgICAgKGJ1ZmZlci1zdHJpbmcpKSkKICAg
ICAgICAgICh2ZXJkYXRlCiAgICAgICAgICAgOzsgQ29udmVydCBHaXQncyBkYXRlIGludG8gc29t
ZXRoaW5nIHRoYXQgbG9va3MgbGlrZSBhIHZlcnNpb24gbnVtYmVyLgotLSAKMi40MS4wCgo=
--=-u9i+kT17SsRoEkMBV6cQ--
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.Received: (at 63916) by debbugs.gnu.org; 11 Jun 2023 17:32:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 11 13:32:14 2023 Received: from localhost ([127.0.0.1]:37704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q8OvG-0001ak-0y for submit <at> debbugs.gnu.org; Sun, 11 Jun 2023 13:32:14 -0400 Received: from mailproxy07.manitu.net ([217.11.48.71]:37874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <benjamin@HIDDEN>) id 1q8OvD-0001aZ-E0 for 63916 <at> debbugs.gnu.org; Sun, 11 Jun 2023 13:32:12 -0400 Received: from [192.168.178.23] (dslb-092-073-125-242.092.073.pools.vodafone-ip.de [92.73.125.242]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin@HIDDEN) by mailproxy07.manitu.net (Postfix) with ESMTPSA id 438E2C81C8; Sun, 11 Jun 2023 19:32:10 +0200 (CEST) Message-ID: <bd9414ec73ab925cd081e4ed333ebd95310aabd7.camel@HIDDEN> Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel From: Benjamin Orthen <benjamin@HIDDEN> To: Stefan Monnier <monnier@HIDDEN>, Philip Kaludercic <philipk@HIDDEN> Date: Sun, 11 Jun 2023 19:32:09 +0200 In-Reply-To: <jwvmt16ueib.fsf-monnier+emacs@HIDDEN> References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN> <874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN> <87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN> <87fs6y6jkq.fsf@HIDDEN> <jwvmt16ueib.fsf-monnier+emacs@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63916 Cc: 63916 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, I think I figured out why elpa does not build a new version of use- package. To determine the devel version, it looks only at the git log of `(elpa- -main-file pkg-spec)`, which in this case turns out to be use- package.el. However, use-package.el has not been changed since 20230115, I suppose this is why no new version is built. Best, Benjamin On Sun, 2023-06-11 at 12:55 -0400, Stefan Monnier wrote: > > > I agree that these kinds of problems are annoying to debug.=C2=A0 It > > > would be > > > nice to offer a "debug mode" where the user can see what's going > > > on > > > within the sandbox.=C2=A0 Maybe we could do that by opening an > > > interactive > > > shell with a message saying "this is the command that we want to > > > run" > > > and then let the user run that command? > > Shouldn't just invoking bash do that? >=20 > Yes, it should be fairly easy to do. >=20 > > But returning to the initial issue (hoping I did not miss > > anything), if > > the issue is not what I mentioned, then why is use-package not > > building? >=20 > You did not miss anything: it's not building simply because the > process > run within the sandbox cannot read the target of the `use- > package.texi` > symlink because the sandbox does not expose this target. >=20 >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan >=20
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 11 Jun 2023 16:55:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 11 12:55:51 2023
Received: from localhost ([127.0.0.1]:37697 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q8OM2-0000eH-Rk
for submit <at> debbugs.gnu.org; Sun, 11 Jun 2023 12:55:51 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7699)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1q8OM0-0000e4-KU
for 63916 <at> debbugs.gnu.org; Sun, 11 Jun 2023 12:55:49 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ED9901000C3;
Sun, 11 Jun 2023 12:55:42 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F147F100006;
Sun, 11 Jun 2023 12:55:41 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1686502542;
bh=AZeSlr8Ox29xWgCVogyKf+pYhm8UBlrRlH7V/UgaDrE=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=brGwPvwpbpXyA5uES0F/Ks/hrQpctpDZhBn+SXjyfTKEjvaU2/6SE6hQppMegmA2P
6g01MThGwC2GRFn7ESuN/YUJDk6kfdyy9FtEFaFGr3DhyKVlfEdKsCf/rlNTfACjZT
FqfTEwtgy9RceymgcrlTIbSC7+4c5DgfA+ZT+LZIpVnrLqVEV1gZc3x1iPZG63zi38
kACpePddgDyanic1J3VIXGWqIdBPL4ilV+mD5b+1VqrtlvdKKWwp2hYpm+MK6SxSqG
czialRJ459/P8IDnhBYFkQc53rddtsObt5u3bNnjwYJHk+NPX3frG1GjCzN25oUZP+
eCIHaICnsRP9A==
Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6E8411205D9;
Sun, 11 Jun 2023 12:55:41 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
In-Reply-To: <87fs6y6jkq.fsf@HIDDEN> (Philip Kaludercic's message of "Sun,
11 Jun 2023 16:37:57 +0000")
Message-ID: <jwvmt16ueib.fsf-monnier+emacs@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
<87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN>
<87fs6y6jkq.fsf@HIDDEN>
Date: Sun, 11 Jun 2023 12:55:39 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.084 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Benjamin Orthen <benjamin@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> I agree that these kinds of problems are annoying to debug. It would be
>> nice to offer a "debug mode" where the user can see what's going on
>> within the sandbox. Maybe we could do that by opening an interactive
>> shell with a message saying "this is the command that we want to run"
>> and then let the user run that command?
> Shouldn't just invoking bash do that?
Yes, it should be fairly easy to do.
> But returning to the initial issue (hoping I did not miss anything), if
> the issue is not what I mentioned, then why is use-package not building?
You did not miss anything: it's not building simply because the process
run within the sandbox cannot read the target of the `use-package.texi`
symlink because the sandbox does not expose this target.
Stefan
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.Received: (at 63916) by debbugs.gnu.org; 11 Jun 2023 16:38:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 11 12:38:08 2023 Received: from localhost ([127.0.0.1]:37677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q8O4t-0000CP-TR for submit <at> debbugs.gnu.org; Sun, 11 Jun 2023 12:38:08 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1q8O4r-0000Bt-0R for 63916 <at> debbugs.gnu.org; Sun, 11 Jun 2023 12:38:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F2E5E240104 for <63916 <at> debbugs.gnu.org>; Sun, 11 Jun 2023 18:37:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686501479; bh=McmIAEJ0uXBVOm+Om6hdPL9s7xZPKuxW8oMuJ/7j5Bw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Rr+MKH77nE0fUZUYvDX8gibizZrh7WCfOfUDIovAVFz1g3wvQvhyVzrzOFLVxCfXR Wfy1DT+4NGVRce7chwnXRKUv8VVIveFCa5g2WBcXQyk2RGR4D434zIg6JK43zE5i4m x5bkKatdAUGTB0VF5JpuhlJUJOULsMeprkQ/cST0DCgkrA8AcotF87QHsvFb78YuGJ NDPY4y0iGe0IsB73xzUPWc2xFdhjuVVOc3oQz06nEKoDGrG12nMLcl4+qcPG6gpU2r J1UQ80qaxP1dMXCk/TGd6ixqBTS1QXArjST7u/VGTEsbgEQX/h4O7rfXzCLpzHZMis NCuh4TH4yCtvw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QfL8k2YByz6tvb; Sun, 11 Jun 2023 18:37:58 +0200 (CEST) From: Philip Kaludercic <philipk@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel In-Reply-To: <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Sun, 11 Jun 2023 11:55:59 -0400") References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN> <874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN> <87wn0a2sp8.fsf@HIDDEN> <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 11 Jun 2023 16:37:57 +0000 Message-ID: <87fs6y6jkq.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63916 Cc: Benjamin Orthen <benjamin@HIDDEN>, 63916 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Stefan Monnier <monnier@HIDDEN> writes: >>> The above patch feels a bit hackish because it depends on the >>> directory that happens to be current when the file is loaded. >> I agree, that could be made more robust but isn't elpa-admin.el always >> invoked via make? > > In 99% of the cases, yes, but users are free to be more creative. > >> Of course, that was my first idea but I wanted to find a solution that >> wouldn't require every user to manually configure this, since the error >> message does not make it obvious what went wrong. > > I agree that these kinds of problems are annoying to debug. It would be > nice to offer a "debug mode" where the user can see what's going on > within the sandbox. Maybe we could do that by opening an interactive > shell with a message saying "this is the command that we want to run" > and then let the user run that command? Shouldn't just invoking bash do that? But returning to the initial issue (hoping I did not miss anything), if the issue is not what I mentioned, then why is use-package not building? -- Philip Kaludercic
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 11 Jun 2023 15:56:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 11 11:56:09 2023
Received: from localhost ([127.0.0.1]:37635 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q8NQH-0007YN-4a
for submit <at> debbugs.gnu.org; Sun, 11 Jun 2023 11:56:09 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20834)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1q8NQF-0007YA-Da
for 63916 <at> debbugs.gnu.org; Sun, 11 Jun 2023 11:56:07 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1CB84441071;
Sun, 11 Jun 2023 11:56:02 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CE9C8440FA7;
Sun, 11 Jun 2023 11:56:00 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1686498960;
bh=VfB7BNPCMXwx7oGxn5CGjREhDYmCFIFOutN3aHXLPWg=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=D2qwK4urf4NEo+bJpt2GdBEnxy8s19EBMI5ks8G9Qj1OZlmsCmTD5m+thF80EwS7B
4TqWVswAGz/JndJW8KTK20F54O8jctF+xVMUcQleEYXffPNws0sp312ib9B1NOrqtn
f5AQaNIOaof6tdCMsiy4Wxjv47rehhuVabUP5cHUv64QRD/iZGI7dwned48yLf8zyX
Dufh0l9O3RTrIoHmMF2GxWGWDGCAAfmH4b52aFNOm5Ss3naylz/O+JT22Wgk4l1Njw
RTjAOPgrDwXM1vIrqGk8BYtiHXoiXeucOAZRLunD9hE+U6yLzTGs4Nrl2HGSH25q3s
Pxm43Rsc+Cgng==
Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A7B5A12080A;
Sun, 11 Jun 2023 11:56:00 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
In-Reply-To: <87wn0a2sp8.fsf@HIDDEN> (Philip Kaludercic's message of "Sun,
11 Jun 2023 10:34:27 +0000")
Message-ID: <jwvlegqvvxe.fsf-monnier+emacs@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
<87wn0a2sp8.fsf@HIDDEN>
Date: Sun, 11 Jun 2023 11:55:59 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.112 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Benjamin Orthen <benjamin@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> The above patch feels a bit hackish because it depends on the
>> directory that happens to be current when the file is loaded.
> I agree, that could be made more robust but isn't elpa-admin.el always
> invoked via make?
In 99% of the cases, yes, but users are free to be more creative.
> Of course, that was my first idea but I wanted to find a solution that
> wouldn't require every user to manually configure this, since the error
> message does not make it obvious what went wrong.
I agree that these kinds of problems are annoying to debug. It would be
nice to offer a "debug mode" where the user can see what's going on
within the sandbox. Maybe we could do that by opening an interactive
shell with a message saying "this is the command that we want to run"
and then let the user run that command?
Stefan
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 11 Jun 2023 10:34:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 11 06:34:42 2023
Received: from localhost ([127.0.0.1]:36763 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q8IP9-0004Ni-Dp
for submit <at> debbugs.gnu.org; Sun, 11 Jun 2023 06:34:42 -0400
Received: from mout01.posteo.de ([185.67.36.65]:59931)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1q8IP4-0004NN-Db
for 63916 <at> debbugs.gnu.org; Sun, 11 Jun 2023 06:34:38 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout01.posteo.de (Postfix) with ESMTPS id 2F3AB240027
for <63916 <at> debbugs.gnu.org>; Sun, 11 Jun 2023 12:34:28 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1686479668; bh=Oz4lkAwp/It+vgZRTM41rzytNEpf+wdQ07czwKtxCLk=;
h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From;
b=Qiv51Y3hdXMp2T+J9rew902rCR7qUnXz+MSj81hgZR+IRRobD38j5uoPsfaYh2zDY
IpXOJKbxcdImhilui28RJU2bIWPNpZDGulPbF2pg7BUZxd7wDUiq+vjPG0t5NJOSbd
uKGx7m8xzXS+W0/F3dMBkaPsN+4NzlTy6zuOm9F5dkA30JZ3y0s2Q6ffs+rTijtAwY
Zpqh4IloCX+uD+F9EO1ysFSF8Xy5Pl65LMX75J+Mw1s6RJXNgu8YfIfrsrsksoOopS
mk3+poqsZW34GuEW7rfFjLGAcfrKUF26DnbjeTQVk1zKpv7PmvuFk5BcyCk8aHtS0D
Pes9wQ3Y8O8+g==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4QfB5H3cHMz6tvq;
Sun, 11 Jun 2023 12:34:27 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Stefan Monnier <monnier@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
In-Reply-To: <jwv1qijz55o.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
of "Sat, 10 Jun 2023 12:01:04 -0400")
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN> <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
z4oM
Date: Sun, 11 Jun 2023 10:34:27 +0000
Message-ID: <87wn0a2sp8.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Benjamin Orthen <benjamin@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Stefan Monnier <monnier@HIDDEN> writes:
>> But if I disable sandboxing, then it works. The issue appears to be
>> that the files under package/use-package are linked in using symlinks,
>> but the directory (the emacs checkout) that is being linked to is not
>> exposed via bwarp. If I add that to the ro-binds, then I can build the
>> package. This diff might be enough to resolve the issue:
>>
>> diff --git a/elpa-admin.el b/elpa-admin.el
>> index 24dd16d3cb..81467aa628 100644
>> --- a/elpa-admin.el
>> +++ b/elpa-admin.el
>> @@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil."
>> "--tmpfs" "/tmp"))
>>
>> (defvar elpaa--sandbox-ro-binds
>> - '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"))
>> + `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"
>> + ,(file-truename (expand-file-name "emacs"))))
> [...]
>> CC: Stefan, does this look OK to you?
>
> Building of :core packages outside of `elpa.gnu.org` is indeed tested on
> very lightly. In `elpa.gnu.org`, the `emacs` subdirectory is not
> a symlink so we avoid that problem.
OK, I forgot that I added the symlink.
> The above patch feels a bit hackish because it depends on the
> directory that happens to be current when the file is loaded.
I agree, that could be made more robust but isn't elpa-admin.el always
invoked via make?
> BTW, you should be able to make the current code work without changing
> it, by adding
>
> (sandbox-extra-ro-dirs "/where/ever/your/emacs/source/dir/is")
>
> to the `elpa-config` file.
Of course, that was my first idea but I wanted to find a solution that
wouldn't require every user to manually configure this, since the error
message does not make it obvious what went wrong.
>
> Stefan
>
--
Philip Kaludercic
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 10 Jun 2023 16:01:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 10 12:01:18 2023
Received: from localhost ([127.0.0.1]:36138 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q811i-00009r-I9
for submit <at> debbugs.gnu.org; Sat, 10 Jun 2023 12:01:18 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38615)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1q811f-00009Y-Qv
for 63916 <at> debbugs.gnu.org; Sat, 10 Jun 2023 12:01:16 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4A8671000BA;
Sat, 10 Jun 2023 12:01:10 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1D91410000A;
Sat, 10 Jun 2023 12:01:05 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1686412865;
bh=h00uHh1Ro+typbdYY1H0SjsQsuGNlJ3JEM34qmt7KLY=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=DiLsUV6Q8eif5w4YLEHEIyPbQMveZwAMXWao46zAnyzPDARm7d8WxKUW4KY9/Xosj
vQy4F99svDl0ph8Tmp9iLzkwssZc/qrxl5lgM4KNN05jQu65ZiRAdfqv5ZtSdIXxHo
ri9cO9P0F9s5UvUxADhebHUc5FD9Y31NaEVkiyyzId89R7mQyL9fkBGcx5chLrcTN6
P/O2ILU/vT/z7l2LUveXFXLUd8DpprpoANKIRjQ4r2y9T1TihjRumEnwf7l2uY36ab
WgnkgB0Z2WuFjjrUGTIs8uduqZDDSRiPR2hFKqaNgSE2GAc23Py+urI6vvuO19Qs5k
qQEFSvB9uhybw==
Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7C7612086B;
Sat, 10 Jun 2023 12:01:04 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
In-Reply-To: <874jnf3d0c.fsf@HIDDEN> (Philip Kaludercic's message of "Sat,
10 Jun 2023 09:03:31 +0000")
Message-ID: <jwv1qijz55o.fsf-monnier+emacs@HIDDEN>
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
<874jnf3d0c.fsf@HIDDEN>
Date: Sat, 10 Jun 2023 12:01:04 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.098 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: Benjamin Orthen <benjamin@HIDDEN>, 63916 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> But if I disable sandboxing, then it works. The issue appears to be
> that the files under package/use-package are linked in using symlinks,
> but the directory (the emacs checkout) that is being linked to is not
> exposed via bwarp. If I add that to the ro-binds, then I can build the
> package. This diff might be enough to resolve the issue:
>
> diff --git a/elpa-admin.el b/elpa-admin.el
> index 24dd16d3cb..81467aa628 100644
> --- a/elpa-admin.el
> +++ b/elpa-admin.el
> @@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil."
> "--tmpfs" "/tmp"))
>
> (defvar elpaa--sandbox-ro-binds
> - '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"))
> + `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"
> + ,(file-truename (expand-file-name "emacs"))))
[...]
> CC: Stefan, does this look OK to you?
Building of :core packages outside of `elpa.gnu.org` is indeed tested on
very lightly. In `elpa.gnu.org`, the `emacs` subdirectory is not
a symlink so we avoid that problem.
The above patch feels a bit hackish because it depends on the
directory that happens to be current when the file is loaded.
BTW, you should be able to make the current code work without changing
it, by adding
(sandbox-extra-ro-dirs "/where/ever/your/emacs/source/dir/is")
to the `elpa-config` file.
Stefan
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
Received: (at 63916) by debbugs.gnu.org; 10 Jun 2023 09:03:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 10 05:03:43 2023
Received: from localhost ([127.0.0.1]:33277 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q7uVa-0002eY-Rv
for submit <at> debbugs.gnu.org; Sat, 10 Jun 2023 05:03:43 -0400
Received: from mout02.posteo.de ([185.67.36.66]:47663)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1q7uVX-0002eJ-Dp
for 63916 <at> debbugs.gnu.org; Sat, 10 Jun 2023 05:03:41 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id 19AE4240103
for <63916 <at> debbugs.gnu.org>; Sat, 10 Jun 2023 11:03:33 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1686387813; bh=FPdj5rPXL+5pmg3QRKZnY6D27Codwi/AEloSbtH/e2Q=;
h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From;
b=KILQ/UF+x2ust9WzARi/Qjro04SYZ3p5hO9bKcQrWjYCC1CkK8qWax6nk8uWNZbm5
toDq9TQOby6d76Hse2PhV0lgQjdrtMuxE0ZeLDoJyEgXEUSZQpWscAL8hNZGgdvdIo
MrbJRfBGJIM7DMI1a0ob3tTKDnH15QLHL1MyB02b+T+uJLr+t3KS4AxSiMn0R4N+1d
lDS4zJLq8CwOCzJBFPohCuoVN7DfjgL6g4YfXR7XtuG/mKlf6J7SIE83HcRKMomp/A
co4OCES8iNfPQSpgcSBsio5Hy6I5X595PQkrGadG3MM4GLqxP6ejjyNJyq/o45IYR9
BxYnXtCd4q39Q==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4QdX6r35kyz9rxD;
Sat, 10 Jun 2023 11:03:32 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Benjamin Orthen <benjamin@HIDDEN>
Subject: Re: bug#63916: 30.0.50; use-package: changes do not propagate to
elpa-devel
In-Reply-To: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN> (Benjamin Orthen's
message of "Mon, 05 Jun 2023 23:21:54 +0200")
References: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
z4oM
Date: Sat, 10 Jun 2023 09:03:31 +0000
Message-ID: <874jnf3d0c.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 63916
Cc: 63916 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--=-=-=
Content-Type: text/plain
Benjamin Orthen <benjamin@HIDDEN> writes:
> Recent changes in use-package (i.e., commit
> 2ce279680bf9c1964e98e2aa48a03d6675c386fe) have not propagated to
> emacs-devel (https://elpa.gnu.org/devel/use-package.html) even though
> use-package is designated as a :core package in elpa.
>
> My understanding is that changes in emacs for :core packages are
> automatically propagated to elpa(-devel). I was however not able to
> find documentation on how this propagation/sync works. I noticed that
> use-package.el does not have the disclaimer ";; This is a GNU ELPA
> :core package. Avoid adding functionality [...]" in its header. I
> suppose this is unrelated to the elpa-devel sync, but could be fixed
> as well.
Unless I broke something on my local end, there seems to be a general
problem with the ELPA build system. When trying to build use-package, I
get these error messages:
--8<---------------cut here---------------start------------->8---
$ make build/use-package
emacs --batch -Q -l admin/elpa-admin.el \
-f elpaa-batch-pkg-spec-make-dependencies .pkg-descs.mk
emacs --batch -l /home/philip/Source/elpa/admin/elpa-admin.el \
-f elpaa-batch-make-one-package use-package
Linking files for package: use-package
lisp/use-package/use-package.el -> use-package.el
lisp/use-package/use-package-lint.el -> use-package-lint.el
lisp/use-package/use-package-jump.el -> use-package-jump.el
lisp/use-package/use-package-ensure.el -> use-package-ensure.el
lisp/use-package/use-package-ensure-system-package.el -> use-package-ensure-system-package.el
lisp/use-package/use-package-diminish.el -> use-package-diminish.el
lisp/use-package/use-package-delight.el -> use-package-delight.el
lisp/use-package/use-package-core.el -> use-package-core.el
lisp/use-package/use-package-bind-key.el -> use-package-bind-key.el
lisp/use-package/bind-key.el -> bind-key.el
doc/emacs/doclicense.texi -> doclicense.texi
doc/emacs/docstyle.texi -> docstyle.texi
doc/misc/use-package.texi -> use-package.texi
======== Building tarball archive-devel/use-package-2.4.5.0.20230115.133305.tar...
Build error for archive-devel/use-package-2.4.5.0.20230115.133305.tar: (error "Error-indicating exit code in elpaa--call-sandboxed:
could not open use-package.texi: No such file or directory
")
######## Build of package archive-devel/use-package-2.4.5.0.20230115.133305.tar FAILED!!
======== Building tarball archive/use-package-2.4.5.tar...
Build error for archive/use-package-2.4.5.tar: (error "Error-indicating exit code in elpaa--call-sandboxed:
could not open use-package.texi: No such file or directory
")
######## Build of package archive/use-package-2.4.5.tar FAILED!!
--8<---------------cut here---------------end--------------->8---
But if I disable sandboxing, then it works. The issue appears to be
that the files under package/use-package are linked in using symlinks,
but the directory (the emacs checkout) that is being linked to is not
exposed via bwarp. If I add that to the ro-binds, then I can build the
package. This diff might be enough to resolve the issue:
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
diff --git a/elpa-admin.el b/elpa-admin.el
index 24dd16d3cb..81467aa628 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil."
"--tmpfs" "/tmp"))
=20
(defvar elpaa--sandbox-ro-binds
- '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"))
+ `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu"
+ ,(file-truename (expand-file-name "emacs"))))
=20
(defun elpaa--call-sandboxed (destination &rest args)
"Like =E2=80=98elpaa--call=E2=80=99 but sandboxed.
--=-=-=
Content-Type: text/plain
CC: Stefan, does this look OK to you?
>
> Best regards,
> Benjamin
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 5 Jun 2023 21:22:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 05 17:22:16 2023 Received: from localhost ([127.0.0.1]:50434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1q6HeZ-0003dc-Cp for submit <at> debbugs.gnu.org; Mon, 05 Jun 2023 17:22:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:53924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <benjamin@HIDDEN>) id 1q6HeM-0003cu-2E for submit <at> debbugs.gnu.org; Mon, 05 Jun 2023 17:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <benjamin@HIDDEN>) id 1q6HeK-0004KS-J6 for bug-gnu-emacs@HIDDEN; Mon, 05 Jun 2023 17:22:00 -0400 Received: from server01.webapps.manitu.net ([217.11.48.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <benjamin@HIDDEN>) id 1q6HeI-0000rv-OF for bug-gnu-emacs@HIDDEN; Mon, 05 Jun 2023 17:22:00 -0400 Received: from webmail.manitu.de (localhost [127.0.0.1]) by server01.webapps.manitu.net (Postfix) with ESMTP id 9EB92AA0E26 for <bug-gnu-emacs@HIDDEN>; Mon, 5 Jun 2023 23:21:54 +0200 (CEST) MIME-Version: 1.0 Date: Mon, 05 Jun 2023 23:21:54 +0200 From: Benjamin Orthen <benjamin@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 30.0.50; use-package: changes do not propagate to elpa-devel User-Agent: Roundcube Webmail/1.4.11 Message-ID: <4b1ff1660351348f3d5f1bc848965d59@HIDDEN> X-Sender: benjamin@HIDDEN Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-manitu-Webmail-Sender: dTMzODE2QG9ydGhlbi5uZXQ= Received-SPF: pass client-ip=217.11.48.33; envelope-from=benjamin@HIDDEN; helo=server01.webapps.manitu.net X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) Recent changes in use-package (i.e., commit 2ce279680bf9c1964e98e2aa48a03d6675c386fe) have not propagated to emacs-devel (https://elpa.gnu.org/devel/use-package.html) even though use-package is designated as a :core package in elpa. My understanding is that changes in emacs for :core packages are automatically propagated to elpa(-devel). I was however not able to find documentation on how this propagation/sync works. I noticed that use-package.el does not have the disclaimer ";; This is a GNU ELPA :core package. Avoid adding functionality [...]" in its header. I suppose this is unrelated to the elpa-devel sync, but could be fixed as well. Best regards, Benjamin
Benjamin Orthen <benjamin@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#63916; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.