GNU bug report logs - #63922
[PATCH] doc: fix typo in screen-locker-service swaylock example

Previous Next

Package: guix-patches;

Reported by: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>

Date: Tue, 6 Jun 2023 09:09:02 UTC

Severity: normal

Tags: patch

Done: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63922 in the body.
You can then email your comments to 63922 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#63922; Package guix-patches. (Tue, 06 Jun 2023 09:09:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 06 Jun 2023 09:09:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: fix typo in screen-locker-service swaylock example
Date: Tue, 6 Jun 2023 11:08:27 +0200
Hello Guix,

I think there is a small typo one of the examples for the 
screen-locker-service-type. The second example is for a 
screen-locker-service that uses swaylock but still uses the xlockmore 
executable. I think the following patch would fix that.


Greetings,

Arvid

---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8df5cc411c..638ab1ed6e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -22577,7 +22577,7 @@ X Window
 (service screen-locker-service-type
          (screen-locker-configuration
            (name "swaylock")
-           (program (file-append xlockmore "/bin/xlock"))
+           (program (file-append swaylock "/bin/swaylock"))
            (using-pam? #t)
            (using-setuid? #f)))
 @end lisp

base-commit: e3cd3f03202c48cd8d777f4769b4e31fea8dcd60
--
2.40.1






Information forwarded to guix-patches <at> gnu.org:
bug#63922; Package guix-patches. (Tue, 06 Jun 2023 12:00:02 GMT) Full text and rfc822 format available.

Message #8 received at 63922 <at> debbugs.gnu.org (full text, mbox):

From: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
To: 63922 <at> debbugs.gnu.org
Cc: Arvid Krein <arvid <at> krein.moe>
Subject: [PATCH] doc: fix typo in screen-locker-service swaylock example
Date: Tue,  6 Jun 2023 13:59:20 +0200
From: Arvid Krein <arvid <at> krein.moe>

Greetings,
Arvid

---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8df5cc411c..638ab1ed6e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -22577,7 +22577,7 @@ X Window
 (service screen-locker-service-type
          (screen-locker-configuration
            (name "swaylock")
-           (program (file-append xlockmore "/bin/xlock"))
+           (program (file-append swaylock "/bin/swaylock"))
            (using-pam? #t)
            (using-setuid? #f)))
 @end lisp

base-commit: e3cd3f03202c48cd8d777f4769b4e31fea8dcd60
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#63922; Package guix-patches. (Fri, 07 Jul 2023 10:37:01 GMT) Full text and rfc822 format available.

Message #11 received at 63922 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
Cc: 63922 <at> debbugs.gnu.org, Arvid Krein <arvid <at> krein.moe>
Subject: Re: [bug#63922] [PATCH] doc: fix typo in screen-locker-service
 swaylock example
Date: Fri, 07 Jul 2023 12:35:45 +0200
Arvid Krein <arvidkrein <at> zedat.fu-berlin.de> writes:
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 8df5cc411c..638ab1ed6e 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -22577,7 +22577,7 @@ X Window
>  (service screen-locker-service-type
>           (screen-locker-configuration
>             (name "swaylock")
> -           (program (file-append xlockmore "/bin/xlock"))
> +           (program (file-append swaylock "/bin/swaylock"))
>             (using-pam? #t)
>             (using-setuid? #f)))
>  @end lisp

Thank you Arvid for your patch.  Thing is, it seems what is specified in
`program' actually does not matter, only the `name' field matters when
using-pam? is true.  I’m not going to work on this; perhaps someone
using screen lockers will decide what needs repairing.

Regards,
Florian





Information forwarded to guix-patches <at> gnu.org:
bug#63922; Package guix-patches. (Fri, 07 Jul 2023 19:53:01 GMT) Full text and rfc822 format available.

Message #14 received at 63922 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>, 63922 <at> debbugs.gnu.org
Cc: Arvid Krein <arvid <at> krein.moe>
Subject: Re: [bug#63922] [PATCH] doc: fix typo in screen-locker-service
 swaylock example
Date: Fri, 07 Jul 2023 21:52:39 +0200
[Message part 1 (text/plain, inline)]
Hi Arvid,

Arvid Krein <arvidkrein <at> zedat.fu-berlin.de> writes:

> From: Arvid Krein <arvid <at> krein.moe>
>
> Greetings,
> Arvid
>
> ---
>  doc/guix.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Pushed as 5b6e9b2463f94ae41121e379515c756a6eed9b7f, thanks!

Best,
-- 
Josselin Poiret
[signature.asc (application/pgp-signature, inline)]

bug closed, send any further explanations to 63922 <at> debbugs.gnu.org and Arvid Krein <arvidkrein <at> zedat.fu-berlin.de> Request was from "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> to control <at> debbugs.gnu.org. (Thu, 13 Jul 2023 16:13:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 11 Aug 2023 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 230 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.