GNU bug report logs - #64100
[PATCH] gnu: llvm: make clang-make-toolchain public

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64100 in the body.
You can then email your comments to 64100 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lists <at> coryfields.com
To: guix-patches <at> gnu.org
Cc: efraim <at> flashner.co.il, Cory Fields <cory-nospam-@coryfields.com>
Subject: [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Thu, 15 Jun 2023 18:05:14 +0000

From: Cory Fields <cory-nospam-@coryfields.com>

Matches gcc-make-toolchain. Allow for llvm build to be patched.

* gnu/packages/llvm.scm: make clang-make-toolchain public

Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
---
 gnu/packages/llvm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index f59c8e9592..6d83313af6 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -502,7 +502,7 @@ code analysis tools.")
               "znver3")
             '())))))
 
-(define (make-clang-toolchain clang libomp)
+(define-public (make-clang-toolchain clang libomp)
   (package
     (name (string-append (package-name clang) "-toolchain"))
     (version (package-version clang))

base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
-- 
2.25.1

Message #8 received at 64100 <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: lists <at> coryfields.com
Cc: 64100 <at> debbugs.gnu.org, efraim <at> flashner.co.il,
 Cory Fields <cory-nospam-@coryfields.com>
Subject: Re: [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Fri, 16 Jun 2023 16:40:22 -0400

Simple enough and matches gcc-make-toolchain.

Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.

I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).

–Carl

> On Jun 15, 2023, at 2:05 PM, lists <at> coryfields.com wrote:
> 
> From: Cory Fields <cory-nospam-@coryfields.com>
> 
> Matches gcc-make-toolchain. Allow for llvm build to be patched.
> 
> * gnu/packages/llvm.scm: make clang-make-toolchain public
> 
> Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
> ---
> gnu/packages/llvm.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index f59c8e9592..6d83313af6 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -502,7 +502,7 @@ code analysis tools.")
>               "znver3")
>             '())))))
> 
> -(define (make-clang-toolchain clang libomp)
> +(define-public (make-clang-toolchain clang libomp)
>   (package
>     (name (string-append (package-name clang) "-toolchain"))
>     (version (package-version clang))
> 
> base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
> -- 
> 2.25.1
> 
> 
> 
> 

Message #14 received at 64100 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Carl Dong <contact <at> carldong.me>
Cc: 64100 <at> debbugs.gnu.org, lists <at> coryfields.com,
 Cory Fields <cory-nospam-@coryfields.com>
Subject: Re: [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Sun, 18 Jun 2023 09:38:05 +0300

[Message part 1 (text/plain, inline)]

On Fri, Jun 16, 2023 at 04:40:22PM -0400, Carl Dong wrote:
> Simple enough and matches gcc-make-toolchain.
> 
> Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
> 
> I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).

Sounds good to me

> > On Jun 15, 2023, at 2:05 PM, lists <at> coryfields.com wrote:
> > 
> > From: Cory Fields <cory-nospam-@coryfields.com>
> > 
> > Matches gcc-make-toolchain. Allow for llvm build to be patched.
> > 
> > * gnu/packages/llvm.scm: make clang-make-toolchain public
> > 
> > Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
> > ---
> > gnu/packages/llvm.scm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> > index f59c8e9592..6d83313af6 100644
> > --- a/gnu/packages/llvm.scm
> > +++ b/gnu/packages/llvm.scm
> > @@ -502,7 +502,7 @@ code analysis tools.")
> >               "znver3")
> >             '())))))
> > 
> > -(define (make-clang-toolchain clang libomp)
> > +(define-public (make-clang-toolchain clang libomp)
> >   (package
> >     (name (string-append (package-name clang) "-toolchain"))
> >     (version (package-version clang))
> > 
> > base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
> > -- 
> > 2.25.1
> > 
> > 
> > 
> > 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 64100 <at> debbugs.gnu.org (full text, mbox):

From: Michael Ford <fanquake <at> gmail.com>
To: 64100 <at> debbugs.gnu.org
Subject: Re: [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Mon, 19 Jun 2023 14:50:36 +0100

> Matches gcc-make-toolchain. Allow for llvm build to be patched.
> * gnu/packages/llvm.scm: make clang-make-toolchain public

This is great. Thanks for the change.
Definitely useful for downstream Guix users!

Message #20 received at 64100 <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Michael Ford <fanquake <at> gmail.com>, 64100 <at> debbugs.gnu.org,
 lists <at> coryfields.com, Cory Fields <cory-nospam-@coryfields.com>
Subject: Re: [bug#64100] [PATCH] gnu: llvm: make clang-make-toolchain public
Date: Sun, 2 Jul 2023 13:16:21 -0400

[Message part 1 (text/plain, inline)]

Pushed to master as 39a3251feb2559e0b448f25671c26b9dd3318108

I’m not sure I can close this ticket as I didn’t open it.

–Carl

> On Jun 18, 2023, at 2:38 AM, Efraim Flashner <efraim <at> flashner.co.il> wrote:
> 
> On Fri, Jun 16, 2023 at 04:40:22PM -0400, Carl Dong wrote:
>> Simple enough and matches gcc-make-toolchain.
>> 
>> Allows for more complex manifests and packages to be built with a custom clang toolchains without forking Guix.
>> 
>> I think I still have push rights so I’ll push in 2 weeks if there are no other objections (this shouldn’t trigger any rebuilds at all).
> 
> Sounds good to me
> 
>>> On Jun 15, 2023, at 2:05 PM, lists <at> coryfields.com wrote:
>>> 
>>> From: Cory Fields <cory-nospam-@coryfields.com>
>>> 
>>> Matches gcc-make-toolchain. Allow for llvm build to be patched.
>>> 
>>> * gnu/packages/llvm.scm: make clang-make-toolchain public
>>> 
>>> Signed-off-by: Cory Fields <cory-nospam-@coryfields.com>
>>> ---
>>> gnu/packages/llvm.scm | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
>>> index f59c8e9592..6d83313af6 100644
>>> --- a/gnu/packages/llvm.scm
>>> +++ b/gnu/packages/llvm.scm
>>> @@ -502,7 +502,7 @@ code analysis tools.")
>>>              "znver3")
>>>            '())))))
>>> 
>>> -(define (make-clang-toolchain clang libomp)
>>> +(define-public (make-clang-toolchain clang libomp)
>>>  (package
>>>    (name (string-append (package-name clang) "-toolchain"))
>>>    (version (package-version clang))
>>> 
>>> base-commit: 6e1215fb9c03ccb4a2d4440990aee5a66a935268
>>> --
>>> 2.25.1
>>> 
>>> 
>>> 
>>> 
>> 
> 
> --
> Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.