GNU bug report logs - #64222
[PATCH 0/4] Add senpai IRC client

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64222 in the body.
You can then email your comments to 64222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 0/4] Add senpai IRC client
Date: Thu, 22 Jun 2023 19:52:30 +0900

Nguyễn Gia Phong (4):
  gnu: go-github-com-godbus-dbus: Update to 5.1.0
  gnu: Add go-github-com-delthas-go-libnp
  gnu: Add go-github-com-delthas-go-localeinfo
  gnu: Add senpai.

 gnu/packages/golang.scm    | 48 +++++++++++++++++++++++++++++++++--
 gnu/packages/messaging.scm | 52 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 98 insertions(+), 2 deletions(-)


base-commit: 7f3c6d3b3ba86a8051e394e4ec9a6f6089753cb1
-- 
2.40.1

Message #8 received at 64222 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 64222 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 1/4] gnu: go-github-com-godbus-dbus: Update to 5.1.0
Date: Thu, 22 Jun 2023 19:54:24 +0900

gnu/packages/golang.scm (go-github-com-godbus-dbus): Update to 5.1.0.

Signed-off-by: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
---
 gnu/packages/golang.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e4c4cb299b48..a392c10cd7fe 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9909,7 +9909,7 @@ (define-public go-github-com-xdg-go-scram
 (define-public go-github-com-godbus-dbus
   (package
     (name "go-github-com-godbus-dbus")
-    (version "5.0.3")
+    (version "5.1.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -9918,7 +9918,7 @@ (define-public go-github-com-godbus-dbus
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1bkc904073k807yxg6mvqaxrr6ammmhginr9p54jfb55mz3hfw3s"))))
+                "1kayd4x7idrhi06ahh5kqkgwzgh9icvv71mjar2d0jl486dfs8r5"))))
     (build-system go-build-system)
     (arguments
      `(#:tests? #f ;no /var/run/dbus/system_bus_socket

base-commit: 7f3c6d3b3ba86a8051e394e4ec9a6f6089753cb1
-- 
2.40.1

Message #11 received at 64222 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 64222 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 2/4] gnu: Add go-github-com-delthas-go-libnp
Date: Thu, 22 Jun 2023 19:54:25 +0900

gnu/packages/golang.scm (go-github-com-delthas-go-libnp): New variable.

Signed-off-by: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
---
 gnu/packages/golang.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index a392c10cd7fe..9ffe8b3e7cbf 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9931,6 +9931,28 @@ (define-public go-github-com-godbus-dbus
 bindings for the D-Bus message bus system.")
     (license license:bsd-2)))
 
+(define-public go-github-com-delthas-go-libnp
+  (let ((commit "0e45ece1f878f202fee2c74801e287804668f677"))
+    (package
+      (name "go-github-com-delthas-go-libnp")
+      (version (git-version "0.0.0" "0" commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                       (url "https://github.com/delthas/go-libnp")
+                       (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1hylpvwz3kb8wr00knba6mggjacak2vmqafwysansj0ns038lp8w"))))
+      (build-system go-build-system)
+      (arguments `(#:import-path "github.com/delthas/go-libnp"))
+      (propagated-inputs (list go-github-com-godbus-dbus))
+      (home-page "https://github.com/delthas/go-libnp")
+      (synopsis "Tiny library providing information about now-playing media")
+      (description "@code{go-libnp} is a tiny cross-platform library for extracting information about the music/image/video that is Now Playing on the system.")
+      (license license:expat))))
+
 (define-public go-github-com-prometheus-common
   (package
     (name "go-github-com-prometheus-common")
-- 
2.40.1

Message #14 received at 64222 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 64222 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 3/4] gnu: Add go-github-com-delthas-go-localeinfo
Date: Thu, 22 Jun 2023 19:54:26 +0900

gnu/packages/golang.scm (go-github-com-delthas-go-localeinfo): New variable.

Signed-off-by: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
---
 gnu/packages/golang.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 9ffe8b3e7cbf..d2d7f855871d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9953,6 +9953,28 @@ (define-public go-github-com-delthas-go-libnp
       (description "@code{go-libnp} is a tiny cross-platform library for extracting information about the music/image/video that is Now Playing on the system.")
       (license license:expat))))
 
+(define-public go-github-com-delthas-go-localeinfo
+  (let ((commit "686a1e18511819b2f1625f00437f6e1246c04a5d"))
+    (package
+      (name "go-github-com-delthas-go-localeinfo")
+      (version (git-version "0.0.0" "0" commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                       (url "https://github.com/delthas/go-localeinfo")
+                       (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "0r0v42ggvyss8327nggwinxl42pj4l0dwz96g9wk1w8h8vmfrh0z"))))
+      (build-system go-build-system)
+      (arguments `(#:tests? #f ; FIXME: tests assume certain locale
+                   #:import-path "github.com/delthas/go-localeinfo"))
+      (home-page "https://github.com/delthas/go-localeinfo")
+      (synopsis "Library for extracting locale information")
+      (description "@code{go-localeinfo} extracts monetary/numeric/time formatting information, rather than the current locale name.")
+      (license license:expat))))
+
 (define-public go-github-com-prometheus-common
   (package
     (name "go-github-com-prometheus-common")
-- 
2.40.1

Message #17 received at 64222 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 64222 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 4/4] gnu: Add senpai.
Date: Thu, 22 Jun 2023 19:54:27 +0900

* gnu/packaging/messaging.scm (senpai): New variable.

Signed-off-by: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
---
 gnu/packages/messaging.scm | 52 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 3629d9a6d544..4fa04e5a1842 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3496,4 +3496,56 @@ (define-public pn
 a text snippet), using @code{libphonenumber}.")
     (license license:asl2.0)))
 
+(define-public senpai
+  (package
+    (name "senpai")
+    (version "0.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri
+        (git-reference
+         (url "https://git.sr.ht/~taiite/senpai")
+         (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1qw955i5f3jr42h4afr23v7wq616bcsyq68if75qdw8j1yibnpmb"))))
+    (build-system go-build-system)
+    (arguments
+      (list #:import-path "git.sr.ht/~taiite/senpai/cmd/senpai"
+            #:unpack-path "git.sr.ht/~taiite/senpai"
+            #:install-source? #f
+            #:phases
+            #~(modify-phases %standard-phases
+                (add-after 'build 'build-doc
+                  (lambda* (#:key unpack-path #:allow-other-keys)
+                    (invoke "make" "doc/senpai.1" "doc/senpai.5"
+                            "-C" (string-append "src/" unpack-path))))
+                (add-after 'install 'install-doc
+                  (lambda* (#:key unpack-path #:allow-other-keys)
+                    (let ((man1 (string-append #$output "/share/man/man1"))
+                          (man5 (string-append #$output "/share/man/man5")))
+                      (mkdir-p man1)
+                      (mkdir-p man5)
+                      (install-file
+                        (string-append "src/" unpack-path "/doc/senpai.1")
+                        man1)
+                      (install-file
+                        (string-append "src/" unpack-path "/doc/senpai.5")
+                        man5)))))))
+    (native-inputs (list go-git-sr-ht-emersion-go-scfg
+                         go-github-com-delthas-go-libnp
+                         go-github-com-delthas-go-localeinfo
+                         go-github-com-gdamore-tcell-v2
+                         go-github-com-mattn-go-runewidth
+                         go-golang-org-x-net
+                         go-golang-org-x-term
+                         go-golang-org-x-time
+                         go-mvdan-cc-xurls
+                         scdoc))
+    (home-page "https://sr.ht/~taiite/senpai")
+    (synopsis "Modern terminal IRC client")
+    (description "@code{senpai} is an IRC client that works best with bouncers")
+    (license license:isc)))
+
 ;;; messaging.scm ends here
-- 
2.40.1

Message #22 received at 64222-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Cc: 64222-done <at> debbugs.gnu.org
Subject: Re: [bug#64222] [PATCH 0/4] Add senpai IRC client
Date: Thu, 12 Oct 2023 17:12:50 +0200

Hi!

Nguyễn Gia Phong <mcsinyx <at> disroot.org> skribis:

>   gnu: go-github-com-godbus-dbus: Update to 5.1.0
>   gnu: Add go-github-com-delthas-go-libnp
>   gnu: Add go-github-com-delthas-go-localeinfo
>   gnu: Add senpai.

<https://qa.guix.gnu.org/issue/64222> was inconclusive (for some reason
it had not built all the dependents) so I checked locally and the
go-github-com-godbus-dbus upgrade does not introduce new breakage.

I wrapped the long ‘description’ lines, removed ‘Signed-off-by’ tags
from the logs (they’re for committers), and committed.

Thank you and apologies for the delay!

Ludo’.

Message #25 received at 64222-done <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 64222-done <at> debbugs.gnu.org
Subject: Re: [bug#64222] [PATCH 0/4] Add senpai IRC client
Date: Fri, 13 Oct 2023 01:16:29 +0900

On 2023-10-12 at 17:12+02:00, Ludovic Courtès wrote:
> <https://qa.guix.gnu.org/issue/64222> was inconclusive
> (for some reason it had not built all the dependents)

qa.guix.gnu.org was briefly broken at the time IIRC,
happened to other adjacent patchsets.

On 2023-10-12 at 17:12+02:00, Ludovic Courtès wrote:
> so I checked locally and the go-github-com-godbus-dbus upgrade
> does not introduce new breakage.
>
> I wrapped the long ‘description’ lines, removed ‘Signed-off-by’ tags
> from the logs (they’re for committers), and committed.

Thanks a lot!

Message #28 received at 64222 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 64222 <at> debbugs.gnu.org,
 50035 <at> debbugs.gnu.org, Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: Re: bug#64222: [PATCH 0/4] Add senpai IRC client
Date: Thu, 12 Oct 2023 17:53:34 +0000

Hi Ludo’ and Nguyễn (and cc'ing Sarah from earlier patches),

On Fri, Oct 13, 2023 at 01:16 AM, Nguyễn Gia Phong wrote:

> On 2023-10-12 at 17:12+02:00, Ludovic Courtès wrote:
>> <https://qa.guix.gnu.org/issue/64222> was inconclusive
>> (for some reason it had not built all the dependents)
>
> qa.guix.gnu.org was briefly broken at the time IIRC,
> happened to other adjacent patchsets.
>
> On 2023-10-12 at 17:12+02:00, Ludovic Courtès wrote:
>> so I checked locally and the go-github-com-godbus-dbus upgrade
>> does not introduce new breakage.
>>

I haven't checked but this might need some fixing as based on an earlier
patch for updating godbus (I can't help but read this as "god bus") the
import name has changed. Though as an example chezmoi seems to have been
broken for some time anyway. Maybe the import-name doesn't need the v5?

See

<https://issues.guix.gnu.org/50035>

and

<https://issues.guix.gnu.org/50037>.

The earlier patch also has fixes for the tests which would be good to
include now.

My apologies to Sarah as my original replies way back when only went to
the bug number (we should document this, easy beginner mistake!) and
once I became a committer this was on my list to update and push but I
didn't get around to it.

Nguyễn and/or Sarah would you like to submit a patch to change the
import path if needed, enable tests, and make any other changes? I could
also take a look if no one gets to it quickly.

>> I wrapped the long ‘description’ lines, removed ‘Signed-off-by’ tags
>> from the logs (they’re for committers), and committed.
>
> Thanks a lot!

Thanks to all on this updates!

John

PS: Looks like one extra signed-off-by tag made it through on a commit.
Oh well, glad I'm not the only one who's not perfect at these things!

Message #31 received at 64222 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: "John Kehayias" <john.kehayias <at> protonmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 64222 <at> debbugs.gnu.org,
 50035 <at> debbugs.gnu.org, Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: Re: gnu: go-github-com-godbus-dbus-v5
Date: Fri, 13 Oct 2023 13:52:29 +0900

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:
> [godbus's] import name has changed.  Though as an example
> chezmoi seems to have been broken for some time anyway.
> Maybe the import-name doesn't need the v5?

IIUC go-github-com-godbus-dbus is just a name for human consumption,
on the other hand I don't understand how it works without
the import-path matching the one in the go.mod file:

On 2021-08-13 at 20:49-07:00, Sarah Morgensen wrote in patchset 50037:
> -     `(#:import-path "github.com/godbus/dbus"
> +     `(#:import-path "github.com/godbus/dbus/v5"

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:
> Nguyễn and/or Sarah would you like to submit a patch to change the
> import path if needed, enable tests, and make any other changes? I could
> also take a look if no one gets to it quickly.

As stated above, I don't quite understand how go packages work
(when they don't seem to be supposed to), so you two please go ahead.
(BTW you can call me by my given name Phong.)

On 2023-10-12 at 17:53+00:00, John Kehayias wrote:
> I can't help but read this as "god bus"

Yea DBus is short for Dieu Bus anyway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.