GNU bug report logs - #64317
[Cuirass] Download products can disappear, leading to HTTP 500

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64317 in the body.
You can then email your comments to 64317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludovic.courtes <at> inria.fr>
To: bug-guix <at> gnu.org
Subject: [Cuirass] Download products can disappear, leading to HTTP 500
Date: Tue, 27 Jun 2023 16:09:16 +0200

The /download endpoint refers directly to store items.  However, they
can be GC’d in the meantime, in which case the HTTP handler fails
gracelessly (HTTP 500 or so) as shown here:

--8<---------------cut here---------------start------------->8---
2023-06-27 16:02:24 GET /download/718
2023-06-27 16:02:24 Uncaught exception in task:
2023-06-27 16:02:24 In fibers.scm:
2023-06-27 16:02:24     172:8  1 (_)
2023-06-27 16:02:24 In ice-9/boot-9.scm:
2023-06-27 16:02:24   1685:16  0 (raise-exception _ #:continuable? _)
2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz"
--8<---------------cut here---------------end--------------->8---

The solution IMO is to (1) register GC roots for these, (2) periodically
remove old GC roots, and (3) return 404 when the file has vanished.

Ludo’.

Message #10 received at 64317-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 64317-done <at> debbugs.gnu.org
Subject: Re: bug#64317: [Cuirass] Download products can disappear, leading
 to HTTP 500
Date: Thu, 24 Aug 2023 17:22:18 +0200

Ludovic Courtès <ludovic.courtes <at> inria.fr> skribis:

> The /download endpoint refers directly to store items.  However, they
> can be GC’d in the meantime, in which case the HTTP handler fails
> gracelessly (HTTP 500 or so) as shown here:
>
> 2023-06-27 16:02:24 GET /download/718
> 2023-06-27 16:02:24 Uncaught exception in task:
> 2023-06-27 16:02:24 In fibers.scm:
> 2023-06-27 16:02:24     172:8  1 (_)
> 2023-06-27 16:02:24 In ice-9/boot-9.scm:
> 2023-06-27 16:02:24   1685:16  0 (raise-exception _ #:continuable? _)
> 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> 2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz"
>
> The solution IMO is to (1) register GC roots for these, (2) periodically
> remove old GC roots, and (3) return 404 when the file has vanished.

Fixed with these Cuirass commits:

  9e897d8 'create-build-outputs' registers a GC root on build products.
  103a6ec http: Gracefully handle missing files in "/download".
  5e3e49c http: "/download" returns 404 rather than 500 for "not found".

Ludo’.

Message #13 received at 64317-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 64317-done <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, ludovic.courtes <at> inria.fr
Subject: Re: bug#64317: [Cuirass] Download products can disappear, leading
 to HTTP 500
Date: Sat, 26 Aug 2023 16:15:45 -0400

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Ludovic Courtès <ludovic.courtes <at> inria.fr> skribis:
>
>> The /download endpoint refers directly to store items.  However, they
>> can be GC’d in the meantime, in which case the HTTP handler fails
>> gracelessly (HTTP 500 or so) as shown here:
>>
>> 2023-06-27 16:02:24 GET /download/718
>> 2023-06-27 16:02:24 Uncaught exception in task:
>> 2023-06-27 16:02:24 In fibers.scm:
>> 2023-06-27 16:02:24     172:8  1 (_)
>> 2023-06-27 16:02:24 In ice-9/boot-9.scm:
>> 2023-06-27 16:02:24   1685:16  0 (raise-exception _ #:continuable? _)
>> 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
>> 2023-06-27 16:02:24 In procedure open-file: No such file or
>> directory:
>> "/gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz"
>>
>> The solution IMO is to (1) register GC roots for these, (2) periodically
>> remove old GC roots, and (3) return 404 when the file has vanished.
>
> Fixed with these Cuirass commits:
>
>   9e897d8 'create-build-outputs' registers a GC root on build products.
>   103a6ec http: Gracefully handle missing files in "/download".
>   5e3e49c http: "/download" returns 404 rather than 500 for "not found".

Yay!  Thanks for fixing this long standing issue!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.