GNU bug report logs - #64386
29.0.91; [PATCH] *src/emacs.c: a comma for elements of usage_message

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64386 in the body.
You can then email your comments to 64386 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> yahoo.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: 29.0.91; [PATCH] *src/emacs.c: a comma for elements of usage_message
Date: Fri, 30 Jun 2023 14:55:14 -0700

[Message part 1 (text/plain, inline)]

Hi,

It missed a comma in the array "usage_message". It won't hurt the
usage, but the lint tool (clang-tidy) will give a warning.

Please help review that patch. Thanks.

[0001-src-emacs.c-a-comma-for-elements-of-usage_message.patch (application/x-patch, attachment)]

Message #8 received at 64386 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Lin Sun <sunlin7 <at> yahoo.com>
Cc: 64386 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#64386: 29.0.91; [PATCH] *src/emacs.c: a comma for elements
 of usage_message
Date: Sat, 01 Jul 2023 09:34:13 +0800

Lin Sun <sunlin7 <at> yahoo.com> writes:

> Hi,
>
> It missed a comma in the array "usage_message". It won't hurt the
> usage, but the lint tool (clang-tidy) will give a warning.
>
> Please help review that patch. Thanks.

Thanks, but we prefer to avoid purely stylistic changes, deferring them
until they can be made in conjunction with other nearby changes to code.

Message #11 received at 64386 <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> yahoo.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 64386 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#64386: 29.0.91;
 [PATCH] *src/emacs.c: a comma for elements of usage_message
Date: Fri, 30 Jun 2023 21:43:23 -0700

[Message part 1 (text/plain, inline)]

Agree, please feel free to close this ticket, thanks

On Fri, Jun 30, 2023, 18:34 Po Lu <luangruo <at> yahoo.com> wrote:

> Lin Sun <sunlin7 <at> yahoo.com> writes:
>
> > Hi,
> >
> > It missed a comma in the array "usage_message". It won't hurt the
> > usage, but the lint tool (clang-tidy) will give a warning.
> >
> > Please help review that patch. Thanks.
>
> Thanks, but we prefer to avoid purely stylistic changes, deferring them
> until they can be made in conjunction with other nearby changes to code.
>

[Message part 2 (text/html, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> yahoo.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: 29.0.91;
 [PATCH] *src/emacs.c: a comma for elements of usage_message
Date: Sat, 01 Jul 2023 09:10:04 +0300

> From: Lin Sun <sunlin7 <at> yahoo.com>
> Date: Fri, 30 Jun 2023 14:55:14 -0700
> 
> It missed a comma in the array "usage_message". It won't hurt the
> usage, but the lint tool (clang-tidy) will give a warning.

Which warning do you get?  And why do you think the comma is missing?

Message #21 received at 64386-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lin Sun <sunlin7 <at> yahoo.com>
Cc: Po Lu <luangruo <at> yahoo.com>, 64386-done <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#64386: 29.0.91;
 [PATCH] *src/emacs.c: a comma for elements of usage_message
Date: Fri, 1 Sep 2023 20:56:45 +0200

> Agree, please feel free to close this ticket, thanks

Done, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.