GNU bug report logs - #64468
[PATCH] services: dhcp-client-service-type: Support DDNS.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64468 in the body.
You can then email your comments to 64468 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: guix-patches <at> gnu.org
Cc: Lilah Tascheter <lilah <at> lunabee.space>
Subject: [PATCH] services: dhcp-client-service-type: Support DDNS.
Date: Tue,  4 Jul 2023 19:10:21 -0500

* gnu/services/networking.scm (dhcp-client-shepherd-service): Enable -I
  flag on dhclient.
---
 gnu/services/networking.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 5657b141d9..0fbba1b8c7 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -350,7 +350,7 @@ (define ifaces
 
                          (false-if-exception (delete-file #$pid-file))
                          (let ((pid (fork+exec-command
-                                     (cons* dhclient "-nw"
+                                     (cons* dhclient "-nw" "-I"
                                             "-pf" #$pid-file ifaces))))
                            (and (zero? (cdr (waitpid pid)))
                                 (read-pid-file #$pid-file)))))

base-commit: 9122736455a9085d51b71b269b7c26a695a474ef
-- 
2.40.1

Message #8 received at 64468 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lilah Tascheter <lilah <at> lunabee.space>
Cc: 64468 <at> debbugs.gnu.org
Subject: Re: [bug#64468] [PATCH] services: dhcp-client-service-type: Support
 DDNS.
Date: Wed, 11 Oct 2023 19:14:06 +0200

Hi,

Lilah Tascheter <lilah <at> lunabee.space> skribis:

> * gnu/services/networking.scm (dhcp-client-shepherd-service): Enable -I
>   flag on dhclient.

[...]

> +                                     (cons* dhclient "-nw" "-I"

Could there be unintended side effects from passing “-I”?  The
dhclient(8) man page is silent about the implications.

If there are none, the patch LGTM.

Thanks,
Ludo’.

Message #13 received at 64468 <at> debbugs.gnu.org (full text, mbox):

From: Lilah Tascheter <lilah <at> lunabee.space>
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#64468] [PATCH] services: dhcp-client-service-type: Support
 DDNS.
Date: Thu, 12 Oct 2023 15:23:49 -0500

Ludovic Courtès <ludo <at> gnu.org> wrote:
> Could there be unintended side effects from passing "-I"?

the isc-dhcp knowledgebase says that by default dhclient uses a
pre-standardization implementation of DDNS, which is incompatable with non-isc
DHCP servers. no idea why that's the default, but -I just switches to using the
standardized protocol.

kb link with more details: https://kb.isc.org/docs/aa-01091

~lunabee

Message #18 received at 64468-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Lilah Tascheter <lilah <at> lunabee.space>
Cc: 64468-done <at> debbugs.gnu.org
Subject: Re: [bug#64468] [PATCH] services: dhcp-client-service-type: Support
 DDNS.
Date: Sat, 14 Oct 2023 19:45:11 +0200

Lilah Tascheter <lilah <at> lunabee.space> skribis:

> Ludovic Courtès <ludo <at> gnu.org> wrote:
>> Could there be unintended side effects from passing "-I"?
>
> the isc-dhcp knowledgebase says that by default dhclient uses a
> pre-standardization implementation of DDNS, which is incompatable with non-isc
> DHCP servers. no idea why that's the default, but -I just switches to using the
> standardized protocol.
>
> kb link with more details: https://kb.isc.org/docs/aa-01091

Thanks for explaining.  I added this explanation as a comment in the
code and committed.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.