GNU bug report logs - #64559
[PATCH] gnu: freesasa: Fix memerr tests.

Previous Next

Package: guix-patches;

Reported by: David Elsing <david.elsing <at> posteo.net>

Date: Mon, 10 Jul 2023 18:07:01 UTC

Severity: normal

Tags: patch

Done: David Elsing <david.elsing <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64559 in the body.
You can then email your comments to 64559 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to andreas <at> enge.fr, efraim <at> flashner.co.il, bavier <at> posteo.net, guix-patches <at> gnu.org:
bug#64559; Package guix-patches. (Mon, 10 Jul 2023 18:07:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to David Elsing <david.elsing <at> posteo.net>:
New bug report received and forwarded. Copy sent to andreas <at> enge.fr, efraim <at> flashner.co.il, bavier <at> posteo.net, guix-patches <at> gnu.org. (Mon, 10 Jul 2023 18:07:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Elsing <david.elsing <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: David Elsing <david.elsing <at> posteo.net>
Subject: [PATCH] gnu: freesasa: Fix memerr tests.
Date: Mon, 10 Jul 2023 18:06:11 +0000
* gnu/packages/chemistry.scm (freesasa)[arguments]: Add
"CFLAGS=-fno-builtin-malloc" to #:configure-flags.
---
 gnu/packages/chemistry.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/chemistry.scm b/gnu/packages/chemistry.scm
index cddccf8aea..431b845989 100644
--- a/gnu/packages/chemistry.scm
+++ b/gnu/packages/chemistry.scm
@@ -703,7 +703,11 @@ (define-public freesasa
       #~(list "--enable-check"
               "--enable-parser-generator"
               "CXXFLAGS=-std=c++17"
-              "--enable-doxygen")
+              "--enable-doxygen"
+              ;; Some tests rely on replacing malloc with a wrapper which
+              ;; fails in a controlled way, but this does not work if the call
+              ;; is replaced.
+              "CFLAGS=-fno-builtin-malloc")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'remove-libc++-linking
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#64559; Package guix-patches. (Fri, 14 Jul 2023 02:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 64559 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: David Elsing <david.elsing <at> posteo.net>
Cc: andreas <at> enge.fr, efraim <at> flashner.co.il, 64559 <at> debbugs.gnu.org,
 bavier <at> posteo.net
Subject: Re: [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.
Date: Fri, 14 Jul 2023 03:33:02 +0100
Hi David,

On 2023-07-10 19:06, David Elsing wrote:
> +              ;; Some tests rely on replacing malloc with a wrapper which
> +              ;; fails in a controlled way, but this does not work if the call
> +              ;; is replaced.
> +              "CFLAGS=-fno-builtin-malloc")

Have you filed an issue with upstream regarding this?
It looks to me that this is something that should be figured out by the
build system or the unit tests.


-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.





Information forwarded to guix-patches <at> gnu.org:
bug#64559; Package guix-patches. (Fri, 14 Jul 2023 23:02:02 GMT) Full text and rfc822 format available.

Message #11 received at 64559 <at> debbugs.gnu.org (full text, mbox):

From: David Elsing <david.elsing <at> posteo.net>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: andreas <at> enge.fr, efraim <at> flashner.co.il, 64559 <at> debbugs.gnu.org,
 bavier <at> posteo.net
Subject: Re: [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.
Date: Fri, 14 Jul 2023 23:01:46 +0000
Bruno Victal <mirai <at> makinata.eu> writes:

Hello Bruno,

> Have you filed an issue with upstream regarding this?
> It looks to me that this is something that should be figured out by the
> build system or the unit tests.
that's true, I just filed an issue: https://github.com/mittinatten/freesasa/issues/94.

Cheers,
David




Information forwarded to guix-patches <at> gnu.org:
bug#64559; Package guix-patches. (Wed, 14 Feb 2024 19:21:02 GMT) Full text and rfc822 format available.

Message #14 received at 64559 <at> debbugs.gnu.org (full text, mbox):

From: David Elsing <david.elsing <at> posteo.net>
To: 64559 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>, 64559-done <at> debbugs.gnu.org
Subject: Re: [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.
Date: Wed, 14 Feb 2024 19:20:19 +0000
David Elsing <david.elsing <at> posteo.net> writes:

> that's true, I just filed an issue: https://github.com/mittinatten/freesasa/issues/94.

I included this patch in another patch series for rdkit, which was now
applied in commit cc772e7f3172a8014e32c7ea3f6626963d4e9e16. The issue
was also fixed upstream.




Reply sent to David Elsing <david.elsing <at> posteo.net>:
You have taken responsibility. (Wed, 14 Feb 2024 19:21:02 GMT) Full text and rfc822 format available.

Notification sent to David Elsing <david.elsing <at> posteo.net>:
bug acknowledged by developer. (Wed, 14 Feb 2024 19:21:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 14 Mar 2024 11:24:15 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 83 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.