GNU bug report logs - #64651
[PATCH] gnu: pantalaimon: Fix media downloads.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64651 in the body.
You can then email your comments to 64651 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wojtek Kosior <koszko <at> koszko.org>
To: guix-patches <at> gnu.org
Cc: Wojtek Kosior <koszko <at> koszko.org>
Subject: [PATCH] gnu: pantalaimon: Fix media downloads.
Date: Sat, 15 Jul 2023 16:22:28 +0200

* gnu/packages/matrix.scm (pantalaimon)[arguments]: Patch incorrect function
invokation that made downloads of attachments impossible
---
 gnu/packages/matrix.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/matrix.scm b/gnu/packages/matrix.scm
index 6107dfc979..60c5543e5f 100644
--- a/gnu/packages/matrix.scm
+++ b/gnu/packages/matrix.scm
@@ -259,6 +259,14 @@ (define-public pantalaimon
                 ;; Upgrading python-appdirs requires rebuilting 3000+ packages,
                 ;; when 1.4.4 is a simple maintenance fix from 1.4.3.
                 (("appdirs >= 1.4.4") "appdirs >= 1.4.3"))))
+          (add-after 'downgrade-appdirs-requirement 'bugfixes
+            (lambda _
+              (substitute* "pantalaimon/daemon.py"
+                ;; FIXME: Remove this once a pantalaimon version with this fix
+                ;; is officially released.
+                ;; https://github.com/matrix-org/pantalaimon/pull/152/commits/d71770ca94981afde8c9be6aaaca951f0685b64e
+                (("client.download\\(server_name, media_id, file_name\\)")
+                 "client.download(server_name=server_name, media_id=media_id, filename=file_name)"))))
           (add-after 'install 'install-doc
             (lambda _
               (with-directory-excursion "docs/man"

base-commit: 00ed2901f5171e4f9435641a91678217cae38030
-- 
2.41.0

Message #8 received at 64651 <at> debbugs.gnu.org (full text, mbox):

From: Wojtek Kosior <koszko <at> koszko.org>
To: 64651 <at> debbugs.gnu.org
Subject: [PATCH] gnu: pantalaimon: Fix media downloads.
Date: Fri, 22 Dec 2023 16:13:28 +0100

[Message part 1 (text/plain, inline)]

Hello,

a gentle ping here :)  It's been over 6 months since I sent this patch.
Does it need any improvements?

Wojtek


-- (sig_start)
website: https://koszko.org/koszko.html
fingerprint: E972 7060 E3C5 637C 8A4F  4B42 4BC5 221C 5A79 FD1A
follow me on Fediverse: https://friendica.me/profile/koszko/profile

♥ R29kIGlzIHRoZXJlIGFuZCBsb3ZlcyBtZQ== | ÷ c2luIHNlcGFyYXRlZCBtZSBmcm9tIEhpbQ==
✝ YnV0IEplc3VzIGRpZWQgdG8gc2F2ZSBtZQ== | ? U2hhbGwgSSBiZWNvbWUgSGlzIGZyaWVuZD8=
-- (sig_end)

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 64651 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Wojtek Kosior <koszko <at> koszko.org>
Cc: 64651 <at> debbugs.gnu.org
Subject: Re: [bug#64651] [PATCH] gnu: pantalaimon: Fix media downloads.
Date: Sat, 01 Mar 2025 10:46:26 -0800

Hi Wojtek,

Wojtek Kosior <koszko <at> koszko.org> writes:

> Hello,
>
> a gentle ping here :)  It's been over 6 months since I sent this 
> patch.
> Does it need any improvements?

Sorry for the delayed response here, Guix patch review is rough, 
and especially patches >1 month old are hard to find.

I updated Pantalaimon at the end of January (#75960), which 
contains a fix for the problem your patch addresses.

Appreciate the patch, I’m sorry nobody did anything with it.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.