GNU bug report logs - #64667
[PATCH 0/1] Add grub-coreboot

Message received at 64667 <at> debbugs.gnu.org:

Received: (at 64667) by debbugs.gnu.org; 16 Jul 2023 16:56:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 16 12:56:38 2023
Received: from localhost ([127.0.0.1]:48464 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qL530-0001Pz-0v
	for submit <at> debbugs.gnu.org; Sun, 16 Jul 2023 12:56:38 -0400
Received: from cyberdimension.org ([2001:910:1314:ffff::1]:60052
 helo=gnutoo.cyberdimension.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <GNUtoo@HIDDEN>) id 1qL52x-0001Pm-6M
 for 64667 <at> debbugs.gnu.org; Sun, 16 Jul 2023 12:56:36 -0400
Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1])
 by cyberdimension.org (OpenSMTPD) with ESMTP id aecdb929;
 Sun, 16 Jul 2023 16:56:34 +0000 (UTC)
Received: from localhost.localdomain (localhost [::1])
 by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 651e6234;
 Sun, 16 Jul 2023 16:56:34 +0000 (UTC)
From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
To: 64667 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: Add grub-coreboot
Date: Sun, 16 Jul 2023 18:56:25 +0200
Message-ID: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <cover.1689524124.git.GNUtoo@HIDDEN>
References: <cover.1689524124.git.GNUtoo@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Efraim Flashner <efraim@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Vagrant Cascadian <vagrant@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 64667
Cc: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/bootloaders.scm (grub-coreboot): New variable.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
---
 gnu/packages/bootloaders.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 01fd1093ff..c5090d1ead 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -15,7 +15,7 @@
 ;;; Copyright © 2020, 2021 Pierre Langlois <pierre.langlois@HIDDEN>
 ;;; Copyright © 2021 Vincent Legoll <vincent.legoll@HIDDEN>
 ;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN>
-;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
+;;; Copyright © 2022, 2023 Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
 ;;; Copyright © 2021 Stefan <stefan-guix@HIDDEN>
 ;;; Copyright © 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;;
@@ -297,6 +297,21 @@ (define-public grub-minimal
 
                #t))))))))
 
+(define-public grub-coreboot
+  (package
+    (inherit grub)
+    (name "grub-coreboot")
+    (synopsis "GRand Unified Boot loader (Coreboot payload version)")
+    (arguments
+     `(,@(substitute-keyword-arguments (package-arguments grub)
+           ;; Several tests fail
+           ((#:tests? _ #f)
+            #f)
+           ((#:configure-flags flags
+             ''())
+            `(cons* "--with-platform=coreboot"
+                    ,flags)))))))
+
 (define-public grub-efi
   (package
     (inherit grub)
-- 
2.41.0

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 16 Jul 2023 16:50:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jul 16 12:50:04 2023
Received: from localhost ([127.0.0.1]:48450 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qL4wd-0001F9-TX
	for submit <at> debbugs.gnu.org; Sun, 16 Jul 2023 12:50:04 -0400
Received: from lists.gnu.org ([2001:470:142::17]:56068)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <GNUtoo@HIDDEN>) id 1qL4wa-0001EM-09
 for submit <at> debbugs.gnu.org; Sun, 16 Jul 2023 12:50:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <GNUtoo@HIDDEN>)
 id 1qL4wU-0005A3-HO
 for guix-patches@HIDDEN; Sun, 16 Jul 2023 12:49:54 -0400
Received: from cyberdimension.org ([80.67.179.20]
 helo=gnutoo.cyberdimension.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <GNUtoo@HIDDEN>)
 id 1qL4wS-00063p-HY
 for guix-patches@HIDDEN; Sun, 16 Jul 2023 12:49:54 -0400
Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1])
 by cyberdimension.org (OpenSMTPD) with ESMTP id 4575bff4;
 Sun, 16 Jul 2023 16:49:48 +0000 (UTC)
Received: from localhost.localdomain (localhost [::1])
 by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id a608a8c7;
 Sun, 16 Jul 2023 16:49:48 +0000 (UTC)
From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH 0/1] Add grub-coreboot
Date: Sun, 16 Jul 2023 18:49:32 +0200
Message-ID: <cover.1689524124.git.GNUtoo@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: ( <paren@HIDDEN>, Christopher Baines <mail@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Raghav Gururajan <rg@HIDDEN>, Ricardo Wurmus <rekado@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, jgart <jgart@HIDDEN>
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=80.67.179.20;
 envelope-from=GNUtoo@HIDDEN; helo=gnutoo.cyberdimension.org
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Hi,

In the following mail there will be a patch that adds grub-coreboot.

The './pre-inst-env guix lint grub-coreboot' command shows some warnings:
    [...]/bootloaders.scm:301:2: grub-coreboot@HIDDEN:
    label 'qemu' does not match package name 'qemu-minimal'
    [...]/bootloaders.scm:301:2: grub-coreboot@HIDDEN:
    label 'gettext' does not match package name 'gettext-minimal'
    [...]/bootloaders.scm:301:2: grub-coreboot@HIDDEN:
    file names of patches should start with the package name
    [...]/bootloaders.scm:301:2: grub-coreboot@HIDDEN:
    probably vulnerable to CVE-2022-2601, CVE-2022-3775, CVE-2021-3981
    [...]/bootloaders.scm:301:2: grub-coreboot@HIDDEN:
    updater 'gnu' failed to find upstream releases
but since this package is based on grub-coreboot, I guess that things should
be fixed there instead.

A standalone image was built with the following commands:

    modules="ahci at_keyboard cbfs ehci ext2 fat ohci part_gpt part_msdos \
             pata uhci usb_keyboard usbms usbserial_usbdebug"

    install_modules="acpi ahci all_video archelp at_keyboard ata blocklist \
    boot btrfs cat cbfs cbls cbls cbmemc cbmemc cbtime cbtime chain chain \
    cmosdump cmostest cmp configfile configfile cpio cpuid crc64 crypto \
    cryptodisk cs5536 date datehook datetime disk diskfilter div dm_nv echo \
    echo ehci elf eval exfat ext2 extcmd fat file fshelp gcry_crc gcry_rfc2268 \
    gcry_rijndael gcry_rsa gcry_seed gcry_serpent gcry_sha1 gcry_sha256 \
    gcry_sha512 gcry_twofish gettext gfxmenu gfxterm_background gfxterm_menu \
    gptsync gzio gzio halt halt hashsum hdparm help help hexdump hexdump iorw \
    iorw iso9660 jpeg keylayouts keystatus ldm linux linux linux16 linux16 \
    loadenv loopback ls ls lsacpi lsacpi lsmmap lsmmap lspci lspci luks lvm \
    lzopio mda_text memdisk memrw memrw minicmd minicmd mmap morse mpi \
    msdospart multiboot multiboot multiboot2 nativedisk newc nilfs2 normal \
    normal odc offsetio ohci part_gpt part_msdos parttool password \
    password_pbkdf2 password_pbkdf2 pata pbkdf2 pci pcidump pcidump pgp play \
    priority_queue probe procfs progress random read reboot reboot regexp \
    regexp relocator romfs scsi search search search_fs_file search_fs_uuid \
    search_label serial serial setjmp setpci setpci sfs sleep spkmodem squash4 \
    syslinuxcfg syslinuxcfg tar terminal terminfo test test testload testspeed \
    time tr trig true udf uhci usb usb_keyboard usbms usbserial_common \
    usbserial_ftdi usbserial_pl2303 usbserial_usbdebug video_colors videoinfo \
    xnu xzio"

    "/gnu/store/[...]/bin/grub-mkstandalone" \
	-O i386-coreboot \
	-o grub_payload.elf \
	--fonts= \
	--themes= \
	--locales= \
	--modules="${modules}" \
	--install-modules="${install_modules}" \
	/boot/grub/grub.cfg=coreboot.cfg

The coreboot.cfg file was taken from grub source code (GPLv3+) and consist of
the following:
    
    if test -f (cbfsdisk)/etc/grub.cfg; then
       source (cbfsdisk)/etc/grub.cfg
    fi

The resulting image was tested on a Thinkpad X200 running a custom 100% free
software version of Coreboot with as a GRUB payload) with the following
commands:
  
    chainloader /path/to/grub_payload.elf
    boot

It then booted fine. As for the partitions I used, I have LUKS encrypted hard
drive with LVM2 and a mix of BTRFS and ext4 partitions.

Denis 'GNUtoo' Carikli (1):
  gnu: Add grub-coreboot

 gnu/packages/bootloaders.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)


base-commit: 796c823a0d1d0aec9f4af908eca462e58e5675b5
-- 
2.41.0