GNU bug report logs - #64813
[PATCH] gnu: Add python-manimpango.

Previous Next

Package: guix-patches;

Reported by: "Wamm K. D" <jaft.r <at> outlook.com>

Date: Sun, 23 Jul 2023 21:04:01 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64813 in the body.
You can then email your comments to 64813 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#64813; Package guix-patches. (Sun, 23 Jul 2023 21:04:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Wamm K. D" <jaft.r <at> outlook.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 23 Jul 2023 21:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Wamm K. D" <jaft.r <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: "Wamm K. D" <jaft.r <at> outlook.com>
Subject: [PATCH] gnu: Add python-manimpango.
Date: Sun, 23 Jul 2023 15:57:25 -0500
* gnu/packages/python-xyz.scm (python-manimpango): New variable.
---
 gnu/packages/python-xyz.scm | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index db3e69fb45..14cb375a8a 100644

Right now, the tests are failing with "No module named 'manimpango.cmanimpango'";
it's clearly trying to import the package so it can use it for testing but the
test files are failing to find it (it looks like the "cmanimpango" file is a C
file (along with .pxd and .pyx files) so maybe it's Cython related?).

Is there a way we usually handle this for Python/Cython packages?
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -119,7 +119,7 @@
 ;;; Copyright © 2022 Evgeny Pisemsky <evgeny <at> pisemsky.com>
 ;;; Copyright © 2022 drozdov <drozdov <at> portalenergy.tech>
 ;;; Copyright © 2022 Peter Polidoro <peter <at> polidoro.io>
-;;; Copyright © 2022 Wamm K. D. <jaft.r <at> outlook.com>
+;;; Copyright © 2022, 2023 Wamm K. D. <jaft.r <at> outlook.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
 ;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2022 Paul A. Patience <paul <at> apatience.com>
@@ -9292,6 +9292,26 @@ (define-public python-xcffib
 support for Python 3 and PyPy.  It is based on cffi.")
     (license license:expat)))
 
+(define-public python-manimpango
+  (package
+    (name "python-manimpango")
+    (version "0.4.3")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "ManimPango" version))
+              (sha256 (base32
+                       "00x1l55wy0k6v3b6l2g5603zk5d5dab59fwkxq6jq4ncifwiqbvk"))))
+    (build-system pyproject-build-system)
+    (native-inputs (list pkg-config python-cython python-pytest))
+    (inputs (list pango))
+    (home-page "https://pypi.org/project/ManimPango/")
+    (synopsis "Bindings for Pango for using with Manim.")
+    (description "Python bindings for ManimPango which is a C binding for Pango,
+using Cython.
+
+ManimPango is internally used in Manim to render (non-LaTeX) text.")
+    (license license:expat)))
+
 (define-public python-cairocffi
   (package
     (name "python-cairocffi")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#64813; Package guix-patches. (Wed, 16 Aug 2023 20:36:02 GMT) Full text and rfc822 format available.

Message #8 received at 64813 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Wamm K. D" <jaft.r <at> outlook.com>
Cc: 64813 <at> debbugs.gnu.org
Subject: Re: bug#64813: [PATCH] gnu: Add python-manimpango.
Date: Wed, 16 Aug 2023 22:35:15 +0200
Hi,

"Wamm K. D" <jaft.r <at> outlook.com> skribis:

> * gnu/packages/python-xyz.scm (python-manimpango): New variable.
> ---
>  gnu/packages/python-xyz.scm | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index db3e69fb45..14cb375a8a 100644
>
> Right now, the tests are failing with "No module named 'manimpango.cmanimpango'";
> it's clearly trying to import the package so it can use it for testing but the
> test files are failing to find it (it looks like the "cmanimpango" file is a C
> file (along with .pxd and .pyx files) so maybe it's Cython related?).
>
> Is there a way we usually handle this for Python/Cython packages?

I don’t know if there are specific tricks here, though maybe you could
grep around or look for other packages that depend on Cython?

HTH,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#64813; Package guix-patches. (Sat, 16 Dec 2023 19:27:02 GMT) Full text and rfc822 format available.

Message #11 received at 64813 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 64813 <at> debbugs.gnu.org
Date: Sat, 16 Dec 2023 20:26:17 +0100
Hi both of you,

I took the liberty to

- fix the build (the extensions still needed to be built)
- upgrade to the latest release
- rebase on master

Hope this helps!

Best wishes,

Troy




Information forwarded to guix-patches <at> gnu.org:
bug#64813; Package guix-patches. (Sat, 16 Dec 2023 19:29:02 GMT) Full text and rfc822 format available.

Message #14 received at 64813 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 64813 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-manimpango.
Date: Sat, 16 Dec 2023 20:24:47 +0100
* gnu/packages/python-xyz.scm (python-manimpango): New variable.

Change-Id: I5ee6faa9cfd51a173f73d03c5c18e3c7d399582a
---
 gnu/packages/python-xyz.scm | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 86f8d81689..6bc02393e0 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -119,7 +119,7 @@
 ;;; Copyright © 2022 Evgeny Pisemsky <evgeny <at> pisemsky.com>
 ;;; Copyright © 2022 drozdov <drozdov <at> portalenergy.tech>
 ;;; Copyright © 2022 Peter Polidoro <peter <at> polidoro.io>
-;;; Copyright © 2022 Wamm K. D. <jaft.r <at> outlook.com>
+;;; Copyright © 2022, 2023 Wamm K. D. <jaft.r <at> outlook.com>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
 ;;; Copyright © 2022 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2022 Paul A. Patience <paul <at> apatience.com>
@@ -9615,6 +9615,39 @@ (define-public python-pywinrm
 any machine that can run Python.")
     (license license:expat)))
 
+(define-public python-manimpango
+  (package
+    (name "python-manimpango")
+    (version "0.5.0")
+    (source
+     (origin
+       ;; Test fixtures are not included in the PyPI tarball. We need the Github
+       ;; release to successfully run the tests.
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ManimCommunity/ManimPango")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "00mrvswk8yly0m13jq0f432pr19sy3j6w37lrv78ah1j6jz9n50h"))))
+    (build-system pyproject-build-system)
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (add-before 'check 'build-extensions
+                    (lambda _
+                      (invoke "python" "setup.py" "build_ext" "--inplace"))))))
+    (native-inputs (list pkg-config python-cython python-pytest
+                         python-pytest-cov))
+    (inputs (list pango))
+    (home-page "https://pypi.org/project/ManimPango/")
+    (synopsis "Bindings for Pango for using with Manim")
+    (description
+     "Python bindings for ManimPango which is a C binding for Pango,
+using Cython.
+
+ManimPango is internally used in Manim to render (non-LaTeX) text.")
+    (license license:expat)))
+
 (define-public python-xcffib
   (package
     (name "python-xcffib")

base-commit: d5298c5e334e56a9aabddcb62d312e63135864f6
-- 
2.40.1





Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Sat, 20 Jan 2024 21:43:01 GMT) Full text and rfc822 format available.

Notification sent to "Wamm K. D" <jaft.r <at> outlook.com>:
bug acknowledged by developer. (Sat, 20 Jan 2024 21:43:02 GMT) Full text and rfc822 format available.

Message #19 received at 64813-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 64813-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-manimpango.
Date: Sat, 20 Jan 2024 21:42:00 +0000
[Message part 1 (text/plain, inline)]
I've added Co-author-by Troy Figiel <troy <at> troyfigiel.com>, updated home-page to
https://manimpango.manim.community/, applied G-Expressions package style.

Pushed as 782d69fb7f88eeb5ea470f365d8ecbc761dfa1ff

Thanks,
Oleg
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Feb 2024 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 81 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.