Received: (at 64845) by debbugs.gnu.org; 25 Jul 2023 17:11:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 25 13:11:27 2023
Received: from localhost ([127.0.0.1]:46867 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qOLZH-0004Ps-A2
for submit <at> debbugs.gnu.org; Tue, 25 Jul 2023 13:11:27 -0400
Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:43998)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <vagrant@HIDDEN>) id 1qOLZD-0004Pd-5T
for 64845 <at> debbugs.gnu.org; Tue, 25 Jul 2023 13:11:25 -0400
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
(Authenticated sender: vagrant@HIDDEN)
by cascadia.aikidev.net (Postfix) with ESMTPSA id 8B7421AD32;
Tue, 25 Jul 2023 10:11:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org;
s=1.vagrant.user; t=1690305074;
bh=A3J5wUzcUQrW1uDWKqXj03fWZkedv1xj/Fw2R945Q3g=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=aJd+bnhI5l+RIGbaE4bx2prBpGimW3gK4yCYsglooUPBzLenf9Ym9rfx9ZqCC4r1B
rHrfBQkYuwAN9oQIv2pIswoTgd/awgOZjVJKVjX3UcK1wAPL9s66VLkKq7ihJkYISb
c+e/ig5V0J2UvZ9lm1HU6LF3FEO5WNbc9QQorqGS6thQlSHo1NrF7BBzzD9p7tw6QS
FTeQPRQzN+aLvY/jK9XqtASCZOximXKT3SPACWSCcn59FKypCmWkWpxlzPasaSXNe/
YF6+a495DmdkVaAGQtB02nCLXJE2tUMmavI1BuvgflOpqcZuInek3K0qOBn75gC8go
P14DyHko38Iag==
From: Vagrant Cascadian <vagrant@HIDDEN>
To: Zheng Junjie <873216071@HIDDEN>, 64845 <at> debbugs.gnu.org
Subject: Re: [bug#64845] [PATCH] gnu: fcode-utils: Fix cross-compilation.
In-Reply-To: <tencent_A089532DFC26692A4696DF9FA64E52B95106@HIDDEN>
References: <tencent_A089532DFC26692A4696DF9FA64E52B95106@HIDDEN>
Date: Tue, 25 Jul 2023 10:11:11 -0700
Message-ID: <87edkvgbm8.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 64845
Cc: Ludovic Court?s <ludo@HIDDEN>, Efraim Flashner <efraim@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 2023-07-25, Zheng Junjie wrote:
> * gnu/packages/firmware.scm (fcode-utils)
> [arguments]: add remove-makefile-strip phase.
> ---
> gnu/packages/firmware.scm | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
> index 35d3100ac6..01565ed18a 100644
> --- a/gnu/packages/firmware.scm
> +++ b/gnu/packages/firmware.scm
> @@ -9,6 +9,7 @@
> ;;; Copyright =C2=A9 2020, 2021, 2022 Marius Bakke <marius@HIDDEN>
> ;;; Copyright =C2=A9 2021 Petr Hodina <phodina@HIDDEN>
> ;;; Copyright =C2=A9 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN=
om>
> +;;; Copyright =C2=A9 2023 Zheng Junjie <873216071@HIDDEN>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -387,7 +388,14 @@ (define-public fcode-utils
> (string-append "DESTDIR=3D" #$output))
> #:phases
> #~(modify-phases %standard-phases
> - (delete 'configure)))) ; No configure script.
> + (delete 'configure) ; No configure script.
> + (add-after 'unpack 'remove-makefile-strip
> + (lambda _
> + (substitute* '("detok/Makefile"
> + "romheaders/Makefile"
> + "toke/Makefile")
> + (("\\$\\(STRIP\\).*")
> + "")))))))
Can you include a brief comment? That is a bit easier than rummaging
around through git history commit messages... :)
> (native-inputs
> (list tcsh))
> (home-page "https://www.openfirmware.info/FCODE_suite")
>
> base-commit: 76e041f9eef85bb039c5251d3350c62ee2066883
> --=20
> 2.41.0
live well,
vagrant
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZMACLwAKCRDcUY/If5cW
quDMAP900Wys15C654BbSUci6BFh4Kk6S2/naVI0xiwPkpvQ8QD+Mm9IyuEwsQ5M
IazJt4NDHNMf2riqIh636yGTp3gcZw0=
=/0jG
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#64845; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 25 Jul 2023 07:46:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 25 03:46:06 2023
Received: from localhost ([127.0.0.1]:44581 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qOCk7-0001km-SQ
for submit <at> debbugs.gnu.org; Tue, 25 Jul 2023 03:46:06 -0400
Received: from lists.gnu.org ([2001:470:142::17]:58754)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <873216071@HIDDEN>) id 1qOCk2-0001jv-DL
for submit <at> debbugs.gnu.org; Tue, 25 Jul 2023 03:46:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <873216071@HIDDEN>) id 1qOCjq-0002a9-MV
for guix-patches@HIDDEN; Tue, 25 Jul 2023 03:45:52 -0400
Received: from out203-205-221-210.mail.qq.com ([203.205.221.210])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <873216071@HIDDEN>) id 1qOCjk-0002EN-JZ
for guix-patches@HIDDEN; Tue, 25 Jul 2023 03:45:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512;
t=1690271124; bh=FkCJimj3rKroq8j0mwUDejtait+4nB92O8B0MUYGc7o=;
h=From:To:Subject:Date;
b=nXcYI651O4gTrm39F5gra3tXSx0r93ixwGuKwOJ63Nc3UgotC4vosjq3e+DX+/DlM
62yrXr5Fj7+nCOcTSTIMFVURqfz/2XWzwIXPvlILFykzGEE99KhZyKTBeA5IM115/s
i9fy1uxi9bm4LzjufQZ71Nyu+7JFTa0N+AAKutgA=
Received: from localhost.localdomain ([111.0.51.236])
by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP
id B56B06C5; Tue, 25 Jul 2023 15:45:22 +0800
X-QQ-mid: xmsmtpt1690271122tjncjbp9h
Message-ID: <tencent_A089532DFC26692A4696DF9FA64E52B95106@HIDDEN>
X-QQ-XMAILINFO: OZZSS56D9fAj5iyT2f+VspC199JnWbCfeh+/IB7ZSOGRSGESrc9k4B9KcBV4Ro
H7LT9ldLCcWeL0vA3Q6mZNpWgSKIQxfn4eQ48iFFjGvXndbzkWg2LN6SCC2QAUFBB/3lKWkO9IO6
DOAD6XkPn22c5HCyWiSo/FdYaDRrYuzliXs0sVPYhl9jBmZEJN4tELoqP1n+vMlKp8+8pQYajRkZ
TXFPyHce2nCdNm/LoIV1mu91KAH9wMykTq/4ONcBNyXvjaKcqhYLsEJOunpi31exwbHkkUo8UA5R
v7dcLsuFPN9IVOB0xSLzwAfw+/78DGzWAyxErfVGkF2jtZe736rCyGjgypbx1C8SdHla2KPbZUNK
vML53RwhVcVAx958SVTzxyH3vWvG+VGSpA6G98r05fixnaJcOCMEoxS30Sma+rcuVwKM8zEor28U
bmZMJrLOYAFYUOCXY2iebUssHzgQX1Jf7YevuM1Gvlbcd+8qEK+Ln6ak+ZnnDezDVlmJimEn/tG0
LNhzCOTma4jdfYanLB7sMzXGnZwTmVCJU+8L3/Kiu860Eg/KHhg+mF5lZvZCplcOYwjnt33j3yro
w7uQd0Of/DSzJsWY06H59i133CJE9IMAjRYTgbRu527gndfXeV/1ko0JMWkW9+uDu1q0jtLBUpgZ
fEV/tGFx3OB1cCBlM2XidT9m//azP/GHhXqew0A1eNQxXmzCtpjjlJyeSfik22S40uKduM9H0B07
F8uMb5ViVcR4vd9B7SznWQt8btzMmclTSEIS+vdbgQtZlEpHJxeavJ7EEJNEJUqeHd4aFiZT5P4p
10BIBtIaqqIH4KYmEfvs0ZW8VkELG+WMqS/dVQTIkxRLi3A7KGfmhPm2Xew/3PqnxD1Ok+IXyQAP
ccBdEbe2K1s+8G2XSTUsPFZ+inN1jgqiSpcQYNd7z13CKf6EN4hw9TxjOJP/Nv2YIJtrpu++CXld
wKhrlxjZvhdBVVAZF0U3sgJL39Ih87
X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg=
From: Zheng Junjie <873216071@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: fcode-utils: Fix cross-compilation.
Date: Tue, 25 Jul 2023 15:45:13 +0800
X-OQ-MSGID: <4ad10ff14c055b88994d92d3b84063a796e43f46.1690271113.git.873216071@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Efraim Flashner <efraim@HIDDEN>,
Ludovic Court?s <ludo@HIDDEN>, Vagrant Cascadian <vagrant@HIDDEN>
Content-Type: text/plain; charset=y
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=203.205.221.210; envelope-from=873216071@HIDDEN;
helo=out203-205-221-210.mail.qq.com
X-Spam_score_int: 11
X-Spam_score: 1.1
X-Spam_bar: +
X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25,
FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001,
RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: * gnu/packages/firmware.scm (fcode-utils) [arguments]: add
remove-makefile-strip phase. --- gnu/packages/firmware.scm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/firmware.scm
b/gnu/packages/firmware.scm index 35d3100ac6..01565ed18a 100644 --- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm @@ -9,6 +9,7 @@ ;;; Copyright © [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.9 SPF_FAIL SPF: sender does not match SPF record (fail)
[SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=873216071%40qq.com;ip=2001%3A470%3A142%3A%3A17;r=debbugs.gnu.org]
0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
in digit (873216071[at]qq.com)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (873216071[at]qq.com)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.0 SPOOFED_FREEMAIL No description available.
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
* gnu/packages/firmware.scm (fcode-utils)
[arguments]: add remove-makefile-strip phase.
---
gnu/packages/firmware.scm | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
index 35d3100ac6..01565ed18a 100644
--- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm
@@ -9,6 +9,7 @@
;;; Copyright © 2020, 2021, 2022 Marius Bakke <marius@HIDDEN>
;;; Copyright © 2021 Petr Hodina <phodina@HIDDEN>
;;; Copyright © 2022, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
+;;; Copyright © 2023 Zheng Junjie <873216071@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -387,7 +388,14 @@ (define-public fcode-utils
(string-append "DESTDIR=" #$output))
#:phases
#~(modify-phases %standard-phases
- (delete 'configure)))) ; No configure script.
+ (delete 'configure) ; No configure script.
+ (add-after 'unpack 'remove-makefile-strip
+ (lambda _
+ (substitute* '("detok/Makefile"
+ "romheaders/Makefile"
+ "toke/Makefile")
+ (("\\$\\(STRIP\\).*")
+ "")))))))
(native-inputs
(list tcsh))
(home-page "https://www.openfirmware.info/FCODE_suite")
base-commit: 76e041f9eef85bb039c5251d3350c62ee2066883
--
2.41.0
Zheng Junjie <873216071@HIDDEN>:efraim@HIDDEN, ludo@HIDDEN, vagrant@HIDDEN, guix-patches@HIDDEN.
Full text available.efraim@HIDDEN, ludo@HIDDEN, vagrant@HIDDEN, guix-patches@HIDDEN:bug#64845; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.