X-Loop: help-debbugs@HIDDEN Subject: bug#64914: [PATCH] * gdb-mi.el: allow disabling the gdb io buffer Resent-From: StrawberryTea <look@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 28 Jul 2023 07:12:03 +0000 Resent-Message-ID: <handler.64914.B.169052831229291 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 64914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 64914 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.169052831229291 (code B ref -1); Fri, 28 Jul 2023 07:12:03 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jul 2023 07:11:52 +0000 Received: from localhost ([127.0.0.1]:43545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qPHdf-0007cH-JV for submit <at> debbugs.gnu.org; Fri, 28 Jul 2023 03:11:51 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <look@HIDDEN>) id 1qPCBE-0006Uk-Vq for submit <at> debbugs.gnu.org; Thu, 27 Jul 2023 21:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <look@HIDDEN>) id 1qPCB9-0005zk-KE for bug-gnu-emacs@HIDDEN; Thu, 27 Jul 2023 21:22:03 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <look@HIDDEN>) id 1qPCB8-0006YK-2G for bug-gnu-emacs@HIDDEN; Thu, 27 Jul 2023 21:22:03 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D03CC32000E5 for <bug-gnu-emacs@HIDDEN>; Thu, 27 Jul 2023 21:22:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 27 Jul 2023 21:22:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= strawberrytea.xyz; h=cc:content-type:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm1; t=1690507320; x=1690593720; bh=e+ U6Fu3BsmWr8aIQrEJvmtPq6W0CT3nS/XTH9tMiXEE=; b=Rc+8/8yxdyW8d2eRmH i2oyupsQ+HZntZwExBahAsqjhOSCiRl5h0Q4tFh60fzXB0efzgB46P3VChNbRVML A+3HBC4lvHrggth7oFKnnxIcpzK6Z7DKq6o+frXzpmuUa0HjojtYGp1rPfrNBTZS 2RBsytUoBkkeS8v/N8/sz4HYR2+VQz8/6QZRI+PrvpZDwwTQNlzdI4sFWL9Rngyr vs4GCWfwaNXO4qQFg/V70auFPm2zgCm9bJZDPKEiKDKYOdxU0MB+3S2CvNpPA2Na ZMc68mcv3oUjJKDw9+yuz8fsApwsP/cUveofy1ubtumKdNtRw9go+JfCiqYF+ni2 FywA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690507320; x=1690593720; bh=e+U6Fu3BsmWr8aIQrEJvmtPq6W0CT3nS/XT H9tMiXEE=; b=KU22eHjn0ETVL0t4zVaLqfOAhKIw/cwzB+1sq72ggEbpndgkSVH B3o6fK9nuRDUkrBQRdL29/Jh0tM7+2k7/QYOx6VJsLVfYidwUUNDxivwt3JKJ52N 0meB1R7r6rb/Von0DvXTSv343g0QxhFqVf6fi5iGaTtYCd9TKnfzckjaE80ULKGU UAMu9lIM0C7sD2JvhbIgQS3g5gW0B8CFyeOnPRC2I/GOPNRueEXSSXHTE32whefp xhgjkLU82jjS2m8MsijB+t+mOrA697LbsinbnXAmUIgatTQ8qPvlzVvz1oB4bROA SGHw/KQz48lMtu3X63MpQ5bJ21CQuG/VYLw== X-ME-Sender: <xms:OBjDZBzyAN-FMjyp7xK0YWO49MfbtIWCu1bR-Dh_3p0lMItzSeW1og> <xme:OBjDZBRaso6yr3e-Fd0RMDOX4d-eBoNHiUvbm_U3xVZaisfqlc93pGOvB41fvcnVv PRC9HeOUabtHmazOJA> X-ME-Received: <xmr:OBjDZLWqrljUcvDJ0zUnJ8CXei-YdDlFVD4ktP8UAXaza5LC3bOVhWlNqns> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieehgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhephffvuf ffkfggtgesthdtredttddttdenucfhrhhomhepufhtrhgrfigsvghrrhihvfgvrgcuoehl ohhokhesshhtrhgrfigsvghrrhihthgvrgdrgiihiieqnecuggftrfgrthhtvghrnheptd fgueffhffhgffhjefghedvheefkeefheekfeeiveegveegfeevudeuhfehleffnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhhoohhksehsth hrrgifsggvrhhrhihtvggrrdighiii X-ME-Proxy: <xmx:OBjDZDi5fElgv6a03JMwd6kun2zGpqvtRY4m-MPhahr_f8DoQGnhow> <xmx:OBjDZDDxZuQ8cnE76c895Qk33bAcwJ3koPPo8NK0HQRMd1frHQMg3g> <xmx:OBjDZMJtrDWX_5Guh150z4OV0p8UA0aaBIibgy-Umx2OXTpseh7DNQ> <xmx:OBjDZG87mAtfaMX5nZVRe6wwEZZ8gRIpP4JDMPk42eKLvM32MkLcwA> Feedback-ID: id85149b6:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <bug-gnu-emacs@HIDDEN>; Thu, 27 Jul 2023 21:21:59 -0400 (EDT) From: StrawberryTea <look@HIDDEN> Date: Thu, 27 Jul 2023 20:33:39 -0400 Message-ID: <v8e4x22w.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.21; envelope-from=look@HIDDEN; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM28=0.799, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Mailman-Approved-At: Fri, 28 Jul 2023 03:11:46 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.4 (/) This change allows the user to disable the `gdb-inferior-io' buffer. This is useful for users that prefer a more classical gdb experience where you just have the GDB window and the source window. --- lisp/progmodes/gdb-mi.el | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el index a1091de43e9..0d6d7ab02c0 100644 --- a/lisp/progmodes/gdb-mi.el +++ b/lisp/progmodes/gdb-mi.el @@ -1098,9 +1098,10 @@ detailed description of this mode. (if gdb-debuginfod-enable "on" "off")) 'gdb-debuginfod-message) - (gdb-get-buffer-create 'gdb-inferior-io) - (gdb-clear-inferior-io) - (gdb-inferior-io--init-proc (get-process "gdb-inferior")) + (when gdb-display-io-buffer + (gdb-get-buffer-create 'gdb-inferior-io) + (gdb-clear-inferior-io) + (gdb-inferior-io--init-proc (get-process "gdb-inferior"))) (when (eq system-type 'windows-nt) ;; Don't create a separate console window for the debuggee. @@ -1828,6 +1829,13 @@ this trigger is subscribed to `gdb-buf-publisher' and called with :group 'gdb :version "25.1") +(defcustom gdb-display-io-buffer t + "When non-nil, display the `gdb-inferior-io' buffer. Otherwise, +send program output to the GDB buffer." + :type 'boolean + :group 'gdb + :version "30.1") + (defun gdb-inferior-filter (proc string) (unless (string-equal string "") (let (buf) -- 2.41.0
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: StrawberryTea <look@HIDDEN> Subject: bug#64914: Acknowledgement ([PATCH] * gdb-mi.el: allow disabling the gdb io buffer) Message-ID: <handler.64914.B.169052831229291.ack <at> debbugs.gnu.org> References: <v8e4x22w.fsf@HIDDEN> X-Gnu-PR-Message: ack 64914 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 64914 <at> debbugs.gnu.org Date: Fri, 28 Jul 2023 07:12:03 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 64914 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 64914: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64914 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#64914: [PATCH] * gdb-mi.el: allow disabling the gdb io buffer Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 28 Jul 2023 11:17:01 +0000 Resent-Message-ID: <handler.64914.B64914.16905429771088 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 64914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: StrawberryTea <look@HIDDEN> Cc: 64914 <at> debbugs.gnu.org Received: via spool by 64914-submit <at> debbugs.gnu.org id=B64914.16905429771088 (code B ref 64914); Fri, 28 Jul 2023 11:17:01 +0000 Received: (at 64914) by debbugs.gnu.org; 28 Jul 2023 11:16:17 +0000 Received: from localhost ([127.0.0.1]:43891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qPLSD-0000HT-BJ for submit <at> debbugs.gnu.org; Fri, 28 Jul 2023 07:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qPLSA-0000HH-Jn for 64914 <at> debbugs.gnu.org; Fri, 28 Jul 2023 07:16:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qPLS5-0001Zm-7O; Fri, 28 Jul 2023 07:16:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ogwe9dlKlNmfG7kp5ULOkgLmY1b9iDP9u4Jec1+H23w=; b=e58yBahqsMwD AFSO+0v8UeUH5V7FfESqyC4wFTGqx2BCrzt65ubszC9yR3y2ct/+hdRQ3ErFVYYxjx8ZkwD2OWGV5 DgoXUdL3S7yWJNkyb6VAMhKkfzHtLetwpnCAl34/KewDdbRceXxDFLn0faCGEOACTuDW5wLhDH+NB qSn6xn0FIP6F7zVzy6Lb4sRTn1H+d9YQgFHGUoKYYtRHoTe9/slEMpT2ek7ZmZgg1r9aAQbkbcEo2 vzaaDtteTXk1ZCCjxSBaN2iXkJzHp6ejHLusBSqFWt8znJ0VcycXJwsl/VW8vsoCycaB64ElyYQza RBw36KWKJheXdspb/mKK2g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qPLS4-0001FQ-1Z; Fri, 28 Jul 2023 07:16:08 -0400 Date: Fri, 28 Jul 2023 14:17:00 +0300 Message-Id: <83mszgjnf7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <v8e4x22w.fsf@HIDDEN> (message from StrawberryTea on Thu, 27 Jul 2023 20:33:39 -0400) References: <v8e4x22w.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: StrawberryTea <look@HIDDEN> > Date: Thu, 27 Jul 2023 20:33:39 -0400 > > This change allows the user to disable the `gdb-inferior-io' buffer. > This is useful for users that prefer a more classical gdb experience > where you just have the GDB window and the source window. Sorry, I don't think I understand why you need a new defcustom. Doesn't setting gdb-display-io-nopopup non-nil already achieve what you want? It does here. Thanks.
Received: (at control) by debbugs.gnu.org; 28 Jul 2023 11:18:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 28 07:18:19 2023 Received: from localhost ([127.0.0.1]:43898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qPLUB-0000Kg-8R for submit <at> debbugs.gnu.org; Fri, 28 Jul 2023 07:18:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qPLU6-0000KD-Fa; Fri, 28 Jul 2023 07:18:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qPLU1-00025U-8x; Fri, 28 Jul 2023 07:18:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yEO+FbIWV8/VH4zGlBpRnETc8G0FGK6emSqeTe/g958=; b=qV0XzCSggrAd 2Tl/C37GZvvKbsMCMETyVzFFRdRZRcz2PkPI4p0sRVc73jMejGjTY/jUnQEdmfAO4Wc39a5jQDiZM KNdEOXfNxs4cYAueUZdRHAb0Sxfp5eiF9PEErv84oyNtcLhEWIAaBJBVKvAxEYPtOgEtz4Ijmq4k7 DwjwhM+y3Ly0y5hbeKSfaBrhdtHpXFspohfLYQXhqeMNNGZByMvEKZ3jOoTUovzRv5mFCLhGBqnxH LHXOUHRCzjCSQyiqj2BD6Q9nhy4sw1KsdbsCJAtKto73DSJzSDQEO6zQFzyzKdR5yytx45CdzDe7g 5k/s9MBVp1k0a151OpKUAw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qPLU0-0001XB-A7; Fri, 28 Jul 2023 07:18:09 -0400 Date: Fri, 28 Jul 2023 14:19:00 +0300 Message-Id: <83lef0jnbv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: StrawberryTea <look@HIDDEN> In-Reply-To: <wmykx28e.fsf@HIDDEN> (message from StrawberryTea on Thu, 27 Jul 2023 20:33:39 -0400) Subject: Re: bug#64913: [PATCH] * gdb-mi.el: allow disabling the gdb io buffer References: <wmykx28e.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 64913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) merge 64913 64914 thanks > From: StrawberryTea <look@HIDDEN> > Date: Thu, 27 Jul 2023 20:33:39 -0400 > > This change allows the user to disable the `gdb-inferior-io' buffer. > This is useful for users that prefer a more classical gdb experience > where you just have the GDB window and the source window. Looks like you submitted the same bug report twice... My response here is the same: I think gdb-display-io-nopopup already can handle this situation.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.