GNU bug report logs - #64933
[PATCH] gnu: Add dexy-color-sddm-theme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64933 in the body.
You can then email your comments to 64933 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: guix-patches <at> gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH] gnu: Add dexy-color-sddm-theme.
Date: Sat, 29 Jul 2023 15:02:32 +0200

* gnu/packages/display-managers.scm (dexy-color-sddm-theme): New variable.
---
 gnu/packages/display-managers.scm | 35 +++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index f6c9283a29..dcfa3bcf3f 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -142,6 +142,41 @@ (define-public sddm
     ;; QML files are MIT licensed and images are CC BY 3.0.
     (license (list license:gpl2+ license:expat license:cc-by3.0))))
 
+(define-public dexy-color-sddm-theme
+  (let ((commit "7929384dbb9305e6da53a8942bca3d75593fd99f")
+        (revision "0"))
+    (package
+      (name "dexy-color-sddm-theme")
+      (version (git-version "0.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/L4ki/Dexy-Plasma-Themes")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1dcp3pvs6x63740sz852yr19fjrdnh81dbrq7rssgm6ssi1rqjig"))))
+      (build-system trivial-build-system)
+      (arguments
+       `(#:modules ((guix build utils))
+         #:builder (begin
+                     (use-modules (guix build utils))
+                     (let* ((out (assoc-ref %outputs "out"))
+                            (sddm-themes (string-append out
+                                                        "/share/sddm/themes")))
+                       (mkdir-p sddm-themes)
+                       (copy-recursively (string-append (assoc-ref
+                                                         %build-inputs
+                                                         "source")
+                                                        "/Dexy-Color-SDDM")
+                                         (string-append sddm-themes
+                                                        "/dexy-color"))))))
+      (home-page "https://github.com/L4ki/Dexy-Plasma-Themes")
+      (synopsis "Dexy Color theme for SDDM")
+      (description "Dexy-Color-SDDM is part of KDE Themes and Extensions.")
+      (license license:gpl3+))))
+
 (define-public guix-simplyblack-sddm-theme
   (package
     (name "guix-simplyblack-sddm-theme")

base-commit: e43cbeafd1b632f39b08b3644af5230d5350a656
-- 
2.39.2

Message #8 received at 64933 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Cc: 64933 <at> debbugs.gnu.org
Subject: Re: bug#64933: [PATCH] gnu: Add dexy-color-sddm-theme.
Date: Sun, 17 Sep 2023 15:13:54 +0200

Hi,

And apologies for the late reply.

Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es> skribis:

> * gnu/packages/display-managers.scm (dexy-color-sddm-theme): New variable.

[...]

> +      (build-system trivial-build-system)
> +      (arguments
> +       `(#:modules ((guix build utils))
> +         #:builder (begin
> +                     (use-modules (guix build utils))
> +                     (let* ((out (assoc-ref %outputs "out"))
> +                            (sddm-themes (string-append out
> +                                                        "/share/sddm/themes")))
> +                       (mkdir-p sddm-themes)
> +                       (copy-recursively (string-append (assoc-ref
> +                                                         %build-inputs
> +                                                         "source")
> +                                                        "/Dexy-Color-SDDM")
> +                                         (string-append sddm-themes
> +                                                        "/dexy-color"))))))

Could you consider writing it using ‘copy-build-system’?  It should lead
to a more concise definition.

> +      (home-page "https://github.com/L4ki/Dexy-Plasma-Themes")
> +      (synopsis "Dexy Color theme for SDDM")
> +      (description "Dexy-Color-SDDM is part of KDE Themes and Extensions.")

It would be great if you could add a sentence saying what the package
provides (think about someone running ‘guix search’ and not knowing
which package might provide the thing).

Could you send an updated patch?

Thanks in advance,
Ludo’.

Message #11 received at 64933 <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: ludo <at> gnu.org
Cc: 64933 <at> debbugs.gnu.org,
 Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH v2] gnu: Add dexy-color-sddm-theme.
Date: Wed, 20 Sep 2023 23:27:50 +0200

* gnu/packages/display-managers.scm (dexy-color-sddm-theme): New variable.
---
 gnu/packages/display-managers.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index 327a29aa9e..ef9826c0f7 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -142,6 +142,32 @@ (define-public sddm
     ;; QML files are MIT licensed and images are CC BY 3.0.
     (license (list license:gpl2+ license:expat license:cc-by3.0))))
 
+(define-public dexy-color-sddm-theme
+  (let ((commit "7929384dbb9305e6da53a8942bca3d75593fd99f")
+        (revision "0"))
+    (package
+      (name "dexy-color-sddm-theme")
+      (version (git-version "0.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/L4ki/Dexy-Plasma-Themes")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1dcp3pvs6x63740sz852yr19fjrdnh81dbrq7rssgm6ssi1rqjig"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:install-plan '(("Dexy-Color-SDDM"
+                           "/share/sddm/themes/dexy-color-sddm"))))
+      (home-page "https://github.com/L4ki/Dexy-Plasma-Themes")
+      (synopsis "Dexy Color theme for SDDM")
+      (description
+       "This package provides a minimalistic and modern SDDM theme with blured
+background.")
+      (license license:gpl3+))))
+
 (define-public guix-simplyblack-sddm-theme
   (package
     (name "guix-simplyblack-sddm-theme")

base-commit: 4bdb8bd2674c2b630626be43a5cd3c2b65401b52
-- 
2.41.0

Message #16 received at 64933-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Cc: 64933-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add dexy-color-sddm-theme.
Date: Sat, 14 Oct 2023 17:32:58 +0200

Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es> skribis:

> * gnu/packages/display-managers.scm (dexy-color-sddm-theme): New variable.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.