GNU bug report logs - #64961
[PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64961 in the body.
You can then email your comments to 64961 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
Date: Sun, 30 Jul 2023 19:51:03 +0200

* gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
---
 gnu/packages/emacs-xyz.scm | 60 ++++++++++++++++++++------------------
 1 file changed, 31 insertions(+), 29 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e8d1ac6034..0bd4ff93bc 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32420,35 +32420,37 @@ (define-public emacs-wc-mode
     (license license:gpl3+)))
 
 (define-public emacs-mastodon
-  (package
-    (name "emacs-mastodon")
-    (version "1.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://codeberg.org/martianh/mastodon.el")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "13swcbvwhjl8ksrgzvmfafkgd3iz8znk49bs1n48w3g9qvh097w7"))))
-    (build-system emacs-build-system)
-    (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               ;; Move the source files to the top level, which is included in
-               ;; the EMACSLOADPATH.
-               (add-after 'unpack 'move-source-files
-                 (lambda _
-                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
-                     (for-each (lambda (f)
-                                 (rename-file f (basename f)))
-                               el-files)))))))
-    (propagated-inputs
-     (list emacs-request))
-    (home-page "https://codeberg.org/martianh/mastodon.el")
-    (synopsis "Emacs client for Mastodon")
-    (description "@code{mastodon.el} is an Emacs client for Mastodon, the
+  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
+        (revision "1"))
+    (package
+      (name "emacs-mastodon")
+      (version (git-version "1.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://codeberg.org/martianh/mastodon.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "15cfjny99yw5frdp8nlyazlwgscvfvbinsj0fbdfprxf50k2zjs6"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list #:phases
+             #~(modify-phases %standard-phases
+                 ;; Move the source files to the top level, which is included in
+                 ;; the EMACSLOADPATH.
+                 (add-after 'unpack 'move-source-files
+                   (lambda _
+                     (let ((el-files (find-files "./lisp" ".*\\.el$")))
+                       (for-each (lambda (f)
+                                   (rename-file f (basename f)))
+                                 el-files)))))))
+      (propagated-inputs
+       (list emacs-request emacs-ts emacs-persist))
+      (home-page "https://codeberg.org/martianh/mastodon.el")
+      (synopsis "Emacs client for Mastodon")
+      (description "@code{mastodon.el} is an Emacs client for Mastodon, the
 federated microblogging social network.")
     (license license:gpl3+)))
 

base-commit: c173819c8e5235ce02d60b79bd88b10023a7c614
-- 
2.41.0

Message #8 received at 64961 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 64961 <at> debbugs.gnu.org
Subject: Re: bug#64961: [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
Date: Sun, 20 Aug 2023 23:20:52 +0200

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.

[...]

> +  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
> +        (revision "1"))
> +    (package
> +      (name "emacs-mastodon")
> +      (version (git-version "1.0.0" revision commit))

Normally we only package releases, unless there’s a good reason to grab
a snapshot, in which case there should be a comment explaining it.

What’s the situation here?

> +      (synopsis "Emacs client for Mastodon")
> +      (description "@code{mastodon.el} is an Emacs client for Mastodon, the
>  federated microblogging social network.")
>      (license license:gpl3+)))

There’s a missing paren here, which made qa.guix unhappy:

  https://qa.guix.gnu.org/issue/64961

:-)

Thanks,
Ludo’.

Message #11 received at 64961 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 64961 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
Date: Mon, 21 Aug 2023 09:46:34 +0200

* gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
---
 gnu/packages/emacs-xyz.scm | 62 ++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e8d1ac6034..192f697efb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32420,37 +32420,39 @@ (define-public emacs-wc-mode
     (license license:gpl3+)))
 
 (define-public emacs-mastodon
-  (package
-    (name "emacs-mastodon")
-    (version "1.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://codeberg.org/martianh/mastodon.el")
-                    (commit version)))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "13swcbvwhjl8ksrgzvmfafkgd3iz8znk49bs1n48w3g9qvh097w7"))))
-    (build-system emacs-build-system)
-    (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               ;; Move the source files to the top level, which is included in
-               ;; the EMACSLOADPATH.
-               (add-after 'unpack 'move-source-files
-                 (lambda _
-                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
-                     (for-each (lambda (f)
-                                 (rename-file f (basename f)))
-                               el-files)))))))
-    (propagated-inputs
-     (list emacs-request))
-    (home-page "https://codeberg.org/martianh/mastodon.el")
-    (synopsis "Emacs client for Mastodon")
-    (description "@code{mastodon.el} is an Emacs client for Mastodon, the
+  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
+        (revision "1"))
+    (package
+      (name "emacs-mastodon")
+      (version (git-version "1.0.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://codeberg.org/martianh/mastodon.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "15cfjny99yw5frdp8nlyazlwgscvfvbinsj0fbdfprxf50k2zjs6"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list #:phases
+             #~(modify-phases %standard-phases
+                 ;; Move the source files to the top level, which is included in
+                 ;; the EMACSLOADPATH.
+                 (add-after 'unpack 'move-source-files
+                   (lambda _
+                     (let ((el-files (find-files "./lisp" ".*\\.el$")))
+                       (for-each (lambda (f)
+                                   (rename-file f (basename f)))
+                                 el-files)))))))
+      (propagated-inputs
+       (list emacs-request emacs-ts emacs-persist))
+      (home-page "https://codeberg.org/martianh/mastodon.el")
+      (synopsis "Emacs client for Mastodon")
+      (description "@code{mastodon.el} is an Emacs client for Mastodon, the
 federated microblogging social network.")
-    (license license:gpl3+)))
+	  (license license:gpl3+))))
 
 (define-public emacs-ebdb
   (package

base-commit: c173819c8e5235ce02d60b79bd88b10023a7c614
-- 
2.41.0

Message #14 received at 64961 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 64961 <at> debbugs.gnu.org
Subject: Re: bug#64961: [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
Date: Mon, 21 Aug 2023 10:01:08 +0200

>dim. 20 août 2023 at 23:20, Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Cayetano,
>
> Cayetano Santos <csantosb <at> inventati.org> skribis:
>
>> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
>
> [...]
>
>> +  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-mastodon")
>> +      (version (git-version "1.0.0" revision commit))
>
> Normally we only package releases, unless there’s a good reason to grab
> a snapshot, in which case there should be a comment explaining it.
>
> What’s the situation here?

Nothing special here, other than the fact that latest stable is from
more than one year ago.

In my opinion, we should debate this question once for ever in a broader
discussion about emacs packages (guix-devel?): what do we package ?
only stables (obsolete packages, see emacs-org-ref) ? always master (we
run after latest commit) ? something in between (current situation) ?

As for now, it is stated that we privilege releases ... except that
emacs-xyz is full of snapshots, and for a good reason (case of magit,
etc.), probably due to releases being too old (author just forgets
releasing).

(By the way. Similar debate comes to using melpa or melpa-stable)

What do you think ?

Cayetano

Message #19 received at 64961 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 64961 <at> debbugs.gnu.org
Subject: Re: bug#64961: [PATCH] gnu: emacs-mastodon: Update to 1.0.0-1.20dec88.
Date: Mon, 11 Sep 2023 23:54:06 +0200

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> skribis:

>>dim. 20 août 2023 at 23:20, Ludovic Courtès <ludo <at> gnu.org> wrote:
>
>> Hi Cayetano,
>>
>> Cayetano Santos <csantosb <at> inventati.org> skribis:
>>
>>> * gnu/packages/emacs-xyz.scm (emacs-mastodon): Update to 1.0.0-1.20dec88.
>>
>> [...]
>>
>>> +  (let ((commit "20dec8871c9bb5f5e418bfc197e7533b5e3065e3")
>>> +        (revision "1"))
>>> +    (package
>>> +      (name "emacs-mastodon")
>>> +      (version (git-version "1.0.0" revision commit))
>>
>> Normally we only package releases, unless there’s a good reason to grab
>> a snapshot, in which case there should be a comment explaining it.
>>
>> What’s the situation here?
>
> Nothing special here, other than the fact that latest stable is from
> more than one year ago.

OK.  I went ahead and applied the patch (there’s not a lot at stake in
this case anyway).

> In my opinion, we should debate this question once for ever in a broader
> discussion about emacs packages (guix-devel?): what do we package ?
> only stables (obsolete packages, see emacs-org-ref) ? always master (we
> run after latest commit) ? something in between (current situation) ?

The question’s not really up for debate in that the policy is to choose
releases, unless there’s a good reason not to do so.  But…

> As for now, it is stated that we privilege releases ... except that
> emacs-xyz is full of snapshots, and for a good reason (case of magit,
> etc.), probably due to releases being too old (author just forgets
> releasing).

… you’re right of course.  The situation of Emacs packages is a bit
special I guess, and it would be worth clarifying that somehow.  Please
feel free to launch the discussion on guix-devel!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.