Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 13:05:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 08 09:05:15 2023 Received: from localhost ([127.0.0.1]:35557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qTMOh-00086e-FN for submit <at> debbugs.gnu.org; Tue, 08 Aug 2023 09:05:15 -0400 Received: from mail18c50.megamailservers.eu ([91.136.10.28]:51534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1qTMOf-00086T-3f for 65030 <at> debbugs.gnu.org; Tue, 08 Aug 2023 09:05:14 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1691499910; bh=lhxv5XCHLq4jud5SGGJyuMoPo2JtFizsSD6teF09HoA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=O2kFiTi4MfTD9meBKZ9iSwcIJsRamTpxnGurrkukrrHEydy0lESx9bi3d19yHtyKE 2eOLmr14Xyj/FKTwjQRt52gYebCxzsk+PqRYZvf5npwk+KidEpZdbJB02+qF/woYMh dww0ePSPDGIim4oUb5eiDMGCwF/od+zJIFKs3F5o= Feedback-ID: mattiase@HIDDEN Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 378D57JG076993; Tue, 8 Aug 2023 13:05:09 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <83350tohjg.fsf@HIDDEN> Date: Tue, 8 Aug 2023 15:05:06 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <CAA10E02-8097-4BC6-8E89-1FC21C885C15@HIDDEN> References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN> <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN> <D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN> <87sf8tapbf.fsf@HIDDEN> <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN> <83350tohjg.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrledvgdehlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpeevkeffudejhfekhedvgfffieekgffhfedvkeeuffelgeefkeeulefhjeeifeekgfenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeehpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpdhrtghpthhtohepvghllhgvrhdrhhgvlhhmuhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepieehtdeftdesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 65030 Cc: rpluim@HIDDEN, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) 8 aug. 2023 kl. 14.16 skrev Eli Zaretskii <eliz@HIDDEN>: > Misspelled arguments to make-process don't elicit errors as of now, do > they? No and that would be good to fix as well, but we should first make = existing errors understandable. For example, (wrong-type-argument stringp nil) is not a human-readable = way to say "You forgot the :name parameter which is actually mandatory = despite the docs making this almost impossible to find out"
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 12:16:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 08 08:16:40 2023 Received: from localhost ([127.0.0.1]:35404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qTLdf-00040P-NY for submit <at> debbugs.gnu.org; Tue, 08 Aug 2023 08:16:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qTLdd-000407-Rm for 65030 <at> debbugs.gnu.org; Tue, 08 Aug 2023 08:16:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qTLdX-0006HO-LY; Tue, 08 Aug 2023 08:16:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tzMM1wx6EW4XL+lzuRa0IIjK8/6xWFi5nULUJOiC5eM=; b=BEldVfsHdTLzzeQS9HRW G+rspIpYCWFfAGNWOr6T81yTSFu3mG9dHNw/L7G+bdv2z6z7cKWkhbGzO83583fQpMdsHp5SYeYCV xwqAZDRMCT74r9nNDgcEsCB/NVwjqm6jfmAXJtou8VFkv0ei2RpCZVww/sybpHdwiyMTGAPYSaMeK Wb5v8xsBeASA4Hvh6U+3EbFbRJp2qUwsz27AX3QgqTBYIFaEDQWo0INPWH/zFBnfeyO7ce682vlrs 6kjqF2rxV34TGtR9ZULzsSe8r0CYbZ0TK7DNDAOraKgY71Opyr3biRMmnVE1OIP5FSPITebeVZilX CDSRB1jEnWM+OA==; Date: Tue, 08 Aug 2023 15:16:51 +0300 Message-Id: <83350tohjg.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 8 Aug 2023 11:16:07 +0200) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN> <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN> <D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN> <87sf8tapbf.fsf@HIDDEN> <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65030 Cc: rpluim@HIDDEN, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattiase@HIDDEN> > Date: Tue, 8 Aug 2023 11:16:07 +0200 > Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, > eller.helmut@HIDDEN, 65030 <at> debbugs.gnu.org > > > Mattias> The main objection is that `make-process`, due to its design, is often > > Mattias> called indirectly using `apply` which would not trigger the > > Mattias> application of this compiler macro, so perhaps we should improve the > > Mattias> error handling of Fmake_process instead. > > > > As long as that improvement results in warnings for mistakes such as > > misspelled keywords, rather than errors. > > Of course not. Incorrect arguments detected at run-time should elicit errors, as they do now. > The point being that for something as complex as make-process they should be more helpful than just `wrong-type-argument`. Misspelled arguments to make-process don't elicit errors as of now, do they?
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 09:42:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 08 05:42:26 2023 Received: from localhost ([127.0.0.1]:35217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qTJEQ-0005MB-FC for submit <at> debbugs.gnu.org; Tue, 08 Aug 2023 05:42:26 -0400 Received: from mail212c50.megamailservers.eu ([91.136.10.222]:50974 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1qTJEL-0005Lz-QK for 65030 <at> debbugs.gnu.org; Tue, 08 Aug 2023 05:42:25 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1691487739; bh=2EHKdgQMYix2qs4mt7TaHNOf9bDxDFtmN+Dn4auwhCU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Qs8i/1G3icjzHvAqmjnq+A4tE/w9V/RNhG9D0eFvqP/Nu27/8YdrkOF2SYPn8ekVP FAF4DEBEkPETog85daYWf+w2mVRKRZsRP+LJ7mvuAAyuD5A+7iX0XgRForImpd9gHU kEqUEVTyx/5zYAx/2ktXEn0dir7kUx/IMx0jzPpg= Feedback-ID: mattiase@HIDDEN Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3789gGAm012042; Tue, 8 Aug 2023 09:42:18 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <87jzu5anpa.fsf@HIDDEN> Date: Tue, 8 Aug 2023 11:42:16 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <DFFD8575-17FF-4CFB-B333-66FA2AD42F9B@HIDDEN> References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN> <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN> <D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN> <87sf8tapbf.fsf@HIDDEN> <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN> <87jzu5anpa.fsf@HIDDEN> To: Robert Pluim <rpluim@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrledvgddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpeevkeffudejhfekhedvgfffieekgffhfedvkeeuffelgeefkeeulefhjeeifeekgfenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeehpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpdhrtghpthhtohepvghllhgvrhdrhhgvlhhmuhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepieehtdeftdesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 65030 Cc: Eli Zaretskii <eliz@HIDDEN>, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) 8 aug. 2023 kl. 11.27 skrev Robert Pluim <rpluim@HIDDEN>: > You want to transform working code that passes ':coding-system' to > `make-process' into code that signals an error? That's probably a good idea (unless we are talking about a specific = keyword that has to be ignored for compatibility), but I think we should = start by improving existing errors. However it should not preclude compile-time warnings of the kind = proposed in the patch, which again can be applied more or less as-is.
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.
Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 09:27:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 08 05:27:41 2023
Received: from localhost ([127.0.0.1]:35202 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qTJ09-0004zA-3t
for submit <at> debbugs.gnu.org; Tue, 08 Aug 2023 05:27:41 -0400
Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:61582)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rpluim@HIDDEN>) id 1qTJ05-0004yw-TZ
for 65030 <at> debbugs.gnu.org; Tue, 08 Aug 2023 05:27:39 -0400
Received: by mail-wr1-x42c.google.com with SMTP id
ffacd0b85a97d-3090d3e9c92so4657475f8f.2
for <65030 <at> debbugs.gnu.org>; Tue, 08 Aug 2023 02:27:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1691486851; x=1692091651;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=CW5Xrgj9U4B5fkExM+H5/eR5dh/7aFpBjo/wlQXs2A8=;
b=P0hVzsyuwn46b8tB17LU39YWOvShUA/V7uwpt5nStnwIcSK68g4jfXVgSvuHYM8YgL
1oaWnNZGJ+7C2aov8iC65+C2yjt2YiZ9Io5qvX/7y6nLNCHSa7ZOIAT4d7fppAakl6Yz
FQhvq0bMJ0bUB1b2wGU53mPUmvBOxDkl1Rsu9rVU9maSd3krpVRokjBmXo/PNsP7Jrpm
iGWPpKqi4MghMZyHeQlH1HVK71byxil1YuKmxaaSETEwv/FuumkJQVn6dSUV1azirD/X
xQVINzqhQHMM2NN99NQ+k8ENlk43euDwHtka0/SK9fwWhm2y/1g6nJPS/UAFCaUtxklS
lETg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1691486851; x=1692091651;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=CW5Xrgj9U4B5fkExM+H5/eR5dh/7aFpBjo/wlQXs2A8=;
b=l1Uh5llaQvoXBXjt545y5HUVQHM1PrifVU2aTfNefLJN9BgdWEmnu6T23OYZqXvR2m
p7ZY5NKRLh0ote8iXb8w+9EsNDbhe88sHnaj5q5ChlTNafYsvKrclrkvB0vqSCcqB984
6XvVynSjLRSmG01HXEGwzre49PcPQxT2d59wWuggZ/Ro5KKdwpRHLjvB5RkKdP6QMlXy
thtKpr43PGHDKgubvkUlGBTV4N0svh0wpNPZFxBN3rH5OgIr+J1tUU0ZfMNhq5YmV+ji
eGjzro37R7brMcXW4fI/N5So4wXBNx0MfvX6Pz5GKlbV3dRHLIwa5ms+fRES/Fy6aePc
8mYQ==
X-Gm-Message-State: AOJu0Yx+7wDfKPUZvzSCy3XZzlyhbpzOfwARQkogiatYtc7csfglwSFB
uflHx+abEQzAh58rZNnGwoI4IJeo2nc=
X-Google-Smtp-Source: AGHT+IG7U9HzaxIuJdmF+ESLgHriZFuHIThDDtt2HSMBoEUrvVaUMlo56ddTDhR/KdETeqOCFLCR8g==
X-Received: by 2002:a5d:4e0f:0:b0:317:6513:da7e with SMTP id
p15-20020a5d4e0f000000b003176513da7emr8801354wrt.36.1691486850703;
Tue, 08 Aug 2023 02:27:30 -0700 (PDT)
Received: from rltb ([2a01:e0a:3f3:fb50:602c:69f4:ec01:92cc])
by smtp.gmail.com with ESMTPSA id
l18-20020a5d5612000000b00317e9c05d35sm6058021wrv.85.2023.08.08.02.27.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 08 Aug 2023 02:27:30 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>
Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process
In-Reply-To: <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 8 Aug 2023 11:16:07
+0200")
References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN>
<jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN>
<D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN>
<87sf8tapbf.fsf@HIDDEN>
<0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN>
Date: Tue, 08 Aug 2023 11:27:29 +0200
Message-ID: <87jzu5anpa.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 65030
Cc: Eli Zaretskii <eliz@HIDDEN>, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN,
Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>>>>> On Tue, 8 Aug 2023 11:16:07 +0200, Mattias Engdeg=C3=A5rd <mattiase@a=
cm.org> said:
>>=20
>> As long as that improvement results in warnings for mistakes such as
>> misspelled keywords, rather than errors.
Mattias> Of course not. Incorrect arguments detected at run-time
Mattias> should elicit errors, as they do now. The point being
Mattias> that for something as complex as make-process they should
Mattias> be more helpful than just `wrong-type-argument`.
You want to transform working code that passes ':coding-system' to
`make-process' into code that signals an error? (yes, it doesn=CA=BCt work
100% as the programmer thinks it does, but that means we should warn,
not error).
Robert
--=20
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 09:16:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 08 05:16:18 2023 Received: from localhost ([127.0.0.1]:35163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qTIp7-0004gd-VT for submit <at> debbugs.gnu.org; Tue, 08 Aug 2023 05:16:18 -0400 Received: from mail236c50.megamailservers.eu ([91.136.10.246]:58574 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1qTIp3-0004gQ-8A for 65030 <at> debbugs.gnu.org; Tue, 08 Aug 2023 05:16:17 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1691486171; bh=Sh9mwBDtdGca/xVLhDuGiZ2HtgmNYDB9ut/hmz/rJj0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ajKFFWpLKWajFOEGAGYG7NmWB1PUfCnNSYNXsmfc6EE1ovJ6Ic8O0CfX6eCVQoyCh e2zeTuV813kM7smJ0U+16rdcbgyaNhoSeRg59ZZl8Ugct5ywzivuqMY3Cr8KSlAkQH Hp64AGSMub4nJJlhnxWiObg0ki3R8fp1ATBCtCCM= Feedback-ID: mattiase@HIDDEN Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3789G8HM049786; Tue, 8 Aug 2023 09:16:09 +0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <87sf8tapbf.fsf@HIDDEN> Date: Tue, 8 Aug 2023 11:16:07 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@HIDDEN> References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN> <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN> <D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN> <87sf8tapbf.fsf@HIDDEN> To: Robert Pluim <rpluim@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrledvgddufecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtdejnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpedvhfeiveekgfevledugfeuffeiudejtddtleehteetffdugeekveehgffhfefhtdenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeehpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpdhrtghpthhtohepvghllhgvrhdrhhgvlhhmuhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepieehtdeftdesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 65030 Cc: Eli Zaretskii <eliz@HIDDEN>, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) 8 aug. 2023 kl. 10.52 skrev Robert Pluim <rpluim@HIDDEN>: > I don=CA=BCt think any of the `make-process' keywords accept keywords = as > values, but missing values tends to cause catastrophic failure, so I > don=CA=BCt think it=CA=BCs that common a mistake. No, the usefulness of good compiler warnings goes far beyond that. A = determined programmer may eventually get something working despite an = error-prone API, but decent diagnostics will speed up the process = manifold by pointing out mistakes before the code is even run. (With = flymake/flycheck, even faster.) > Mattias> The main objection is that `make-process`, due to its = design, is often > Mattias> called indirectly using `apply` which would not trigger = the > Mattias> application of this compiler macro, so perhaps we should = improve the > Mattias> error handling of Fmake_process instead. >=20 > As long as that improvement results in warnings for mistakes such as > misspelled keywords, rather than errors. Of course not. Incorrect arguments detected at run-time should elicit = errors, as they do now. The point being that for something as complex as make-process they = should be more helpful than just `wrong-type-argument`.
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.
Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 08:52:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 08 04:52:50 2023
Received: from localhost ([127.0.0.1]:35125 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qTISP-00045s-UB
for submit <at> debbugs.gnu.org; Tue, 08 Aug 2023 04:52:50 -0400
Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:58730)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <rpluim@HIDDEN>) id 1qTISK-00045c-M8
for 65030 <at> debbugs.gnu.org; Tue, 08 Aug 2023 04:52:48 -0400
Received: by mail-lf1-x12e.google.com with SMTP id
2adb3069b0e04-4fe383c1a26so8851549e87.1
for <65030 <at> debbugs.gnu.org>; Tue, 08 Aug 2023 01:52:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1691484758; x=1692089558;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=uhaq9aQlVdKq+qJHy+jtmNyw56iwWqW4wTy2RWFmhN0=;
b=kIOeSg6PuhQmh9bFAd1kvkvIER6L7CLnpu/RBKXJSOR536TdVaTeloXU/3dTq9pBhI
uWXLGza5YlrsZIii7dC68RE+SxKMFTrmpMWv/DruQplw/D18amen6V2kePzLBp4+dvMs
h3UCQtz3rh4womy6qyVkEGqLuvr6wqwmgsFyWB/6Nyl257JCocq6W8llaHKO1EabQ1ME
TW0viqtiYga2pwyMbWl2JpPuBKB7NArMTIT/aBNAO+tFbjv2fCJ4pQqIU7FZvkPpB4jg
POsvaCiJ0whlqf1zVfqdW8bpwUeL9uaoQ6ZeAEqGRq/sGqkuqCWrglGAVgIno4GRfU41
H5aw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1691484758; x=1692089558;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=uhaq9aQlVdKq+qJHy+jtmNyw56iwWqW4wTy2RWFmhN0=;
b=C3S44WlyNXGu5vM5fE7Hgq9b1PD4fsdouqj0lChH0PfZmdG28cwktIUXXFLh8Gc6OW
2Oh5HpLJYM3SN3ik5US6s1AyjqcjV7218Pw1mLi70tZ9rzqfrSjWTMA3j9az7I0qYK8m
eVaHh4laDlKJbMeA/1cd4AolCaQtZ7KkDfMkCiGPLgAXsAWhx3bjkU4/u7IVjD5zx3Z5
DcNZ/pLC2edkM+czdBNFxmuSeTjbC4IpopC9l/vMgZUjYuXkUsZDRFWfwRhtUMK6kTKx
3uqLi4QVIloKAvjmOK5mV6iV4AshoUNhO/5ixXc1J8vRMCk1CQEHvj3qPgK2KfPQqmkN
xY8A==
X-Gm-Message-State: AOJu0YwtyEpUO/Y4xi43B6xvUUluA0k8z5I/ogXltY0QDiXE+7yEsfKi
1XKy+283R7AWROmHbOd2HbMKUjJ6IGM=
X-Google-Smtp-Source: AGHT+IH/quEt4wphqO46OzT8/Yr7xYyBWS0lUNp43v6KnxS1G1p/csYaK9GT9mvPoZAoMaYtCLPJLg==
X-Received: by 2002:a05:6512:3b2:b0:4fe:ecd:4959 with SMTP id
v18-20020a05651203b200b004fe0ecd4959mr7047808lfp.32.1691484757868;
Tue, 08 Aug 2023 01:52:37 -0700 (PDT)
Received: from rltb ([2a01:e0a:3f3:fb50:602c:69f4:ec01:92cc])
by smtp.gmail.com with ESMTPSA id
z10-20020a7bc7ca000000b003fbc9b9699dsm12982604wmk.45.2023.08.08.01.52.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 08 Aug 2023 01:52:37 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN>
Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process
In-Reply-To: <D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 6 Aug 2023 10:49:59
+0200")
References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN>
<jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN>
<D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN>
Date: Tue, 08 Aug 2023 10:52:36 +0200
Message-ID: <87sf8tapbf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 65030
Cc: Eli Zaretskii <eliz@HIDDEN>, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN,
Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
>>>>> On Sun, 6 Aug 2023 10:49:59 +0200, Mattias Engdeg=C3=A5rd <mattiase@a=
cm.org> said:
Mattias> 6 aug. 2023 kl. 06.58 skrev Eli Zaretskii <eliz@HIDDEN>:
>> Any specific comments to the proposed patch? Or do you think it is
>> good to go?
Mattias> Good to go as far as I'm concerned. It will be genuinely usefu=
l, and I
Mattias> see no serious problems with the implementation.
Mattias> It can be extended but that would not prevent it from being co=
mmitted
Mattias> as-is. For example, something that detects omitted values in t=
he
Mattias> middle, not just the end, of the argument list. (The feasibili=
ty of
Mattias> this depends on the likelihood of argument values being keywor=
ds
Mattias> themselves.)
I don=CA=BCt think any of the `make-process' keywords accept keywords as
values, but missing values tends to cause catastrophic failure, so I
don=CA=BCt think it=CA=BCs that common a mistake.
Mattias> The main objection is that `make-process`, due to its design, =
is often
Mattias> called indirectly using `apply` which would not trigger the
Mattias> application of this compiler macro, so perhaps we should impro=
ve the
Mattias> error handling of Fmake_process instead.
As long as that improvement results in warnings for mistakes such as
misspelled keywords, rather than errors.
Robert
--=20
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.Received: (at 65030) by debbugs.gnu.org; 6 Aug 2023 08:50:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 06 04:50:11 2023 Received: from localhost ([127.0.0.1]:58642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qSZSk-0002vy-S3 for submit <at> debbugs.gnu.org; Sun, 06 Aug 2023 04:50:11 -0400 Received: from mail205c50.megamailservers.eu ([91.136.10.215]:45330 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattiase@HIDDEN>) id 1qSZSf-0002vj-FV for 65030 <at> debbugs.gnu.org; Sun, 06 Aug 2023 04:50:09 -0400 X-Authenticated-User: mattiase@HIDDEN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1691311803; bh=2hf050fS8pblFbUAhzjAT6FtdBTQRABuug+7r6I1b2c=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=UgyOeEZw1bYxBtvAhwiZEYeUOg+c6Y3NQXXhz+8g93Tf61XV7ePJ3MA9K9qoe8dLN LDYMk/ziUqn3PEHAHdYF6DmCA8rsAl+R2HmSVJL1yjOjnSqGLPESD9O07qzblhsyak GCeNF9Kr2LLa9wXc70Z70uV3H3r4xr6nl1dvOcGo= Feedback-ID: mattiase@HIDDEN Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3768o04M120126; Sun, 6 Aug 2023 08:50:02 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattiase@HIDDEN> In-Reply-To: <83o7jkrcme.fsf@HIDDEN> Date: Sun, 6 Aug 2023 10:49:59 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <D16021F8-7D7E-49F0-971E-32B040E303BF@HIDDEN> References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN> <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> <83o7jkrcme.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrkeekgddtkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfjqffuvffqrffktedpqfgfvfdpgffpggdqveehtdenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeforghtthhirghsucfgnhhguggvghonrhguuceomhgrthhtihgrshgvsegrtghmrdhorhhgqeenucggtffrrghtthgvrhhnpeevkeffudejhfekhedvgfffieekgffhfedvkeeuffelgeefkeeulefhjeeifeekgfenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopeehpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrpdhrtghpthhtohepvghllhgvrhdrhhgvlhhmuhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhplhhuihhmsehgmhgrihhlrdgtohhmpdhrtghpthhtohepieehtdeftdesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 65030 Cc: rpluim@HIDDEN, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) 6 aug. 2023 kl. 06.58 skrev Eli Zaretskii <eliz@HIDDEN>: > Any specific comments to the proposed patch? Or do you think it is > good to go? Good to go as far as I'm concerned. It will be genuinely useful, and I = see no serious problems with the implementation. It can be extended but that would not prevent it from being committed = as-is. For example, something that detects omitted values in the middle, = not just the end, of the argument list. (The feasibility of this depends = on the likelihood of argument values being keywords themselves.) The main objection is that `make-process`, due to its design, is often = called indirectly using `apply` which would not trigger the application = of this compiler macro, so perhaps we should improve the error handling = of Fmake_process instead.
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.Received: (at 65030) by debbugs.gnu.org; 6 Aug 2023 04:57:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Aug 06 00:57:53 2023 Received: from localhost ([127.0.0.1]:58512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qSVpw-0002PG-VO for submit <at> debbugs.gnu.org; Sun, 06 Aug 2023 00:57:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qSVpu-0002P1-CK for 65030 <at> debbugs.gnu.org; Sun, 06 Aug 2023 00:57:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qSVpo-00016V-Pv; Sun, 06 Aug 2023 00:57:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uVlPMFQu0evMHktatnsdVp1jeTQLSFYnSONCmkqosYI=; b=WE7PDzpaNAoLPQBAWjLD eZtvqwDGou5fJZgPZVBRWTQI21uaWZBWZYynstW9WAYQgMGZpaRvhboAn5A/R/YPssVTO0LGTlLag wxr3UBX3qhzkbBoTyShxM1udJ2kQzDPiqxc9vX0MSPa0fRqz4vlMV6cvOEflq1k46BUavrotcBJd6 kg/3702pz17NqmyJy7aZnF6ewQTMUiVN3qJ22cmjKNFHx0GDWgr9GmpSkA6bB4UaRBxMFwivf2H8A h/SiEoCrqcQdD0p9pEldUOBb/j7HSI88mc8St396xzUp35wg11tlHM96/5RtxUHmKJLwjUgXTyC3J 1A3l/rlZqPoAgA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qSVpo-00051s-8i; Sun, 06 Aug 2023 00:57:44 -0400 Date: Sun, 06 Aug 2023 07:58:01 +0300 Message-Id: <83o7jkrcme.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> In-Reply-To: <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> (message from Stefan Monnier on Sat, 05 Aug 2023 19:07:53 -0400) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN> <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65030 Cc: mattiase@HIDDEN, rpluim@HIDDEN, 65030 <at> debbugs.gnu.org, eller.helmut@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Monnier <monnier@HIDDEN> > Cc: Helmut Eller <eller.helmut@HIDDEN>, Mattias Engdegård > <mattiase@HIDDEN>, Robert Pluim <rpluim@HIDDEN>, > 65030 <at> debbugs.gnu.org > Date: Sat, 05 Aug 2023 19:07:53 -0400 > > >> The functions make-process and make-network-process have many keyword > >> arguments and it's somewhat easy to misspell some of them. E.g. using > >> :coding-system instead of :coding. These functions don't detect such > >> mistakes at runtime. What would people think about adding some checks > >> as a compiler macro as with the patch below? > > Good idea, thanks. Any specific comments to the proposed patch? Or do you think it is good to go?
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.
Received: (at 65030) by debbugs.gnu.org; 5 Aug 2023 23:08:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 05 19:08:15 2023
Received: from localhost ([127.0.0.1]:58333 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qSQNb-0001xL-0e
for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 19:08:15 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37669)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1qSQNZ-0001x8-HT
for 65030 <at> debbugs.gnu.org; Sat, 05 Aug 2023 19:08:14 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 35FB71000EF;
Sat, 5 Aug 2023 19:08:08 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1691276887;
bh=a2M1EFMidf9Yvsv27ulvnMzSrzEm8QRtKLa4/RoOT30=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=KYiaZNF0giWsbgS94ZyjViTJGEH16ElMxBiaXztLo801KFR3GEe4wCHtDeBue5cme
9gVLy9Ye3SC5OzD+JM8arXMJrfu0py5LcwsISMmuPvIvfPVvcUYCKHfPqMxR5ii0LQ
jUoaO56746WzBkjopxoVmlBX+VVabW0C5uckt3kxTvg05afBKYDQvGHDTu8zg2laq8
DoFoK75G2a0fbr6ylW6ZRPAqgAF8MJa4dUGdYGuJZy+gME30TADzE5BHuHlxyp3Z2q
726w6mdt+53ZloTwWgKTv86bYXB4AXNvIVdcBzkgsG+CVcNmquTE5K7X7YahP/+yed
bOs2WKCPnmpOw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F18E21000AD;
Sat, 5 Aug 2023 19:08:06 -0400 (EDT)
Received: from alfajor (unknown [190.16.213.142])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 67AE512026A;
Sat, 5 Aug 2023 19:08:05 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process
In-Reply-To: <83a5v5u9nf.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 05 Aug
2023 12:21:40 +0300")
Message-ID: <jwvpm41ytqr.fsf-monnier+emacs@HIDDEN>
References: <m2zg38r59r.fsf@HIDDEN> <83a5v5u9nf.fsf@HIDDEN>
Date: Sat, 05 Aug 2023 19:07:53 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.083 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 65030
Cc: Mattias =?windows-1252?Q?Engde?= =?windows-1252?Q?g=E5rd?=
<mattiase@HIDDEN>, Robert Pluim <rpluim@HIDDEN>, 65030 <at> debbugs.gnu.org,
Helmut Eller <eller.helmut@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> The functions make-process and make-network-process have many keyword
>> arguments and it's somewhat easy to misspell some of them. E.g. using
>> :coding-system instead of :coding. These functions don't detect such
>> mistakes at runtime. What would people think about adding some checks
>> as a compiler macro as with the patch below?
Good idea, thanks.
Stefan
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.Received: (at 65030) by debbugs.gnu.org; 5 Aug 2023 09:21:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 05 05:21:33 2023 Received: from localhost ([127.0.0.1]:55606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qSDTZ-0008Jq-4c for submit <at> debbugs.gnu.org; Sat, 05 Aug 2023 05:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1qSDTX-0008JK-3I for 65030 <at> debbugs.gnu.org; Sat, 05 Aug 2023 05:21:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qSDTR-0004gz-SE; Sat, 05 Aug 2023 05:21:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xZUD3jMbkdHAnFUzECVu9pEmw5e7rOtDqy0zys+TH1I=; b=JsB4cKmbyQv6usMJfPNS XGWT58f0sdgZ3P8Zay6x3ySzBt9MHWNmFgOkMb+lW3BhT3LDZg0iPR312jOHbd6f+pbF/Fzkq4n0/ 5egOx/vHFpJWkFPElLEz94ibg5xfQG2g/TBZ8xJ5BtxJz1rc5GnOeV9nxKLPledqX14528FCiXAU3 q5Yy3/hPrumlA8Sf7zrfT86mU69PcGCIQfzEVe1WhDIYFzIaLf7lMxXNqfnd0KM5QpZfx+qx9aj8X lijxDGZUWBmh+ns37UtbW76TPW0FKNSRi1HnqPGaJUfdRRJaEbcrDMh+jvO/8+Q7UbDq7tR+8aDCM 8xEMxqDoDXjBrg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1qSDTR-0006tv-Ay; Sat, 05 Aug 2023 05:21:25 -0400 Date: Sat, 05 Aug 2023 12:21:40 +0300 Message-Id: <83a5v5u9nf.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Helmut Eller <eller.helmut@HIDDEN>, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattiase@HIDDEN> Robert Pluim <rpluim@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <m2zg38r59r.fsf@HIDDEN> (message from Helmut Eller on Thu, 03 Aug 2023 08:47:44 +0200) Subject: Re: bug#65030: 30.0.50; Check keyword args of make-process References: <m2zg38r59r.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 65030 Cc: 65030 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Helmut Eller <eller.helmut@HIDDEN> > Date: Thu, 03 Aug 2023 08:47:44 +0200 > > The functions make-process and make-network-process have many keyword > arguments and it's somewhat easy to misspell some of them. E.g. using > :coding-system instead of :coding. These functions don't detect such > mistakes at runtime. What would people think about adding some checks > as a compiler macro as with the patch below? > > I didn't know where to put this, so I just left it in bytecomp.el. > > Perhaps the advertised-calling-convention declaration could do this, but > since keyword arguments seem to be generally discouraged, a special case > for make-process and make-network-process maybe simpler. Mattias, Robert and Stefan: any comments on this? Thanks.
bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 3 Aug 2023 06:48:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 03 02:48:04 2023
Received: from localhost ([127.0.0.1]:50571 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qRS7w-0002PW-2F
for submit <at> debbugs.gnu.org; Thu, 03 Aug 2023 02:48:04 -0400
Received: from lists.gnu.org ([2001:470:142::17]:46004)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eller.helmut@HIDDEN>) id 1qRS7t-0002OO-Oh
for submit <at> debbugs.gnu.org; Thu, 03 Aug 2023 02:48:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eller.helmut@HIDDEN>)
id 1qRS7o-0005nJ-9C
for bug-gnu-emacs@HIDDEN; Thu, 03 Aug 2023 02:47:56 -0400
Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <eller.helmut@HIDDEN>)
id 1qRS7m-0008Vk-AA
for bug-gnu-emacs@HIDDEN; Thu, 03 Aug 2023 02:47:56 -0400
Received: by mail-wm1-x333.google.com with SMTP id
5b1f17b1804b1-3fbea14706eso6042885e9.2
for <bug-gnu-emacs@HIDDEN>; Wed, 02 Aug 2023 23:47:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1691045272; x=1691650072;
h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
:date:message-id:reply-to;
bh=RPZooucziZ7IiTKWGQk05I3lCxyJLSy7z3vJbSVD3fc=;
b=DSlea9p4sLy2AnU+KHr/8s/ijPZ5Yepy4uhhw970j0DU1ba13raxJZM2TnnzXkVs6w
Klm3R/er0weKfbqRJBVvaCrtrvyrIY/GwpN9yyMQB+lZVCKNLDiOtHLanQymUGUxChIB
ZrSztLQpP64yjLRGQa+xiikYZWu1aYudvV2wBygD+A/G9mer5n/T7vWXq33hTe6GP6ez
/bmxy/u4HTz+qGQsp5Cf+hgb0l21rW5D1khphFmeDHZorP7A2ZDQpo4HQRi3e8B3ePXZ
GTk7HksNmJ8nJNkVg2VVOljejH0UAuIuKEtlki/Q5yjGu12UY5hrfstDpd9/KAU+klTv
+Qig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1691045272; x=1691650072;
h=mime-version:message-id:date:subject:to:from:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=RPZooucziZ7IiTKWGQk05I3lCxyJLSy7z3vJbSVD3fc=;
b=lODxsc9u57y6BoLY1khH7IBCrZL/DG4sHCGJSFAgpTZIl1/JTW4qt7LmAkXzcSrL8N
I+XjV8TQmVV42bAbXcYeV1ZqToPkqvyi2pegZ1++27Q55HfPB17iu6IMau2vka0kHK8m
uKo6T6zh2cNrQ3KQOgQ1UsteZh5VNTRJ0zqCKfWhhIBUUi2xtqk8r9EeuVqsFZKXUkDJ
3MJk8yXGN18IcjPCoNH3Xdk546Rqpc+0DNYg1KmOUwcBZVBFCkmegJMPWdx7mNrBMY7g
D1wnSprB+7bJsQ87HZYGrKwhdKq1AwdjWxAMUW49Piukra5BQzb0SBGXFLqhcHRTyiSa
2GeA==
X-Gm-Message-State: ABy/qLY1vabZVg89fFo6yVK1FJ6PfA41zUc7qtDREPRyUSUBEhpCmCrA
aTV9+RvAeKCsVWjk5zxZYEpwXR2c53c=
X-Google-Smtp-Source: APBJJlHPagROq888IrzHCRbqCMzB8gbLnGRr9/Hzt3jDGn6yyhdl+DXDTvAjGRZfVtYm+criejG6PA==
X-Received: by 2002:a1c:ed0f:0:b0:3fe:1c05:3c8f with SMTP id
l15-20020a1ced0f000000b003fe1c053c8fmr6355540wmh.35.1691045271646;
Wed, 02 Aug 2023 23:47:51 -0700 (PDT)
Received: from caladan (dialin-228086.xdsl.raiffeisen.net. [195.254.228.86])
by smtp.gmail.com with ESMTPSA id
l7-20020a7bc347000000b003fbdbd0a7desm3420560wmj.27.2023.08.02.23.47.50
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 02 Aug 2023 23:47:50 -0700 (PDT)
From: Helmut Eller <eller.helmut@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; Check keyword args of make-process
Date: Thu, 03 Aug 2023 08:47:44 +0200
Message-ID: <m2zg38r59r.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=2a00:1450:4864:20::333;
envelope-from=eller.helmut@HIDDEN; helo=mail-wm1-x333.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain
The functions make-process and make-network-process have many keyword
arguments and it's somewhat easy to misspell some of them. E.g. using
:coding-system instead of :coding. These functions don't detect such
mistakes at runtime. What would people think about adding some checks
as a compiler macro as with the patch below?
I didn't know where to put this, so I just left it in bytecomp.el.
Perhaps the advertised-calling-convention declaration could do this, but
since keyword arguments seem to be generally discouraged, a special case
for make-process and make-network-process maybe simpler.
Helmut
--=-=-=
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: inline;
filename=0001-Check-keyword-args-of-make-process.patch
Content-Transfer-Encoding: quoted-printable
From 758ba9b8b26333fc60ca4693616c5f2b355d4fcc Mon Sep 17 00:00:00 2001
From: Helmut Eller <eller.helmut@HIDDEN>
Date: Thu, 3 Aug 2023 08:33:40 +0200
Subject: [PATCH] Check keyword args of make-process
The functions make-process and make-network-process have many
keyword args and it's easy to misspell some of them.
Use a compiler macro to warn about some possible mistakes.
* lisp/emacs-lisp/bytecomp.el (bytecomp--check-keyword-args): New
helper.
(make-process, make-network-process): Define a compiler macro that
performs some checks but doesn't anything else.
* test/lisp/emacs-lisp/bytecomp-tests.el: Add some tests.
* test/lisp/emacs-lisp/bytecomp-resources/:
(warn-make-process-missing-keyword-arg.el,
warn-make-process-missing-keyword-value.el,
warn-make-process-repeated-keyword-arg.el,
warn-make-process-unknown-keyword-arg.el): New test files
---
lisp/emacs-lisp/bytecomp.el | 61 +++++++++++++++++++
.../warn-make-process-missing-keyword-arg.el | 3 +
...warn-make-process-missing-keyword-value.el | 3 +
.../warn-make-process-repeated-keyword-arg.el | 3 +
.../warn-make-process-unknown-keyword-arg.el | 4 ++
test/lisp/emacs-lisp/bytecomp-tests.el | 16 +++++
6 files changed, 90 insertions(+)
create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/warn-make-proce=
ss-missing-keyword-arg.el
create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/warn-make-proce=
ss-missing-keyword-value.el
create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/warn-make-proce=
ss-repeated-keyword-arg.el
create mode 100644 test/lisp/emacs-lisp/bytecomp-resources/warn-make-proce=
ss-unknown-keyword-arg.el
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 5b1d958e6c2..d3a434b5593 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -5782,6 +5782,67 @@ bytecomp--backward-word
form ; arity error
`(forward-word (- (or ,arg 1)))))
=20
+(defun bytecomp--check-keyword-args (form arglist allowed-keys required-ke=
ys)
+ (let ((fun (car form)))
+ (cl-flet ((missing (form keyword)
+ (byte-compile-warn-x
+ form
+ "`%S=C2=B4 called without required keyword argument %S"
+ fun keyword))
+ (unrecognized (form keyword)
+ (byte-compile-warn-x
+ form
+ "`%S=C2=B4 called with unknown keyword argument %S"
+ fun keyword))
+ (duplicate (form keyword)
+ (byte-compile-warn-x
+ form
+ "`%S=C2=B4 called with repeated keyword argument %S"
+ fun keyword))
+ (missing-val (form keyword)
+ (byte-compile-warn-x
+ form
+ "missing value for keyword argument %S"
+ keyword)))
+ (let* ((seen '())
+ (l arglist))
+ (while (consp l)
+ (let ((key (car l)))
+ (cond ((and (keywordp key) (memq key allowed-keys))
+ (cond ((memq key seen)
+ (duplicate l key))
+ (t
+ (push key seen))))
+ (t (unrecognized l key)))
+ (when (null (cdr l))
+ (missing-val l key)))
+ (setq l (cddr l)))
+ (dolist (key required-keys)
+ (unless (memq key seen)
+ (missing form key))))))
+ form)
+
+(put 'make-process 'compiler-macro
+ #'(lambda (form &rest args)
+ (bytecomp--check-keyword-args
+ form args
+ '(:name
+ :buffer :command :coding :noquery :stop :connection-type
+ :filter :sentinel :stderr :file-handler)
+ '(:name :command))))
+
+(put 'make-network-process 'compiler-macro
+ #'(lambda (form &rest args)
+ (bytecomp--check-keyword-args
+ form args
+ '(:name
+ :buffer :host :service :type :family :local :remote :coding
+ :nowait :noquery :stop :filter :filter-multibyte :sentinel
+ :log :plist :tls-parameters :server :broadcast :dontroute
+ :keepalive :linger :oobinline :priority :reuseaddr :bindtodevi=
ce
+ :use-external-socket)
+ '(:name :service))))
+
(provide 'byte-compile)
(provide 'bytecomp)
=20
diff --git a/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-miss=
ing-keyword-arg.el b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-proc=
ess-missing-keyword-arg.el
new file mode 100644
index 00000000000..9369e78ff54
--- /dev/null
+++ b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-missing-key=
word-arg.el
@@ -0,0 +1,3 @@
+;;; -*- lexical-binding: t -*-
+(defun foo ()
+ (make-process :name "ls"))
diff --git a/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-miss=
ing-keyword-value.el b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-pr=
ocess-missing-keyword-value.el
new file mode 100644
index 00000000000..4226349afef
--- /dev/null
+++ b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-missing-key=
word-value.el
@@ -0,0 +1,3 @@
+;;; -*- lexical-binding: t -*-
+(defun foo ()
+ (make-process :name "ls" :command))
diff --git a/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-repe=
ated-keyword-arg.el b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-pro=
cess-repeated-keyword-arg.el
new file mode 100644
index 00000000000..18250f14ee9
--- /dev/null
+++ b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-repeated-ke=
yword-arg.el
@@ -0,0 +1,3 @@
+;;; -*- lexical-binding: t -*-
+(defun foo ()
+ (make-process :name "ls" :command "ls" :name "ls"))
diff --git a/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-unkn=
own-keyword-arg.el b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-proc=
ess-unknown-keyword-arg.el
new file mode 100644
index 00000000000..4721035780b
--- /dev/null
+++ b/test/lisp/emacs-lisp/bytecomp-resources/warn-make-process-unknown-key=
word-arg.el
@@ -0,0 +1,4 @@
+;;; -*- lexical-binding: t -*-
+(defun foo ()
+ (make-process :name "ls" :command "ls"
+ :coding-system 'binary))
diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/=
bytecomp-tests.el
index 593fd117685..6ed907ead7b 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -1199,6 +1199,22 @@ bytecomp--tests-obsolete-var
"nowarn-inline-after-defvar.el"
"Lexical argument shadows" 'reverse)
=20
+(bytecomp--define-warning-file-test
+ "warn-make-process-missing-keyword-arg.el"
+ "called without required keyword argument :command")
+
+(bytecomp--define-warning-file-test
+ "warn-make-process-unknown-keyword-arg.el"
+ "called with unknown keyword argument :coding-system")
+
+(bytecomp--define-warning-file-test
+ "warn-make-process-repeated-keyword-arg.el"
+ "called with repeated keyword argument :name")
+
+(bytecomp--define-warning-file-test
+ "warn-make-process-missing-keyword-value.el"
+ "missing value for keyword argument :command")
+
;;;; Macro expansion.
=20
--=20
2.39.2
--=-=-=--
Helmut Eller <eller.helmut@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#65030; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.